Tria/edr-platform
1
0
Fork 0
mirror of https://github.com/Tria-plc/edr-platform.git synced 2026-09-09 07:08:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(train-scheduling): exempt direct-to-train export bookings from GRN gate

Browse Source 
confirmScheduleLoading's assertExportBookingsReceived checked every
wagon-assigned export booking for a warehouse GRN, with no exception for
DIRECT_TO_TRAIN (manual truck-straight-to-wagon) bookings — the one
call site that lacked the carve-out already applied everywhere else GRN
is checked (export-received-gate, booking-journey, carriage acceptance).
Warehouse-routed export cargo still requires GRN; direct handovers rely
on the carriage acceptance sheet instead.
This commit is contained in:
Hagernesh
2026-08-11 12:13:34 +00:00
parent ae9bf8bd31
commit 1be72799f4
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/edr-freight-api/src/modules/train-scheduling/services/train-scheduling.service.ts
View File

@@ -3262,6 +3262,12 @@ export class TrainSchedulingService {
* Every export booking being confirmed loaded must already be received at the * Every export booking being confirmed loaded must already be received at the
* warehouse with a GRN. An allocation puts a booking on a wagon on paper; this * warehouse with a GRN. An allocation puts a booking on a wagon on paper; this
* is the check that the cargo is physically in the yard before we call it loaded. * is the check that the cargo is physically in the yard before we call it loaded.
*
* Direct truck-to-train (exportHandoverMode = DIRECT_TO_TRAIN) is excluded —
* that cargo is manually loaded from the customer's truck straight onto the
* wagon, never sees the warehouse, and is never GRN'd. Its custody is attested
* by the carriage acceptance sheet instead (same carve-out as the shared
* assertExportReceivedWithGrn gate — see common/export-received-gate.ts).
*/ */
private async assertExportBookingsReceived(bookingIds: string[]): Promise<void> { private async assertExportBookingsReceived(bookingIds: string[]): Promise<void> {
if (!bookingIds.length) return; if (!bookingIds.length) return;
@@ -3270,6 +3276,7 @@ export class TrainSchedulingService {
FROM freight.bookings b FROM freight.bookings b
WHERE b.id = ANY($1) WHERE b.id = ANY($1)
AND b.deleted_at IS NULL AND b.deleted_at IS NULL
AND b.export_handover_mode IS DISTINCT FROM 'DIRECT_TO_TRAIN'
AND NOT EXISTS ( AND NOT EXISTS (
SELECT 1 FROM freight.warehouse_inventory inv SELECT 1 FROM freight.warehouse_inventory inv
WHERE inv.booking_id = b.id WHERE inv.booking_id = b.id