refactor(api client): reuse the existing services instead

apps/edr-freight-web/portal/src/services/api.ts

@@ -1,5 +1,5 @@
 import type { Freight, PaginatedResponse } from "@edr/types";
-import { client, endpoint, unwrap } from "@/utils/api";
+import { endpoint } from "@/utils/api";
 import type {
   CreateFileUploadFieldDto,
   CreateFileUploadSettingDto,
@@ -8,6 +8,10 @@ import type {
   UpdateFileUploadFieldDto,
   UpdateFileUploadSettingDto,
 } from "@/types/fileUploadSettings";
+import { bookingsService } from "./bookings.service";
+import { consignmentsService } from "./consignments.service";
+import { trackingService } from "./tracking.service";
+import { fileUploadSettingsService } from "./fileUploadSettings.service";
 
 // ---------------------------------------------------------------------------
 // API definition
@@ -18,19 +22,13 @@ export const api = {
     list: endpoint<void, PaginatedResponse<Freight.IBooking>>(
       "bookings",
       "list",
-      async () => {
+      bookingsService.list,
-        const { data } = await client.get("/bookings");
-        return unwrap(data);
-      },
     ),
 
     get: endpoint<{ id: string }, Freight.IBooking>(
       "bookings",
       "get",
-      async ({ id }) => {
+      ({ id }) => bookingsService.get(id),
-        const { data } = await client.get(`/bookings/${id}`);
-        return unwrap(data);
-      },
     ),
 
     create: endpoint<
@@ -42,17 +40,12 @@ export const api = {
         trainId?: string;
       },
       Freight.IBooking
-    >("bookings", "create", async (input) => {
+    >("bookings", "create", (input) => bookingsService.create(input)),
-      const { data } = await client.post("/bookings", input);
-      return unwrap(data);
-    }),
 
     remove: endpoint<{ id: string }, void>(
       "bookings",
       "remove",
-      async ({ id }) => {
+      ({ id }) => bookingsService.remove(id),
-        await client.delete(`/bookings/${id}`);
-      },
     ),
   },
 
@@ -60,19 +53,13 @@ export const api = {
     list: endpoint<void, PaginatedResponse<Freight.IConsignment>>(
       "consignments",
       "list",
-      async () => {
+      consignmentsService.list,
-        const { data } = await client.get("/consignments");
-        return unwrap(data);
-      },
     ),
 
     get: endpoint<{ id: string }, Freight.IConsignment>(
       "consignments",
       "get",
-      async ({ id }) => {
+      ({ id }) => consignmentsService.get(id),
-        const { data } = await client.get(`/consignments/${id}`);
-        return unwrap(data);
-      },
     ),
   },
 
@@ -80,112 +67,74 @@ export const api = {
     forConsignment: endpoint<
       { consignmentId: string },
       Freight.ITrackingEvent[]
-    >("tracking", "forConsignment", async ({ consignmentId }) => {
+    >("tracking", "forConsignment", ({ consignmentId }) =>
-      const { data } = await client.get(`/tracking/${consignmentId}`);
+      trackingService.forConsignment(consignmentId),
-      return unwrap(data);
+    ),
-    }),
   },
 
   fileUploadSettings: {
     list: endpoint<void, FileUploadSetting[]>(
       "file-upload-settings",
       "list",
-      async () => {
+      fileUploadSettingsService.list,
-        const { data } = await client.get("/api/file-upload-settings");
-        return unwrap(data);
-      },
     ),
 
     getById: endpoint<{ id: string }, FileUploadSetting>(
       "file-upload-settings",
       "getById",
-      async ({ id }) => {
+      ({ id }) => fileUploadSettingsService.getById(id),
-        const { data } = await client.get(`/api/file-upload-settings/${id}`);
-        return unwrap(data);
-      },
     ),
 
     getByCode: endpoint<{ code: string }, FileUploadSetting>(
       "file-upload-settings",
       "getByCode",
-      async ({ code }) => {
+      ({ code }) => fileUploadSettingsService.getByCode(code),
-        const { data } = await client.get(
-          `/api/file-upload-settings/by-code/${encodeURIComponent(code)}`,
-        );
-        return unwrap(data);
-      },
     ),
 
     create: endpoint<CreateFileUploadSettingDto, FileUploadSetting>(
       "file-upload-settings",
       "create",
-      async (payload) => {
+      (payload) => fileUploadSettingsService.create(payload),
-        const { data } = await client.post(
-          "/api/file-upload-settings",
-          payload,
-        );
-        return unwrap(data);
-      },
     ),
 
     update: endpoint<
       { id: string; dto: UpdateFileUploadSettingDto },
       FileUploadSetting
-    >("file-upload-settings", "update", async ({ id, dto }) => {
+    >("file-upload-settings", "update", ({ id, dto }) =>
-      const { data } = await client.patch(
+      fileUploadSettingsService.update(id, dto),
-        `/api/file-upload-settings/${id}`,
+    ),
-        dto,
-      );
-      return unwrap(data);
-    }),
 
     remove: endpoint<{ id: string }, void>(
       "file-upload-settings",
       "remove",
-      async ({ id }) => {
+      ({ id }) => fileUploadSettingsService.remove(id),
-        await client.delete(`/api/file-upload-settings/${id}`);
-      },
     ),
 
     replaceFields: endpoint<
       { id: string; fields: CreateFileUploadFieldDto[] },
       FileUploadField[]
-    >("file-upload-settings", "replaceFields", async ({ id, fields }) => {
+    >("file-upload-settings", "replaceFields", ({ id, fields }) =>
-      const { data } = await client.put(
+      fileUploadSettingsService.replaceFields(id, fields),
-        `/api/file-upload-settings/${id}/fields`,
+    ),
-        fields,
-      );
-      return unwrap(data);
-    }),
 
     addField: endpoint<
       { settingId: string; dto: CreateFileUploadFieldDto },
       FileUploadField
-    >("file-upload-settings", "addField", async ({ settingId, dto }) => {
+    >("file-upload-settings", "addField", ({ settingId, dto }) =>
-      const { data } = await client.post(
+      fileUploadSettingsService.addField(settingId, dto),
-        `/api/file-upload-settings/${settingId}/fields`,
+    ),
-        dto,
-      );
-      return unwrap(data);
-    }),
 
     updateField: endpoint<
       { fieldId: string; dto: UpdateFileUploadFieldDto },
       FileUploadField
-    >("file-upload-settings", "updateField", async ({ fieldId, dto }) => {
+    >("file-upload-settings", "updateField", ({ fieldId, dto }) =>
-      const { data } = await client.patch(
+      fileUploadSettingsService.updateField(fieldId, dto),
-        `/api/file-upload-settings/fields/${fieldId}`,
+    ),
-        dto,
-      );
-      return unwrap(data);
-    }),
 
     removeField: endpoint<{ fieldId: string }, void>(
       "file-upload-settings",
       "removeField",
-      async ({ fieldId }) => {
+      ({ fieldId }) => fileUploadSettingsService.removeField(fieldId),
-        await client.delete(`/api/file-upload-settings/fields/${fieldId}`);
-      },
     ),
   },
 };

apps/edr-freight-web/portal/src/services/bookings.service.ts

@@ -1,6 +1,6 @@
 import type { Freight, PaginatedResponse } from "@edr/types";
 
-import { api } from "../utils/api";
+import { api } from "./crud";
 
 export interface CreateBookingPayload {
   reference: string;