From 92371f17da48e4fdde7050a77444ae54e7c82bd2 Mon Sep 17 00:00:00 2001
From: Nathnael <nathnael@example.com>
Date: Mon, 10 Aug 2026 18:45:54 +0000
Subject: [PATCH] fix: the position based gl gate on sidbear

---
 .../components/layout/sidebar-sections.tsx    | 45 +------------------
 1 file changed, 2 insertions(+), 43 deletions(-)

diff --git a/apps/edr-freight-web/backoffice/src/components/layout/sidebar-sections.tsx b/apps/edr-freight-web/backoffice/src/components/layout/sidebar-sections.tsx
index cfbc50528..83e80d11e 100644
--- a/apps/edr-freight-web/backoffice/src/components/layout/sidebar-sections.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/layout/sidebar-sections.tsx
@@ -40,8 +40,6 @@ import type { SidebarItem, SidebarSection } from "./types";
 import {
   FREIGHT_PERMS,
   hasPermission as hasFreightPermission,
-  isDjiboutiGl,
-  isEthiopianGl,
   isSuperAdmin,
 } from "@/lib/permissions";
 import { getCategorySidebarChildren } from "@/pages/ruleEngine/config/resources";
@@ -554,38 +552,10 @@ export const buildSidebarSections = (demoItems: SidebarItem[]): SidebarSection[]
   },
 ];
 
-/** Hrefs of the two document-clearance menu items (stable identifiers). */
-export const ET_CLEARANCE_HREF = "/dashboard/contracts/clearance";
-export const DJ_CLEARANCE_HREF = "/dashboard/gl-djibouti/clearance";
-
-// Routes a GL officer may reach beyond their clearance hub. Path B booking is
-// part of their job (create/rebook under a cleared contract, then view that
-// booking's clearance), but those routes live outside the clearance prefix —
-// without this allowlist the single-prefix lock bounces them out of their own
-// workflow. Matched against location.pathname (no query string).
-export const GL_WORKFLOW_PATH_PATTERNS: RegExp[] = [
-  /^\/dashboard\/contracts\/[^/]+\/create-booking(\/|$)/,
-  /^\/dashboard\/bookings\/[^/]+\/clearance(\/|$)/,
-  // The ET hub's rows open the shipment clearance detail at this URL.
-  /^\/dashboard\/clearance\/[^/]+(\/|$)/,
-];
-
-const isEtClearanceItem = (item: SidebarItem): boolean =>
-  item.href === ET_CLEARANCE_HREF;
-const isDjClearanceItem = (item: SidebarItem): boolean =>
-  item.href === DJ_CLEARANCE_HREF;
-const isClearanceItem = (item: SidebarItem): boolean =>
-  isEtClearanceItem(item) || isDjClearanceItem(item);
-
 /**
  * Keep only items the user is permitted to see; drop now-empty sections.
- *
- * Position-scoped visibility (super_admin sees everything):
- * - Super Admin → sees all items (all permissions pass, all tabs visible)
- * - Ethiopian GL  → sees ONLY the ET document-clearance page.
- * - Djibouti GL   → sees ONLY the DJ clearance page.
- * - Everyone else → sees everything they have permission for, EXCEPT the two
- *   clearance pages (those are GL-only).
+ * Super Admin sees everything; everyone else is filtered purely by each
+ * item's `permission` field (OR across the array when one is given).
  */
 export const filterSidebarByPermission = (
   sections: SidebarSection[],
@@ -594,9 +564,6 @@ export const filterSidebarByPermission = (
   // Superadmin sees every section and item — no permission filtering.
   if (isSuperAdmin(user)) return sections;
 
-  const etGl = isEthiopianGl(user);
-  const djGl = isDjiboutiGl(user);
-
   const permissionAllowed = (item: SidebarItem): boolean => {
     if (!item.permission) return true;
     const keys = Array.isArray(item.permission)
@@ -616,14 +583,6 @@ export const filterSidebarByPermission = (
           : item,
       )
       .filter((item) => {
-        if (etGl || djGl) {
-          // GL positions are locked to their single clearance page (parents
-          // survive only as the path to that page).
-          const isTarget = etGl ? isEtClearanceItem : isDjClearanceItem;
-          return isTarget(item) || (item.children?.length ?? 0) > 0;
-        }
-        // Everyone else: hide the GL-only clearance pages entirely.
-        if (isClearanceItem(item)) return false;
         if (!permissionAllowed(item)) return false;
         if (item.children) return item.children.length > 0;
         return true;