mirror of
https://github.com/Tria-plc/edr-platform.git
synced 2026-08-29 17:38:12 +00:00
fix: premature payable invoice
This commit is contained in:
@@ -376,4 +376,97 @@ describe("BillingService.expirePayable — locked write runs in a transaction",
|
||||
expect(result).toBeNull();
|
||||
expect(transaction).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("also retires a DRAFT invoice — a superseded/cancelled source must not leave one behind", async () => {
|
||||
const { service, defaultManager } = build({
|
||||
...openInvoice,
|
||||
status: Freight.InvoiceStatus.Draft,
|
||||
});
|
||||
|
||||
await service.expirePayable(
|
||||
Freight.InvoiceSource.Booking,
|
||||
"booking-1",
|
||||
"prepaid",
|
||||
);
|
||||
|
||||
const { where } = defaultManager.findOne.mock.calls[0][1];
|
||||
expect(where.status.value).toContain(Freight.InvoiceStatus.Draft);
|
||||
});
|
||||
});
|
||||
|
||||
describe("BillingService.issuePayable", () => {
|
||||
const dueAt = new Date("2026-01-02T00:00:00.000Z");
|
||||
|
||||
const build = (found: Record<string, unknown> | null) => {
|
||||
const manager = {
|
||||
findOne: jest.fn().mockResolvedValue(found),
|
||||
update: jest.fn().mockResolvedValue(undefined),
|
||||
};
|
||||
const service = new BillingService(
|
||||
{ manager, transaction: jest.fn() } as never,
|
||||
{} as never,
|
||||
{} as never,
|
||||
makeEvents() as never,
|
||||
{} as never,
|
||||
{} as never,
|
||||
{} as never,
|
||||
);
|
||||
return { service, manager };
|
||||
};
|
||||
|
||||
const issue = (service: BillingService) =>
|
||||
service.issuePayable(
|
||||
Freight.InvoiceSource.Booking,
|
||||
"booking-1",
|
||||
dueAt,
|
||||
"PREPAID",
|
||||
);
|
||||
|
||||
it("issues a DRAFT invoice to PENDING, stamping issuedAt and the pay-window dueAt", async () => {
|
||||
const { service, manager } = build({
|
||||
id: "inv-1",
|
||||
invoiceNumber: "INV-20260101-00001",
|
||||
status: Freight.InvoiceStatus.Draft,
|
||||
issuedAt: null,
|
||||
});
|
||||
|
||||
const result = await issue(service);
|
||||
|
||||
const patch = manager.update.mock.calls[0][2];
|
||||
expect(patch.status).toBe(Freight.InvoiceStatus.Pending);
|
||||
expect(patch.dueAt).toBe(dueAt);
|
||||
expect(patch.issuedAt).toBeInstanceOf(Date);
|
||||
expect(result?.status).toBe(Freight.InvoiceStatus.Pending);
|
||||
});
|
||||
|
||||
it("looks up DRAFT invoices — a booking's invoice is minted DRAFT and this is what makes it payable", async () => {
|
||||
const { service, manager } = build(null);
|
||||
|
||||
await issue(service);
|
||||
|
||||
const { where } = manager.findOne.mock.calls[0][1];
|
||||
expect(where.status.value).toContain(Freight.InvoiceStatus.Draft);
|
||||
});
|
||||
|
||||
it("only refreshes dueAt on an already-issued invoice, so a re-reserve never re-issues", async () => {
|
||||
const issuedAt = new Date("2026-01-01T00:00:00.000Z");
|
||||
const { service, manager } = build({
|
||||
id: "inv-1",
|
||||
invoiceNumber: "INV-20260101-00001",
|
||||
status: Freight.InvoiceStatus.Pending,
|
||||
issuedAt,
|
||||
});
|
||||
|
||||
const result = await issue(service);
|
||||
|
||||
expect(manager.update.mock.calls[0][2]).toEqual({ dueAt });
|
||||
expect(result?.issuedAt).toBe(issuedAt);
|
||||
});
|
||||
|
||||
it("is a no-op (returns null, writes nothing) when the source has no draft-or-open invoice", async () => {
|
||||
const { service, manager } = build(null);
|
||||
|
||||
await expect(issue(service)).resolves.toBeNull();
|
||||
expect(manager.update).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user