fix: payemetn race condition

apps/edr-freight-api/src/modules/payment/payment.service.ts

@@ -451,7 +451,19 @@ export class PaymentService {
   ): Promise<{ alreadyFinalized: boolean }> {
     const intent = await this.paymentRepo.findOneBy({ id: intentId });
     if (!intent) throw new NotFoundException("PaymentIntent not found");
-    if (intent.status === "success") return { alreadyFinalized: true };
+    if (intent.status === "success") {
+      // Still notify billing: a prior delivery may have flipped the intent to
+      // success and then died before the invoice settled (the two steps are not
+      // atomic). settleByPaymentId is idempotent — no open invoice, no-op.
+      if (opts.notify !== false) {
+        await this.billing.settleByPaymentId(
+          intent.id,
+          opts.providerTxnId ?? intent.transactionId ?? undefined,
+          opts.paidAt ?? intent.paidAt ?? undefined,
+        );
+      }
+      return { alreadyFinalized: true };
+    }
 
     const paidAt = opts.paidAt ?? new Date();
     await this.paymentRepo.update(