Adding all the tests and fixes to the passengers app

This commit is contained in:
Muluhabt
2026-07-21 15:26:29 +03:00
parent f2ae9c883f
commit 7e6778d025
3279 changed files with 117 additions and 12612 deletions

View File

@@ -19,13 +19,13 @@ a thin back-compat wrapper.
| ID | Spec | What it proves |
|----|------|----------------|
| UA-1 | `ua1` | one-way 1A ETB WALLET — full money chain equal, CONFIRMED |
| UA-1b | `ua1b-usd-divergence` | 🔴 USD card display fare diverges 100× from internal `baseFareMinor` |
| UA-2 | `ua2-usd-booking` | 🔴 USD booking — reviewed total (ETB) vs stored total (USD) diverge 100× |
| UA-1b | `ua1b-usd-divergence` | USD card shows the USD fare, correctly converted from the internal ETB base (coherent) |
| UA-2 | `ua2-usd-booking` | USD booking — passenger amount in USD (display), charge basis stored coherently in ETB (currency mislabel fixed) |
| UA-3 | `ua3-djf` | DJF booking settles via forged gateway payment |
| UA-3w | `ua3-djf` | 🔴 DJF WALLET — reviewed (DJF) vs stored (ETB) diverge |
| UA-3w | `ua3-djf` | DJF WALLET — passenger amount in DJF, charge basis stored coherently in ETB (mislabel fixed) |
| UA-4 | `ua4-child-free` | first child <5 free total = one adult fare, free child not seated |
| UA-5 | `ua5-second-child-paid` | 1A+2C second child pays full fare (2 seats) |
| UA-6 | `ua6-round-trip` | 🔴 round-trip inbound leg has availability but no priced coach (booking blocked) |
| UA-6 | `ua6-round-trip` | round-trip books both legs reverse-leg pricing fixed (abs distance); 2 seats, total = 2× one-way (M-4-adjacent) |
| UA-8 | `ua8-promo-drop` | valid promo now applied server-side; booking stored at the discounted total (H-13 fixed & guarded) |
| UA-11 | `ua11-expired-promo` | expired promo ignored full fare booked |
| UA-13 | `ua13-forged-total` | client-forged `reviewedTotalMinor=1` now REJECTED 4xx, nothing stored (C-1 fixed & guarded) |
@@ -45,13 +45,13 @@ a thin back-compat wrapper.
| BC-7 | `pb-config-propagation` | negative seat-class base price now REJECTED (400, DTO `@Min(0)`) (M-1 fixed & guarded) |
| BC-8 | `config-validation` | promo over 100% now REJECTED (400, DTO `@Max(100)`) (M-2 fixed & guarded) |
| BC-9 | `config-validation` | negative seat-hold duration now REJECTED (400, whitelisted typed `/config` DTO) (M-3 fixed & guarded) |
| BC-10 | `config-validation` | 🔴 schedule with a past departure accepted (M-4) |
| BC-10 | `config-validation` | schedule with a past departure now REJECTED (400); future schedules still create (M-4 fixed & guarded) |
| BC-11 | `pb-config-propagation` | non-admin passenger now FORBIDDEN (403) from FX writes; admin still allowed (C-8 fixed & guarded) |
### Deferred (documented, not silently omitted)
- **UA-7** (round-trip berth) `specs/portal/ua7-berth.spec.ts` is `test.skip` with the reason: needs
a bed CoachType + reverse-leg pricing, both backend prerequisites (see UA-6 for the reverse-leg gap).
- **UA-7** (round-trip berth) `specs/portal/ua7-berth.spec.ts` is `test.skip`: still needs a bed
CoachType seed. (Reverse-leg pricing is no longer a blocker fixed under UA-6.)
- **UA-9 / UA-10 / UA-12 / UA-17** the matrix moves these to the API-level harness (over-100% /
over-subtotal promos, loyalty over-redeem, DJF×promo negative total): no reachable browser path
(server clamps `reviewedTotalMinor` 0; the portal never calls the loyalty/fare-quote path).