diff --git a/.claude/skills/edr-db/SKILL.md b/.claude/skills/edr-db/SKILL.md
new file mode 100644
index 000000000..47333128d
--- /dev/null
+++ b/.claude/skills/edr-db/SKILL.md
@@ -0,0 +1,42 @@
+---
+name: edr-db
+description: Query, EXPLAIN-validate, and inspect the remote EDR freight dev database. Use whenever you need to check data, verify a raw SQL statement before shipping it, list a table's columns, check schema drift, or see which migrations are recorded. psql is NOT installed on this machine — this runner is the sanctioned path. Triggers - "check the db", "query edr_dev", "does column X exist", "validate this SQL", "is migration recorded", "seed check", diagnosing a 400/500 whose cause may be data or schema.
+---
+
+# EDR dev-DB runner
+
+One script, runs from anywhere in the repo (resolves `pg` from `apps/edr-freight-api`):
+
+```bash
+node .claude/skills/edr-db/query.cjs "SELECT ... " # run SQL, console.table output
+node .claude/skills/edr-db/query.cjs explain "SELECT ..." # EXPLAIN-validate only (no rows touched)
+node .claude/skills/edr-db/query.cjs columns
# bare column names, for diffing vs the entity
+```
+
+Connection comes from `DB_HOST` / `DB_PORT` / `DB_USER` / `DB_PASSWORD` / `DB_NAME`,
+defaulting to the shared dev database (`edr_dev`).
+
+## Rules that go with it
+
+- **HARD RULE: every raw SQL statement you write into a service must pass
+ `explain` here before you ship it.** A typo'd column is a runtime 500 the
+ type-checker cannot catch.
+- Never assume a recorded migration applied — check `migrations ` **and**
+ `columns
` together. Recorded-but-absent = schema drift; fix with a
+ NEW repair migration (idempotent DDL, no-op `down()`), never by editing the
+ recorded one.
+- Writes to dev data are fine for seeding/diagnosis but keep them idempotent
+ (`WHERE NOT EXISTS` guards) — watch-mode API instances race `migrationsRun`,
+ and non-idempotent statements have double-run here before.
+- Timestamps for new migrations: must be unique across `src/migrations/` AND
+ higher than `SELECT max(timestamp) FROM public.migrations`.
+
+## Diagnosing a pasted 400/500 (the recurring loop)
+
+1. Find the route: grep the path segment in `apps/edr-freight-api/src/modules/*/**.controller.ts`.
+2. Read the service method — list its guard `throw`s. Most "bugs" are a guard
+ working as designed (handover unsigned, fee unpaid, not PAID, wrong direction).
+3. Check the actual DB state for that record with this runner.
+4. Only then decide: guard doing its job (fix the UI affordance) vs real defect.
diff --git a/.claude/skills/edr-db/query.cjs b/.claude/skills/edr-db/query.cjs
new file mode 100644
index 000000000..b4797bd45
--- /dev/null
+++ b/.claude/skills/edr-db/query.cjs
@@ -0,0 +1,88 @@
+#!/usr/bin/env node
+/**
+ * Dev-DB runner for the EDR freight database. psql is NOT installed on this
+ * machine; this is the sanctioned way to query, EXPLAIN-validate, and inspect
+ * the remote dev DB. Resolves `pg` from apps/edr-freight-api so it runs from
+ * anywhere in the repo.
+ *
+ * node .claude/skills/edr-db/query.cjs "SELECT ... " run SQL (console.table)
+ * node .claude/skills/edr-db/query.cjs explain "SELECT..." EXPLAIN-validate only
+ * node .claude/skills/edr-db/query.cjs columns
');
+ process.exit(2);
+ }
+ const c = new Client(cfg);
+ await c.connect();
+ try {
+ if (first === 'columns') {
+ const r = await c.query(
+ `SELECT column_name, data_type, is_nullable, column_default
+ FROM information_schema.columns
+ WHERE table_schema='freight' AND table_name=$1
+ ORDER BY ordinal_position`,
+ [rest[0]],
+ );
+ console.table(r.rows);
+ } else if (first === 'migrations') {
+ const like = rest[0] ? `%${rest[0]}%` : '%';
+ const r = await c.query(
+ `SELECT id, timestamp, name FROM public.migrations
+ WHERE name ILIKE $1 ORDER BY id DESC LIMIT 40`,
+ [like],
+ );
+ console.table(r.rows);
+ } else if (first === 'drift') {
+ // Quick drift signal: DB columns for the table. Compare by eye against
+ // the entity's @Column names; a recorded-but-absent column = drift.
+ const r = await c.query(
+ `SELECT column_name FROM information_schema.columns
+ WHERE table_schema='freight' AND table_name=$1 ORDER BY column_name`,
+ [rest[0]],
+ );
+ console.log(r.rows.map((x) => x.column_name).join('\n'));
+ } else if (first === 'explain') {
+ await c.query('EXPLAIN ' + rest.join(' '));
+ console.log('OK — statement is valid against', cfg.database);
+ } else {
+ const sql = [first, ...rest].join(' ');
+ const started = Date.now();
+ const r = await c.query(sql);
+ if (Array.isArray(r.rows) && r.rows.length) console.table(r.rows);
+ console.log(`${r.rowCount ?? 0} row(s), ${Date.now() - started}ms`);
+ }
+ } finally {
+ await c.end();
+ }
+}
+
+main().catch((e) => {
+ console.error('FAIL:', e.message);
+ process.exit(1);
+});
diff --git a/.claude/skills/standup/SKILL.md b/.claude/skills/standup/SKILL.md
new file mode 100644
index 000000000..272f280e7
--- /dev/null
+++ b/.claude/skills/standup/SKILL.md
@@ -0,0 +1,40 @@
+---
+name: standup
+description: Produce the work report Hagernesh asks for - "what have I done today", "tasks of yesterday and today", daily/period summaries for tickets or timesheets. Builds the answer from git history plus uncommitted work, never from memory alone.
+---
+
+# Work report (standup / ticket summary)
+
+Ground every line in git. Do not reconstruct from conversation memory — commits
+are the record.
+
+## Gather
+
+```bash
+# Commits in the window (adjust dates; author matches "Hagernesh")
+git log --since="YYYY-MM-DD 00:00" --until="YYYY-MM-DD 00:00" --author=Hagernesh \
+ --pretty=format:"%h|%ad|%s" --date=short
+
+# What each commit actually contains (subjects lie sometimes)
+git show --stat --pretty=format:"%s" | head -12
+
+# In-flight work = part of "today" even if uncommitted
+git status --short
+git log origin/dev..HEAD --oneline # branch commits not yet in dev
+```
+
+## Known pitfalls in this repo
+
+- **Check subjects against contents.** Commit titles here sometimes mismatch the
+ diff (e.g. a commit titled "unload export" that actually contained ISO
+ container validation). Use `git show --stat` before reporting a title as fact.
+- A day with no commits usually still has uncommitted/in-flight work — report it
+ as its own section with per-item status (done / uncommitted / blocked).
+- Merge commits from other authors are noise; filter with `--author`.
+
+## Output format
+
+One table per day: `# | Task (plain language, not the commit subject verbatim) |
+Commit / Status`. Follow with a short "carry-over / blocked" list naming what
+blocks each item. Keep it ticket-ready: no jargon that needs the repo open to
+decode.
diff --git a/.claude/skills/verify/SKILL.md b/.claude/skills/verify/SKILL.md
new file mode 100644
index 000000000..a2c715db4
--- /dev/null
+++ b/.claude/skills/verify/SKILL.md
@@ -0,0 +1,59 @@
+---
+name: verify
+description: Project definition-of-done runner for the EDR platform. Use before calling any code change finished, before committing, and whenever asked "is it done / does it work". Runs the targeted checks that actually catch this repo's failure modes - type-check with turbo filters, @edr/types dist rebuild, raw-SQL EXPLAIN validation, migration safety, and honest test reporting.
+---
+
+# Verify a change (EDR definition of done)
+
+Run these in order. Report which you ran and what each said — never call
+unverified work done.
+
+## 1. Type-check exactly what you touched
+
+```bash
+pnpm turbo type-check --filter=@edr/freight-api --filter=@edr/freight-backoffice --filter=@edr/freight-portal
+```
+
+Drop filters you didn't touch; whole-repo runs waste minutes. **If you edited
+`packages/types`, rebuild it FIRST** — consumers read its `dist/`, not `src/`:
+
+```bash
+pnpm turbo build --filter=@edr/types
+```
+
+## 2. Validate every raw SQL statement
+
+Each new/edited `dataSource.query` / `manager.query` string must pass:
+
+```bash
+node .claude/skills/edr-db/query.cjs explain ""
+```
+
+## 3. Migration checklist (if you added one)
+
+- Timestamp unique in `src/migrations/` **and** greater than
+ `node .claude/skills/edr-db/query.cjs "SELECT max(timestamp) FROM public.migrations"`.
+- DDL idempotent (`IF NOT EXISTS`, guarded backfills).
+- Watch-mode reload does NOT run migrations — apply the SQL to the dev DB
+ yourself or fully restart the API, then confirm with
+ `query.cjs columns
`.
+
+## 4. Tests — honest bar
+
+`pnpm test` for `@edr/freight-api` is currently red on `dev`, so a green suite
+is not the bar. The bar: run the specs nearest what you touched and introduce
+**no new failure**. If you touched a service constructor, update its `.spec.ts`
+mocks (constructor-arity breaks are this repo's most common test regression).
+
+## 5. Observe the behaviour
+
+Compiling is not working. Hit the endpoint, drive the UI flow, or query the
+resulting rows. If you genuinely could not observe it, say so explicitly in the
+summary — do not imply it was seen working.
+
+## 6. Before commit
+
+- Conventional message (`fix(warehouses): …`). Git hooks do NOT run in this
+ repo (husky shims exist but no user hooks) — nothing will catch it for you.
+- Lint the files you touched if in doubt: `pnpm turbo lint --filter=`.
+- Do not commit or push unless the user asked.
diff --git a/CLAUDE_NEW.md b/CLAUDE_NEW.md
new file mode 100644
index 000000000..11075e9f0
--- /dev/null
+++ b/CLAUDE_NEW.md
@@ -0,0 +1,294 @@
+# EDR Platform — Developer Guide
+
+> This file is the contract. If something here contradicts the code, the code is the
+> truth and this file is a bug — fix it in the same PR.
+
+## Overview
+
+Monorepo for the Ethio Djibouti Railway (EDR) digital platform. Contains the Freight
+Management and Passenger Management applications, a payment microservice, plus shared
+types, NestJS utilities, and React component libraries.
+
+The freight domain is the largest and most active area. Its core flow is:
+**booking → receive to warehouse → store → load onto train → dispatch → arrive → unload
+→ customer truck (self-haul) or EDR last mile → handover → exit paper → delivered.**
+Fees (storage, demurrage, double handling, truck detention) and allocation rules
+(warehouse/yard/zone) hang off the warehouse stage.
+
+## Apps
+
+| App | Package name | Purpose | Default port |
+| ------------------------------ | --------------------------- | -------------------------------------------------- | ------------ |
+| `edr-freight-api` | `@edr/freight-api` | NestJS API for freight management | 3001 |
+| `edr-freight-web/portal` | `@edr/freight-portal` | React frontend for freight customer/portal users | 5173 |
+| `edr-freight-web/backoffice` | `@edr/freight-backoffice` | React frontend for freight backoffice employees | 5183 |
+| `edr-passenger-api` | `@edr/passenger-api` | NestJS API for passenger management | 3002 |
+| `edr-payment-api` | `@edr/payment-api` | NestJS payment microservice (intents, webhooks) | 3003 |
+| `edr-passenger-web/portal` | `@edr/passenger-portal` | React frontend for passenger customer/portal users | 5174 |
+| `edr-passenger-web/backoffice` | `@edr/passenger-backoffice` | React frontend for passenger backoffice employees | 5184 |
+
+`edr-freight-web` and `edr-passenger-web` are grouping folders, not workspace packages.
+Each holds a `portal/` and `backoffice/` sub-app, both independent pnpm workspace
+packages (see `pnpm-workspace.yaml`).
+
+`apps/edr-landing/` exists on disk but has **no `package.json`** — it is not a workspace
+package and is not built, linted, or type-checked. Leave it alone unless asked.
+
+## Packages
+
+| Package | Purpose |
+| ---------------------- | ---------------------------------------------------------------------------------- |
+| `@edr/types` | Shared TypeScript interfaces and enums |
+| `@edr/api-common` | Shared NestJS decorators, filters, interceptors, pipes, BaseEntity, BaseRepository |
+| `@edr/ui-common` | Shared React components and theme |
+| `@edr/eslint-config` | Shared ESLint configurations (base/nestjs/react) |
+| `@edr/tsconfig` | Shared TypeScript configurations |
+| `@edr/prettier-config` | Shared Prettier configuration |
+
+**`@edr/types` is consumed as its built `dist/`** (`main: ./dist/index.js`). Editing a
+type in `packages/types/src` changes nothing for consumers until you rebuild:
+
+```bash
+pnpm turbo build --filter=@edr/types
+```
+
+If a type-check fails on a field you just added to `@edr/types`, this is why.
+
+## Commands
+
+| Command | Description |
+| --------------------------- | ---------------------------------------- |
+| `pnpm install` | Install all workspace dependencies |
+| `pnpm dev` | Run every app in dev mode |
+| `pnpm dev:freight` | Freight API + portal + backoffice |
+| `pnpm dev:freight:api` | Freight API only |
+| `pnpm dev:freight:portal` | Freight portal only |
+| `pnpm dev:freight:backoffice` | Freight backoffice only |
+| `pnpm dev:passenger` | Passenger API + web |
+| `pnpm dev:payment` | Payment API |
+| `pnpm build` | Build every package and app |
+| `pnpm test` | Run all tests (turbo) |
+| `pnpm lint` | Lint everything |
+| `pnpm type-check` | Type-check every package |
+| `pnpm format` | Format all files with Prettier |
+
+Prefer targeted turbo filters over whole-repo runs — they are minutes faster:
+
+```bash
+pnpm turbo type-check --filter=@edr/freight-api --filter=@edr/freight-backoffice
+```
+
+`apps/edr-freight-api` also carries many `seed:*` scripts (demo bookings, wagons, trains,
+gate-pass scenarios). Read the script before running one; several write real rows.
+
+## Environment & database
+
+- Postgres is **external**. There is no postgres service in `docker-compose.yaml`, and
+ no port `5433`/`5434` is published anywhere in the repo.
+- Freight API connection comes from `DB_HOST`, `DB_PORT`, `DB_USER`, `DB_PASSWORD`,
+ `DB_NAME` (defaults: `localhost:5433`, `edr_freight`). Development points these at a
+ remote database.
+- The connection sits behind a **connection pooler**. Do **not** pass
+ `extra.options: '-c search_path=…'` — the pooler rejects it with
+ `08P01 unsupported startup parameter in options: search_path`. `search_path` is applied
+ per-connection in a pool `connect` handler instead. See
+ `apps/edr-freight-api/src/config/database.config.ts` before touching connection options.
+- Each app owns its own database. **No cross-database joins**; cross-domain data flows
+ through API calls or message queues.
+- `psql` is not installed on the dev machine. To query the database, write a short Node
+ script using the `pg` client and run it from `apps/edr-freight-api` (where `pg` resolves).
+
+## Hard rules
+
+These are non-negotiable. Everything else is a strong default.
+
+- **pnpm only.** Never run `npm install` or `yarn`.
+- **TypeScript strict mode** is on in every package and app. Do not weaken it, and do not
+ reach for `any` to make an error go away.
+- **Never `synchronize: true`.** Not in production, not anywhere. It is currently `false`
+ in every config and it has already corrupted this database twice (see *Migrations*).
+ All schema changes go through TypeORM migrations.
+- **All entities** use UUID primary keys (`@PrimaryGeneratedColumn('uuid')`).
+- **All entities** extend `BaseEntity` from `@edr/api-common` — `createdAt`, `updatedAt`,
+ `deletedAt` (soft delete).
+- **All columns** are `snake_case` in the database (`@Column({ name: 'snake_case' })`);
+ TypeScript properties are `camelCase`.
+- **Controllers contain no business logic.** They validate, delegate, and shape the response.
+- **Conventional commits.** `fix(warehouses): …`, `feat(bookings): …`.
+- **Do not commit or push unless asked.** Propose the change; let the human decide when it lands.
+- **Do not break working behaviour to add new behaviour.** When a fix is risky, say so and
+ offer the safe version.
+
+## Architecture
+
+### NestJS module shape
+
+`module → controller → service → repository`, with `entities/` and `dto/` alongside.
+
+### Data access — the real model
+
+There are two sanctioned ways to read and write, and you must pick the right one:
+
+1. **Entity CRUD → the custom repository class.** Extends `BaseRepository` from
+ `@edr/api-common`. Services inject the repository class, never `Repository` directly.
+2. **Read projections, queue endpoints, cross-table reports → raw SQL** via
+ `this.dataSource.query(...)` or `manager.query(...)` inside a transaction.
+
+Raw SQL is normal here, not a smell — the warehouse and scheduling modules are built on it.
+It carries one obligation:
+
+> **HARD RULE — validate every raw SQL statement against a real database before you ship it.**
+> A typo'd column name is a runtime 500 that no type-checker will catch. Run it through
+> `EXPLAIN` against the dev database. Column drift is real (see *Migrations*).
+
+Writes inside a transaction use `manager.getRepository(Entity)`, not the injected repository,
+so they join the caller's transaction.
+
+**Never do slow I/O inside a database transaction.** Queue the work and fan it out after
+commit. An SMS awaited inside a transaction once held capacity locks open for the whole
+gateway timeout. Any outbound HTTP call must set an explicit `timeout` — axios defaults to
+no timeout and will wait forever.
+
+### Migrations
+
+Migrations are the most dangerous surface in this repo. Two production-grade incidents have
+already come from it.
+
+- `migrationsRun: true` — **migrations run automatically on API boot**, with
+ `migrationsTransactionMode: 'each'`.
+- Consequences you must design for:
+ - Running several `nest start --watch` instances races `migrationsRun`. A non-idempotent
+ data migration can execute twice. Keep one instance.
+ - A watch-mode hot reload does **not** re-run migrations. If you add a column that new
+ code reads, apply it to the dev database yourself (idempotently) or fully restart.
+- **Give every migration a unique timestamp.** 34 timestamps are currently shared by two or
+ more migrations. TypeORM orders by timestamp and breaks ties non-deterministically. Before
+ adding one, check the filename prefix is unused *and* higher than the newest recorded row.
+- **Write idempotent DDL**: `ADD COLUMN IF NOT EXISTS`, `CREATE INDEX IF NOT EXISTS`, and
+ backfills guarded by `WHERE col IS NULL`.
+- **Never assume a recorded migration actually applied.** `AddGrnNumberToWarehouseInventory`
+ was recorded in `migrations` while its column was absent — it had been dropped out of band.
+ TypeORM will never re-run a recorded migration, so the fix is a *new repair migration*.
+- **A repair migration's `down()` should be a no-op.** Reverting a repair must not
+ re-introduce the outage it fixed.
+
+### Auth
+
+Auth **is implemented in this repo.** Do not add TODO stubs, and do not write your own.
+
+- `@CurrentUser()` (`@edr/api-common`) is a real `createParamDecorator`, not a metadata stub.
+- Route protection uses `@UseGuards(JwtGuard)` and `@UseGuards(PermissionGuard([...]))`.
+- Freight-domain checks use `hasFreightPermission(user, FREIGHT_PERMS..)`.
+- Permissions are declared in `apps/edr-freight-api/src/seed/freight-permissions.registry.ts`.
+ Add a permission there before referencing it.
+- IAM has its own migrations, run ahead of freight migrations from the same data source, and
+ its own CLI scripts (`iam:migration:run`, `iam:seed:run`).
+
+Ownership checks are separate from permission checks. A staff user passes
+`hasFreightPermission`; a customer must additionally pass an ownership assertion such as
+`assertCustomerCanAccessBooking`. Do not drop the ownership check because the permission check passed.
+
+## Frontend conventions
+
+- The web apps use **Mantine v9**. Its APIs differ from v6/v7 — check the installed version
+ before copying a snippet.
+- `@edr/ui-common` holds shared components and theme; it is imported in ~94 files across the
+ freight web apps. Prefer it over re-implementing a component.
+- **Blob downloads need the async error decoder.** A request with `responseType: 'blob'`
+ delivers the JSON error body as a `Blob`, so the synchronous `extractErrorMessage` finds no
+ `.message` and degrades to `"Request failed with status code 400"`. Use
+ `await extractDownloadErrorMessage(error)` in every PDF/blob catch block. Mutation catches
+ keep the synchronous version — their bodies are already parsed JSON.
+- Server-side guards must be reflected in the UI. If the API will reject the action, the
+ button should be disabled, hidden, or explain the blocker — not fire and surface a 400.
+- Prefer disabling a control with a visible reason over silently hiding it.
+
+## Notifications
+
+In-app notifications resolve recipients from the company's **linked portal users**. If a
+company has none, `notify()` logs `0 recipients — skipped` and stores nothing, with no error.
+SMS and email still send, because they address the company's phone and email directly. Check
+this before debugging a "missing notification".
+
+## PDF generation
+
+Chromium is not installed in every environment. PDF paths must fall back to the hand-rolled
+generators (`styled-pdf.util.ts`, `buildFallbackPdf`, `buildTabularFallbackPdf`) rather than
+assume a headless browser exists.
+
+## Adding a new module to a NestJS app
+
+1. Create `modules//` with `entities/`, `dto/`, and the four
+ `.{module,controller,service,repository}.ts` files.
+2. The entity extends `BaseEntity` from `@edr/api-common`.
+3. The repository extends `BaseRepository` from `@edr/api-common`.
+4. The service injects the repository class (not `Repository` directly).
+5. The controller uses `@ApiTags()` + `@ApiOperation()` for Swagger, and guards the route.
+6. Register the module in the app's `app.module.ts`.
+
+## Adding a new shared component to `@edr/ui-common`
+
+1. Create `src/components//.tsx` and `src/components//index.ts`.
+2. Export from `src/index.ts`.
+3. Component is a functional component with a `ComponentNameProps` interface
+ (named-exported alongside the default).
+
+## Definition of done
+
+A change is done when **all** of these hold. State explicitly which you ran.
+
+1. **It type-checks.** `pnpm turbo type-check --filter=` passes.
+ If you edited `packages/types`, you ran `pnpm turbo build --filter=@edr/types` first.
+2. **Raw SQL is verified.** Every new or edited SQL statement ran under `EXPLAIN` against the
+ dev database without error.
+3. **Migrations are safe.** Unique timestamp, idempotent DDL, and — if the migration adds
+ something the new code reads — applied to the dev database, since watch mode will not run it.
+4. **No new test failures.** `pnpm test` for `@edr/freight-api` is **currently red on `dev`**,
+ so a fully green suite is not the bar. Run the specs covering what you touched and confirm
+ you introduced no new failure.
+5. **Lint and format are clean** for the files you touched. Git hooks do **not** run these
+ automatically (see below), so run them yourself.
+6. **The behaviour was actually observed**, not merely compiled — you drove the flow, hit the
+ endpoint, or ran the query. If you could not, say so plainly.
+7. **Report honestly.** If a check was skipped, tests failed, or a fix is unverified, say it in
+ the summary. Never describe unverified work as done.
+
+### Hooks do not run
+
+`commitlint.config.js` and a `lint-staged` config both exist, and husky's shims are installed
+at `.husky/_/`. But there are **no user hook scripts** (`.husky/pre-commit`,
+`.husky/commit-msg`), so husky's shim exits 0 and **neither lint-staged nor commitlint ever
+fire.** Nothing validates your commit message or formats your staged files. Run the checks by
+hand; do not assume the hook caught it.
+
+## Known traps
+
+| Trap | What happens | What to do |
+| --- | --- | --- |
+| Schema drift | A recorded migration's column is missing; queries and inserts 500 | Write a new repair migration; never edit the recorded one |
+| Duplicate migration timestamps | Non-deterministic ordering; a migration can be skipped | Pick a fresh, higher timestamp |
+| `@edr/types` not rebuilt | Consumers can't see your new field | `pnpm turbo build --filter=@edr/types` |
+| Slow I/O in a transaction | Locks held for the gateway timeout | Queue it; fan out after commit; always set an HTTP timeout |
+| Blob error bodies | Real 400 message replaced by "Request failed with status code 400" | `await extractDownloadErrorMessage(error)` |
+| Company with no portal user | In-app notification silently vanishes | Check portal users before debugging |
+| Watch-mode reload | New code, old schema → 500 | Apply the migration to the dev DB or restart fully |
+
+## Project skills
+
+Reusable workflows live in `.claude/skills/`. Use them instead of re-deriving the steps:
+
+| Skill | Use for |
+| --- | --- |
+| `edr-db` | Query / `EXPLAIN`-validate / inspect the remote dev DB (`node .claude/skills/edr-db/query.cjs …`). psql is not installed — this is the sanctioned path. Also carries the 400/500 diagnosis loop. |
+| `verify` | The definition-of-done runner: targeted type-check, `@edr/types` rebuild, SQL validation, migration checklist, honest test bar. Run before calling anything finished. |
+| `standup` | "What did I do today / this week" reports for tickets, grounded in `git log` — including the check that commit subjects match their contents. |
+
+## Working style
+
+- **Verify before asserting.** Read the code or query the database. Do not infer behaviour
+ from a filename.
+- **Investigate, then propose.** For anything risky or wide-reaching, present the plan and the
+ trade-off before changing files.
+- **Small, reviewable commits**, one logical change each, conventional message.
+- **Branch from `dev`; PRs target `dev`.**
+- When a finding turns out to be wrong, say so and retract it. A rejected finding is a result.
diff --git a/apps/edr-freight-api/src/app.module.ts b/apps/edr-freight-api/src/app.module.ts
index 9561a7b73..afb214137 100644
--- a/apps/edr-freight-api/src/app.module.ts
+++ b/apps/edr-freight-api/src/app.module.ts
@@ -41,6 +41,7 @@ import { NotificationsModule } from "./modules/notifications/notifications.modul
import { NotificationInboxModule } from "./modules/notification-inbox/notification-inbox.module";
import { FileUploadSettingsModule } from "./modules/file-upload-settings/file-upload-settings.module";
import { DropdownSettingsModule } from "./modules/dropdown-settings/dropdown-settings.module";
+import { ContractTemplatesModule } from "./modules/contract-templates/contract-templates.module";
import { OtpModule } from "./modules/otp/otp.module";
import { RuleEngineModule } from "./modules/rule-engine/rule-engine.module";
import { BackofficeModule } from "./modules/backoffice/backoffice.module";
@@ -158,6 +159,7 @@ import { LoggerMiddleware } from "./logger.middleware";
NotificationInboxModule,
FileUploadSettingsModule,
DropdownSettingsModule,
+ ContractTemplatesModule,
OtpModule,
RuleEngineModule,
BackofficeModule,
diff --git a/apps/edr-freight-api/src/contracts/contract-article.util.ts b/apps/edr-freight-api/src/contracts/contract-article.util.ts
new file mode 100644
index 000000000..5f0c86a6c
--- /dev/null
+++ b/apps/edr-freight-api/src/contracts/contract-article.util.ts
@@ -0,0 +1,63 @@
+import Handlebars from 'handlebars';
+
+/** One numbered clause of a dynamic article, with optional nested bullets. */
+export interface RenderedClause {
+ text: string;
+ bullets: string[];
+}
+
+/** A dynamic article ready for the Handlebars template. */
+export interface RenderedArticle {
+ number: number;
+ title: string;
+ /** Set (instead of clauses) when the body is a single plain paragraph. */
+ paragraph?: string;
+ clauses: RenderedClause[];
+}
+
+/**
+ * Parse a template article body into clauses. Format: one clause per line;
+ * lines prefixed with "- " become bullets nested under the preceding clause.
+ * A body that reduces to a single clause without bullets renders as a plain
+ * paragraph rather than a numbered list of one.
+ */
+export function parseArticleBody(body: string): Pick {
+ const lines = (body ?? '')
+ .split('\n')
+ .map((line) => line.trim())
+ .filter((line) => line.length > 0);
+
+ const clauses: RenderedClause[] = [];
+ for (const line of lines) {
+ if (line.startsWith('- ')) {
+ const bullet = line.slice(2).trim();
+ if (clauses.length === 0) {
+ clauses.push({ text: bullet, bullets: [] });
+ } else {
+ clauses[clauses.length - 1].bullets.push(bullet);
+ }
+ } else {
+ clauses.push({ text: line, bullets: [] });
+ }
+ }
+
+ if (clauses.length === 1 && clauses[0].bullets.length === 0) {
+ return { paragraph: clauses[0].text, clauses: [] };
+ }
+ return { clauses };
+}
+
+/**
+ * Interpolate Handlebars placeholders ({{client.companyName}}, {{contractDate}},
+ * …) inside admin-authored template text against the contract view model.
+ * Malformed placeholders must never break document generation — fall back to
+ * the raw text.
+ */
+export function interpolateTemplateText(text: string, context: unknown): string {
+ if (!text || !text.includes('{{')) return text ?? '';
+ try {
+ return Handlebars.compile(text)(context);
+ } catch {
+ return text;
+ }
+}
diff --git a/apps/edr-freight-api/src/contracts/contract-document-view-model.builder.ts b/apps/edr-freight-api/src/contracts/contract-document-view-model.builder.ts
index 05061ed9a..559415fd8 100644
--- a/apps/edr-freight-api/src/contracts/contract-document-view-model.builder.ts
+++ b/apps/edr-freight-api/src/contracts/contract-document-view-model.builder.ts
@@ -8,6 +8,7 @@ import {
ContractSignerRole,
} from '../modules/contracts/entities/contract-signature.entity';
import { ContractPricingBreakdown } from '../modules/contracts/contract-pricing.service';
+import { ContractTemplatesService } from '../modules/contract-templates/contract-templates.service';
import { ContractTemplateResolver } from './contract-template.resolver';
import { getTemplateMeta } from './contract-template.registry';
import { ContractViewModel } from './contract-view-model.builder';
@@ -74,6 +75,7 @@ export class ContractDocumentViewModelBuilder {
constructor(
private readonly contractsRepository: ContractsRepository,
private readonly templateResolver: ContractTemplateResolver,
+ private readonly contractTemplates: ContractTemplatesService,
) {}
async build(
@@ -86,7 +88,32 @@ export class ContractDocumentViewModelBuilder {
const templateKey =
contract.contractTemplateKey ?? this.templateResolver.resolve(this.toResolverInput(contract));
- const template = getTemplateMeta(templateKey);
+ let template = getTemplateMeta(templateKey);
+
+ // Prefer the admin-editable DB template matching the contract's
+ // direction/freight pair; fall back to the code-defined generic layout
+ // when none is active.
+ const dynamicSource = await this.contractTemplates.findActiveForContract(
+ contract.tradeDirection,
+ contract.freightType,
+ );
+ const dynamicTemplate = dynamicSource
+ ? {
+ code: dynamicSource.code,
+ name: dynamicSource.name,
+ documentTitle: dynamicSource.documentTitle,
+ whereasClauses: dynamicSource.whereasClauses ?? [],
+ articles: dynamicSource.articles ?? [],
+ }
+ : undefined;
+ if (dynamicTemplate) {
+ template = {
+ ...template,
+ title: dynamicTemplate.name,
+ templateFile: 'edr-dynamic.hbs',
+ };
+ }
+
const pricing = this.buildPricing(contract);
const signatures = await this.loadSignatures(contractId);
@@ -139,6 +166,7 @@ export class ContractDocumentViewModelBuilder {
hasContractDocument: hasContractFile,
hasCustomerSignature: hasCustomer,
hasStaffSignature: hasStaff,
+ dynamicTemplate,
};
return { contract, view };
diff --git a/apps/edr-freight-api/src/contracts/contract-dynamic-template.spec.ts b/apps/edr-freight-api/src/contracts/contract-dynamic-template.spec.ts
new file mode 100644
index 000000000..032030243
--- /dev/null
+++ b/apps/edr-freight-api/src/contracts/contract-dynamic-template.spec.ts
@@ -0,0 +1,151 @@
+import { parseArticleBody, interpolateTemplateText } from './contract-article.util';
+import { ContractRendererService } from './contract-renderer.service';
+import { getTemplateMeta } from './contract-template.registry';
+import type { ContractViewModel } from './contract-view-model.builder';
+
+describe('parseArticleBody', () => {
+ it('numbers each non-empty line as a clause', () => {
+ const parsed = parseArticleBody('First clause.\nSecond clause.\n\nThird clause.');
+ expect(parsed.paragraph).toBeUndefined();
+ expect(parsed.clauses.map((c) => c.text)).toEqual([
+ 'First clause.',
+ 'Second clause.',
+ 'Third clause.',
+ ]);
+ });
+
+ it('nests "- " lines as bullets under the previous clause', () => {
+ const parsed = parseArticleBody('Rates are:\n- USD 10 per ton\n- USD 20 per wagon\nPayment in advance.');
+ expect(parsed.clauses).toHaveLength(2);
+ expect(parsed.clauses[0].bullets).toEqual(['USD 10 per ton', 'USD 20 per wagon']);
+ expect(parsed.clauses[1].text).toBe('Payment in advance.');
+ });
+
+ it('renders a single bare line as a paragraph', () => {
+ const parsed = parseArticleBody('This Agreement becomes effective when signed.');
+ expect(parsed.paragraph).toBe('This Agreement becomes effective when signed.');
+ expect(parsed.clauses).toEqual([]);
+ });
+});
+
+describe('interpolateTemplateText', () => {
+ it('fills placeholders from the view model', () => {
+ expect(
+ interpolateTemplateText('Valid until August 31, {{contractYear}}.', {
+ contractYear: 2026,
+ }),
+ ).toBe('Valid until August 31, 2026.');
+ });
+
+ it('falls back to raw text on malformed placeholders', () => {
+ expect(interpolateTemplateText('Broken {{#if}} tag', {})).toBe('Broken {{#if}} tag');
+ });
+});
+
+describe('dynamic template rendering (edr-dynamic.hbs)', () => {
+ const renderer = new ContractRendererService();
+ renderer.onModuleInit();
+
+ function dynamicView(): ContractViewModel {
+ const meta = getTemplateMeta('IMP_BULK_USD_FORWARDING');
+ return {
+ bookingId: 'test-id',
+ reference: 'EDR/CT/2026/0042',
+ status: 'CONTRACT_READY',
+ templateKey: 'IMP_BULK_USD_FORWARDING',
+ template: { ...meta, title: 'Bulk Import Contract', templateFile: 'edr-dynamic.hbs' },
+ contractDate: '1 January 2026',
+ contractYear: 2026,
+ client: {
+ companyName: 'Abyssinia Trading PLC',
+ companyAddress: 'Bole Sub-city, Addis Ababa',
+ companyLocation: 'Ethiopia',
+ phone: '+251900000000',
+ email: 'test@example.com',
+ tinNumber: '1234567890',
+ vatNumber: 'VAT-001',
+ fanNumber: 'FAN-001',
+ businessLicense: 'BL-001',
+ },
+ provider: {
+ name: 'Ethio-Djibouti Standard Gauge Railway Share Company',
+ address: 'Nifas Silk Lafto Sub City, Addis Ababa, Ethiopia',
+ phone: '+251 11 872 0000',
+ email: 'info@edr.gov.et',
+ tinNumber: '—',
+ },
+ schedule: {
+ originLabel: 'Nagad',
+ destinationLabel: 'Galaan Multipurpose Port',
+ tradeDirection: 'IMPORT',
+ freightType: 'BULK',
+ serviceType: 'Rail + clearance',
+ scheduledDate: '—',
+ contractType: 'GENERAL',
+ cargoDescription: 'Steel billets',
+ totalWeightVgm: '—',
+ equipmentReturn: '—',
+ hazardousLabel: 'No',
+ firstMilePickupAddress: '—',
+ lastMileDeliveryAddress: '—',
+ },
+ pricing: {
+ displayMode: 'UNIT_RATES',
+ unitRates: [
+ { label: 'Rail transport', unitPrice: 59.4, unit: 'ton', currency: 'USD' },
+ ],
+ currency: 'USD',
+ equipmentReturn: '—',
+ originLabel: 'Nagad',
+ destinationLabel: 'Galaan Multipurpose Port',
+ } as unknown as ContractViewModel['pricing'],
+ signatures: [],
+ canSignCustomer: false,
+ canSignStaff: false,
+ hasContractDocument: false,
+ hasCustomerSignature: false,
+ hasStaffSignature: false,
+ dynamicTemplate: {
+ code: 'IMPORT_BULK',
+ name: 'Bulk Import Contract',
+ documentTitle: 'Bulk Cargo Transportation and Customs Clearance Services',
+ whereasClauses: ['The Client has agreed to engage the Service Provider.'],
+ articles: [
+ {
+ id: 'objective',
+ title: 'Objective of the Services',
+ body: 'Integrated logistics services including:\n- Rail transport to GMP\n- Customs clearance',
+ order: 1,
+ },
+ {
+ id: 'duration',
+ title: 'Duration',
+ body: 'Valid until August 31, {{contractYear}}.',
+ order: 2,
+ },
+ ],
+ },
+ };
+ }
+
+ it('renders numbered dynamic articles with bullets and interpolation', () => {
+ const html = renderer.render(dynamicView());
+ expect(html).toContain('Bulk Cargo Transportation and Customs Clearance Services');
+ expect(html).toContain('Article 1');
+ expect(html).toContain('Objective of the Services');
+ expect(html).toContain('Rail transport to GMP');
+ expect(html).toContain('Valid until August 31, 2026.');
+ expect(html).toContain('Abyssinia Trading PLC');
+ expect(html).toContain('Annex A — Commercial Schedule');
+ // Greenish theme marker from styles.hbs
+ expect(html).toContain('#1b9e7a');
+ });
+
+ it('keeps the generic layout when no dynamic template is attached', () => {
+ const view = dynamicView();
+ delete view.dynamicTemplate;
+ view.template = getTemplateMeta('IMP_BULK_USD_FORWARDING');
+ const html = renderer.render(view);
+ expect(html).toContain('Article 5: Contract Price');
+ });
+});
diff --git a/apps/edr-freight-api/src/contracts/contract-renderer.service.ts b/apps/edr-freight-api/src/contracts/contract-renderer.service.ts
index dd539df25..7b3301c87 100644
--- a/apps/edr-freight-api/src/contracts/contract-renderer.service.ts
+++ b/apps/edr-freight-api/src/contracts/contract-renderer.service.ts
@@ -3,6 +3,11 @@ import * as fs from 'fs';
import * as path from 'path';
import Handlebars from 'handlebars';
+import {
+ interpolateTemplateText,
+ parseArticleBody,
+ RenderedArticle,
+} from './contract-article.util';
import { ContractViewModel } from './contract-view-model.builder';
@Injectable()
@@ -31,9 +36,40 @@ export class ContractRendererService implements OnModuleInit {
return template({
...view,
paymentArticle: view.pricing.currency === 'ETB' ? 'ETB' : 'USD',
+ ...this.buildDynamicSections(view),
});
}
+ /**
+ * Turn the DB-backed dynamic template (when present) into render-ready data:
+ * interpolate placeholders against the view model, then parse each article
+ * body into numbered clauses with nested bullets.
+ */
+ private buildDynamicSections(view: ContractViewModel): {
+ dynamicDocumentTitle?: string;
+ dynamicWhereas?: string[];
+ dynamicArticles?: RenderedArticle[];
+ } {
+ const dyn = view.dynamicTemplate;
+ if (!dyn || dyn.articles.length === 0) return {};
+
+ const articles = [...dyn.articles]
+ .sort((a, b) => (a.order ?? 0) - (b.order ?? 0))
+ .map((article, index) => ({
+ number: index + 1,
+ title: interpolateTemplateText(article.title, view),
+ ...parseArticleBody(interpolateTemplateText(article.body, view)),
+ }));
+
+ return {
+ dynamicDocumentTitle: interpolateTemplateText(dyn.documentTitle, view),
+ dynamicWhereas: dyn.whereasClauses.map((clause) =>
+ interpolateTemplateText(clause, view),
+ ),
+ dynamicArticles: articles,
+ };
+ }
+
private getCompiled(fileName: string): Handlebars.TemplateDelegate {
const cached = this.compiled.get(fileName);
if (cached) return cached;
diff --git a/apps/edr-freight-api/src/contracts/contract-view-model.builder.ts b/apps/edr-freight-api/src/contracts/contract-view-model.builder.ts
index 41a2f3b44..d90b8e709 100644
--- a/apps/edr-freight-api/src/contracts/contract-view-model.builder.ts
+++ b/apps/edr-freight-api/src/contracts/contract-view-model.builder.ts
@@ -17,6 +17,21 @@ export interface ContractSignatureView {
signatureImageUrl?: string | null;
}
+/**
+ * DB-backed contract template (freight.contract_templates) attached to the
+ * view model when an active template matches the contract's direction/freight
+ * pair. The renderer turns its articles into numbered clauses and switches to
+ * the dedicated edr-dynamic.hbs layout; absent, the legacy generic layout with
+ * code-defined clause packs is used.
+ */
+export interface ContractDynamicTemplateView {
+ code: string;
+ name: string;
+ documentTitle: string;
+ whereasClauses: string[];
+ articles: Array<{ id: string; title: string; body: string; order: number }>;
+}
+
export interface ContractViewModel {
bookingId: string;
reference: string;
@@ -65,6 +80,7 @@ export interface ContractViewModel {
hasContractDocument: boolean;
hasCustomerSignature: boolean;
hasStaffSignature: boolean;
+ dynamicTemplate?: ContractDynamicTemplateView;
}
@Injectable()
diff --git a/apps/edr-freight-api/src/contracts/templates/_partials/dynamic_articles.hbs b/apps/edr-freight-api/src/contracts/templates/_partials/dynamic_articles.hbs
new file mode 100644
index 000000000..717fbde8f
--- /dev/null
+++ b/apps/edr-freight-api/src/contracts/templates/_partials/dynamic_articles.hbs
@@ -0,0 +1,23 @@
+{{#each dynamicArticles}}
+
+
+ This Contract Agreement is made on {{contractDate}}.
+
+
Between
+
+ Ethio-Djibouti Standard Gauge Railway Share Company (EDR), a share company
+ incorporated under the laws of the Federal Democratic Republic of Ethiopia (FDRE), having its
+ principal place of business at {{provider.address}} (hereinafter referred to as the
+ "Service Provider");
+
+
And
+
+ {{client.companyName}}, an organization incorporated under the laws of the
+ Federal Democratic Republic of Ethiopia (FDRE), having its principal place of business at
+ {{client.companyAddress}} (hereinafter referred to as the "Client").
+
+ The rates below are the frozen unit prices applicable to this contract. Quantities and resulting
+ totals are determined per shipment at booking time.
+
+ In witness whereof, the parties hereto have caused this contract to be signed in their respective
+ names as of the day and year first above written. The signatories confirm that they are fully
+ authorized to sign and execute this Contract Agreement.
+
+ {{> signatures_block}}
+
+
+
Witnesses
+
+
+
Name
Signature
Date
+
+
+
1.
+
2.
+
+
+
+
+
+
+
diff --git a/apps/edr-freight-api/src/migrations/2080000000000-DropWagonSpecColumns.ts b/apps/edr-freight-api/src/migrations/2080000000000-DropWagonSpecColumns.ts
new file mode 100644
index 000000000..0fe3569f4
--- /dev/null
+++ b/apps/edr-freight-api/src/migrations/2080000000000-DropWagonSpecColumns.ts
@@ -0,0 +1,53 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+/**
+ * Wagon spec belongs to the wagon TYPE, not to each physical wagon.
+ *
+ * `wagons.tare_weight` and `wagons.max_payload_weight` duplicated
+ * `wagon_types.tare_weight_tons` / `wagon_types.capacity_tons` on all 1100 rows,
+ * with nothing keeping them in step. They had drifted completely: every wagon
+ * disagreed with its type's tare (seeded ~20T against a real 22.4T NW5), and a
+ * third disagreed on payload (NW5 wagons claiming 22T–70T against a flat 70T).
+ * None of those numbers came from the railway.
+ *
+ * Nothing reads them for capacity — that math resolves tare and capacity through
+ * `wagon_type_id` — so dropping them removes a source of fiction rather than a
+ * source of truth. `wagon_type_id` is NOT NULL with no orphans, so the type is
+ * always reachable.
+ *
+ * A wagon re-tared after repair would need a nullable override column on
+ * `wagons` falling back to the type; deliberately not added, since no such
+ * per-wagon value exists today.
+ */
+export class DropWagonSpecColumns2080000000000 implements MigrationInterface {
+ public async up(queryRunner: QueryRunner): Promise {
+ await queryRunner.query(`
+ ALTER TABLE freight.wagons
+ DROP COLUMN IF EXISTS tare_weight,
+ DROP COLUMN IF EXISTS max_payload_weight;
+ `);
+ }
+
+ public async down(queryRunner: QueryRunner): Promise {
+ // Re-add nullable, backfill from the owning type, then restore NOT NULL.
+ // The pre-drop values were drifted seed data and are not recoverable — the
+ // type's spec is what they should always have held.
+ await queryRunner.query(`
+ ALTER TABLE freight.wagons
+ ADD COLUMN IF NOT EXISTS tare_weight NUMERIC(10, 2),
+ ADD COLUMN IF NOT EXISTS max_payload_weight NUMERIC(10, 2);
+ `);
+ await queryRunner.query(`
+ UPDATE freight.wagons w
+ SET tare_weight = t.tare_weight_tons,
+ max_payload_weight = t.capacity_tons
+ FROM freight.wagon_types t
+ WHERE t.id = w.wagon_type_id;
+ `);
+ await queryRunner.query(`
+ ALTER TABLE freight.wagons
+ ALTER COLUMN tare_weight SET NOT NULL,
+ ALTER COLUMN max_payload_weight SET NOT NULL;
+ `);
+ }
+}
diff --git a/apps/edr-freight-api/src/migrations/2090000000000-CreateContractTemplates.ts b/apps/edr-freight-api/src/migrations/2090000000000-CreateContractTemplates.ts
new file mode 100644
index 000000000..a553319cc
--- /dev/null
+++ b/apps/edr-freight-api/src/migrations/2090000000000-CreateContractTemplates.ts
@@ -0,0 +1,58 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+import { CONTRACT_TEMPLATE_DEFAULTS } from '../seed/data/contract-template-defaults';
+
+/**
+ * Creates freight.contract_templates — the six editable contract document
+ * templates (direction × freight type) whose dynamic articles drive the
+ * generated contract PDF — and seeds them from the EDR reference contract
+ * documents. Seeding is idempotent (ON CONFLICT (code) DO NOTHING) so admin
+ * edits are never overwritten by redeploys.
+ */
+export class CreateContractTemplates2090000000000 implements MigrationInterface {
+ public async up(queryRunner: QueryRunner): Promise {
+ await queryRunner.query(`
+ CREATE TABLE IF NOT EXISTS freight.contract_templates (
+ id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
+ code VARCHAR(40) NOT NULL,
+ name VARCHAR(200) NOT NULL,
+ description TEXT,
+ document_title VARCHAR(300) NOT NULL,
+ whereas_clauses JSONB NOT NULL DEFAULT '[]',
+ articles JSONB NOT NULL DEFAULT '[]',
+ is_active BOOLEAN NOT NULL DEFAULT TRUE,
+ created_at TIMESTAMPTZ NOT NULL DEFAULT now(),
+ updated_at TIMESTAMPTZ NOT NULL DEFAULT now(),
+ deleted_at TIMESTAMPTZ,
+ CONSTRAINT uq_contract_templates_code UNIQUE (code)
+ );
+ `);
+
+ for (const seed of CONTRACT_TEMPLATE_DEFAULTS) {
+ const articles = seed.articles.map((article, index) => ({
+ ...article,
+ order: index + 1,
+ }));
+ await queryRunner.query(
+ `
+ INSERT INTO freight.contract_templates
+ (code, name, description, document_title, whereas_clauses, articles)
+ VALUES ($1, $2, $3, $4, $5::jsonb, $6::jsonb)
+ ON CONFLICT (code) DO NOTHING;
+ `,
+ [
+ seed.code,
+ seed.name,
+ seed.description,
+ seed.documentTitle,
+ JSON.stringify(seed.whereasClauses),
+ JSON.stringify(articles),
+ ],
+ );
+ }
+ }
+
+ public async down(queryRunner: QueryRunner): Promise {
+ await queryRunner.query(`DROP TABLE IF EXISTS freight.contract_templates;`);
+ }
+}
diff --git a/apps/edr-freight-api/src/migrations/2090000000000-RepairGrnNumberColumn.ts b/apps/edr-freight-api/src/migrations/2090000000000-RepairGrnNumberColumn.ts
new file mode 100644
index 000000000..aa2f998a2
--- /dev/null
+++ b/apps/edr-freight-api/src/migrations/2090000000000-RepairGrnNumberColumn.ts
@@ -0,0 +1,55 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+/**
+ * Repairs `freight.warehouse_inventory.grn_number`.
+ *
+ * AddGrnNumberToWarehouseInventory1828000000000 is recorded in `migrations` but
+ * the column is absent on at least one environment - it was added, then dropped
+ * out-of-band (a stray `synchronize: true`, same class of damage that
+ * RepairSynchronizeDrift1870000000000 already had to undo). Because TypeORM has
+ * the original recorded, it will never re-run it.
+ *
+ * Without the column, everything that reads or writes a GRN fails with
+ * `column ... grn_number does not exist`:
+ * - bulkReceive() -> INSERT names grn_number (receive to warehouse)
+ * - importQueueByStatuses() -> Unloaded + Dispatch queues
+ * - exportInventoryByStatus() -> Received / Ready-To-Load / Loaded tabs
+ * - grnDocument() -> GRN PDF
+ *
+ * Idempotent: a no-op on environments where the column survived.
+ */
+export class RepairGrnNumberColumn2090000000000 implements MigrationInterface {
+ name = 'RepairGrnNumberColumn2090000000000';
+
+ public async up(queryRunner: QueryRunner): Promise {
+ await queryRunner.query(`
+ ALTER TABLE freight.warehouse_inventory
+ ADD COLUMN IF NOT EXISTS grn_number VARCHAR(100) NULL
+ `);
+
+ // Recover the GRN for rows received before the column existed: it was also
+ // written into the receive note as "GRN Number: ".
+ await queryRunner.query(`
+ UPDATE freight.warehouse_inventory
+ SET grn_number = substring(notes FROM 'GRN Number: ([^\\n\\r]+)')
+ WHERE grn_number IS NULL
+ AND notes IS NOT NULL
+ AND notes ~ 'GRN Number: '
+ `);
+
+ await queryRunner.query(`
+ CREATE INDEX IF NOT EXISTS idx_warehouse_inventory_grn_number
+ ON freight.warehouse_inventory(grn_number)
+ WHERE grn_number IS NOT NULL
+ `);
+ }
+
+ /**
+ * Deliberately a no-op. Dropping the column is what broke these environments
+ * in the first place, and the original 1828 migration already owns its own
+ * down(). Reverting this repair must not re-introduce the outage.
+ */
+ public async down(): Promise {
+ // intentionally empty
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/auth/customer-reset.controller.ts b/apps/edr-freight-api/src/modules/auth/customer-reset.controller.ts
new file mode 100644
index 000000000..2bf9f82fd
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/auth/customer-reset.controller.ts
@@ -0,0 +1,48 @@
+import {
+ Body,
+ Controller,
+ NotFoundException,
+ Param,
+ ParseUUIDPipe,
+ Post,
+} from "@nestjs/common";
+import { ApiBearerAuth, ApiOperation, ApiTags } from "@nestjs/swagger";
+
+import { BookingStaff } from "../../common/booking-guards";
+import { FREIGHT_PERMS } from "../../seed/freight-permissions.registry";
+import { BackofficeResetPasswordDto } from "./dto/forgot-password.dto";
+import { CustomerResetService } from "./customer-reset.service";
+
+/**
+ * Staff-triggered password reset. The customer receives the code and sets their
+ * own password — staff never see or handle a credential.
+ */
+@ApiTags("backoffice")
+@Controller("backoffice/customers")
+@ApiBearerAuth()
+export class CustomerResetController {
+ constructor(private readonly customerResetService: CustomerResetService) {}
+
+ @Post(":companyId/reset-password")
+ @BookingStaff(FREIGHT_PERMS.customers.resetPassword)
+ @ApiOperation({
+ summary: "Send a password-reset code to a customer's primary contact",
+ })
+ async resetPassword(
+ @Param("companyId", ParseUUIDPipe) companyId: string,
+ @Body() dto: BackofficeResetPasswordDto,
+ ) {
+ const maskedTarget = await this.customerResetService.sendResetToCustomer(
+ companyId,
+ dto.channel,
+ );
+
+ if (!maskedTarget) {
+ throw new NotFoundException(
+ `No active primary contact with ${dto.channel === "email" ? "an email address" : "a phone number"} for this customer`,
+ );
+ }
+
+ return { channel: dto.channel, maskedTarget };
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/auth/customer-reset.service.ts b/apps/edr-freight-api/src/modules/auth/customer-reset.service.ts
new file mode 100644
index 000000000..4c8f67599
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/auth/customer-reset.service.ts
@@ -0,0 +1,59 @@
+import { Injectable, Logger } from "@nestjs/common";
+import { InjectRepository } from "@nestjs/typeorm";
+import { Repository } from "typeorm";
+
+import { ExternalProfile } from "../companies/entities/external-profile.entity";
+import { ResetChannel } from "./dto/forgot-password.dto";
+import { ForgotPasswordService } from "./forgot-password.service";
+
+@Injectable()
+export class CustomerResetService {
+ private readonly logger = new Logger(CustomerResetService.name);
+
+ constructor(
+ @InjectRepository(ExternalProfile)
+ private readonly externalProfileRepository: Repository,
+ private readonly forgotPasswordService: ForgotPasswordService,
+ ) {}
+
+ /**
+ * Send a reset code to the company's primary contact. Returns the masked
+ * destination, or null when there is no eligible account for that channel.
+ *
+ * Unlike the public flow this reports failure honestly — the caller is an
+ * authenticated staff member, so there is nothing to enumerate.
+ */
+ async sendResetToCustomer(
+ companyId: string,
+ channel: ResetChannel,
+ ): Promise {
+ const profile = await this.externalProfileRepository.findOne({
+ where: { companyId, isPrimaryContact: true },
+ });
+
+ if (!profile) {
+ this.logger.warn(`Company ${companyId} has no primary contact profile`);
+ return null;
+ }
+
+ // Resolve through the same active-account gate the public flow uses, so a
+ // suspended customer cannot be reactivated by a staff-triggered reset.
+ const user = await this.forgotPasswordService.resolveActiveUserById(
+ profile.userId,
+ );
+ if (!user) {
+ this.logger.warn(
+ `Primary contact ${profile.userId} of company ${companyId} is not an active account`,
+ );
+ return null;
+ }
+
+ const target = await this.forgotPasswordService.requestReset(user, channel);
+ if (!target) return null;
+
+ this.logger.log(
+ `Staff-triggered ${channel} reset sent to user ${user.id} (company ${companyId})`,
+ );
+ return this.forgotPasswordService.maskTarget(target);
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/auth/dto/forgot-password.dto.ts b/apps/edr-freight-api/src/modules/auth/dto/forgot-password.dto.ts
new file mode 100644
index 000000000..be2f9bdac
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/auth/dto/forgot-password.dto.ts
@@ -0,0 +1,35 @@
+import { ApiProperty } from "@nestjs/swagger";
+import { IsEnum, IsNotEmpty, IsString } from "class-validator";
+
+/** The channel the reset code is delivered over. */
+export enum ResetChannel {
+ Email = "email",
+ Phone = "phone",
+}
+
+export class ForgotPasswordRequestDto {
+ @ApiProperty({
+ description: "Email, username, or phone number of the account to reset",
+ example: "name@company.com",
+ })
+ @IsString()
+ @IsNotEmpty()
+ identifier!: string;
+
+ @ApiProperty({ enum: ResetChannel })
+ @IsEnum(ResetChannel)
+ channel!: ResetChannel;
+}
+
+export class ForgotPasswordVerifyDto extends ForgotPasswordRequestDto {
+ @ApiProperty({ description: "The 6-digit code sent to the chosen channel" })
+ @IsString()
+ @IsNotEmpty()
+ otp!: string;
+}
+
+export class BackofficeResetPasswordDto {
+ @ApiProperty({ enum: ResetChannel })
+ @IsEnum(ResetChannel)
+ channel!: ResetChannel;
+}
diff --git a/apps/edr-freight-api/src/modules/auth/forgot-password.controller.ts b/apps/edr-freight-api/src/modules/auth/forgot-password.controller.ts
new file mode 100644
index 000000000..da49982d2
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/auth/forgot-password.controller.ts
@@ -0,0 +1,69 @@
+import { Body, Controller, Logger, Post } from "@nestjs/common";
+import { ApiOperation, ApiTags } from "@nestjs/swagger";
+import { Public } from "@edr/api-common";
+
+import {
+ ForgotPasswordRequestDto,
+ ForgotPasswordVerifyDto,
+} from "./dto/forgot-password.dto";
+import { ForgotPasswordService, ResetTicket } from "./forgot-password.service";
+
+/**
+ * Freight-owned reset flow. IAM ships a `forgot-password` route, but it only
+ * ever SMSes a magic link (no email channel, and it needs `FE_BASE_URL`, which
+ * this API does not set). These routes drive freight's own email-or-phone OTP
+ * service instead, then hand back a ticket for IAM's public `set-password`.
+ */
+@ApiTags("auth")
+@Controller("auth")
+@Public()
+export class ForgotPasswordController {
+ private readonly logger = new Logger(ForgotPasswordController.name);
+
+ constructor(private readonly forgotPasswordService: ForgotPasswordService) {}
+
+ @Post("forgot-password/request")
+ @ApiOperation({
+ summary: "Send a password-reset code over email or SMS",
+ description:
+ "Always reports success. An unknown, inactive, or channel-less account is " +
+ "indistinguishable from a real one, so this cannot be used to enumerate accounts.",
+ })
+ async request(@Body() dto: ForgotPasswordRequestDto): Promise<{ success: true }> {
+ const user = await this.forgotPasswordService.resolveActiveUser(dto.identifier);
+
+ if (user) {
+ try {
+ await this.forgotPasswordService.requestReset(user, dto.channel);
+ } catch (error) {
+ // A delivery failure must not change the response shape either — log it
+ // and let the caller sit on the OTP screen.
+ this.logger.error(
+ `Reset code delivery failed for user ${user.id}: ${
+ error instanceof Error ? error.message : String(error)
+ }`,
+ error instanceof Error ? error.stack : undefined,
+ );
+ }
+ } else {
+ this.logger.log("Reset requested for an unknown or inactive account");
+ }
+
+ return { success: true };
+ }
+
+ @Post("forgot-password/verify")
+ @ApiOperation({
+ summary: "Exchange a valid reset code for a single-use set-password ticket",
+ description:
+ "The returned { userId, verificationCode } is the body for PATCH /api/auth/set-password, " +
+ "alongside the same identifier and the new password.",
+ })
+ verify(@Body() dto: ForgotPasswordVerifyDto): Promise {
+ return this.forgotPasswordService.verifyAndMintTicket(
+ dto.identifier,
+ dto.channel,
+ dto.otp,
+ );
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/auth/forgot-password.service.ts b/apps/edr-freight-api/src/modules/auth/forgot-password.service.ts
new file mode 100644
index 000000000..42dc723d5
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/auth/forgot-password.service.ts
@@ -0,0 +1,169 @@
+import { randomBytes } from "node:crypto";
+
+import { BadRequestException, Injectable, Logger } from "@nestjs/common";
+import { InjectDataSource, InjectRepository } from "@nestjs/typeorm";
+import { DataSource, Repository } from "typeorm";
+
+import { hashPassword } from "@tria-plc/api-common/utils/argon";
+import { EOtpType } from "@tria-plc/iamapi-common/enums/otp.enum";
+import { User } from "@tria-plc/iamapi-common/entities/iam/user/user.entity";
+import { UserVerification } from "@tria-plc/iamapi-common/entities/iam/user/user-verification.entity";
+
+import { OtpService, OtpTarget } from "../otp/otp.service";
+import { ResetChannel } from "./dto/forgot-password.dto";
+
+/**
+ * How long the reset ticket minted for `PATCH /api/auth/set-password` stays
+ * valid. The IAM `setPassword` handler enforces this via `expiresAt`.
+ */
+const RESET_TICKET_TTL_MS = 10 * 60 * 1000;
+
+/** How long the emailed/SMS'd OTP stays valid before it must be re-requested. */
+const RESET_OTP_TTL_MS = 10 * 60 * 1000;
+
+export interface ResetTicket {
+ userId: string;
+ verificationCode: string;
+}
+
+@Injectable()
+export class ForgotPasswordService {
+ private readonly logger = new Logger(ForgotPasswordService.name);
+
+ constructor(
+ @InjectRepository(User)
+ private readonly userRepository: Repository,
+ @InjectDataSource()
+ private readonly dataSource: DataSource,
+ private readonly otpService: OtpService,
+ ) {}
+
+ /**
+ * Resolve an account that is actually eligible for a password reset.
+ *
+ * IAM's `set-password` handler flips `isActive: true` on the user as a side
+ * effect, so a reset on a deactivated account would silently resurrect it.
+ * Gating here — rather than at the set-password call — is what keeps that
+ * from being reachable. Mirrors IAM's own login lookup: match on any of
+ * email / username / phone, and require an active credential row.
+ */
+ async resolveActiveUser(identifier: string): Promise {
+ const id = identifier.trim();
+ if (!id) return null;
+
+ return await this.activeUserQuery()
+ .andWhere(
+ "(LOWER(u.email) = LOWER(:id) OR u.username = :id OR u.phoneNumber = :id)",
+ { id },
+ )
+ .getOne();
+ }
+
+ /** Same eligibility gate as {@link resolveActiveUser}, keyed by IAM user id. */
+ async resolveActiveUserById(userId: string): Promise {
+ if (!userId) return null;
+ return await this.activeUserQuery()
+ .andWhere("u.id = :userId", { userId })
+ .getOne();
+ }
+
+ /**
+ * Base query for accounts eligible to reset. `.where()` is claimed here so
+ * callers must use `.andWhere()` — TypeORM's `.where()` resets the clause,
+ * which would silently drop the `isActive` gate.
+ */
+ private activeUserQuery() {
+ return this.userRepository
+ .createQueryBuilder("u")
+ .innerJoin("u.userCredentials", "uc", "uc.isActive = true")
+ .where("u.isActive = true")
+ .orderBy("u.createdAt", "DESC");
+ }
+
+ /** The address the code goes to, taken from the account — never from input. */
+ private targetFor(user: User, channel: ResetChannel): OtpTarget | null {
+ if (channel === ResetChannel.Email) {
+ return user.email ? { email: user.email } : null;
+ }
+ return user.phoneNumber ? { phone: user.phoneNumber } : null;
+ }
+
+ /**
+ * Send a reset code to the account's own email/phone. Returns the target so
+ * authenticated (backoffice) callers can echo a masked version; unauthenticated
+ * callers must discard it.
+ *
+ * Note: `otp_verifications` keys rows by a unique phone/email, and `sendOtp`
+ * upserts. A reset request therefore overwrites any pending signup code for
+ * the same address — last code sent wins. That is the pre-existing behaviour
+ * between any two flows sharing this table.
+ */
+ async requestReset(
+ user: User,
+ channel: ResetChannel,
+ ): Promise {
+ const target = this.targetFor(user, channel);
+ if (!target) return null;
+
+ await this.otpService.sendOtp(target);
+ return target;
+ }
+
+ /**
+ * Prove possession of the OTP, then mint an IAM reset ticket the caller can
+ * spend on the public `PATCH /api/auth/set-password`.
+ *
+ * Minting a `UserVerification` row rather than writing `UserCredential`
+ * ourselves keeps IAM as the single owner of the password write path (old
+ * credential deactivation, argon hashing, changed-at bookkeeping).
+ */
+ async verifyAndMintTicket(
+ identifier: string,
+ channel: ResetChannel,
+ otp: string,
+ ): Promise {
+ const user = await this.resolveActiveUser(identifier);
+ const target = user && this.targetFor(user, channel);
+
+ if (!user?.id || !target) {
+ // Same shape as a wrong code: a caller probing for accounts learns nothing
+ // beyond what the request step already (deliberately) refuses to tell them.
+ throw new BadRequestException("Invalid verification code");
+ }
+
+ await this.otpService.verifyOtpForAction(target, otp, RESET_OTP_TTL_MS);
+
+ const code = randomBytes(24).toString("base64url");
+ const verificationCode = await hashPassword(code);
+ const userId = user.id;
+
+ await this.dataSource.transaction(async (manager) => {
+ const repo = manager.getRepository(UserVerification);
+ // Retire any outstanding codes so only the ticket we just minted can be
+ // spent — `findVerificationForPrimaryReset` reads the newest row.
+ await repo.update({ userId }, { isUsed: true });
+ await repo.insert({
+ userId,
+ otpType: EOtpType.RESET_PASSWORD,
+ verificationCode,
+ expiresAt: new Date(Date.now() + RESET_TICKET_TTL_MS),
+ isUsed: false,
+ attemptCount: 0,
+ });
+ });
+
+ this.logger.log(`Reset ticket minted for user ${userId}`);
+ return { userId, verificationCode: code };
+ }
+
+ /** `+251911234567` -> `+251•••••4567`; `ab@x.com` -> `a•@x.com`. */
+ maskTarget(target: OtpTarget): string {
+ if (target.email) {
+ const [local, domain] = target.email.split("@");
+ const head = local.slice(0, 1);
+ return `${head}${"•".repeat(Math.max(local.length - 1, 1))}@${domain}`;
+ }
+ const phone = target.phone ?? "";
+ return `${phone.slice(0, 4)}${"•".repeat(Math.max(phone.length - 8, 1))}${phone.slice(-4)}`;
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/auth/freight-auth.module.ts b/apps/edr-freight-api/src/modules/auth/freight-auth.module.ts
index 16fbeffda..6415cf4c1 100644
--- a/apps/edr-freight-api/src/modules/auth/freight-auth.module.ts
+++ b/apps/edr-freight-api/src/modules/auth/freight-auth.module.ts
@@ -2,15 +2,35 @@ import { Module } from '@nestjs/common';
import { TypeOrmModule } from '@nestjs/typeorm';
import { User } from '@tria-plc/iamapi-common/entities/iam/user/user.entity';
+import { UserVerification } from '@tria-plc/iamapi-common/entities/iam/user/user-verification.entity';
+import { ExternalProfile } from '../companies/entities/external-profile.entity';
+import { OtpModule } from '../otp/otp.module';
import { CheckAvailabilityController } from './check-availability.controller';
import { CheckAvailabilityService } from './check-availability.service';
+import { CustomerResetController } from './customer-reset.controller';
+import { CustomerResetService } from './customer-reset.service';
+import { ForgotPasswordController } from './forgot-password.controller';
+import { ForgotPasswordService } from './forgot-password.service';
import { FreightMeController } from './freight-me.controller';
import { FreightMeService } from './freight-me.service';
@Module({
- imports: [TypeOrmModule.forFeature([User])],
- controllers: [FreightMeController, CheckAvailabilityController],
- providers: [FreightMeService, CheckAvailabilityService],
+ imports: [
+ TypeOrmModule.forFeature([User, UserVerification, ExternalProfile]),
+ OtpModule,
+ ],
+ controllers: [
+ FreightMeController,
+ CheckAvailabilityController,
+ ForgotPasswordController,
+ CustomerResetController,
+ ],
+ providers: [
+ FreightMeService,
+ CheckAvailabilityService,
+ ForgotPasswordService,
+ CustomerResetService,
+ ],
})
export class FreightAuthModule {}
diff --git a/apps/edr-freight-api/src/modules/bookings/booking-pricing.service.ts b/apps/edr-freight-api/src/modules/bookings/booking-pricing.service.ts
index d63106c2b..00cf55e17 100644
--- a/apps/edr-freight-api/src/modules/bookings/booking-pricing.service.ts
+++ b/apps/edr-freight-api/src/modules/bookings/booking-pricing.service.ts
@@ -400,8 +400,18 @@ export class BookingPricingService {
* All three components are produced by RuleEngineService.evaluate, so submit
* simply re-runs the engine — there is no extra submit-time inflation.
*/
- async computeSubmitPriorityScore(booking: Booking): Promise {
+ async computeSubmitPriorityScore(
+ booking: Booking,
+ totalWagonsOverride?: number,
+ ): Promise {
const evalInput = await this.buildEvalInputForBooking(booking);
+ // BULK bookings have no container lines, so buildEvalInputForBooking yields
+ // totalWagons = 0 and every wagon-range priority config misses. The batch
+ // engine derives a bulk booking's wagon footprint from tonnage vs. live
+ // wagon capacity and passes it here to score the booking properly.
+ if (totalWagonsOverride != null && totalWagonsOverride > 0) {
+ evalInput.totalWagons = totalWagonsOverride;
+ }
const ruleResult = await this.ruleEngineService.evaluate(evalInput);
return ruleResult.priorityScore;
}
diff --git a/apps/edr-freight-api/src/modules/bookings/bookings.repository.ts b/apps/edr-freight-api/src/modules/bookings/bookings.repository.ts
index 2fe45bd8a..46b40d212 100644
--- a/apps/edr-freight-api/src/modules/bookings/bookings.repository.ts
+++ b/apps/edr-freight-api/src/modules/bookings/bookings.repository.ts
@@ -44,6 +44,11 @@ export interface BookingListFilterOptions {
customsClearingEnabled?: boolean;
createdFrom?: string;
createdTo?: string;
+ scheduledFrom?: string;
+ scheduledTo?: string;
+ originYardId?: string;
+ destinationYardId?: string;
+ isGovernment?: 'true' | 'false';
consolidationPaired?: string;
}
@@ -546,6 +551,11 @@ export class BookingsRepository extends BaseRepository {
if (!statuses.length) return [];
return this.repository.find({
where: { status: In(statuses) },
+ relations: {
+ company: true,
+ originYard: true,
+ destinationYard: true,
+ },
order: { createdAt: 'DESC' },
});
}
@@ -809,6 +819,32 @@ export class BookingsRepository extends BaseRepository {
createdTo: options.createdTo,
});
}
+ if (options.scheduledFrom) {
+ qb.andWhere('booking.scheduled_date >= :scheduledFrom', {
+ scheduledFrom: options.scheduledFrom,
+ });
+ }
+ if (options.scheduledTo) {
+ // Inclusive end-of-day: callers pass a date; include the whole day.
+ qb.andWhere('booking.scheduled_date <= :scheduledTo', {
+ scheduledTo: options.scheduledTo,
+ });
+ }
+ if (options.originYardId) {
+ qb.andWhere('booking.origin_yard_id = :originYardId', {
+ originYardId: options.originYardId,
+ });
+ }
+ if (options.destinationYardId) {
+ qb.andWhere('booking.destination_yard_id = :destinationYardId', {
+ destinationYardId: options.destinationYardId,
+ });
+ }
+ if (options.isGovernment === 'true') {
+ qb.andWhere('booking.is_government = TRUE');
+ } else if (options.isGovernment === 'false') {
+ qb.andWhere('booking.is_government = FALSE');
+ }
if (options.tradeDirection) {
qb.andWhere('booking.trade_direction = :tradeDirection', {
tradeDirection: options.tradeDirection,
@@ -994,6 +1030,7 @@ export class BookingsRepository extends BaseRepository {
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
.leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.leftJoin(TrainScheduleBooking, 'sb', 'sb.booking_id = booking.id')
.where('booking.train_schedule_id = :scheduleId', { scheduleId })
.andWhere('sb.id IS NULL')
@@ -1025,6 +1062,7 @@ export class BookingsRepository extends BaseRepository {
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
.leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.leftJoin(TrainScheduleBooking, 'sb', 'sb.booking_id = booking.id')
.where('booking.origin_yard_id = :originYardId', { originYardId })
.andWhere('booking.destination_yard_id = :destinationYardId', {
@@ -1064,6 +1102,7 @@ export class BookingsRepository extends BaseRepository {
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
.leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.leftJoin(TrainScheduleBooking, 'sb', 'sb.booking_id = booking.id')
.where('booking.origin_yard_id IN (:...corridorYardIds)', { corridorYardIds })
.andWhere('booking.destination_yard_id IN (:...corridorYardIds)', {
@@ -1129,6 +1168,7 @@ export class BookingsRepository extends BaseRepository {
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
.leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.where('booking.train_schedule_id = :scheduleId', { scheduleId })
.orderBy('booking.is_government', 'DESC')
.addOrderBy('booking.priority_score', 'DESC')
@@ -1143,6 +1183,7 @@ export class BookingsRepository extends BaseRepository {
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
.leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.where('booking.train_schedule_id = :scheduleId', { scheduleId })
.andWhere(`booking.status IN ('SELECTED_FOR_BATCH', 'AWAITING_PAYMENT')`)
.getMany();
@@ -1172,6 +1213,8 @@ export class BookingsRepository extends BaseRepository {
return this.repository
.createQueryBuilder('booking')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
+ .leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.innerJoin(
TrainScheduleBooking,
'sb',
diff --git a/apps/edr-freight-api/src/modules/bookings/bookings.service.ts b/apps/edr-freight-api/src/modules/bookings/bookings.service.ts
index 48a29988a..dac739fbf 100644
--- a/apps/edr-freight-api/src/modules/bookings/bookings.service.ts
+++ b/apps/edr-freight-api/src/modules/bookings/bookings.service.ts
@@ -1125,6 +1125,30 @@ export class BookingsService {
);
}
+ /**
+ * Batched version of the findById flag: marks each page item whose booking
+ * has a generated-but-unsigned SELF_HAUL handover, so list rows (portal
+ * dashboard) can show "Approve delivery" for exactly the generated→signed
+ * window. One query for the whole page.
+ */
+ private async attachHandoverFlags(bookings: Booking[]): Promise {
+ const ids = bookings.map((b) => b.id);
+ if (!ids.length) return;
+ const rows: Array<{ bookingId: string }> = await this.dataSource.query(
+ `SELECT DISTINCT booking_id AS "bookingId"
+ FROM freight.booking_handovers
+ WHERE booking_id = ANY($1::uuid[])
+ AND signed_at IS NULL AND deleted_at IS NULL
+ AND mile_type = 'SELF_HAUL'`,
+ [ids],
+ );
+ const pending = new Set(rows.map((r) => r.bookingId));
+ for (const b of bookings) {
+ (b as Booking & { handoverAwaitingSignature?: boolean }).handoverAwaitingSignature =
+ pending.has(b.id);
+ }
+ }
+
async findAll(
filter: FilterBookingDto,
forceCompanyId?: string,
@@ -1135,7 +1159,7 @@ export class BookingsService {
const statusFilter = this.parseStatusFilter(filter);
const schedulingStatusFilter = this.parseSchedulingStatusFilter(filter);
- return this.bookingsRepository.findAllPaginated({
+ const result = await this.bookingsRepository.findAllPaginated({
page,
pageSize,
...statusFilter,
@@ -1158,10 +1182,17 @@ export class BookingsService {
paymentStatus: filter.paymentStatus,
createdFrom: filter.createdFrom,
createdTo: filter.createdTo,
+ scheduledFrom: filter.scheduledFrom,
+ scheduledTo: filter.scheduledTo,
+ originYardId: filter.originYardId,
+ destinationYardId: filter.destinationYardId,
+ isGovernment: filter.isGovernment,
consolidationPaired: filter.consolidationPaired,
sortBy: filter.sortBy,
sortOrder: filter.sortOrder,
});
+ await this.attachHandoverFlags(result.items ?? []);
+ return result;
}
/** Booking statuses at which a customer can pay (mirrors booking-payment.service). */
@@ -1371,11 +1402,17 @@ export class BookingsService {
serviceTypeId: filter.serviceTypeId,
cargoTypeId: filter.cargoTypeId,
freightType: filter.freightType,
+ bookingType: filter.bookingType,
tradeDirection: filter.tradeDirection,
paymentCurrency: filter.paymentCurrency,
paymentStatus: filter.paymentStatus,
createdFrom: filter.createdFrom,
createdTo: filter.createdTo,
+ scheduledFrom: filter.scheduledFrom,
+ scheduledTo: filter.scheduledTo,
+ originYardId: filter.originYardId,
+ destinationYardId: filter.destinationYardId,
+ isGovernment: filter.isGovernment,
consolidationPaired: filter.consolidationPaired,
};
diff --git a/apps/edr-freight-api/src/modules/bookings/dto/filter-booking.dto.ts b/apps/edr-freight-api/src/modules/bookings/dto/filter-booking.dto.ts
index d189f5448..ae973b97d 100644
--- a/apps/edr-freight-api/src/modules/bookings/dto/filter-booking.dto.ts
+++ b/apps/edr-freight-api/src/modules/bookings/dto/filter-booking.dto.ts
@@ -81,6 +81,31 @@ export class FilterBookingDto {
@IsDateString()
createdTo?: string;
+ @ApiPropertyOptional({ description: 'Filter bookings scheduled on/after this date (ISO)' })
+ @IsOptional()
+ @IsDateString()
+ scheduledFrom?: string;
+
+ @ApiPropertyOptional({ description: 'Filter bookings scheduled on/before this date (ISO)' })
+ @IsOptional()
+ @IsDateString()
+ scheduledTo?: string;
+
+ @ApiPropertyOptional({ format: 'uuid', description: 'Filter by origin yard' })
+ @IsOptional()
+ @IsUUID()
+ originYardId?: string;
+
+ @ApiPropertyOptional({ format: 'uuid', description: 'Filter by destination yard' })
+ @IsOptional()
+ @IsUUID()
+ destinationYardId?: string;
+
+ @ApiPropertyOptional({ enum: ['true', 'false'], description: 'Filter government vs private bookings' })
+ @IsOptional()
+ @IsIn(['true', 'false'])
+ isGovernment?: 'true' | 'false';
+
@ApiPropertyOptional({ enum: TRADE_DIRECTIONS })
@IsOptional()
@IsIn([...TRADE_DIRECTIONS])
diff --git a/apps/edr-freight-api/src/modules/companies/company-change-request.repository.spec.ts b/apps/edr-freight-api/src/modules/companies/company-change-request.repository.spec.ts
new file mode 100644
index 000000000..73271e0af
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/companies/company-change-request.repository.spec.ts
@@ -0,0 +1,88 @@
+import { Repository } from "typeorm";
+
+import { CompanyChangeRequestRepository } from "./company-change-request.repository";
+import {
+ ChangeRequestStatus,
+ CompanyChangeRequest,
+} from "./entities/company-change-request.entity";
+
+type Row = Pick & { createdAt: Date };
+
+const COMPANY_ID = "company-1";
+
+/**
+ * Stands in for the TypeORM repository over a fixed set of rows, honouring the
+ * `where.status` filter and the `createdAt DESC` ordering findOne relies on.
+ */
+function mockRepositoryOver(rows: Row[]) {
+ return {
+ findOne: jest.fn(
+ ({ where }: { where: Partial & { companyId: string } }) =>
+ Promise.resolve(
+ rows
+ .filter(
+ (row) =>
+ where.companyId === COMPANY_ID &&
+ (where.status === undefined || row.status === where.status),
+ )
+ .sort((a, b) => b.createdAt.getTime() - a.createdAt.getTime())[0] ??
+ null,
+ ),
+ ),
+ } as unknown as Repository;
+}
+
+function subject(rows: Row[]) {
+ return new CompanyChangeRequestRepository(mockRepositoryOver(rows));
+}
+
+describe("CompanyChangeRequestRepository.findLatestOpenByCompanyId", () => {
+ const rejected: Row = {
+ id: "rejected",
+ status: ChangeRequestStatus.Rejected,
+ createdAt: new Date("2026-01-01T00:00:00.000Z"),
+ };
+
+ it("returns the pending request when one is open", async () => {
+ const pending: Row = {
+ id: "pending",
+ status: ChangeRequestStatus.Pending,
+ createdAt: new Date("2026-01-02T00:00:00.000Z"),
+ };
+
+ const result = await subject([rejected, pending]).findLatestOpenByCompanyId(
+ COMPANY_ID,
+ );
+
+ expect(result?.id).toBe("pending");
+ });
+
+ it("returns the latest rejected request when nothing is pending", async () => {
+ const result = await subject([rejected]).findLatestOpenByCompanyId(
+ COMPANY_ID,
+ );
+
+ expect(result?.id).toBe("rejected");
+ });
+
+ it("returns null once a resubmit of a rejected request is approved", async () => {
+ const approved: Row = {
+ id: "approved",
+ status: ChangeRequestStatus.Approved,
+ createdAt: new Date("2026-01-02T00:00:00.000Z"),
+ };
+
+ const result = await subject([
+ rejected,
+ approved,
+ ]).findLatestOpenByCompanyId(COMPANY_ID);
+
+ expect(result).toBeNull();
+ });
+
+ it("returns null when the company has no requests", async () => {
+ const result = await subject([]).findLatestOpenByCompanyId(COMPANY_ID);
+
+ expect(result).toBeNull();
+ });
+});
diff --git a/apps/edr-freight-api/src/modules/companies/company-change-request.repository.ts b/apps/edr-freight-api/src/modules/companies/company-change-request.repository.ts
index 24d988452..eb44d56cb 100644
--- a/apps/edr-freight-api/src/modules/companies/company-change-request.repository.ts
+++ b/apps/edr-freight-api/src/modules/companies/company-change-request.repository.ts
@@ -28,18 +28,23 @@ export class CompanyChangeRequestRepository extends BaseRepository {
const pending = await this.findPendingByCompanyId(companyId);
if (pending) return pending;
- return this.repository.findOne({
- where: { companyId, status: ChangeRequestStatus.Rejected },
+ const latest = await this.repository.findOne({
+ where: { companyId },
order: { createdAt: "DESC" },
});
+ return latest?.status === ChangeRequestStatus.Rejected ? latest : null;
}
async findById(id: string): Promise {
diff --git a/apps/edr-freight-api/src/modules/companies/company-profile.repository.ts b/apps/edr-freight-api/src/modules/companies/company-profile.repository.ts
index 15aec5ac6..9bf14cd61 100644
--- a/apps/edr-freight-api/src/modules/companies/company-profile.repository.ts
+++ b/apps/edr-freight-api/src/modules/companies/company-profile.repository.ts
@@ -1,4 +1,4 @@
-import { Injectable } from "@nestjs/common";
+import { Injectable, InternalServerErrorException } from "@nestjs/common";
import { InjectRepository } from "@nestjs/typeorm";
import { Repository } from "typeorm";
import { BaseRepository } from "@edr/api-common";
@@ -20,6 +20,11 @@ const PREFIX_MAP: Record = {
[ProfileType.transporter]: "TR",
};
+const SERIES_LETTERS = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
+
+/** Numbers per series letter: A00001..A99999, then B00001. */
+const SERIES_SIZE = 99_999;
+
@Injectable()
export class CompanyProfileRepository extends BaseRepository {
constructor(
@@ -38,9 +43,20 @@ export class CompanyProfileRepository extends BaseRepository {
const result = await this.repository.query(
`SELECT nextval('${seqName}') AS next_id`,
);
- const nextId = result[0].next_id as number;
+ const nextId = Number(result[0].next_id);
+ const offset = nextId - 1;
+ const seriesIndex = Math.floor(offset / SERIES_SIZE);
+
+ if (seriesIndex >= SERIES_LETTERS.length) {
+ throw new InternalServerErrorException(
+ `Company profile reference series exhausted for type "${type}"`,
+ );
+ }
+
+ const letter = SERIES_LETTERS[seriesIndex];
+ const number = (offset % SERIES_SIZE) + 1;
const prefix = PREFIX_MAP[type];
- return `${prefix}-${String(nextId).padStart(5, "0")}`;
+ return `${prefix}-${letter}${String(number).padStart(5, "0")}`;
}
async findByCompanyId(companyId: string): Promise {
diff --git a/apps/edr-freight-api/src/modules/companies/entities/company-profile.entity.ts b/apps/edr-freight-api/src/modules/companies/entities/company-profile.entity.ts
index 72696766f..2266b0c65 100644
--- a/apps/edr-freight-api/src/modules/companies/entities/company-profile.entity.ts
+++ b/apps/edr-freight-api/src/modules/companies/entities/company-profile.entity.ts
@@ -60,7 +60,7 @@ export class CompanyProfile extends BaseEntity {
type!: ProfileType;
/**
- * Official profile reference (e.g. "EX-00001"). Minted only when the profile
+ * Official profile reference (e.g. "EX-A00001"). Minted only when the profile
* is approved (status → Active); pending/unapproved profiles carry NULL.
* The unique index tolerates this because Postgres treats NULLs as distinct.
* API responses surface it as "" when absent — see ResponseCompanyProfileDto.
diff --git a/apps/edr-freight-api/src/modules/contract-templates/contract-templates.controller.ts b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.controller.ts
new file mode 100644
index 000000000..8cf1c5671
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.controller.ts
@@ -0,0 +1,97 @@
+import {
+ Body,
+ Controller,
+ Delete,
+ Get,
+ Param,
+ Patch,
+ Post,
+ Put,
+} from "@nestjs/common";
+import { ApiOperation, ApiTags } from "@nestjs/swagger";
+
+import { FreightAdmin } from "../../common/booking-guards";
+import { ContractTemplatesService } from "./contract-templates.service";
+import {
+ CreateArticleDto,
+ PreviewContractTemplateDto,
+ ReplaceArticlesDto,
+ UpdateArticleDto,
+ UpdateContractTemplateDto,
+} from "./dto/contract-template.dto";
+
+@ApiTags("contract-templates")
+@Controller("contract-templates")
+export class ContractTemplatesController {
+ constructor(private readonly service: ContractTemplatesService) {}
+
+ // Reads stay open to authenticated staff (the backoffice Templates tab);
+ // writes are admin-guarded like other freight configuration resources.
+
+ @Get()
+ @ApiOperation({ summary: "List the six contract document templates" })
+ list() {
+ return this.service.list();
+ }
+
+ @Get(":code")
+ @ApiOperation({ summary: "Get one contract template by code" })
+ getByCode(@Param("code") code: string) {
+ return this.service.getByCode(code);
+ }
+
+ @Patch(":code")
+ @FreightAdmin()
+ @ApiOperation({ summary: "Update template metadata (name, title, recitals, active flag)" })
+ update(@Param("code") code: string, @Body() dto: UpdateContractTemplateDto) {
+ return this.service.update(code, dto);
+ }
+
+ @Post(":code/preview")
+ @ApiOperation({
+ summary: "Render an HTML preview of the template against mock contract data",
+ })
+ preview(
+ @Param("code") code: string,
+ @Body() dto: PreviewContractTemplateDto,
+ ) {
+ return this.service.preview(code, dto);
+ }
+
+ /* ------------------------- article routes ------------------------- */
+
+ @Put(":code/articles")
+ @FreightAdmin()
+ @ApiOperation({ summary: "Replace the full ordered article list (used for reorder)" })
+ replaceArticles(@Param("code") code: string, @Body() dto: ReplaceArticlesDto) {
+ return this.service.replaceArticles(code, dto.articles);
+ }
+
+ @Post(":code/articles")
+ @FreightAdmin()
+ @ApiOperation({ summary: "Add an article to the template" })
+ addArticle(@Param("code") code: string, @Body() dto: CreateArticleDto) {
+ return this.service.addArticle(code, dto);
+ }
+
+ @Patch(":code/articles/:articleId")
+ @FreightAdmin()
+ @ApiOperation({ summary: "Update an article's title or body" })
+ updateArticle(
+ @Param("code") code: string,
+ @Param("articleId") articleId: string,
+ @Body() dto: UpdateArticleDto,
+ ) {
+ return this.service.updateArticle(code, articleId, dto);
+ }
+
+ @Delete(":code/articles/:articleId")
+ @FreightAdmin()
+ @ApiOperation({ summary: "Remove an article from the template" })
+ removeArticle(
+ @Param("code") code: string,
+ @Param("articleId") articleId: string,
+ ) {
+ return this.service.removeArticle(code, articleId);
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/contract-templates/contract-templates.module.ts b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.module.ts
new file mode 100644
index 000000000..d2a658ca8
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.module.ts
@@ -0,0 +1,21 @@
+import { Module } from "@nestjs/common";
+import { TypeOrmModule } from "@nestjs/typeorm";
+
+import { ContractRendererService } from "../../contracts/contract-renderer.service";
+import { ContractTemplatesController } from "./contract-templates.controller";
+import { ContractTemplatesRepository } from "./contract-templates.repository";
+import { ContractTemplatesService } from "./contract-templates.service";
+import { ContractTemplate } from "./entities/contract-template.entity";
+
+@Module({
+ imports: [TypeOrmModule.forFeature([ContractTemplate])],
+ controllers: [ContractTemplatesController],
+ providers: [
+ ContractTemplatesRepository,
+ ContractTemplatesService,
+ // Stateless Handlebars renderer reused from src/contracts for previews.
+ ContractRendererService,
+ ],
+ exports: [ContractTemplatesService],
+})
+export class ContractTemplatesModule {}
diff --git a/apps/edr-freight-api/src/modules/contract-templates/contract-templates.repository.ts b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.repository.ts
new file mode 100644
index 000000000..2f4fb0117
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.repository.ts
@@ -0,0 +1,31 @@
+import { BaseRepository } from "@edr/api-common";
+import { Injectable } from "@nestjs/common";
+import { InjectRepository } from "@nestjs/typeorm";
+import { Repository } from "typeorm";
+
+import {
+ ContractTemplate,
+ ContractTemplateCode,
+} from "./entities/contract-template.entity";
+
+@Injectable()
+export class ContractTemplatesRepository extends BaseRepository {
+ constructor(
+ @InjectRepository(ContractTemplate)
+ repository: Repository,
+ ) {
+ super(repository);
+ }
+
+ findByCode(code: ContractTemplateCode): Promise {
+ return this.repository.findOne({ where: { code } });
+ }
+
+ override findAll(): Promise {
+ return this.repository.find({ order: { code: "ASC" } });
+ }
+
+ async saveTemplate(template: ContractTemplate): Promise {
+ return this.repository.save(template);
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/contract-templates/contract-templates.service.spec.ts b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.service.spec.ts
new file mode 100644
index 000000000..0478db102
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.service.spec.ts
@@ -0,0 +1,66 @@
+import { ContractRendererService } from "../../contracts/contract-renderer.service";
+import { CONTRACT_TEMPLATE_DEFAULTS } from "../../seed/data/contract-template-defaults";
+import { ContractTemplatesService } from "./contract-templates.service";
+import { ContractTemplatesRepository } from "./contract-templates.repository";
+import {
+ ContractTemplate,
+ contractTemplateCodeFor,
+} from "./entities/contract-template.entity";
+
+function seededTemplate(code: string): ContractTemplate {
+ const seed = CONTRACT_TEMPLATE_DEFAULTS.find((t) => t.code === code)!;
+ return {
+ id: "00000000-0000-0000-0000-000000000001",
+ code: seed.code,
+ name: seed.name,
+ description: seed.description,
+ documentTitle: seed.documentTitle,
+ whereasClauses: seed.whereasClauses,
+ articles: seed.articles.map((article, index) => ({ ...article, order: index + 1 })),
+ isActive: true,
+ createdAt: new Date(),
+ updatedAt: new Date(),
+ deletedAt: null,
+ } as ContractTemplate;
+}
+
+describe("contractTemplateCodeFor", () => {
+ it("maps every direction/freight pair to one of the six codes", () => {
+ expect(contractTemplateCodeFor("IMPORT", "BULK")).toBe("IMPORT_BULK");
+ expect(contractTemplateCodeFor("EXPORT", "CONTAINER")).toBe("EXPORT_CONTAINER");
+ expect(contractTemplateCodeFor("DOMESTIC", "CONTAINER")).toBe("INTERCITY_CONTAINER");
+ expect(contractTemplateCodeFor("DOMESTIC", "BULK")).toBe("INTERCITY_BULK");
+ expect(contractTemplateCodeFor(null, null)).toBe("INTERCITY_CONTAINER");
+ });
+});
+
+describe("ContractTemplatesService.preview", () => {
+ const renderer = new ContractRendererService();
+ renderer.onModuleInit();
+
+ const repository = {
+ findByCode: jest.fn((code: string) => Promise.resolve(seededTemplate(code))),
+ } as unknown as ContractTemplatesRepository;
+
+ const service = new ContractTemplatesService(repository, renderer);
+
+ it.each(CONTRACT_TEMPLATE_DEFAULTS.map((t) => [t.code] as const))(
+ "renders a complete mock preview for %s",
+ async (code) => {
+ const { html } = await service.preview(code);
+ expect(html).toContain("Article 1");
+ expect(html).toContain("Article 13");
+ expect(html).toContain("Abyssinia Trading PLC");
+ expect(html).toContain("Annex A — Commercial Schedule");
+ // No unrendered handlebars placeholders may leak into the document.
+ expect(html).not.toContain("{{");
+ // Greenish theme applied.
+ expect(html).toContain("#1b9e7a");
+ },
+ );
+
+ it("interpolates {{contractYear}} inside seeded article bodies", async () => {
+ const { html } = await service.preview("IMPORT_BULK");
+ expect(html).toContain(`August 31, ${new Date().getFullYear()}`);
+ });
+});
diff --git a/apps/edr-freight-api/src/modules/contract-templates/contract-templates.service.ts b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.service.ts
new file mode 100644
index 000000000..d2aea9bc7
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/contract-templates.service.ts
@@ -0,0 +1,276 @@
+import { BadRequestException, Injectable, NotFoundException } from "@nestjs/common";
+import { randomUUID } from "node:crypto";
+
+import { ContractRendererService } from "../../contracts/contract-renderer.service";
+import { getTemplateMeta } from "../../contracts/contract-template.registry";
+import {
+ ContractDynamicTemplateView,
+ ContractViewModel,
+} from "../../contracts/contract-view-model.builder";
+import { ContractTemplatesRepository } from "./contract-templates.repository";
+import {
+ CreateArticleDto,
+ PreviewContractTemplateDto,
+ ReplaceArticleDto,
+ UpdateArticleDto,
+ UpdateContractTemplateDto,
+} from "./dto/contract-template.dto";
+import {
+ CONTRACT_TEMPLATE_CODES,
+ ContractTemplate,
+ ContractTemplateArticle,
+ ContractTemplateCode,
+ contractTemplateCodeFor,
+} from "./entities/contract-template.entity";
+
+/** Registry keys used to derive labels for the mock preview per template code. */
+const PREVIEW_TEMPLATE_KEYS: Record = {
+ IMPORT_BULK: "IMP_BULK_USD_FORWARDING",
+ EXPORT_BULK: "EXP_BULK_USD_TRANSPORT_ONLY",
+ INTERCITY_BULK: "DOM_BULK_USD_TRANSPORT_ONLY",
+ IMPORT_CONTAINER: "IMP_CON_USD_TRANSPORT_ONLY",
+ EXPORT_CONTAINER: "EXP_CON_USD_FORWARDING",
+ INTERCITY_CONTAINER: "DOM_CON_USD_TRANSPORT_ONLY",
+};
+
+@Injectable()
+export class ContractTemplatesService {
+ constructor(
+ private readonly repository: ContractTemplatesRepository,
+ private readonly renderer: ContractRendererService,
+ ) {}
+
+ async list(): Promise {
+ const templates = await this.repository.findAll();
+ const rank = new Map(CONTRACT_TEMPLATE_CODES.map((code, i) => [code, i] as const));
+ return templates.sort(
+ (a, b) => (rank.get(a.code) ?? 99) - (rank.get(b.code) ?? 99),
+ );
+ }
+
+ async getByCode(code: string): Promise {
+ const template = await this.repository.findByCode(this.assertCode(code));
+ if (!template) {
+ throw new NotFoundException(`Contract template ${code} not found`);
+ }
+ return template;
+ }
+
+ /**
+ * The active template used when generating a contract document for the given
+ * direction/freight pair; null when missing or deactivated (the renderer then
+ * falls back to the built-in generic layout).
+ */
+ async findActiveForContract(
+ tradeDirection?: string | null,
+ freightType?: string | null,
+ ): Promise {
+ const code = contractTemplateCodeFor(tradeDirection, freightType);
+ const template = await this.repository.findByCode(code);
+ return template?.isActive ? template : null;
+ }
+
+ async update(code: string, dto: UpdateContractTemplateDto): Promise {
+ const template = await this.getByCode(code);
+ if (dto.name !== undefined) template.name = dto.name;
+ if (dto.description !== undefined) template.description = dto.description;
+ if (dto.documentTitle !== undefined) template.documentTitle = dto.documentTitle;
+ if (dto.whereasClauses !== undefined) template.whereasClauses = dto.whereasClauses;
+ if (dto.isActive !== undefined) template.isActive = dto.isActive;
+ return this.repository.saveTemplate(template);
+ }
+
+ async addArticle(code: string, dto: CreateArticleDto): Promise {
+ const template = await this.getByCode(code);
+ const articles = this.sorted(template.articles);
+ const article: ContractTemplateArticle = {
+ id: randomUUID(),
+ title: dto.title,
+ body: dto.body,
+ order: 0,
+ };
+ const index =
+ dto.position && dto.position <= articles.length ? dto.position - 1 : articles.length;
+ articles.splice(index, 0, article);
+ template.articles = this.renumber(articles);
+ return this.repository.saveTemplate(template);
+ }
+
+ async updateArticle(
+ code: string,
+ articleId: string,
+ dto: UpdateArticleDto,
+ ): Promise {
+ const template = await this.getByCode(code);
+ const article = template.articles.find((item) => item.id === articleId);
+ if (!article) {
+ throw new NotFoundException(`Article ${articleId} not found on template ${code}`);
+ }
+ if (dto.title !== undefined) article.title = dto.title;
+ if (dto.body !== undefined) article.body = dto.body;
+ template.articles = this.renumber(this.sorted(template.articles));
+ return this.repository.saveTemplate(template);
+ }
+
+ async removeArticle(code: string, articleId: string): Promise {
+ const template = await this.getByCode(code);
+ const remaining = template.articles.filter((item) => item.id !== articleId);
+ if (remaining.length === template.articles.length) {
+ throw new NotFoundException(`Article ${articleId} not found on template ${code}`);
+ }
+ template.articles = this.renumber(this.sorted(remaining));
+ return this.repository.saveTemplate(template);
+ }
+
+ /** Replace the full ordered article list (also how the editor reorders). */
+ async replaceArticles(
+ code: string,
+ articles: ReplaceArticleDto[],
+ ): Promise {
+ const template = await this.getByCode(code);
+ template.articles = this.renumber(
+ articles.map((item) => ({
+ id: item.id ?? randomUUID(),
+ title: item.title,
+ body: item.body,
+ order: 0,
+ })),
+ );
+ return this.repository.saveTemplate(template);
+ }
+
+ /**
+ * Render the template against a representative mock contract so admins can
+ * see the final document without touching a real contract. Draft overrides
+ * allow previewing unsaved editor state.
+ */
+ async preview(
+ code: string,
+ overrides?: PreviewContractTemplateDto,
+ ): Promise<{ html: string }> {
+ const template = await this.getByCode(code);
+
+ const dynamicTemplate: ContractDynamicTemplateView = {
+ code: template.code,
+ name: overrides?.name ?? template.name,
+ documentTitle: overrides?.documentTitle ?? template.documentTitle,
+ whereasClauses: overrides?.whereasClauses ?? template.whereasClauses,
+ articles: overrides?.articles
+ ? overrides.articles.map((item, index) => ({
+ id: item.id ?? randomUUID(),
+ title: item.title,
+ body: item.body,
+ order: index + 1,
+ }))
+ : this.sorted(template.articles),
+ };
+
+ const view = this.buildMockView(template.code, dynamicTemplate);
+ return { html: this.renderer.render(view) };
+ }
+
+ private buildMockView(
+ code: ContractTemplateCode,
+ dynamicTemplate: ContractDynamicTemplateView,
+ ): ContractViewModel {
+ const meta = getTemplateMeta(PREVIEW_TEMPLATE_KEYS[code]);
+ const isBulk = code.endsWith("_BULK");
+ const now = new Date();
+
+ const unitRates = isBulk
+ ? [
+ { label: "Rail transport — per metric ton", unitPrice: 59.4, unit: "ton", currency: "USD" },
+ { label: "Origin handling and documentation", unitPrice: 18, unit: "ton", currency: "USD" },
+ { label: "Lashing material (when provided by EDR)", unitPrice: 150, unit: "unit", currency: "USD" },
+ ]
+ : [
+ { label: "Rail transport — 40ft container", unitPrice: 1916, unit: "container", currency: "USD" },
+ { label: "Rail transport — 2 × 20ft containers", unitPrice: 1944, unit: "container", currency: "USD" },
+ { label: "Excess tonnage surcharge", unitPrice: 10, unit: "ton", currency: "USD" },
+ ];
+
+ return {
+ bookingId: "00000000-0000-0000-0000-000000000000",
+ reference: "EDR/CT/2026/0042",
+ status: "CONTRACT_READY",
+ templateKey: PREVIEW_TEMPLATE_KEYS[code],
+ template: { ...meta, title: dynamicTemplate.name, templateFile: "edr-dynamic.hbs" },
+ contractDate: now.toLocaleDateString("en-GB", {
+ day: "numeric",
+ month: "long",
+ year: "numeric",
+ }),
+ contractYear: now.getFullYear(),
+ client: {
+ companyName: "Abyssinia Trading PLC",
+ companyAddress: "Bole Sub-city, Woreda 03, H.No 1234, Addis Ababa",
+ companyLocation: "Ethiopia",
+ phone: "+251 91 123 4567",
+ email: "logistics@abyssiniatrading.et",
+ tinNumber: "0011223344",
+ vatNumber: "VAT-556677",
+ fanNumber: "FAN-889900",
+ businessLicense: "BL/AA/12/345678",
+ },
+ provider: {
+ name: "Ethio-Djibouti Standard Gauge Railway Share Company",
+ address: "Nifas Silk Lafto Sub City, Addis Ababa, Ethiopia",
+ phone: "+251 11 872 0000",
+ email: "info@edr.gov.et",
+ tinNumber: "—",
+ },
+ schedule: {
+ originLabel: isBulk ? "Nagad Railway Station" : "SGTD Freight Station",
+ destinationLabel: "Galaan Multipurpose Port (GMP)",
+ tradeDirection: code.startsWith("IMPORT")
+ ? "IMPORT"
+ : code.startsWith("EXPORT")
+ ? "EXPORT"
+ : "DOMESTIC",
+ freightType: isBulk ? "BULK" : "CONTAINER",
+ serviceType: "Rail transport and customs clearance",
+ scheduledDate: "—",
+ contractType: "GENERAL",
+ cargoDescription: isBulk ? "Steel billets — 2,800 MT" : "40ft containers — FMCG cargo",
+ totalWeightVgm: "—",
+ equipmentReturn: isBulk ? "—" : "With empty return",
+ hazardousLabel: "No",
+ firstMilePickupAddress: "—",
+ lastMileDeliveryAddress: "—",
+ },
+ pricing: {
+ displayMode: "UNIT_RATES",
+ unitRates,
+ currency: "USD",
+ equipmentReturn: isBulk ? "—" : "With empty return",
+ originLabel: isBulk ? "Nagad Railway Station" : "SGTD Freight Station",
+ destinationLabel: "Galaan Multipurpose Port (GMP)",
+ } as unknown as ContractViewModel["pricing"],
+ signatures: [],
+ canSignCustomer: false,
+ canSignStaff: false,
+ hasContractDocument: false,
+ hasCustomerSignature: false,
+ hasStaffSignature: false,
+ dynamicTemplate,
+ };
+ }
+
+ private assertCode(code: string): ContractTemplateCode {
+ const upper = code?.toUpperCase() as ContractTemplateCode;
+ if (!CONTRACT_TEMPLATE_CODES.includes(upper)) {
+ throw new BadRequestException(
+ `Unknown contract template code "${code}". Valid codes: ${CONTRACT_TEMPLATE_CODES.join(", ")}`,
+ );
+ }
+ return upper;
+ }
+
+ private sorted(articles: ContractTemplateArticle[]): ContractTemplateArticle[] {
+ return [...(articles ?? [])].sort((a, b) => (a.order ?? 0) - (b.order ?? 0));
+ }
+
+ private renumber(articles: ContractTemplateArticle[]): ContractTemplateArticle[] {
+ return articles.map((article, index) => ({ ...article, order: index + 1 }));
+ }
+}
diff --git a/apps/edr-freight-api/src/modules/contract-templates/dto/contract-template.dto.ts b/apps/edr-freight-api/src/modules/contract-templates/dto/contract-template.dto.ts
new file mode 100644
index 000000000..0ea69f262
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/dto/contract-template.dto.ts
@@ -0,0 +1,134 @@
+import { ApiPropertyOptional, ApiProperty } from "@nestjs/swagger";
+import { Type } from "class-transformer";
+import {
+ IsArray,
+ IsBoolean,
+ IsInt,
+ IsOptional,
+ IsString,
+ MaxLength,
+ Min,
+ MinLength,
+ ValidateNested,
+} from "class-validator";
+
+export class UpdateContractTemplateDto {
+ @ApiPropertyOptional({ description: "Display name of the template" })
+ @IsOptional()
+ @IsString()
+ @MinLength(3)
+ @MaxLength(200)
+ name?: string;
+
+ @ApiPropertyOptional({ description: "Short description shown on the template card" })
+ @IsOptional()
+ @IsString()
+ description?: string;
+
+ @ApiPropertyOptional({ description: "Cover-page service title of the generated document" })
+ @IsOptional()
+ @IsString()
+ @MinLength(3)
+ @MaxLength(300)
+ documentTitle?: string;
+
+ @ApiPropertyOptional({ description: "WHEREAS recitals", type: [String] })
+ @IsOptional()
+ @IsArray()
+ @IsString({ each: true })
+ whereasClauses?: string[];
+
+ @ApiPropertyOptional({ description: "Whether the template is used for generation" })
+ @IsOptional()
+ @IsBoolean()
+ isActive?: boolean;
+}
+
+export class CreateArticleDto {
+ @ApiProperty({ description: "Article heading (without the Article N prefix)" })
+ @IsString()
+ @MinLength(2)
+ @MaxLength(200)
+ title!: string;
+
+ @ApiProperty({
+ description:
+ 'Article body. One clause per line; prefix a line with "- " to nest it as a bullet under the previous clause.',
+ })
+ @IsString()
+ @MinLength(2)
+ body!: string;
+
+ @ApiPropertyOptional({ description: "1-based position to insert at (appends when omitted)" })
+ @IsOptional()
+ @IsInt()
+ @Min(1)
+ position?: number;
+}
+
+export class UpdateArticleDto {
+ @ApiPropertyOptional()
+ @IsOptional()
+ @IsString()
+ @MinLength(2)
+ @MaxLength(200)
+ title?: string;
+
+ @ApiPropertyOptional()
+ @IsOptional()
+ @IsString()
+ @MinLength(2)
+ body?: string;
+}
+
+export class ReplaceArticleDto {
+ @ApiPropertyOptional({ description: "Existing article id (new id assigned when omitted)" })
+ @IsOptional()
+ @IsString()
+ id?: string;
+
+ @ApiProperty()
+ @IsString()
+ @MinLength(2)
+ @MaxLength(200)
+ title!: string;
+
+ @ApiProperty()
+ @IsString()
+ @MinLength(2)
+ body!: string;
+}
+
+export class ReplaceArticlesDto {
+ @ApiProperty({ type: [ReplaceArticleDto], description: "Full ordered article list" })
+ @IsArray()
+ @ValidateNested({ each: true })
+ @Type(() => ReplaceArticleDto)
+ articles!: ReplaceArticleDto[];
+}
+
+/** Optional draft overrides so the editor can preview unsaved changes. */
+export class PreviewContractTemplateDto {
+ @ApiPropertyOptional()
+ @IsOptional()
+ @IsString()
+ name?: string;
+
+ @ApiPropertyOptional()
+ @IsOptional()
+ @IsString()
+ documentTitle?: string;
+
+ @ApiPropertyOptional({ type: [String] })
+ @IsOptional()
+ @IsArray()
+ @IsString({ each: true })
+ whereasClauses?: string[];
+
+ @ApiPropertyOptional({ type: [ReplaceArticleDto] })
+ @IsOptional()
+ @IsArray()
+ @ValidateNested({ each: true })
+ @Type(() => ReplaceArticleDto)
+ articles?: ReplaceArticleDto[];
+}
diff --git a/apps/edr-freight-api/src/modules/contract-templates/entities/contract-template.entity.ts b/apps/edr-freight-api/src/modules/contract-templates/entities/contract-template.entity.ts
new file mode 100644
index 000000000..73729fbb6
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contract-templates/entities/contract-template.entity.ts
@@ -0,0 +1,77 @@
+import { BaseEntity } from "@edr/api-common";
+import { Column, Entity, Index } from "typeorm";
+
+/**
+ * The six canonical contract document templates, one per
+ * (trade direction × freight type) combination. Contracts store DOMESTIC for
+ * intercity movements; the template layer labels those INTERCITY to match the
+ * commercial vocabulary used on the printed documents.
+ */
+export const CONTRACT_TEMPLATE_CODES = [
+ "IMPORT_BULK",
+ "EXPORT_BULK",
+ "INTERCITY_BULK",
+ "IMPORT_CONTAINER",
+ "EXPORT_CONTAINER",
+ "INTERCITY_CONTAINER",
+] as const;
+
+export type ContractTemplateCode = (typeof CONTRACT_TEMPLATE_CODES)[number];
+
+/**
+ * One dynamic article on a contract template. `body` is plain multiline text:
+ * each non-empty line renders as a numbered clause; lines prefixed with "- "
+ * render as bullet points nested under the preceding clause. A single-line
+ * body renders as an unnumbered paragraph. Handlebars placeholders (e.g.
+ * {{client.companyName}}, {{contractDate}}, {{contractYear}}, {{reference}})
+ * are interpolated against the contract view model at render time.
+ */
+export interface ContractTemplateArticle {
+ id: string;
+ title: string;
+ body: string;
+ order: number;
+}
+
+/** Map a contract's stored direction/freight pair onto a template code. */
+export function contractTemplateCodeFor(
+ tradeDirection?: string | null,
+ freightType?: string | null,
+): ContractTemplateCode {
+ const direction =
+ tradeDirection === "IMPORT"
+ ? "IMPORT"
+ : tradeDirection === "EXPORT"
+ ? "EXPORT"
+ : "INTERCITY";
+ const freight =
+ (freightType ?? "").toUpperCase().includes("BULK") ? "BULK" : "CONTAINER";
+ return `${direction}_${freight}` as ContractTemplateCode;
+}
+
+@Entity({ schema: "freight", name: "contract_templates" })
+@Index(["code"], { unique: true })
+export class ContractTemplate extends BaseEntity {
+ @Column({ name: "code", type: "varchar", length: 40, unique: true })
+ code!: ContractTemplateCode;
+
+ @Column({ name: "name", type: "varchar", length: 200 })
+ name!: string;
+
+ @Column({ name: "description", type: "text", nullable: true })
+ description?: string | null;
+
+ /** Cover-page service line, e.g. "Steel Billet Transportation and Customs Clearance Services". */
+ @Column({ name: "document_title", type: "varchar", length: 300 })
+ documentTitle!: string;
+
+ /** WHEREAS recitals rendered between the parties block and the articles. */
+ @Column({ name: "whereas_clauses", type: "jsonb", default: () => "'[]'" })
+ whereasClauses!: string[];
+
+ @Column({ name: "articles", type: "jsonb", default: () => "'[]'" })
+ articles!: ContractTemplateArticle[];
+
+ @Column({ name: "is_active", type: "boolean", default: true })
+ isActive!: boolean;
+}
diff --git a/apps/edr-freight-api/src/modules/contracts/booking-request.service.ts b/apps/edr-freight-api/src/modules/contracts/booking-request.service.ts
index 4752b004f..e038c7bff 100644
--- a/apps/edr-freight-api/src/modules/contracts/booking-request.service.ts
+++ b/apps/edr-freight-api/src/modules/contracts/booking-request.service.ts
@@ -51,6 +51,11 @@ export class BookingRequestService {
const contract = await this.contractsService.findById(contractId);
await this.contractsService.assertCustomerCanAccessContract(userId, contract);
this.assertGeneralCustoms(contract);
+ if (contract.status === 'CONTRACT_CLOSED') {
+ throw new ConflictException(
+ 'This contract is completed — the full contracted quantity has been booked.',
+ );
+ }
if (contract.status !== 'CONTRACT_ACTIVE') {
throw new ConflictException(
'The contract must be active before requesting a shipment.',
diff --git a/apps/edr-freight-api/src/modules/contracts/clearance-milestone.risk.spec.ts b/apps/edr-freight-api/src/modules/contracts/clearance-milestone.risk.spec.ts
new file mode 100644
index 000000000..eb77533ac
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contracts/clearance-milestone.risk.spec.ts
@@ -0,0 +1,68 @@
+import { BadRequestException } from '@nestjs/common';
+import type { DataSource } from 'typeorm';
+
+import { ClearanceMilestoneService } from './clearance-milestone.service';
+import type { ClearanceMilestone } from './entities/clearance-milestone.entity';
+
+type Status = 'PENDING' | 'COMPLETED' | 'SKIPPED';
+
+/**
+ * Risk assignment is gated on the T1 being closed (catalog order
+ * T1_CLOSED → RISK_ASSIGNED): customs cannot rate cargo still under transit.
+ */
+function makeService(t1Status: Status | 'MISSING') {
+ const rows = new Map();
+ if (t1Status !== 'MISSING') {
+ rows.set('T1_CLOSED', { milestoneCode: 'T1_CLOSED', status: t1Status } as ClearanceMilestone);
+ }
+ const risk = { milestoneCode: 'RISK_ASSIGNED', status: 'PENDING' } as ClearanceMilestone;
+ rows.set('RISK_ASSIGNED', risk);
+
+ const repo = {
+ findOne: jest.fn(({ where }: { where: { milestoneCode: string } }) =>
+ Promise.resolve(rows.get(where.milestoneCode) ?? null),
+ ),
+ save: jest.fn((m: ClearanceMilestone) => Promise.resolve(m)),
+ };
+ const dataSource = { getRepository: () => repo } as unknown as DataSource;
+ return { service: new ClearanceMilestoneService(dataSource), repo, risk };
+}
+
+describe('ClearanceMilestoneService.assignRisk', () => {
+ it('rejects the assignment while the T1 is still open', async () => {
+ const { service, repo } = makeService('PENDING');
+
+ await expect(service.assignRisk('b-1', 'GREEN')).rejects.toBeInstanceOf(
+ BadRequestException,
+ );
+ expect(repo.save).not.toHaveBeenCalled();
+ });
+
+ it('rejects the assignment when the booking has no T1_CLOSED milestone', async () => {
+ const { service, repo } = makeService('MISSING');
+
+ await expect(service.assignRisk('b-1', 'GREEN')).rejects.toBeInstanceOf(
+ BadRequestException,
+ );
+ expect(repo.save).not.toHaveBeenCalled();
+ });
+
+ it('assigns the risk level once the T1 is closed', async () => {
+ const { service, risk } = makeService('COMPLETED');
+
+ const saved = await service.assignRisk('b-1', 'RED', 'user-1');
+
+ expect(saved.status).toBe('COMPLETED');
+ expect(saved.metadata?.riskLevel).toBe('RED');
+ expect(risk.triggeredByUserId).toBe('user-1');
+ });
+
+ it('assigns the risk level when the T1 step was skipped', async () => {
+ const { service } = makeService('SKIPPED');
+
+ const saved = await service.assignRisk('b-1', 'YELLOW');
+
+ expect(saved.status).toBe('COMPLETED');
+ expect(saved.metadata?.riskLevel).toBe('YELLOW');
+ });
+});
diff --git a/apps/edr-freight-api/src/modules/contracts/clearance-milestone.service.ts b/apps/edr-freight-api/src/modules/contracts/clearance-milestone.service.ts
index 4a58e50be..81ed305e4 100644
--- a/apps/edr-freight-api/src/modules/contracts/clearance-milestone.service.ts
+++ b/apps/edr-freight-api/src/modules/contracts/clearance-milestone.service.ts
@@ -1,4 +1,4 @@
-import { Injectable, NotFoundException } from '@nestjs/common';
+import { BadRequestException, Injectable, NotFoundException } from '@nestjs/common';
import { DataSource } from 'typeorm';
import {
@@ -181,6 +181,10 @@ export class ClearanceMilestoneService {
* Assign a customs risk level (GREEN/YELLOW/RED) and complete the RISK_ASSIGNED
* milestone on a booking (GL Import US-04 / §11.3 #19). Stores the level in the
* milestone metadata so the timeline shows it.
+ *
+ * Customs cannot risk-rate cargo still moving under transit: the T1 must be
+ * closed (accepted by GL Ethiopia after the train arrives) first, which is the
+ * catalog order T1_CLOSED → RISK_ASSIGNED.
*/
async assignRisk(
bookingId: string,
@@ -188,9 +192,22 @@ export class ClearanceMilestoneService {
userId?: string,
note?: string,
): Promise {
+ await this.assertT1Closed(bookingId);
return this.completeWithMetadata(bookingId, 'RISK_ASSIGNED', { riskLevel }, userId, note);
}
+ /** Guard: the booking's T1 must be closed before customs risk can be assigned. */
+ private async assertT1Closed(bookingId: string): Promise {
+ const t1 = await this.repo.findOne({
+ where: { bookingId, milestoneCode: 'T1_CLOSED' },
+ });
+ if (t1?.status !== 'COMPLETED' && t1?.status !== 'SKIPPED') {
+ throw new BadRequestException(
+ 'The T1 must be closed before a customs risk level can be assigned.',
+ );
+ }
+ }
+
/**
* Advise duty & tax (amount + declaration serial) and complete the
* DUTY_TAXES_ADVISED milestone (§11.3 #6). The customer then uploads the
diff --git a/apps/edr-freight-api/src/modules/contracts/contract-booking.completion.spec.ts b/apps/edr-freight-api/src/modules/contracts/contract-booking.completion.spec.ts
new file mode 100644
index 000000000..fb57be209
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/contracts/contract-booking.completion.spec.ts
@@ -0,0 +1,149 @@
+import { BadRequestException } from '@nestjs/common';
+
+import { ContractBookingService } from './contract-booking.service';
+import { Contract } from './entities/contract.entity';
+
+/**
+ * Contract auto-completion by quantity cap. Once a GENERAL contract's capped
+ * scope is fully consumed (e.g. a split remainder rebooked), the contract moves
+ * to CONTRACT_CLOSED even inside its validity window, and further bookings are
+ * blocked — including while a booking window is open. Released capacity
+ * (cancelled/expired booking) reopens the contract on the next attempt.
+ */
+describe('ContractBookingService — quantity-cap completion', () => {
+ function makeService() {
+ const contractsRepository = {
+ findByIdWithRelations: jest.fn(),
+ update: jest.fn().mockResolvedValue(undefined),
+ };
+ const service = new ContractBookingService(
+ contractsRepository as never,
+ {} as never, // bookingsRepository
+ {} as never, // bookingPricingService
+ {} as never, // consolidationService
+ {} as never, // containerTypesService
+ {} as never, // ruleEngineService
+ {} as never, // milestoneService
+ {} as never, // workflowService
+ {} as never, // invoiceService
+ {} as never, // dataSource
+ {} as never, // trainSchedulingService
+ );
+ return { service, contractsRepository };
+ }
+
+ type WithPrivate = {
+ maybeCompleteContract: (c: Contract) => Promise;
+ };
+
+ const generalContract = (status: string): Contract =>
+ ({
+ id: 'c-1',
+ reference: 'CTR-1',
+ contractKind: 'GENERAL',
+ status,
+ }) as Contract;
+
+ it('closes a GENERAL contract when every capped line is exhausted', async () => {
+ const { service, contractsRepository } = makeService();
+ jest.spyOn(service, 'computeCapacity').mockResolvedValue([
+ { containerSize: '20FT', cap: 10, booked: 10, remaining: 0 },
+ { containerSize: '40FT', cap: 4, booked: 4, remaining: 0 },
+ ]);
+
+ await (service as never as WithPrivate).maybeCompleteContract(
+ generalContract('CONTRACT_ACTIVE'),
+ );
+
+ expect(contractsRepository.update).toHaveBeenCalledWith('c-1', {
+ status: 'CONTRACT_CLOSED',
+ });
+ });
+
+ it('absorbs bulk-ton float dust when judging exhaustion', async () => {
+ const { service, contractsRepository } = makeService();
+ jest
+ .spyOn(service, 'computeCapacity')
+ .mockResolvedValue([{ cap: 100, booked: 99.9995, remaining: 0.0005 }]);
+
+ await (service as never as WithPrivate).maybeCompleteContract(
+ generalContract('FULLY_EXECUTED'),
+ );
+
+ expect(contractsRepository.update).toHaveBeenCalledWith('c-1', {
+ status: 'CONTRACT_CLOSED',
+ });
+ });
+
+ it('keeps the contract open while any capped line has capacity left', async () => {
+ const { service, contractsRepository } = makeService();
+ jest.spyOn(service, 'computeCapacity').mockResolvedValue([
+ { containerSize: '20FT', cap: 10, booked: 10, remaining: 0 },
+ { containerSize: '40FT', cap: 4, booked: 3, remaining: 1 },
+ ]);
+
+ await (service as never as WithPrivate).maybeCompleteContract(
+ generalContract('CONTRACT_ACTIVE'),
+ );
+
+ expect(contractsRepository.update).not.toHaveBeenCalled();
+ });
+
+ it('never closes an uncapped contract', async () => {
+ const { service, contractsRepository } = makeService();
+ jest.spyOn(service, 'computeCapacity').mockResolvedValue([]);
+
+ await (service as never as WithPrivate).maybeCompleteContract(
+ generalContract('CONTRACT_ACTIVE'),
+ );
+
+ expect(contractsRepository.update).not.toHaveBeenCalled();
+ });
+
+ it('never closes a ONE_TIME contract (single-slot rule governs it)', async () => {
+ const { service, contractsRepository } = makeService();
+ const spy = jest.spyOn(service, 'computeCapacity');
+
+ await (service as never as WithPrivate).maybeCompleteContract({
+ id: 'c-1',
+ contractKind: 'ONE_TIME',
+ status: 'FULLY_EXECUTED',
+ } as Contract);
+
+ expect(spy).not.toHaveBeenCalled();
+ expect(contractsRepository.update).not.toHaveBeenCalled();
+ });
+
+ it('rejects a new booking on a completed contract even inside an open window', async () => {
+ const { service, contractsRepository } = makeService();
+ contractsRepository.findByIdWithRelations.mockResolvedValue(
+ generalContract('CONTRACT_CLOSED'),
+ );
+ jest
+ .spyOn(service, 'computeCapacity')
+ .mockResolvedValue([{ cap: 10, booked: 10, remaining: 0 }]);
+
+ await expect(
+ service.createUnderContract('c-1', {} as never, null, null),
+ ).rejects.toThrow(BadRequestException);
+ expect(contractsRepository.update).not.toHaveBeenCalled();
+ });
+
+ it('reopens a completed contract when capacity was released', async () => {
+ const { service, contractsRepository } = makeService();
+ contractsRepository.findByIdWithRelations.mockResolvedValue(
+ generalContract('CONTRACT_CLOSED'),
+ );
+ jest
+ .spyOn(service, 'computeCapacity')
+ .mockResolvedValue([{ cap: 10, booked: 8, remaining: 2 }]);
+
+ // The create path continues past the gate and dies later on the bare mocks —
+ // only the reopen transition is under test here.
+ await service.createUnderContract('c-1', {} as never, null, null).catch(() => undefined);
+
+ expect(contractsRepository.update).toHaveBeenCalledWith('c-1', {
+ status: 'CONTRACT_ACTIVE',
+ });
+ });
+});
diff --git a/apps/edr-freight-api/src/modules/contracts/contract-booking.service.ts b/apps/edr-freight-api/src/modules/contracts/contract-booking.service.ts
index 55dd5c29f..70083a2ae 100644
--- a/apps/edr-freight-api/src/modules/contracts/contract-booking.service.ts
+++ b/apps/edr-freight-api/src/modules/contracts/contract-booking.service.ts
@@ -83,6 +83,24 @@ export class ContractBookingService {
const contract = await this.contractsRepository.findByIdWithRelations(contractId);
if (!contract) throw new NotFoundException(`Contract ${contractId} not found`);
+ // A contract whose quantity cap was fully booked is completed — no further
+ // bookings, even while contract validity and a booking window are still
+ // open. Capacity released after closure (a cancelled/expired booking)
+ // reopens the contract on the next booking attempt.
+ if (contract.status === 'CONTRACT_CLOSED') {
+ const capacity = await this.computeCapacity(contract);
+ const hasRoom = capacity.some((c) => c.remaining == null || c.remaining > 0);
+ if (!hasRoom) {
+ throw new BadRequestException(
+ 'This contract is completed — the full contracted quantity has been booked.',
+ );
+ }
+ await this.contractsRepository.update(contract.id, {
+ status: 'CONTRACT_ACTIVE',
+ } as never);
+ contract.status = 'CONTRACT_ACTIVE';
+ }
+
// GL Ethiopia is identified by the dedicated contract create-booking permission
// (granted to the edr_gl_ethiopia preset).
const isGlActor =
@@ -122,6 +140,15 @@ export class ContractBookingService {
const generalCustoms =
contract.contractKind === 'GENERAL' && Boolean(contract.customsClearingEnabled);
+ // GENERAL without customs (Path A) ALSO clears per booking: the customer
+ // uploads his own clearance proof on each booking and Operations reviews it
+ // (legacy AWAITING_DOCUMENTS → DOCUMENTS_UNDER_REVIEW → CLEARANCE_READY →
+ // requestOperation machine). DOMESTIC has no border, so no gate.
+ const generalSelfClear =
+ contract.contractKind === 'GENERAL' &&
+ !contract.customsClearingEnabled &&
+ contract.tradeDirection !== 'DOMESTIC';
+
// Intercity (DOMESTIC) bookings ride on a passing import/export train:
// there is no window and no date — staff accept them onto a train at
// finalize time, so both the window gate and scheduledDate are skipped.
@@ -140,9 +167,10 @@ export class ContractBookingService {
// Booking-window gate (config-driven): an operations booking may only be
// created while the route's booking window is open — import: the day's window
// (windowOpenHour EAT, importWindowLeadDays before departure, windowDurationHours);
- // export: within exportBookingLeadHours of departure. Customs Path B bookings
- // enter clearance first and are scheduled later, so they are not gated here.
- if (!generalCustoms && !isIntercity) {
+ // export: within exportBookingLeadHours of departure. Bookings that enter the
+ // clearance gate first (Path B customs AND Path A per-booking self-clearance)
+ // are scheduled later, so they are not gated here.
+ if (!generalCustoms && !generalSelfClear && !isIntercity) {
await this.trainSchedulingService.assertBookingWindowOpen({
originYardId: route?.originYardId ?? null,
destinationYardId: route?.destinationYardId ?? null,
@@ -174,7 +202,10 @@ export class ContractBookingService {
companyProfileId: contract.companyProfileId ?? null,
isGovernment: contract.isGovernment,
governmentInstitution: contract.governmentInstitution ?? null,
- status: generalCustoms ? 'AWAITING_DOCUMENTS' : 'OPERATION_REQUEST_PENDING',
+ status:
+ generalCustoms || generalSelfClear
+ ? 'AWAITING_DOCUMENTS'
+ : 'OPERATION_REQUEST_PENDING',
bookingType: 'ONE_TIME',
contractId: contract.id,
contractRouteId: route?.id ?? null,
@@ -259,9 +290,10 @@ export class ContractBookingService {
const withContainers = await this.bookingsRepository.findByIdWithFiles(
booking.id,
);
- const intendedStatus = generalCustoms
- ? 'AWAITING_DOCUMENTS'
- : 'OPERATION_REQUEST_PENDING';
+ const intendedStatus =
+ generalCustoms || generalSelfClear
+ ? 'AWAITING_DOCUMENTS'
+ : 'OPERATION_REQUEST_PENDING';
if (
withContainers &&
freightType === 'CONTAINER' &&
@@ -277,6 +309,9 @@ export class ContractBookingService {
if (!parked.paired) {
// Waiting for a partner — stop here. The booking sits in
// PENDING_CONSOLIDATION, unbilled and unscheduled, until it pairs.
+ // A parked booking still holds contract capacity, so the cap may
+ // already be exhausted by it.
+ await this.maybeCompleteContract(contract);
const pendingResult = await this.bookingsRepository.findByIdWithFiles(
booking.id,
);
@@ -290,6 +325,8 @@ export class ContractBookingService {
generalCustoms,
);
+ await this.maybeCompleteContract(contract);
+
const result = await this.bookingsRepository.findByIdWithFiles(booking.id);
return { booking: result ?? booking, warnings };
}
@@ -592,6 +629,44 @@ export class ContractBookingService {
});
}
+ /**
+ * Complete the contract once its quantity cap is fully consumed. Runs after
+ * every booking created under a GENERAL contract (including a split remainder
+ * being rebooked): when no capped scope line has capacity left, the contract
+ * moves to CONTRACT_CLOSED even though its validity window is still open —
+ * blocking further bookings and shipment requests, including inside an open
+ * booking window. Never throws: a status hiccup must not undo the booking
+ * that was just created.
+ */
+ private async maybeCompleteContract(contract: Contract): Promise {
+ try {
+ // ONE_TIME contracts are governed by the single-active-booking slot (and
+ // are promoted to GENERAL on split), so only GENERAL completes by cap.
+ if (contract.contractKind !== 'GENERAL') return;
+ if (!['CONTRACT_ACTIVE', 'FULLY_EXECUTED'].includes(contract.status)) return;
+ const capacity = await this.computeCapacity(contract);
+ if (capacity.length === 0) return; // uncapped — completes only by expiry
+ // 0.001 tolerance absorbs bulk-ton float rounding (split weights round to
+ // 3 decimals); container caps are integers and unaffected.
+ const exhausted = capacity.every(
+ (c) => c.remaining != null && c.remaining <= 0.001,
+ );
+ if (!exhausted) return;
+ await this.contractsRepository.update(contract.id, {
+ status: 'CONTRACT_CLOSED',
+ } as never);
+ this.logger.log(
+ `Contract ${contract.reference} quantity cap fully booked — completed; no further bookings within validity.`,
+ );
+ } catch (err) {
+ this.logger.error(
+ `Could not evaluate completion for contract ${contract.id}: ${
+ err instanceof Error ? err.message : String(err)
+ }`,
+ );
+ }
+ }
+
/**
* Quantities already booked under a contract that still hold capacity. Excludes
* bookings that never shipped (CANCELLED / REJECTED / EXPIRED).
diff --git a/apps/edr-freight-api/src/modules/contracts/contract-transition.service.ts b/apps/edr-freight-api/src/modules/contracts/contract-transition.service.ts
index 9f12b937d..4da2677bd 100644
--- a/apps/edr-freight-api/src/modules/contracts/contract-transition.service.ts
+++ b/apps/edr-freight-api/src/modules/contracts/contract-transition.service.ts
@@ -350,6 +350,17 @@ export class ContractTransitionService {
const updated = await this.contractsService.findById(contractId);
if (allDone) {
this.notifier.approved(updated);
+ // Final approval step also generates the contract document from the
+ // template matching the contract's direction/freight pair. Best-effort:
+ // a rendering hiccup must not roll back the approval — the document can
+ // still be generated manually or lazily on view/download.
+ try {
+ return await this.generateContract(contractId);
+ } catch (err) {
+ this.logger.warn(
+ `Auto contract generation after final approval failed for ${updated.reference}: ${err}`,
+ );
+ }
}
return updated;
}
@@ -582,7 +593,7 @@ export class ContractTransitionService {
if (!dto.otpPhone || !dto.otp) {
throw new BadRequestException('OTP verification is required to sign the contract');
}
- await this.otpService.verifyOtpForAction(dto.otpPhone, dto.otp);
+ await this.otpService.verifyOtpForAction({ phone: dto.otpPhone }, dto.otp);
await this.applySignature(contract, dto, options);
await this.contractsRepository.update(contractId, {
status: 'SIGNED_CUSTOMER',
@@ -632,16 +643,15 @@ export class ContractTransitionService {
contract.customsClearingEnabled ?? false,
);
- // GENERAL + customs (Path B) runs clearance PER BOOKING, not at the contract
- // level: there is no contract clearance cycle. The contract just becomes
- // active; the customer then files shipment requests and GL books + clears
- // each one. ONE_TIME customs and Path A self-clearance keep the contract
- // cycle below.
- const isGeneralCustoms =
- contract.contractKind === 'GENERAL' &&
- Boolean(contract.customsClearingEnabled);
+ // GENERAL contracts run clearance PER BOOKING, not at the contract level —
+ // both paths. Customs (Path B): the customer files shipment requests, GL
+ // books each one and the booking carries its own clearance. Self-clearance
+ // (Path A): the customer books, then uploads the clearance docs on that
+ // booking for Operations to review. Only ONE_TIME contracts keep the
+ // contract-level cycle below.
+ const isGeneral = contract.contractKind === 'GENERAL';
- if (clearanceCode && !isGeneralCustoms) {
+ if (clearanceCode && !isGeneral) {
// Open a clearance cycle, seed the pre-booking milestones, and route the
// customer to upload. Path A is ops-reviewed; Path B is GL-reviewed — the
// distinction is enforced at the review/finalize endpoints, not here.
@@ -652,8 +662,8 @@ export class ContractTransitionService {
updates.clearanceStatus = 'AWAITING_DOCUMENTS';
updates.clearanceCycleNumber = cycleNumber;
} else {
- // No contract-level clearance gate — DOMESTIC, or GENERAL+customs (which
- // clears per booking). Ready for shipment requests / direct booking.
+ // No contract-level clearance gate — DOMESTIC, or any GENERAL contract
+ // (which clears per booking). Ready for shipment requests / direct booking.
updates.status =
contract.contractKind === 'GENERAL' ? 'CONTRACT_ACTIVE' : 'FULLY_EXECUTED';
updates.clearanceStatus = 'NOT_APPLICABLE';
diff --git a/apps/edr-freight-api/src/modules/contracts/contracts.module.ts b/apps/edr-freight-api/src/modules/contracts/contracts.module.ts
index 33a547a9f..96bdf22b1 100644
--- a/apps/edr-freight-api/src/modules/contracts/contracts.module.ts
+++ b/apps/edr-freight-api/src/modules/contracts/contracts.module.ts
@@ -16,6 +16,7 @@ import { NotificationsModule } from '../notifications/notifications.module';
import { NotificationInboxModule } from '../notification-inbox/notification-inbox.module';
import { BookingsModule } from '../bookings/bookings.module';
import { TrainSchedulingModule } from '../train-scheduling/train-scheduling.module';
+import { ContractTemplatesModule } from '../contract-templates/contract-templates.module';
import { ContractsController } from './contracts.controller';
import { ContractsService } from './contracts.service';
@@ -81,6 +82,9 @@ import { ContractDocumentViewModelBuilder } from '../../contracts/contract-docum
NotificationsModule,
NotificationInboxModule,
CompaniesModule,
+ // Provides the admin-editable contract document templates consumed by
+ // ContractDocumentViewModelBuilder when rendering contract PDFs.
+ ContractTemplatesModule,
// BookingsModule provides BookingsRepository/BookingPricingService used by the
// contract PDF builders (they read a Booking today — see docs/new-doc.md §3.3).
forwardRef(() => BookingsModule),
diff --git a/apps/edr-freight-api/src/modules/contracts/contracts.service.ts b/apps/edr-freight-api/src/modules/contracts/contracts.service.ts
index 095857959..517d818bf 100644
--- a/apps/edr-freight-api/src/modules/contracts/contracts.service.ts
+++ b/apps/edr-freight-api/src/modules/contracts/contracts.service.ts
@@ -265,10 +265,11 @@ export class ContractsService {
}
}
- // Attach the company profile's onboarding / business-license documents to the
- // contract by reference. The separate "Documents" intake step was removed —
- // the profile documents are simply carried onto every contract automatically.
- await this.attachProfileDocuments(contract.id, companyProfileId);
+ // Attach the company's onboarding documents (TIN, licenses, IDs) and the
+ // profile's business-license documents to the contract by reference. The
+ // separate "Documents" intake step was removed — the profile documents are
+ // simply carried onto every contract automatically.
+ await this.attachProfileDocuments(contract.id, companyId ?? null, companyProfileId);
return { contract: await this.findById(contract.id), warnings };
}
@@ -316,51 +317,95 @@ export class ContractsService {
}
/**
- * Copy a company profile's stored business-license / onboarding documents onto
- * a contract by reference (no byte re-upload). Codes are slugged from each
- * document name so they group under "Profile documents" on the contract detail
- * page. No-op when the contract has no profile or the profile has no documents.
+ * Copy the company's onboarding documents (TIN certificate, commercial /
+ * investment license, national ID, passport — resource "companies", coded by
+ * the upload-setting fileKey) and the company profile's business-license
+ * documents (resource "company_profiles") onto a contract by reference (no
+ * byte re-upload). Idempotent: codes already present on the contract — user
+ * uploads or an earlier carry — are never duplicated or overwritten, so it is
+ * safe to run on every create and update. No-op when there is nothing to copy.
*/
private async attachProfileDocuments(
contractId: string,
+ companyId: string | null,
companyProfileId: string | null,
): Promise {
- if (!companyProfileId) return;
- // Business-license files are FileRecords (resource "company_profiles"); carry
- // the live ones by reference. Staged/pending uploads are excluded by code.
- const records = await this.filesService.findByResource(
- companyProfileId,
- 'company_profiles',
+ if (!companyId && !companyProfileId) return;
+
+ const existingCodes = new Set(
+ (await this.filesService.findByResource(contractId, 'contracts')).map(
+ (r) => r.code,
+ ),
);
- const docs = records
- .filter((r) => r.code === 'business_license')
- .map((r) => ({
- name: r.name,
- url: r.url,
- size: r.size,
- mimeType: r.mimeType,
- }));
+ const docs: Array<{
+ code: string;
+ name: string;
+ url: string;
+ size: number;
+ mimeType?: string;
+ }> = [];
+
+ if (companyId) {
+ // Company onboarding documents keep their fileKey codes (tin_certificate,
+ // commercial_license, …) so the portal can match them against the
+ // onboarding upload-setting fields. Re-uploads append rows, so keep only
+ // the newest record per code.
+ const companyRecords = await this.filesService.findByResource(
+ companyId,
+ 'companies',
+ );
+ const latestByCode = new Map();
+ for (const r of companyRecords) {
+ const prev = latestByCode.get(r.code);
+ if (!prev || r.createdAt > prev.createdAt) latestByCode.set(r.code, r);
+ }
+ for (const r of latestByCode.values()) {
+ if (existingCodes.has(r.code)) continue;
+ docs.push({
+ code: r.code,
+ name: r.name,
+ url: r.url,
+ size: r.size,
+ mimeType: r.mimeType,
+ });
+ }
+ }
+
+ if (companyProfileId) {
+ // Business-license files are FileRecords (resource "company_profiles");
+ // carry the live ones by reference. Staged/pending uploads are excluded by
+ // code. Codes are slugged from each document name so they group under
+ // "Profile documents" on the contract detail page.
+ const records = await this.filesService.findByResource(
+ companyProfileId,
+ 'company_profiles',
+ );
+ const slug = (name: string) =>
+ name
+ .toLowerCase()
+ .replace(/\.[a-z0-9]+$/, '')
+ .replace(/[^a-z0-9]+/g, '_')
+ .replace(/^_+|_+$/g, '') || 'profile_document';
+
+ records
+ .filter((r) => r.code === 'business_license')
+ .forEach((r, i) => {
+ const code = `${slug(r.name)}_${i + 1}`;
+ if (existingCodes.has(code)) return;
+ docs.push({
+ code,
+ name: r.name,
+ url: r.url,
+ size: r.size,
+ mimeType: r.mimeType,
+ });
+ });
+ }
+
if (docs.length === 0) return;
- const slug = (name: string) =>
- name
- .toLowerCase()
- .replace(/\.[a-z0-9]+$/, '')
- .replace(/[^a-z0-9]+/g, '_')
- .replace(/^_+|_+$/g, '') || 'profile_document';
-
try {
- await this.filesService.attachExistingFiles(
- contractId,
- 'contracts',
- docs.map((d, i) => ({
- code: `${slug(d.name)}_${i + 1}`,
- name: d.name,
- url: d.url,
- size: d.size,
- mimeType: d.mimeType,
- })),
- );
+ await this.filesService.attachExistingFiles(contractId, 'contracts', docs);
} catch {
// Non-fatal — the contract is still valid without the carried documents.
}
@@ -481,6 +526,15 @@ export class ContractsService {
await this.filesService.uploadMany(id, 'contracts', files);
}
+ // Re-carry any company/profile document that is still missing from the
+ // contract (runs after the upload so fresh replacements keep their slot).
+ // Backfills contracts created before profile documents were carried over.
+ await this.attachProfileDocuments(
+ id,
+ existing.companyId ?? null,
+ existing.companyProfileId ?? null,
+ );
+
return { contract: await this.findById(id), warnings };
}
diff --git a/apps/edr-freight-api/src/modules/gps-tracking/README.md b/apps/edr-freight-api/src/modules/gps-tracking/README.md
new file mode 100644
index 000000000..668b581b8
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/gps-tracking/README.md
@@ -0,0 +1,150 @@
+# GPS Tracking (GT06) — Operations & Device Configuration
+
+GT06 trackers speak a **raw TCP binary protocol**, not HTTP/HTTPS. This shapes
+everything about how the service is deployed and how devices are pointed at it.
+
+---
+
+## 1. Why GPS needs its own dedicated TCP port
+
+- **Not HTTP.** GT06 devices send binary frames
+ (`0x78 0x78 | len | protocol | payload | serial | CRC16 | 0x0D 0x0A`).
+ An HTTP server receiving these answers `400 Bad Request` and closes.
+- **Dedicated port required.** A listening socket is keyed on `(IP, port)`; two
+ listeners on the same pair collide (`EADDRINUSE`). The REST API already owns
+ its port, so GPS traffic needs a separate one.
+- **No hostname routing.** GT06 frames carry no `Host` header and no TLS SNI, so
+ L7 proxies (Nginx `http`, AWS ALB, Cloudflare proxy) cannot route them by
+ domain. Routing must happen at **Layer 4 (TCP)** by port.
+- **DNS carries no port.** An A record maps a name to an IP only. The tracker
+ config must state the port explicitly (e.g. `gps.example.com:5023`).
+
+### Operational requirements
+
+| Item | Value |
+| --- | --- |
+| Protocol | Raw TCP (not HTTP, not TLS) |
+| Default port | `5023` (configurable via `GT06_TCP_PORT`) |
+| Listener bind | `0.0.0.0` inside the `freight-gps` container |
+| Edge terminator | **L4** — AWS NLB or Nginx `stream {}`. **Not** ALB / Cloudflare proxy. |
+
+---
+
+## 2. Port configuration
+
+`5023` is only this project's default — **not** a GT06 protocol requirement. The
+listener binds whatever `GT06_TCP_PORT` says, as long as trackers are configured
+with the same number.
+
+Host and container ports are decoupled in `docker-compose.yaml`:
+
+```yaml
+freight-gps:
+ ports:
+ - "${GT06_TCP_PORT:-5023}:5023" # host is configurable; container fixed
+ environment:
+ GT06_TCP_PORT: "5023" # pinned inside the container
+```
+
+- The **container** always listens on `5023`.
+- The **host/public** port is configurable (443, 5023, 9000, …) via the root
+ `.env`'s `GT06_TCP_PORT`.
+- This split is required because the image runs as a **non-root** user
+ (`nestjs`, uid 1001), which cannot bind ports `<1024`. Docker (root) binds the
+ host port and forwards to `5023` inside.
+- Running **outside Docker** (`pnpm dev:gps`, systemd), `GT06_TCP_PORT` is the
+ actual bind port, so `<1024` needs root or `CAP_NET_BIND_SERVICE`.
+- **443 is allowed but risky:** GT06 stays raw TCP, not TLS. Middleboxes that
+ expect a TLS handshake on 443 may drop the connection.
+
+---
+
+## 3. Deployment topology
+
+The GT06 listener runs as its own process (`dist/main.gps.js`, module
+`GpsIngestModule`) — DB + GPS only, no HTTP server. It shares the `edr_freight`
+DB with the API; the DB is the seam (ingester writes `gps_devices` /
+`gps_positions`, API reads them).
+
+```
+freight-api HTTP :3001 GT06_TCP_PORT=0 (listener off, applies migrations)
+freight-gps TCP :5023 DB_MIGRATIONS_RUN=false (owns the tracker socket)
+```
+
+`DB_MIGRATIONS_RUN=false` keeps the second process from racing migrations.
+
+Horizontal scale: each tracker holds one long-lived TCP connection with
+per-socket session state, so N `freight-gps` replicas can run behind an L4 LB —
+each device sticks to one replica. `ensureDevice` is safe under concurrency
+(unique IMEI).
+
+---
+
+## 4. Device configuration (GT06 side)
+
+Config is done by **SMS to the tracker's SIM**. Commands below are the canonical
+Concox/GT06 set — **verify against your unit's sheet**, syntax varies by firmware.
+Default command password is usually `123456`.
+
+Prep: data-enabled SIM, SMS on, **SIM PIN off**, know your carrier APN.
+
+```
+STATUS# # 1. sanity check — returns GSM/GPS/batt/GPRS
+APN,# # 2. carrier data APN (add ,user,pass if needed)
+SERVER,1,gps.example.com,5023,0# # 3. point at server (1=domain). Port MUST match GT06_TCP_PORT
+GPRSON,1# # 4. enable data
+GPSON,1# # enable GPS
+TIMER,10# # 5. upload interval, seconds (some use UPLOAD,10#)
+RESET# # 6. reboot so it reconnects (many cache DNS until reboot)
+```
+
+Raw-IP variant of step 3: `SERVER,0,203.0.113.50,5023,0#`
+Custom host port (e.g. 443): `SERVER,1,gps.example.com,443,0#`
+
+### Verify from the server
+
+```bash
+docker compose logs -f freight-gps | grep -Ei "login|Auto-registering|ingester up"
+nc -vz gps.example.com 5023
+curl -H "Authorization: Bearer " https://api.example.com/api/gps/positions/latest
+```
+
+First login packet **auto-registers** the IMEI (no manual step). `online:true`
+only when `lastSeenAt` < 5 min (computed at read time).
+
+### Link a tracker to a vehicle (optional)
+
+Auto-register leaves `vehicleId` null. Attach it (needs `tracking.manage`):
+
+```
+PATCH /api/gps/devices/:id { "vehicleId": "", "name": "Truck 03-ET" }
+```
+
+### Failure map
+
+| Symptom | Cause |
+| --- | --- |
+| No SMS reply | SIM PIN on / no signal / wrong number |
+| Replies but never connects | APN wrong, or `SERVER` port ≠ `GT06_TCP_PORT` |
+| Connects then drops | server not ACKing, or middlebox on 443 expecting TLS |
+| Registered but `online:false` | packets blocked by firewall — open inbound TCP |
+| Wrong location / `positioned:false` | no GPS fix yet — open sky, cold start ~1–2 min |
+
+---
+
+## 5. Security
+
+- GT06 authenticates with **IMEI only**, which is **spoofable**. Anyone who can
+ reach the port can inject fake positions.
+- **Do not** expose the port to `0.0.0.0/0`. Restrict at the firewall / security
+ group to the SIM provider's **APN / IP range**.
+- Trackers must use the same host+port as the server:
+ `SERVER,1,gps.example.com,,0#`.
+
+---
+
+## 6. Edge (L4) termination
+
+See [`infrastructure/nginx/gps-stream.conf`](../../../../../infrastructure/nginx/gps-stream.conf)
+for an Nginx `stream {}` example, and the AWS NLB notes in the same file.
+Reminder: **L4 only** — an HTTP proxy cannot route GT06.
diff --git a/apps/edr-freight-api/src/modules/notification-inbox/notification-inbox.controller.ts b/apps/edr-freight-api/src/modules/notification-inbox/notification-inbox.controller.ts
index 1d7fd27fc..80fecf1bf 100644
--- a/apps/edr-freight-api/src/modules/notification-inbox/notification-inbox.controller.ts
+++ b/apps/edr-freight-api/src/modules/notification-inbox/notification-inbox.controller.ts
@@ -13,8 +13,10 @@ import {
Patch,
Post,
Query,
+ UseGuards,
} from "@nestjs/common";
-import { ApiOperation, ApiTags } from "@nestjs/swagger";
+import { ApiBearerAuth, ApiOperation, ApiTags } from "@nestjs/swagger";
+import { JwtGuard } from "@tria-plc/api-common/modules/auth/services/jwt.guard";
import {
AuthUserPayload,
@@ -24,6 +26,8 @@ import { ListNotificationsQueryDto } from "./dto/list-notifications-query.dto";
import { NotificationInboxService } from "./notification-inbox.service";
@ApiTags("notifications")
+@ApiBearerAuth()
+@UseGuards(JwtGuard)
@Controller("notifications")
export class NotificationInboxController {
constructor(private readonly service: NotificationInboxService) {}
diff --git a/apps/edr-freight-api/src/modules/notification-inbox/notifications.gateway.ts b/apps/edr-freight-api/src/modules/notification-inbox/notifications.gateway.ts
index c14dcbaa5..0c4704170 100644
--- a/apps/edr-freight-api/src/modules/notification-inbox/notifications.gateway.ts
+++ b/apps/edr-freight-api/src/modules/notification-inbox/notifications.gateway.ts
@@ -15,9 +15,10 @@ import { WsAuthService } from "./ws-auth.service";
/**
* Server → client push for in-app notifications. Clients only *listen* (no
- * `@SubscribeMessage` handlers), so the global HTTP JwtGuard never applies here;
- * the handshake is authenticated in `handleConnection` and each socket joins a
- * private `user:` room the service targets.
+ * `@SubscribeMessage` handlers), and `@UseGuards(JwtGuard)` on the REST
+ * controller does not cover WebSockets; the handshake is authenticated in
+ * `handleConnection` and each socket joins a private `user:` room the
+ * service targets.
*/
@WebSocketGateway({
namespace: NOTIFICATION_WS_NAMESPACE,
diff --git a/apps/edr-freight-api/src/modules/notifications/strategies/notification.sms.strategy.ts b/apps/edr-freight-api/src/modules/notifications/strategies/notification.sms.strategy.ts
index d8404e84c..cddc67b2d 100644
--- a/apps/edr-freight-api/src/modules/notifications/strategies/notification.sms.strategy.ts
+++ b/apps/edr-freight-api/src/modules/notifications/strategies/notification.sms.strategy.ts
@@ -22,6 +22,10 @@ export class SmsNotificationStrategy implements NotificationStrategy {
this.logger.debug(`Sending SMS to ${recipient} via ${url}`);
+ // axios defaults to no timeout — a hanging gateway would block the caller
+ // (and any transaction it sits in) indefinitely. Always bound the wait.
+ const timeout = Number(this.configService.get("SMS_TIMEOUT_MS") ?? 8000);
+
try {
const response = await axios.post(
url,
@@ -34,6 +38,7 @@ export class SmsNotificationStrategy implements NotificationStrategy {
callbackUrl: "",
},
{
+ timeout,
headers: {
accept: "*/*",
"Content-Type": "application/json",
diff --git a/apps/edr-freight-api/src/modules/otp/otp.service.ts b/apps/edr-freight-api/src/modules/otp/otp.service.ts
index e26ed35c9..b98b41d8d 100644
--- a/apps/edr-freight-api/src/modules/otp/otp.service.ts
+++ b/apps/edr-freight-api/src/modules/otp/otp.service.ts
@@ -50,6 +50,9 @@ export class OtpService {
await this.otpRepository.createOtp(target, otp);
}
+ // A freshly issued code gets a fresh guess budget.
+ this.actionAttempts.delete(this.targetKey(target));
+
if (target.email) {
// send email (queued to RabbitMQ via the shared Email service)
await this.emailClient.sendEmail({
@@ -121,24 +124,44 @@ export class OtpService {
// ---------------------------------------------------------------------------
// Fresh, single-use challenge gating a sensitive action (e.g. applying a
- // contract signature). Unlike verifyOtp above — which marks a phone verified
- // and leaves the code in place — this enforces a short TTL and consumes the
- // code on success so it can never be replayed.
+ // contract signature, resetting a forgotten password). Unlike verifyOtp above
+ // — which marks a target verified and leaves the code in place — this enforces
+ // a TTL and consumes the code on success so it can never be replayed.
private readonly ACTION_OTP_TTL_MS = 5 * 60 * 1000;
- async verifyOtpForAction(phone: string, otp: string) {
- const otpData = await this.otpRepository.findByPhone(phone);
+ // Without a cap, a 6-digit code guarding a password reset is brute-forceable
+ // within its own TTL. `otp_verifications` has no attempt column, so the
+ // counter lives here and the code is burned once the budget is spent.
+ // Per-process: it resets on restart and is not shared across replicas — a
+ // persisted counter needs a migration on OtpVerification.
+ private readonly MAX_ACTION_ATTEMPTS = 5;
+ private readonly actionAttempts = new Map();
+
+ private targetKey(target: OtpTarget): string {
+ return target.email ? `email:${target.email}` : `phone:${target.phone}`;
+ }
+
+ async verifyOtpForAction(
+ target: OtpTarget,
+ otp: string,
+ ttlMs: number = this.ACTION_OTP_TTL_MS,
+ ) {
+ const otpData = await this.otpRepository.findByTarget(target);
+ const key = this.targetKey(target);
if (!otpData) {
throw new BadRequestException(
- "No verification code was requested for this phone",
+ target.email
+ ? "No verification code was requested for this email"
+ : "No verification code was requested for this phone",
);
}
const ageMs = Date.now() - new Date(otpData.updatedAt).getTime();
- if (ageMs > this.ACTION_OTP_TTL_MS) {
+ if (ageMs > ttlMs) {
await this.otpRepository.deleteOtp(otpData);
+ this.actionAttempts.delete(key);
throw new BadRequestException(
"Verification code has expired. Request a new one.",
@@ -146,11 +169,24 @@ export class OtpService {
}
if (otpData.otp !== otp) {
+ const attempts = (this.actionAttempts.get(key) ?? 0) + 1;
+
+ if (attempts >= this.MAX_ACTION_ATTEMPTS) {
+ await this.otpRepository.deleteOtp(otpData);
+ this.actionAttempts.delete(key);
+
+ throw new BadRequestException(
+ "Too many incorrect attempts. Request a new code.",
+ );
+ }
+
+ this.actionAttempts.set(key, attempts);
throw new BadRequestException("Invalid verification code");
}
// single-use: consume on success
await this.otpRepository.deleteOtp(otpData);
+ this.actionAttempts.delete(key);
return { success: true };
}
diff --git a/apps/edr-freight-api/src/modules/routes/entities/route.entity.ts b/apps/edr-freight-api/src/modules/routes/entities/route.entity.ts
index a79a54503..23399bb4d 100644
--- a/apps/edr-freight-api/src/modules/routes/entities/route.entity.ts
+++ b/apps/edr-freight-api/src/modules/routes/entities/route.entity.ts
@@ -39,12 +39,17 @@ export class Route extends BaseEntity {
milestones?: RouteMilestone[];
}
+/**
+ * Human-readable route label: yard names, not yard codes — "Addis Ababa → Dire Dawa",
+ * not "ADDIS_ABABA → DIRE_DAWA". A yard's display name is its `label`; `code` is the
+ * machine identifier and is only a fallback for a yard missing one.
+ */
export function formatRouteLabel(route: {
- originYard?: { code?: string; name?: string } | null;
- destinationYard?: { code?: string; name?: string } | null;
+ originYard?: { code?: string; label?: string } | null;
+ destinationYard?: { code?: string; label?: string } | null;
}): string {
- const origin = route.originYard?.code ?? route.originYard?.name ?? 'Origin';
- const dest = route.destinationYard?.code ?? route.destinationYard?.name ?? 'Destination';
+ const origin = route.originYard?.label ?? route.originYard?.code ?? 'Origin';
+ const dest = route.destinationYard?.label ?? route.destinationYard?.code ?? 'Destination';
return `${origin} → ${dest}`;
}
diff --git a/apps/edr-freight-api/src/modules/train-schedules/train-schedules.repository.ts b/apps/edr-freight-api/src/modules/train-schedules/train-schedules.repository.ts
index 700a38983..a64faabbe 100644
--- a/apps/edr-freight-api/src/modules/train-schedules/train-schedules.repository.ts
+++ b/apps/edr-freight-api/src/modules/train-schedules/train-schedules.repository.ts
@@ -22,7 +22,9 @@ export class TrainSchedulesRepository extends BaseRepository {
return this.repo(manager).findOne({
where: { id },
relations: {
- route: true,
+ // Yards carry the route's display name; without them formatRouteLabel
+ // degrades to the literal "Origin → Destination".
+ route: { originYard: true, destinationYard: true },
trainSet: {
locomotive: true,
locomotives: { locomotive: true },
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.constants.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.constants.ts
index 1ff1880b7..62ed50c0a 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.constants.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.constants.ts
@@ -34,3 +34,13 @@ export const DEFAULT_CONTAINER_WAGON_TARE_TONS = 22.4;
/** Default CW3 gondola tare for bulk bookings (T). */
export const DEFAULT_BULK_WAGON_TARE_TONS = 23.4;
+
+/**
+ * Fallback rated payloads (T) matching the tare fallbacks above. A bulk booking's
+ * wagon count is its cargo divided by this, so a zero here would make the count
+ * infinite — callers must floor it at a positive number.
+ */
+export const DEFAULT_CONTAINER_WAGON_CAPACITY_TONS = 70;
+
+/** Default CW3 gondola rated payload for bulk bookings (T). */
+export const DEFAULT_BULK_WAGON_CAPACITY_TONS = 60;
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.spec.ts
index 6f59ca123..24e908761 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.spec.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.spec.ts
@@ -136,6 +136,7 @@ describe('BookingBatchService — PAID reconcile', () => {
expirePayable: jest.fn().mockResolvedValue(undefined),
} as never,
{ emitPhase: jest.fn() } as never,
+ { computeSubmitPriorityScore: jest.fn().mockResolvedValue(0) } as never,
);
});
@@ -563,6 +564,7 @@ describe('BookingBatchService — PAID reconcile', () => {
trainSchedulingService as never,
{ syncPayableDueDate: jest.fn(), expirePayable: jest.fn() } as never,
{ emitPhase: jest.fn() } as never,
+ { computeSubmitPriorityScore: jest.fn().mockResolvedValue(0) } as never,
undefined,
{ findOpenOffer: jest.fn() } as never,
);
@@ -585,6 +587,7 @@ describe('BookingBatchService — PAID reconcile', () => {
trainSchedulingService as never,
{ syncPayableDueDate: jest.fn(), expirePayable: jest.fn() } as never,
{ emitPhase: jest.fn() } as never,
+ { computeSubmitPriorityScore: jest.fn().mockResolvedValue(0) } as never,
undefined,
{ findOpenOffer: jest.fn() } as never,
);
@@ -615,6 +618,7 @@ describe('BookingBatchService — PAID reconcile', () => {
trainSchedulingService as never,
{ syncPayableDueDate: jest.fn(), expirePayable: jest.fn() } as never,
{ emitPhase: jest.fn() } as never,
+ { computeSubmitPriorityScore: jest.fn().mockResolvedValue(0) } as never,
undefined,
{ findOpenOffer: jest.fn() } as never,
);
@@ -630,4 +634,236 @@ describe('BookingBatchService — PAID reconcile', () => {
expect(check({ ...importGeneral, contractKind: null } as Booking, false)).toBe(false);
});
});
+
+ describe('settleDueReservations — expire then promote the waiting list', () => {
+ const originYardId = 'yard-origin';
+ const destinationYardId = 'yard-dest';
+ const trainId = 'train-a';
+ // 14m / 70t default wagon → two wagon slots on this locomotive.
+ const smallLoco = { maxPullWeightTons: 200, maxTrainLengthMeters: 28 };
+
+ const booking = (id: string, priority: number, overrides = {}): Booking =>
+ ({
+ id,
+ reference: id,
+ isGovernment: false,
+ priorityScore: priority,
+ status: 'FULLY_EXECUTED',
+ wagonsRequired: 1,
+ cargoTotalWeightVgm: 10,
+ freightType: 'CONTAINER',
+ bookingContainers: [],
+ originYardId,
+ destinationYardId,
+ trainScheduleId: trainId,
+ ...overrides,
+ }) as unknown as Booking;
+
+ beforeEach(() => {
+ const scheduleRow = {
+ id: trainId,
+ maxWagons: 2,
+ bookingWindowStatus: 'CLOSED',
+ windowPhase: 'PAYMENT',
+ direction: 'IMPORT',
+ trainSetId: `set-${trainId}`,
+ trainSet: { locomotive: smallLoco },
+ scheduleBookings: [],
+ scheduledDepartureDate: new Date('2026-06-20T06:00:00.000Z'),
+ originStationId: originYardId,
+ destinationStationId: destinationYardId,
+ };
+ trainSchedulesRepository.findAll.mockResolvedValue([{ ...scheduleRow }]);
+ trainSchedulesRepository.findByIdWithFullGraph.mockResolvedValue(scheduleRow);
+ trainSchedulesRepository.findById.mockResolvedValue({
+ id: trainId,
+ bookingWindowStatus: 'CLOSED',
+ windowPhase: 'PAYMENT',
+ scheduledDepartureDate: scheduleRow.scheduledDepartureDate,
+ originStationId: originYardId,
+ destinationStationId: destinationYardId,
+ });
+ });
+
+ it('promotes a waiting booking into the wagons an expired reservation frees', async () => {
+ // One reservation whose pay window lapsed, and one booking on the waiting list.
+ const lapsed = booking('lapsed', 50, {
+ status: 'SELECTED_FOR_BATCH',
+ paymentDeadline: new Date(Date.now() - 60_000),
+ });
+ const waiting = booking('waiting', 10, { trainScheduleId: null });
+
+ bookingsRepository.findReservedForSchedule
+ .mockResolvedValueOnce([lapsed]) // settleReserved sees the lapsed one
+ .mockResolvedValue([]); // afterwards nothing is reserved
+ // The day pool the top-up draws from: only the waiting booking is eligible.
+ bookingsRepository.findBatchPoolByCorridorDay
+ .mockResolvedValueOnce([waiting])
+ .mockResolvedValue([]);
+
+ await service.settleDueReservations(trainId);
+
+ // The lapsed reservation expired...
+ expect(notifier.expired).toHaveBeenCalledTimes(1);
+ expect((notifier.expired.mock.calls[0][0] as Booking).id).toBe('lapsed');
+ // ...and the waiting booking was promoted in the SAME settle, not next cycle.
+ expect(notifier.payNow).toHaveBeenCalledTimes(1);
+ expect((notifier.payNow.mock.calls[0][0] as Booking).id).toBe('waiting');
+ });
+
+ it('serialises concurrent settles so the same reservation is not settled twice', async () => {
+ const lapsed = booking('lapsed', 50, {
+ status: 'SELECTED_FOR_BATCH',
+ paymentDeadline: new Date(Date.now() - 60_000),
+ });
+ // Both callers read the reservation; the lock must stop the second from
+ // acting on rows the first already expired. (The PAYMENT transition and the
+ // tick's overdue backstop do exactly this, in the same second.)
+ let reads = 0;
+ bookingsRepository.findReservedForSchedule.mockImplementation(() => {
+ reads += 1;
+ return Promise.resolve(reads === 1 ? [lapsed] : []);
+ });
+ bookingsRepository.findBatchPoolByCorridorDay.mockResolvedValue([]);
+
+ await Promise.all([
+ service.settleDueReservations(trainId),
+ service.settleDueReservations(trainId),
+ ]);
+
+ expect(notifier.expired).toHaveBeenCalledTimes(1);
+ });
+ });
+});
+
+describe('BookingBatchService — wagonsFor', () => {
+ // wagonsFor is pure arithmetic over its two arguments and touches no injected
+ // dependency, so the service can be built with none.
+ const service = new BookingBatchService(
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ null as never,
+ ) as unknown as {
+ wagonsFor(booking: unknown, dims: unknown): number;
+ needFor(booking: unknown, dims: unknown): {
+ wagons: number;
+ weightTons: number;
+ lengthMeters: number;
+ };
+ };
+
+ // PW2 box wagon: 70T rated payload, 25.2T tare, 17.066m.
+ const dims = {
+ container: { lengthMeters: 13.966, tareWeightTons: 22.4, capacityTons: 70 },
+ bulk: { lengthMeters: 17.066, tareWeightTons: 25.2, capacityTons: 70 },
+ byWagonTypeId: new Map(),
+ };
+
+ const bulk = (cargoTons: number, over: Record = {}) => ({
+ freightType: 'BULK',
+ cargoTotalWeightVgm: cargoTons,
+ bookingContainers: [],
+ ...over,
+ });
+
+ it('sizes a bulk booking by cargo ÷ rated payload, not a flat 1 wagon', () => {
+ // 37 × 1400 fertilizer packages × 50kg = 2590T of cargo.
+ expect(service.wagonsFor(bulk(2590), dims)).toBe(37);
+ });
+
+ it('rounds a partial wagon up', () => {
+ expect(service.wagonsFor(bulk(70.1), dims)).toBe(2);
+ expect(service.wagonsFor(bulk(70), dims)).toBe(1);
+ });
+
+ it('still floors at one wagon when a bulk booking has no recorded cargo', () => {
+ expect(service.wagonsFor(bulk(0), dims)).toBe(1);
+ });
+
+ it('honours an explicit wagonsRequired override', () => {
+ expect(service.wagonsFor(bulk(2590, { wagonsRequired: 40 }), dims)).toBe(40);
+ });
+
+ it('ignores a stale undersized wagonsRequired: 700T of sugar rides 10 wagons, not 1', () => {
+ // Rows written while sumWagonsRequired hardcoded BULK to 1 are still in the
+ // DB; trusting them charged one tare for the whole consist (700 + 25.2
+ // instead of 700 + 10 × 25.2 gross).
+ expect(service.wagonsFor(bulk(700, { wagonsRequired: 1 }), dims)).toBe(10);
+ });
+
+ it('takes the binding axis for containers: weight can exceed TEU geometry', () => {
+ // Two 40ft units => 2 wagons by TEU geometry, but 210T needs 3 at 70T each.
+ const booking = {
+ freightType: 'CONTAINER',
+ cargoTotalWeightVgm: 210,
+ bookingContainers: [
+ { quantity: 2, wagonsRequired: 2, containerType: { wagonsPerUnit: 1, sizeFt: 40 } },
+ ],
+ };
+ expect(service.wagonsFor(booking, dims)).toBe(3);
+ });
+
+ it('keeps TEU geometry when it binds before weight', () => {
+ // Four 20ft units => 2 wagons by geometry; 40T of cargo needs only 1 by weight.
+ const booking = {
+ freightType: 'CONTAINER',
+ cargoTotalWeightVgm: 40,
+ bookingContainers: [
+ { quantity: 4, wagonsRequired: 2, containerType: { wagonsPerUnit: 0.5, sizeFt: 20 } },
+ ],
+ };
+ expect(service.wagonsFor(booking, dims)).toBe(2);
+ });
+
+ describe('per-booking wagon type (cargo/container type FK)', () => {
+ // The booking's cargo type rides PW2 (25.2T tare / 70T), but the
+ // representative bulk fallback is a CW3-ish 23.4T tare. Measuring the
+ // booking on the fallback under-charged its gross (2100 + 30 × 23.4 =
+ // 2802 instead of 2856), so the fill loop admitted sets that allocation's
+ // real-consist check later rejected — after the customer had paid.
+ const dimsWithTypes = {
+ container: { lengthMeters: 13.966, tareWeightTons: 22.4, capacityTons: 70 },
+ bulk: { lengthMeters: 17.066, tareWeightTons: 23.4, capacityTons: 70 },
+ byWagonTypeId: new Map([
+ ['pw2-id', { lengthMeters: 17.066, tareWeightTons: 25.2, capacityTons: 70 }],
+ ]),
+ };
+
+ it('charges a bulk booking the tare of ITS wagon type, not the representative', () => {
+ const booking = bulk(2100, { cargoType: { wagonTypeId: 'pw2-id' } });
+ const need = service.needFor(booking, dimsWithTypes);
+ expect(need.wagons).toBe(30);
+ expect(need.weightTons).toBe(2856); // 2100 + 30 × 25.2 — matches allocation
+ });
+
+ it('falls back to the representative dims when no wagon type is configured', () => {
+ const need = service.needFor(bulk(2100), dimsWithTypes);
+ expect(need.weightTons).toBe(2802); // 2100 + 30 × 23.4 (legacy behavior)
+ });
+
+ it('resolves a container booking through its container type', () => {
+ const booking = {
+ freightType: 'CONTAINER',
+ cargoTotalWeightVgm: 140,
+ bookingContainers: [
+ {
+ quantity: 2,
+ wagonsRequired: 2,
+ containerType: { wagonsPerUnit: 1, sizeFt: 40, wagonTypeId: 'pw2-id' },
+ },
+ ],
+ };
+ const need = service.needFor(booking, dimsWithTypes);
+ expect(need.wagons).toBe(2);
+ expect(need.weightTons).toBe(190.4); // 140 + 2 × 25.2
+ expect(need.lengthMeters).toBeCloseTo(34.132, 3); // 2 × 17.066, not NW5's 13.966
+ });
+ });
});
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.ts
index f0ac6f4a4..7dd78d167 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-batch.service.ts
@@ -1,6 +1,8 @@
import {
BadRequestException,
ConflictException,
+ forwardRef,
+ Inject,
Injectable,
Logger,
NotFoundException,
@@ -9,10 +11,19 @@ import {
} from '@nestjs/common';
import { InjectDataSource } from '@nestjs/typeorm';
import { SchedulerRegistry } from '@nestjs/schedule';
-import { DataSource, In } from 'typeorm';
+import {
+ Between,
+ DataSource,
+ FindOptionsWhere,
+ ILike,
+ In,
+ LessThanOrEqual,
+ MoreThanOrEqual,
+} from 'typeorm';
import { Booking } from '../bookings/entities/booking.entity';
import { BookingsRepository } from '../bookings/bookings.repository';
+import { BookingPricingService } from '../bookings/booking-pricing.service';
import { Locomotive } from '../locomotives/entities/locomotive.entity';
import { formatRouteLabel } from '../routes/entities/route.entity';
import { RouteMilestone } from '../routes/entities/route-milestone.entity';
@@ -24,13 +35,19 @@ import { TrainSchedulingGlobalRules } from './entities/train-scheduling-global-r
import { BookingNotifierService } from './booking-notifier.service';
import { TrainSchedulingService } from './train-scheduling.service';
import { eatDay, groupBookingsIntoBoardWindows } from './batch-window.util';
+import {
+ BATCH_BOARD_STATUSES,
+ BatchBoardQueryDto,
+} from './dto/batch-board-query.dto';
import { Freight, TrainScheduleStatus as TrainScheduleStatusEnum } from "@edr/types";
import { BillingService } from "../billing/billing.service";
import {
+ DEFAULT_BULK_WAGON_CAPACITY_TONS,
DEFAULT_BULK_WAGON_LENGTH_METERS,
DEFAULT_BULK_WAGON_TARE_TONS,
+ DEFAULT_CONTAINER_WAGON_CAPACITY_TONS,
DEFAULT_CONTAINER_WAGON_LENGTH_METERS,
DEFAULT_CONTAINER_WAGON_TARE_TONS,
DEFAULT_WAGONS_PER_BOOKING,
@@ -38,8 +55,8 @@ import {
import {
WagonTypeDimensions,
bookingGrossWeightTons,
- bookingTrainLengthMeters,
deriveTrainCapacityFromLocomotive,
+ sizePartialOfferWagons,
trainHardCaps,
wagonTypeDimensionsFromEntity,
} from './train-capacity.util';
@@ -55,11 +72,18 @@ import {
Capacity,
CorridorBudget,
CorridorLeg,
+ OverageTolerance,
stopYardsFor,
} from './corridor-capacity.util';
export type { Capacity } from './corridor-capacity.util';
+/**
+ * A train's fill limits: the base caps the corridor budget spends from, plus
+ * the locomotive overage tolerance spendable only on whole-booking admission.
+ */
+type TrainLimits = { base: Capacity; tolerance: OverageTolerance };
+
/** A day-level pool key: all trains on this route departing on this EAT day. */
interface RouteDayGroup {
originYardId: string;
@@ -68,13 +92,20 @@ interface RouteDayGroup {
day: string;
}
+/** One wagon type's footprint: its length on the train, the tare it adds to the
+ * locomotive's gross load, and the payload it carries. */
+type PerWagonDims = { lengthMeters: number; tareWeightTons: number; capacityTons: number };
+
/**
- * Per-freight-type wagon dimensions used to size a booking's capacity draw:
- * its length on the train and the tare it adds to the locomotive's gross load.
+ * Wagon dimensions used to size a booking's capacity draw. `byWagonTypeId` holds
+ * every wagon type so a booking is measured on the type its cargo/container type
+ * actually rides (the same FK resolution allocation uses); `container`/`bulk` are
+ * representative fallbacks for bookings whose type has no wagon type configured.
*/
type WagonDims = {
- container: { lengthMeters: number; tareWeightTons: number };
- bulk: { lengthMeters: number; tareWeightTons: number };
+ container: PerWagonDims;
+ bulk: PerWagonDims;
+ byWagonTypeId: Map;
};
export type BatchBoardBookingState =
@@ -139,6 +170,8 @@ export interface BatchWindowGroup {
export interface BatchBoardScheduleDetail {
scheduleId: string;
+ /** Human-facing schedule reference (S-YYYY-NNNNN). */
+ scheduleReference: string | null;
trainNumber: string | null;
routeName: string | null;
origin: string | null;
@@ -163,11 +196,14 @@ export interface BatchBoardScheduleDetail {
export interface BatchBoardSchedule {
scheduleId: string;
+ /** Human-facing schedule reference (S-YYYY-NNNNN). */
+ scheduleReference: string | null;
trainNumber: string | null;
routeName: string | null;
origin: string | null;
destination: string | null;
scheduleDate: string | null;
+ createdAt: string | null;
status: string;
bookingWindowStatus: string;
direction: string | null;
@@ -206,6 +242,16 @@ export interface BatchBoardSchedule {
bookings: BatchBoardBooking[];
}
+/** Paginated batch-board list. `items` (not `data`) — the API response wrapper
+ * already uses `data`, and the frontend's unwrap() strips one `data` level. */
+export interface BatchBoardListResponse {
+ items: BatchBoardSchedule[];
+ total: number;
+ page: number;
+ pageSize: number;
+ totalPages: number;
+}
+
/**
* Demand-batching engine: every 3h (EAT) it ranks each OPEN schedule's ready pool
* by priority, greedily fills the train to capacity (skipping bookings that don't fit),
@@ -219,6 +265,14 @@ export interface BatchBoardSchedule {
export class BookingBatchService implements OnModuleInit {
private readonly logger = new Logger(BookingBatchService.name);
+ /**
+ * Serialises settle/top-up per schedule. The PAYMENT phase transition and the
+ * tick's overdue backstop both call settleDueReservations for the same schedule
+ * in the same second; without this they interleave and the top-up runs against a
+ * schedule whose phase has already been concluded.
+ */
+ private readonly scheduleLocks = new Map>();
+
constructor(
@InjectDataSource() private readonly dataSource: DataSource,
private readonly bookingsRepository: BookingsRepository,
@@ -229,6 +283,8 @@ export class BookingBatchService implements OnModuleInit {
private readonly trainSchedulingService: TrainSchedulingService,
private readonly billing: BillingService,
private readonly bookingWindowGateway: BookingWindowGateway,
+ @Inject(forwardRef(() => BookingPricingService))
+ private readonly pricingService: BookingPricingService,
@Optional() private readonly milestoneService?: ClearanceMilestoneService,
@Optional() private readonly splitService?: BookingSplitService,
@@ -425,7 +481,7 @@ export class BookingBatchService implements OnModuleInit {
const schedule = await this.trainSchedulesRepository.findByIdWithFullGraph(
booking.trainScheduleId,
);
- if (schedule && (await this.remainingWagons(schedule)) <= 0) {
+ if (schedule && (await this.isTrainFull(schedule))) {
await this.setWindow(booking.trainScheduleId, "FULL");
}
@@ -555,7 +611,14 @@ export class BookingBatchService implements OnModuleInit {
const partner = await this.dataSource
.getRepository(Booking)
- .findOne({ where: { id: partnerId }, relations: { company: true, bookingContainers: true } });
+ .findOne({
+ where: { id: partnerId },
+ relations: {
+ company: true,
+ bookingContainers: { containerType: true },
+ cargoType: true,
+ },
+ });
// Partner not yet accepted → this booking is now FULLY_EXECUTED and simply
// waits; the partner's later accept will reserve the pair.
if (!partner || partner.status !== 'FULLY_EXECUTED') {
@@ -576,7 +639,7 @@ export class BookingBatchService implements OnModuleInit {
this.armSettle(scheduleId);
const schedule =
await this.trainSchedulesRepository.findByIdWithFullGraph(scheduleId);
- if (schedule && (await this.remainingWagons(schedule)) <= 0) {
+ if (schedule && (await this.isTrainFull(schedule))) {
await this.setWindow(scheduleId, 'FULL');
}
}
@@ -617,19 +680,80 @@ export class BookingBatchService implements OnModuleInit {
// ---- monitoring board -----------------------------------------------------
/**
- * Read model for the batch monitoring page: every still-relevant schedule (not arrived/
- * cancelled) with its locomotive, capacity usage and its bookings grouped by lifecycle
- * state (allocated / awaiting payment / paid-waiting / pending contract / expired).
+ * Read model for the batch monitoring page: every import schedule — including
+ * dispatched, arrived and cancelled history — with its locomotive, capacity
+ * usage and its bookings grouped by lifecycle state (allocated / awaiting
+ * payment / paid-waiting / pending contract / expired). Paginated and
+ * filterable; per-schedule booking summaries are only computed for the
+ * requested page.
*/
- async getBatchBoard(): Promise {
- const schedules = await this.trainSchedulesRepository.findAll({
+ async getBatchBoard(
+ query: BatchBoardQueryDto = {},
+ ): Promise {
+ const page = query.page ?? 1;
+ const pageSize = query.pageSize ?? 12;
+
+ // Status filter: any subset of the lifecycle. Omitted = all statuses, so
+ // arrived / cancelled / dispatched schedules stay visible as history.
+ const allowedStatuses = new Set(BATCH_BOARD_STATUSES);
+ const statuses = (query.statuses ?? "")
+ .split(",")
+ .map((v) => v.trim().toUpperCase())
+ .filter((v) => allowedStatuses.has(v));
+
+ const dateRange = (from?: string, to?: string) => {
+ const f = from ? new Date(from) : null;
+ const t = to ? new Date(to) : null;
+ if (f && t) return Between(f, t);
+ if (f) return MoreThanOrEqual(f);
+ if (t) return LessThanOrEqual(t);
+ return undefined;
+ };
+
+ // Batch board is IMPORT-only: export is FCFS with no batch/priority calc,
+ // and domestic/legacy schedules run the legacy fill, not the window batch.
+ const base: FindOptionsWhere = { direction: "IMPORT" };
+ if (statuses.length) base.status = In(statuses) as never;
+ if (query.bookingWindowStatus) {
+ base.bookingWindowStatus = query.bookingWindowStatus;
+ }
+ const departure = dateRange(query.departureFrom, query.departureTo);
+ if (departure) base.scheduledDepartureDate = departure as never;
+ const created = dateRange(query.createdFrom, query.createdTo);
+ if (created) base.createdAt = created as never;
+
+ // Search fans out across every human-recognizable label. Each OR variant
+ // repeats the base filters so the search never widens them.
+ const term = query.search?.trim();
+ let where: FindOptionsWhere | FindOptionsWhere[] =
+ base;
+ if (term) {
+ const like = ILike(`%${term}%`);
+ where = [
+ { ...base, trainNumber: like as never },
+ { ...base, originStation: { label: like } },
+ { ...base, destinationStation: { label: like } },
+ { ...base, route: { originYard: { label: like } } },
+ { ...base, route: { destinationYard: { label: like } } },
+ { ...base, trainSet: { locomotive: { code: like } } },
+ ] as FindOptionsWhere[];
+ }
+
+ const sortBy = query.sortBy ?? "createdAt";
+ const sortOrder = query.sortOrder ?? "DESC";
+
+ const [schedules, total] = await this.trainSchedulesRepository.findAndCount({
+ where,
relations: {
trainSet: { locomotive: true },
originStation: true,
destinationStation: true,
- route: true,
+ // Yards supply the route's display name for `routeName` below.
+ route: { originYard: true, destinationYard: true },
},
- order: { scheduledDepartureDate: "ASC" },
+ order: { [sortBy]: sortOrder } as never,
+ skip: (page - 1) * pageSize,
+ take: pageSize,
});
const wagonDims = await this.loadWagonDims();
@@ -638,11 +762,6 @@ export class BookingBatchService implements OnModuleInit {
const board: BatchBoardSchedule[] = [];
for (const s of schedules) {
- if (s.status === "ARRIVED" || s.status === "CANCELLED") continue;
- // Batch board is IMPORT-only: export is FCFS with no batch/priority calc,
- // and domestic/legacy schedules run the legacy fill, not the window batch.
- if (s.direction !== "IMPORT") continue;
-
const links = await linkRepo.find({ where: { trainScheduleId: s.id } });
const linkedIds = new Set(links.map((l) => l.bookingId));
const bookings = await this.bookingsRepository.findAllBySchedule(s.id);
@@ -670,7 +789,14 @@ export class BookingBatchService implements OnModuleInit {
board.push(this.buildScheduleSummary(s, items, rules));
}
- return board;
+
+ return {
+ items: board,
+ total,
+ page,
+ pageSize,
+ totalPages: Math.max(1, Math.ceil(total / pageSize)),
+ };
}
/** Schedule-level batch board with EAT 3h windows grouped by fullyExecutedAt. */
@@ -681,9 +807,8 @@ export class BookingBatchService implements OnModuleInit {
await this.trainSchedulesRepository.findByIdWithFullGraph(scheduleId);
if (!s)
throw new NotFoundException(`Train schedule ${scheduleId} not found`);
- if (s.status === "ARRIVED" || s.status === "CANCELLED") {
- throw new BadRequestException("Schedule is no longer active");
- }
+ // Arrived / cancelled schedules stay viewable — the board is also the
+ // historical record of what each train carried.
// Batch board is IMPORT-only (export is FCFS, no batch/priority calc).
if (s.direction !== "IMPORT") {
throw new BadRequestException(
@@ -858,6 +983,7 @@ export class BookingBatchService implements OnModuleInit {
return {
scheduleId: s.id,
+ scheduleReference: s.reference ?? null,
trainNumber: s.trainNumber ?? null,
routeName: s.route ? formatRouteLabel(s.route) : null,
origin: s.originStation?.label ?? s.originStation?.code ?? null,
@@ -979,6 +1105,7 @@ export class BookingBatchService implements OnModuleInit {
return {
scheduleId: s.id,
+ scheduleReference: s.reference ?? null,
trainNumber: s.trainNumber ?? null,
routeName: s.route ? formatRouteLabel(s.route) : null,
origin: s.originStation?.label ?? s.originStation?.code ?? null,
@@ -987,6 +1114,7 @@ export class BookingBatchService implements OnModuleInit {
scheduleDate: s.scheduledDepartureDate
? s.scheduledDepartureDate.toISOString()
: null,
+ createdAt: s.createdAt ? s.createdAt.toISOString() : null,
status: s.status,
bookingWindowStatus: s.bookingWindowStatus,
direction: s.direction ?? null,
@@ -1080,12 +1208,17 @@ export class BookingBatchService implements OnModuleInit {
const limits = await this.capacityLimits(locomotive, rules);
await this.syncScheduleMaxWagons(schedule, locomotive, rules);
const budget = await this.remainingBudget(schedule, limits, wagonDims);
- if (budget.maxRemaining().wagons <= 0) {
+ const minPerWagon = this.minPerWagonNeed(wagonDims);
+ if (budget.isExhausted(minPerWagon)) {
await this.setWindow(scheduleId, "FULL");
return 0;
}
const pool = await this.bookingsRepository.findBatchPool(scheduleId);
+ // Same bulk re-score as fillRouteDayInternal — the legacy per-schedule fill
+ // must rank bulk bookings by their wagon-derived priority too.
+ await this.recomputeBulkPriorities(pool, wagonDims);
+ this.resortPoolByPriority(pool);
const units = this.groupConsolidatedPool(pool);
let armed = false;
let reservedThisPass = 0;
@@ -1172,7 +1305,7 @@ export class BookingBatchService implements OnModuleInit {
this.logger.log(
`[fillSchedule ${scheduleId}] reserved ${reservedThisPass}/${units.length} unit(s) this pass`,
);
- if (budget.maxRemaining().wagons <= 0) await this.setWindow(scheduleId, "FULL");
+ if (budget.isExhausted(minPerWagon)) await this.setWindow(scheduleId, "FULL");
if (armed) this.armSettle(scheduleId);
void this.triggerWagonAllocation(scheduleId);
return commercialReserved;
@@ -1303,6 +1436,10 @@ export class BookingBatchService implements OnModuleInit {
corridorYards,
day,
);
+ // BULK bookings only get their real (wagon-derived) priority score now, at
+ // batch time — stamp it and re-rank before the fill consumes the pool.
+ await this.recomputeBulkPriorities(pool, wagonDims);
+ this.resortPoolByPriority(pool);
// Consolidated partners collapse into one atomic unit (both-or-neither); a
// consolidated booking whose partner isn't ready this cycle is skipped.
const units = this.groupConsolidatedPool(pool);
@@ -1416,8 +1553,9 @@ export class BookingBatchService implements OnModuleInit {
`[fillRouteDay ${originYardId}->${destinationYardId} ${day}] reserved ${reservedThisPass}/${units.length} unit(s) this pass`,
);
+ const minPerWagon = this.minPerWagonNeed(wagonDims);
for (const t of trains) {
- if (t.budget.maxRemaining().wagons <= 0) await this.setWindow(t.id, "FULL");
+ if (t.budget.isExhausted(minPerWagon)) await this.setWindow(t.id, "FULL");
if (t.armed) this.armSettle(t.id);
void this.triggerWagonAllocation(t.id);
}
@@ -1493,12 +1631,28 @@ export class BookingBatchService implements OnModuleInit {
if (await this.splitService.findOpenOffer(booking.id)) return null;
const wagonDims = await this.loadWagonDims();
- const bulkCapacityTons = await this.loadBulkWagonCapacityTons();
+
+ // The wagon-slot axis alone under-constrains the offer. On a weight- or
+ // length-limited train (slots to spare, but e.g. only 798T of pull weight
+ // left) sizing by slots either produced an offer the fits() check below
+ // rejected, or — when the free slots exceeded the booking's own wagon
+ // count — sizeOffer refused outright, so a bulk booking on a weight-bound
+ // train was never offered a split at all. Size across all three axes,
+ // measured on the booking's REAL wagon type — the same one allocation
+ // validates against. Bulk splits ride FULL wagons only: the offer never
+ // part-loads its last wagon.
+ const perWagon = this.dimsFor(booking, wagonDims);
+ const partial = sizePartialOfferWagons(budget, need.wagons, perWagon, {
+ fullWagonsOnly: booking.freightType === "BULK",
+ });
+ if (!partial) return null;
+
const sized = await this.splitService.sizeOffer(
booking,
- budget.wagons,
+ partial.wagons,
need.wagons,
- bulkCapacityTons,
+ perWagon.capacityTons,
+ partial.maxCargoTons,
);
if (!sized) return null;
@@ -1507,13 +1661,9 @@ export class BookingBatchService implements OnModuleInit {
weightTons: bookingGrossWeightTons(
sized.offeredWeightTons,
sized.offeredWagons,
- this.tareFor(booking.freightType, wagonDims),
- ),
- lengthMeters: bookingTrainLengthMeters(
- booking.freightType,
- sized.offeredWagons,
- this.lengthsOf(wagonDims),
+ perWagon.tareWeightTons,
),
+ lengthMeters: sized.offeredWagons * perWagon.lengthMeters,
};
if (!this.fits(offeredNeed, budget)) return null;
@@ -1531,14 +1681,6 @@ export class BookingBatchService implements OnModuleInit {
return offeredNeed;
}
- private async loadBulkWagonCapacityTons(): Promise {
- const cw3 = await this.dataSource
- .getRepository(WagonType)
- .findOne({ where: { code: "CW3" } });
- const capacity = cw3 ? wagonTypeDimensionsFromEntity(cw3).capacityTons : 60;
- return capacity > 0 ? capacity : 60;
- }
-
/**
* Settle a schedule's reserved bookings. `expireUnpaidUnknownDeadline` decides
* how to treat a reservation with no deadline (durable path: leave it; timeout
@@ -1602,21 +1744,92 @@ export class BookingBatchService implements OnModuleInit {
return anySettled;
}
- /** Durable settle: allocate paid / expire overdue reservations, then top up. */
+ /**
+ * Durable settle: allocate paid / expire overdue reservations, then top up the
+ * freed capacity from the waiting list.
+ *
+ * Serialised per schedule. Two callers race here every time a payment phase
+ * ends: `advanceImport`'s PAYMENT branch and the tick's `settleOverdueReservations`
+ * backstop. Both read the same reserved rows in the same second, so without the
+ * lock the second caller re-settles rows the first is mid-way through expiring,
+ * and `concludeCycle` observes capacity that is neither pre- nor post-expiry.
+ */
async settleDueReservations(scheduleId: string): Promise {
- const anySettled = await this.settleReserved(scheduleId, false);
- // A settle that allocated/expired anything frees or fills capacity → re-run the
- // fill so the next waiting-list bookings get a fresh pay window (top-up).
- if (anySettled) {
+ await this.withScheduleLock(scheduleId, () =>
+ this.settleAndTopUp(scheduleId, false),
+ );
+ }
+
+ /**
+ * Settle, then keep promoting the waiting list until the train can take no more.
+ * Returns whether anything settled.
+ *
+ * One top-up pass is not enough: expiring an N-wagon booking can free room for
+ * several smaller ones, and reserving those can in turn leave room for the next
+ * size down. Loop until a pass reserves nothing, so the batch ends with the train
+ * as full as the pool allows — rather than leaving a booking stranded until the
+ * next window cycle.
+ *
+ * Each round that opens a fresh pay window pushes `paymentPhaseEndsAt` out, so
+ * `concludeCycle` cannot fire before the promoted customers' deadlines.
+ */
+ private async settleAndTopUp(
+ scheduleId: string,
+ expireUnpaidUnknownDeadline: boolean,
+ ): Promise {
+ const anySettled = await this.settleReserved(
+ scheduleId,
+ expireUnpaidUnknownDeadline,
+ );
+ if (!anySettled) return false;
+
+ this.logger.log(
+ `[BATCH] settle changed state on ${scheduleId} — running top-up fill for the waiting list`,
+ );
+
+ // Bounded: every round either reserves at least one unit (shrinking the pool)
+ // or breaks. The cap is a backstop against a pathological reserve/expire cycle.
+ let promoted = 0;
+ for (let round = 0; round < 10; round += 1) {
+ const reservedThisRound = await this.topUpFill(scheduleId);
+ if (reservedThisRound <= 0) break;
+ promoted += reservedThisRound;
+ await this.extendPaymentPhaseForTopUp(scheduleId);
+ }
+
+ if (promoted > 0) {
this.logger.log(
- `[BATCH] settle changed state on ${scheduleId} — running top-up fill for the waiting list`,
+ `[BATCH] top-up promoted ${promoted} waiting booking(s) onto ${scheduleId} ` +
+ `— payment phase extended for them`,
);
- const topUpReserved = await this.topUpFill(scheduleId);
- // A top-up opened a fresh pay window for waiting bookings — push the
- // schedule's PAYMENT phase out so the window tick's concludeCycle doesn't
- // fire before those customers' new deadlines and expire them prematurely.
- if (topUpReserved > 0) {
- await this.extendPaymentPhaseForTopUp(scheduleId);
+ }
+ return true;
+ }
+
+ /**
+ * Run `fn` with exclusive access to `scheduleId`. Concurrent callers await the
+ * in-flight run rather than interleaving with it. Single-process only — a second
+ * API replica would need a row lock on the schedule instead.
+ */
+ private async withScheduleLock(
+ scheduleId: string,
+ fn: () => Promise,
+ ): Promise {
+ const inFlight = this.scheduleLocks.get(scheduleId) ?? Promise.resolve();
+ // Chain onto the previous holder; swallow its rejection so one failure does
+ // not poison every later caller's lock.
+ const run = inFlight.catch(() => undefined).then(fn);
+ const gate = run.then(
+ () => undefined,
+ () => undefined,
+ );
+ this.scheduleLocks.set(scheduleId, gate);
+ try {
+ return await run;
+ } finally {
+ // Last one out clears the slot so the map does not grow without bound.
+ if (this.scheduleLocks.get(scheduleId) === gate) {
+ this.scheduleLocks.delete(scheduleId);
}
}
}
@@ -1626,11 +1839,9 @@ export class BookingBatchService implements OnModuleInit {
/** Allocate paid reservations, expire the rest, then top up. */
async settleBatch(scheduleId: string): Promise {
this.removeTimeout(scheduleId);
- await this.settleReserved(scheduleId, true);
- const topUpReserved = await this.topUpFill(scheduleId);
- if (topUpReserved > 0) {
- await this.extendPaymentPhaseForTopUp(scheduleId);
- }
+ await this.withScheduleLock(scheduleId, () =>
+ this.settleAndTopUp(scheduleId, true),
+ );
void this.triggerWagonAllocation(scheduleId);
}
@@ -1665,7 +1876,7 @@ export class BookingBatchService implements OnModuleInit {
const schedule = await this.trainSchedulesRepository.findByIdWithFullGraph(
booking.trainScheduleId,
);
- if (schedule && (await this.remainingWagons(schedule)) <= 0) {
+ if (schedule && (await this.isTrainFull(schedule))) {
await this.setWindow(booking.trainScheduleId, "FULL");
}
void this.triggerWagonAllocation(booking.trainScheduleId!);
@@ -1839,8 +2050,9 @@ export class BookingBatchService implements OnModuleInit {
"PREPAID",
);
await this.notifier.payNow(booking, deadline);
+ const reservedWagons = this.wagonsFor(booking, await this.loadWagonDims());
this.logger.log(
- `[BATCH] RESERVED ${booking.reference} (${this.wagonsFor(booking)}w, ` +
+ `[BATCH] RESERVED ${booking.reference} (${reservedWagons}w, ` +
`priority ${booking.priorityScore ?? 0}) on schedule ${scheduleId} — ` +
`pay by ${deadline.toISOString()}`,
);
@@ -2157,12 +2369,23 @@ export class BookingBatchService implements OnModuleInit {
const containers = (b: Booking): number =>
(b.bookingContainers ?? []).reduce((sum, c) => sum + Number(c.quantity ?? 0), 0);
const totalContainers = containers(primary) + containers(partner);
- const sharedWagons =
- totalContainers > 0
- ? Math.ceil(totalContainers / MAX_TEU_SLOTS_PER_WAGON)
- : this.wagonsFor(primary) + this.wagonsFor(partner);
const cargoTons =
Number(primary.cargoTotalWeightVgm ?? 0) + Number(partner.cargoTotalWeightVgm ?? 0);
+
+ // Consolidation shares TEU slots, never rated payload: the pair still needs
+ // enough wagons to carry its combined cargo, so the weight axis bounds the
+ // shared count exactly as it bounds an individual booking's. A pair shares
+ // wagons, so the primary's wagon type stands for both partners.
+ const dims = this.dimsFor(primary, wagonDims);
+ const capacityTons = dims.capacityTons;
+ const byWeight =
+ cargoTons > 0 && capacityTons > 0 ? Math.ceil(cargoTons / capacityTons) : 0;
+ const byLength =
+ totalContainers > 0
+ ? Math.ceil(totalContainers / MAX_TEU_SLOTS_PER_WAGON)
+ : this.wagonsFor(primary, wagonDims) + this.wagonsFor(partner, wagonDims);
+ const sharedWagons = Math.max(byLength, byWeight);
+
return {
wagons: sharedWagons,
// Consolidation saves tare as well as slots: the pair rides `sharedWagons`
@@ -2170,43 +2393,95 @@ export class BookingBatchService implements OnModuleInit {
weightTons: bookingGrossWeightTons(
cargoTons,
sharedWagons,
- this.tareFor(primary.freightType, wagonDims),
- ),
- lengthMeters: bookingTrainLengthMeters(
- primary.freightType,
- sharedWagons,
- this.lengthsOf(wagonDims),
+ dims.tareWeightTons,
),
+ lengthMeters: sharedWagons * dims.lengthMeters,
};
}
- /** Per-wagon tare for the wagon type this freight rides on. */
- private tareFor(freightType: string | null | undefined, wagonDims: WagonDims): number {
- return freightType === 'BULK'
- ? wagonDims.bulk.tareWeightTons
- : wagonDims.container.tareWeightTons;
- }
-
- private lengthsOf(wagonDims: WagonDims): { container: number; bulk: number } {
- return {
- container: wagonDims.container.lengthMeters,
- bulk: wagonDims.bulk.lengthMeters,
- };
- }
-
- private wagonsFor(booking: Booking): number {
- if (booking.wagonsRequired && booking.wagonsRequired > 0) {
- return Math.ceil(booking.wagonsRequired);
+ /**
+ * Stamp real priority scores on the pool's BULK bookings before the batch
+ * ranks it. Submit-time scoring runs with totalWagons = 0 for bulk (a bulk
+ * booking has no container lines to carry a wagon count), so every
+ * wagon-range priority config missed and bulk import bookings entered the
+ * batch at score 0 — they were never prioritized. Their wagon footprint is
+ * derivable from tonnage vs. live wagon capacity (wagonsFor), so the score
+ * is computed here — when doc review closes and the batch runs — and
+ * persisted so the priority board shows the same ranking. The pool arrives
+ * SQL-ordered by the old scores; the caller must re-sort after this.
+ */
+ private async recomputeBulkPriorities(
+ pool: Booking[],
+ wagonDims: WagonDims,
+ ): Promise {
+ for (const booking of pool) {
+ if (booking.freightType !== 'BULK') continue;
+ try {
+ const wagons = this.wagonsFor(booking, wagonDims);
+ const score = await this.pricingService.computeSubmitPriorityScore(
+ booking,
+ wagons,
+ );
+ if (Number(booking.priorityScore ?? 0) === score) continue;
+ await this.dataSource
+ .getRepository(Booking)
+ .update(booking.id, { priorityScore: score });
+ booking.priorityScore = score;
+ } catch (err) {
+ // A failed recompute keeps the stored score — never blocks the batch.
+ this.logger.warn(
+ `Bulk priority recompute failed for ${booking.reference ?? booking.id}: ` +
+ `${(err as Error).message}`,
+ );
+ }
}
- // booking.wagonsRequired is NULL for most rows (only set on certain
- // scheduling paths). Derive from the container lines, TEU-aware: two 20ft
- // share one wagon (wagonsPerUnit = 0.5). The old fallback summed raw
- // container QUANTITY, so 20×20ft counted as 20 wagons instead of 10 and
- // wrongly filled the train.
- const fromContainers = containerWagonsForLines(
- booking.bookingContainers ?? [],
+ }
+
+ /** Restore the batch pool ordering (mirrors findBatchPool's ORDER BY) after scores changed. */
+ private resortPoolByPriority(pool: Booking[]): void {
+ pool.sort(
+ (a, b) =>
+ Number(b.isGovernment) - Number(a.isGovernment) ||
+ Number(b.priorityScore ?? 0) - Number(a.priorityScore ?? 0) ||
+ (a.fullyExecutedAt?.getTime() ?? Infinity) -
+ (b.fullyExecutedAt?.getTime() ?? Infinity) ||
+ a.createdAt.getTime() - b.createdAt.getTime(),
);
- return Math.max(DEFAULT_WAGONS_PER_BOOKING, fromContainers);
+ }
+
+ /**
+ * Wagons a booking occupies. Two axes bind independently and the booking needs
+ * enough wagons to satisfy BOTH, so the count is the larger of:
+ *
+ * weight — ceil(cargoTons / wagonType.capacityTons), the rated payload
+ * length — TEU geometry, two 20ft to a wagon (container bookings only)
+ *
+ * The weight axis was missing entirely. A BULK booking carries no container
+ * lines, so `containerWagonsForLines` returned 0 and every bulk booking
+ * collapsed to a single wagon no matter its tonnage — a 2590T fertilizer
+ * booking counted as 1 wagon, and `needFor` then charged 1 tare instead of 37.
+ * That under-reported the board and let the fill loop overbook the train.
+ */
+ private wagonsFor(booking: Booking, wagonDims: WagonDims): number {
+ // Stored wagonsRequired is a candidate, never an early return: rows written
+ // while sumWagonsRequired hardcoded BULK to 1 wagon are still in the DB, and
+ // trusting them charged one tare for a whole bulk consist (a 700T booking on
+ // 70T wagons read 700 + 1 tare instead of 700 + 10 tares).
+ const stored =
+ booking.wagonsRequired && booking.wagonsRequired > 0
+ ? Math.ceil(booking.wagonsRequired)
+ : 0;
+
+ // TEU-aware: two 20ft share one wagon (wagonsPerUnit = 0.5). The old fallback
+ // summed raw container QUANTITY, so 20×20ft counted as 20 wagons, not 10.
+ const byLength = containerWagonsForLines(booking.bookingContainers ?? []);
+
+ const capacityTons = this.dimsFor(booking, wagonDims).capacityTons;
+ const cargoTons = Number(booking.cargoTotalWeightVgm ?? 0);
+ const byWeight =
+ cargoTons > 0 && capacityTons > 0 ? Math.ceil(cargoTons / capacityTons) : 0;
+
+ return Math.max(DEFAULT_WAGONS_PER_BOOKING, stored, byLength, byWeight);
}
/**
@@ -2218,19 +2493,16 @@ export class BookingBatchService implements OnModuleInit {
* 37-wagon box-wagon train read 2590T when it really weighed 3522T.
*/
private needFor(booking: Booking, wagonDims: WagonDims): Capacity {
- const wagons = this.wagonsFor(booking);
+ const wagons = this.wagonsFor(booking, wagonDims);
+ const dims = this.dimsFor(booking, wagonDims);
return {
wagons,
weightTons: bookingGrossWeightTons(
Number(booking.cargoTotalWeightVgm ?? 0),
wagons,
- this.tareFor(booking.freightType, wagonDims),
- ),
- lengthMeters: bookingTrainLengthMeters(
- booking.freightType,
- wagons,
- this.lengthsOf(wagonDims),
+ dims.tareWeightTons,
),
+ lengthMeters: wagons * dims.lengthMeters,
};
}
@@ -2243,14 +2515,16 @@ export class BookingBatchService implements OnModuleInit {
}
/**
- * Hard caps for a schedule's train: gross pull weight, train length, and the
+ * Caps for a schedule's train: gross pull weight, train length, and the
* length-derived wagon slot count (never a fixed 53). Bookings spend against
- * these via {@link needFor}, whose weight axis is gross.
+ * `base` via {@link needFor}, whose weight axis is gross. The locomotive's
+ * overage tolerance is returned separately — the corridor budget spends it
+ * only to admit a booking whole, never to size a split.
*/
private async capacityLimits(
locomotive: Locomotive,
rules: TrainSchedulingGlobalRules | null,
- ): Promise {
+ ): Promise {
const wagonTypes = await this.loadWagonTypeDimensions();
const derived = deriveTrainCapacityFromLocomotive(
{
@@ -2270,9 +2544,15 @@ export class BookingBatchService implements OnModuleInit {
},
);
return {
- wagons: derived.maxWagonSlots,
- weightTons: derived.maxWeightTons,
- lengthMeters: derived.maxLengthMeters,
+ base: {
+ wagons: derived.maxWagonSlots,
+ weightTons: derived.baseWeightTons,
+ lengthMeters: derived.baseLengthMeters,
+ },
+ tolerance: {
+ weightTons: derived.toleranceTons,
+ lengthMeters: derived.toleranceMeters,
+ },
};
}
@@ -2283,11 +2563,11 @@ export class BookingBatchService implements OnModuleInit {
rules: TrainSchedulingGlobalRules | null,
): Promise {
const limits = await this.capacityLimits(locomotive, rules);
- if ((schedule.maxWagons ?? 0) !== limits.wagons) {
+ if ((schedule.maxWagons ?? 0) !== limits.base.wagons) {
await this.dataSource
.getRepository(TrainSchedule)
- .update(schedule.id, { maxWagons: limits.wagons });
- schedule.maxWagons = limits.wagons;
+ .update(schedule.id, { maxWagons: limits.base.wagons });
+ schedule.maxWagons = limits.base.wagons;
}
}
@@ -2314,25 +2594,64 @@ export class BookingBatchService implements OnModuleInit {
];
}
- /** Representative wagon per freight type: NW5 flat for containers, CW3 gondola for bulk. */
+ /**
+ * Every wagon type keyed by id (drives per-booking dims via the cargo/container
+ * type's wagon_type_id FK), plus representative fallbacks per freight type
+ * (NW5 flat for containers, CW3 gondola for bulk) for bookings whose type has
+ * no wagon type configured yet.
+ */
private async loadWagonDims(): Promise {
- const types = await this.dataSource.getRepository(WagonType).find({
- where: [{ code: "NW5" }, { code: "CW3" }],
- });
+ const types = await this.dataSource.getRepository(WagonType).find();
const byCode = new Map(
types.map((t) => [t.code, wagonTypeDimensionsFromEntity(t)]),
);
+ const byWagonTypeId = new Map(
+ types.map((t) => [t.id, wagonTypeDimensionsFromEntity(t)]),
+ );
const nw5 = byCode.get("NW5");
const cw3 = byCode.get("CW3");
+ // capacityTons divides a bulk booking's cargo, so a 0 or missing rated payload
+ // must fall back rather than yield an infinite wagon count.
+ const payload = (value: number | undefined, fallback: number): number =>
+ value && value > 0 ? value : fallback;
return {
container: {
lengthMeters: nw5?.lengthMeters ?? DEFAULT_CONTAINER_WAGON_LENGTH_METERS,
tareWeightTons: nw5?.tareWeightTons ?? DEFAULT_CONTAINER_WAGON_TARE_TONS,
+ capacityTons: payload(nw5?.capacityTons, DEFAULT_CONTAINER_WAGON_CAPACITY_TONS),
},
bulk: {
lengthMeters: cw3?.lengthMeters ?? DEFAULT_BULK_WAGON_LENGTH_METERS,
tareWeightTons: cw3?.tareWeightTons ?? DEFAULT_BULK_WAGON_TARE_TONS,
+ capacityTons: payload(cw3?.capacityTons, DEFAULT_BULK_WAGON_CAPACITY_TONS),
},
+ byWagonTypeId,
+ };
+ }
+
+ /**
+ * Dimensions of the wagon type THIS booking rides: bulk resolves through its
+ * cargo type's wagon_type_id, container through the first container line's
+ * type — the same FK resolution `resolveWagonType` applies when the paid
+ * booking is allocated. Board/fill math measured on a representative wagon
+ * while allocation validated the real one let a selected batch flunk the
+ * post-payment gross-weight check; sharing the resolution closes that gap.
+ * Falls back to the representative dims when the FK or relation is absent.
+ */
+ private dimsFor(booking: Booking, wagonDims: WagonDims): PerWagonDims {
+ const fallback =
+ booking.freightType === "BULK" ? wagonDims.bulk : wagonDims.container;
+ const wagonTypeId =
+ booking.freightType === "BULK"
+ ? booking.cargoType?.wagonTypeId
+ : (booking.bookingContainers ?? [])
+ .map((line) => line.containerType?.wagonTypeId)
+ .find((id): id is string => Boolean(id));
+ const dims = wagonTypeId ? wagonDims.byWagonTypeId.get(wagonTypeId) : undefined;
+ if (!dims) return fallback;
+ return {
+ ...dims,
+ capacityTons: dims.capacityTons > 0 ? dims.capacityTons : fallback.capacityTons,
};
}
@@ -2368,11 +2687,11 @@ export class BookingBatchService implements OnModuleInit {
*/
private async remainingBudget(
schedule: TrainSchedule,
- limits: Capacity,
+ limits: TrainLimits,
wagonDims: WagonDims,
): Promise {
const stops = await this.stopsForSchedule(schedule);
- const budget = new CorridorBudget(stops, limits);
+ const budget = new CorridorBudget(stops, limits.base, limits.tolerance);
const allocated = (schedule.scheduleBookings ?? [])
.map((sb) => sb.booking)
.filter((b): b is Booking => Boolean(b));
@@ -2390,16 +2709,21 @@ export class BookingBatchService implements OnModuleInit {
/**
* Wagon slots still boardable somewhere on the corridor (most-open edge).
- * ≤ 0 means no leg can take another booking — the train-wide FULL signal.
+ * ≤ 0 means no leg can take another booking. Slot axis ONLY — the train-wide
+ * FULL signal is {@link isTrainFull}, which also closes weight/length-bound
+ * trains that still show free slots.
*/
private async remainingWagons(schedule: TrainSchedule): Promise {
const wagonDims = await this.loadWagonDims();
const budget = await this.remainingBudget(
schedule,
{
- wagons: schedule.maxWagons ?? 0,
- weightTons: Number.POSITIVE_INFINITY,
- lengthMeters: Number.POSITIVE_INFINITY,
+ base: {
+ wagons: schedule.maxWagons ?? 0,
+ weightTons: Number.POSITIVE_INFINITY,
+ lengthMeters: Number.POSITIVE_INFINITY,
+ },
+ tolerance: { weightTons: 0, lengthMeters: 0 },
},
wagonDims,
);
@@ -2426,12 +2750,78 @@ export class BookingBatchService implements OnModuleInit {
}
}
- /** No wagon slots left for allocated + reserved bookings. */
+ /**
+ * A reservation on this schedule still has time left to pay.
+ *
+ * The PAYMENT phase ends a hair BEFORE its own reservations do: `paymentPhaseEndsAt`
+ * is stamped when the phase starts, then `reserve()` gives each booking
+ * `now + paymentWindow` a few hundred milliseconds later, one booking at a time. So
+ * the first settle after the phase deadline finds every reservation still in date,
+ * expires nothing, reports `anySettled = false`, runs no top-up — and the caller
+ * concludes the cycle out from under customers who still had time to pay. The next
+ * tick then expires them with no cycle left to promote the waiting list into.
+ *
+ * Callers must not conclude the cycle while this returns true.
+ */
+ async hasLiveReservations(scheduleId: string): Promise {
+ const reserved =
+ await this.bookingsRepository.findReservedForSchedule(scheduleId);
+ const now = Date.now();
+ return reserved.some(
+ (b) =>
+ b.paymentStatus !== "PAID" &&
+ b.status !== "PAID" &&
+ b.paymentDeadline != null &&
+ b.paymentDeadline.getTime() > now,
+ );
+ }
+
+ /**
+ * FULL on ANY capacity axis: out of wagon slots, or out of pull weight /
+ * train length for even one more loaded wagon. The old slot-only check let
+ * a weight-bound train (PW2: weight binds at 37 wagons = 3522.4T of
+ * 3500+90T, slots bind at 44) cycle its booking window forever instead of
+ * finalizing — 7 phantom slots kept it "not full" while nothing could board.
+ */
async isScheduleFull(scheduleId: string): Promise {
const schedule =
await this.trainSchedulesRepository.findByIdWithFullGraph(scheduleId);
if (!schedule) return false;
- return (await this.remainingWagons(schedule)) <= 0;
+ return this.isTrainFull(schedule);
+ }
+
+ /** See {@link isScheduleFull} — same check for callers that already hold the full graph. */
+ private async isTrainFull(schedule: TrainSchedule): Promise {
+ if ((await this.remainingWagons(schedule)) <= 0) return true;
+ const locomotive = schedule.trainSet?.locomotive;
+ if (!locomotive) return false; // no weight/length limits to bind against
+ const rules = await this.loadGlobalRules();
+ const wagonDims = await this.loadWagonDims();
+ const limits = await this.capacityLimits(locomotive, rules);
+ const budget = await this.remainingBudget(schedule, limits, wagonDims);
+ return budget.isExhausted(this.minPerWagonNeed(wagonDims));
+ }
+
+ /**
+ * Smallest gross weight / shortest length one more wagon could add: the
+ * lightest wagon type at its rated payload. Feeds CorridorBudget.isExhausted,
+ * so FULL is only declared when not even this wagon fits anywhere.
+ */
+ private minPerWagonNeed(wagonDims: WagonDims): {
+ grossWeightTons: number;
+ lengthMeters: number;
+ } {
+ const all = [
+ wagonDims.container,
+ wagonDims.bulk,
+ ...wagonDims.byWagonTypeId.values(),
+ ];
+ return {
+ grossWeightTons: Math.min(
+ ...all.map((d) => d.tareWeightTons + d.capacityTons),
+ ),
+ lengthMeters: Math.min(...all.map((d) => d.lengthMeters)),
+ };
}
/**
@@ -2452,7 +2842,10 @@ export class BookingBatchService implements OnModuleInit {
const schedule =
await this.trainSchedulesRepository.findByIdWithFullGraph(scheduleId);
if (!schedule || schedule.bookingWindowStatus !== "FULL") return;
- if ((await this.remainingWagons(schedule)) <= 0) return;
+ // Symmetric with isScheduleFull: a weight/length-bound FULL is not stale
+ // just because slots remain — clearing it here would reopen a train
+ // nothing can board.
+ if (await this.isTrainFull(schedule)) return;
const customerWindowOpen =
schedule.windowPhase == null || schedule.windowPhase === "OPEN";
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-journey.service.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-journey.service.ts
index cdc58083c..2df741bd3 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-journey.service.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-journey.service.ts
@@ -28,6 +28,9 @@ import { TrainCheckpointEvent } from './entities/train-checkpoint-event.entity';
* unload at its destination yard (IN_TRANSIT → ARRIVED for import/export,
* → COMPLETED for intercity), possibly long before the train's final arrival.
* Both are gated on the train's latest recorded checkpoint being at that yard.
+ * Unload also fires automatically: recording a checkpoint at a yard auto-
+ * unloads every booking destined there (autoUnloadAtYard), so the manual
+ * unload endpoint remains only a fallback.
*
* Unloading also settles the physical wagons: each wagon that alights with the
* booking is released at that yard and the move is written to the
@@ -198,6 +201,47 @@ export class BookingJourneyService {
};
}
+ /**
+ * Auto-unload on checkpoint: every IN_TRANSIT booking on this schedule whose
+ * destination is the yard the train just reached alights automatically, so
+ * the customer's booking flips to ARRIVED (COMPLETED for intercity) the
+ * moment the train is recorded at their yard — no separate operator unload.
+ * Runs through the same per-booking unload path (wagon settle + ledger +
+ * milestones); one booking's failure is logged and never blocks the
+ * checkpoint or the other bookings. Returns the unloaded booking ids.
+ */
+ async autoUnloadAtYard(
+ scheduleId: string,
+ yardId: string,
+ userId?: string | null,
+ ): Promise {
+ const bookings = await this.dataSource
+ .getRepository(Booking)
+ .createQueryBuilder('booking')
+ .innerJoin(
+ 'freight.train_schedule_bookings',
+ 'tsb',
+ 'tsb.booking_id = booking.id AND tsb.train_schedule_id = :scheduleId AND tsb.deleted_at IS NULL',
+ { scheduleId },
+ )
+ .where('booking.destination_yard_id = :yardId', { yardId })
+ .andWhere(`booking.status = 'IN_TRANSIT'`)
+ .getMany();
+
+ const unloaded: string[] = [];
+ for (const booking of bookings) {
+ try {
+ await this.unloadBooking(scheduleId, booking.id, userId);
+ unloaded.push(booking.id);
+ } catch (err) {
+ this.logger.warn(
+ `Auto-unload failed for booking ${booking.id} at yard ${yardId}: ${(err as Error).message}`,
+ );
+ }
+ }
+ return unloaded;
+ }
+
/**
* Bulk fallback at the train's FINAL arrival: any booking destined for the
* final yard that operators didn't unload individually gets its per-booking
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-split.service.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-split.service.ts
index 44886f116..ad0967cf0 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-split.service.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-split.service.ts
@@ -36,6 +36,9 @@ export interface SizedOffer {
* rows, so reducing the lines releases it automatically) and can be rebooked in
* any later window within contract validity. A ONE_TIME contract is promoted to
* GENERAL on split (see applySplit) so its remainder is actually rebookable.
+ * Once the remainder is rebooked and the cap hits zero, ContractBookingService
+ * completes the contract (CONTRACT_CLOSED): no further bookings or shipment
+ * requests, even while validity and a booking window are still open.
*/
@Injectable()
export class BookingSplitService {
@@ -55,12 +58,17 @@ export class BookingSplitService {
* Size the largest part of the booking that fits `freeWagons`, priced via an
* in-memory clone. Returns null when nothing meaningful fits (no whole
* container unit / no bulk tonnage, or pricing failed).
+ *
+ * `maxOfferedWeightTons` caps the offered CARGO tonnage (bulk only) — on a
+ * weight-limited train the wagons' own tare eats into the locomotive's
+ * remaining pull weight, so the caller passes the room left after tare.
*/
async sizeOffer(
booking: Booking,
freeWagons: number,
totalWagons: number,
bulkWagonCapacityTons: number,
+ maxOfferedWeightTons?: number,
): Promise {
if (freeWagons < 1 || freeWagons >= totalWagons) return null;
@@ -110,10 +118,15 @@ export class BookingSplitService {
if (!offeredLines.length || offeredWagons <= 0) return null;
clone.bookingContainers = clonedContainers;
} else {
- // Bulk: split by weight — the offered part is what freeWagons can carry.
+ // Bulk: split by weight — the offered part is what freeWagons can carry,
+ // further capped by the caller's weight room when the pull limit binds.
const totalWeight = Number(booking.cargoTotalWeightVgm ?? 0);
if (totalWeight <= 0 || bulkWagonCapacityTons <= 0) return null;
- offeredWeightTons = Math.min(totalWeight, freeWagons * bulkWagonCapacityTons);
+ offeredWeightTons = Math.min(
+ totalWeight,
+ freeWagons * bulkWagonCapacityTons,
+ maxOfferedWeightTons ?? Number.POSITIVE_INFINITY,
+ );
if (offeredWeightTons <= 0) return null;
offeredWagons = Math.min(
freeWagons,
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.spec.ts
index f96c388f8..3286da0eb 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.spec.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.spec.ts
@@ -17,6 +17,8 @@ describe('BookingWindowService — window state machine', () => {
expireUnacceptedForRouteDay: jest.Mock;
settleDueReservations: jest.Mock;
isScheduleFull: jest.Mock;
+ hasLiveReservations: jest.Mock;
+ refreshWindowStatus: jest.Mock;
};
let trainSchedulesRepository: { findById: jest.Mock; findAll: jest.Mock };
let trainSchedulingService: { finalizeSchedule: jest.Mock; getWindowConfig: jest.Mock };
@@ -68,6 +70,9 @@ describe('BookingWindowService — window state machine', () => {
expireUnacceptedForRouteDay: jest.fn().mockResolvedValue(undefined),
settleDueReservations: jest.fn().mockResolvedValue(undefined),
isScheduleFull: jest.fn().mockResolvedValue(false),
+ // No reservation is mid-pay-window by default, so the cycle concludes.
+ hasLiveReservations: jest.fn().mockResolvedValue(false),
+ refreshWindowStatus: jest.fn().mockResolvedValue(undefined),
};
trainSchedulesRepository = {
findById: jest.fn().mockResolvedValue(null),
@@ -154,6 +159,26 @@ describe('BookingWindowService — window state machine', () => {
expect(batch.settleDueReservations).toHaveBeenCalledWith(scheduleId);
});
+ it('PAYMENT holds the cycle open while a reservation is still inside its pay window', async () => {
+ // `paymentPhaseEndsAt` is stamped when the phase starts; reserve() then sets each
+ // booking's own deadline milliseconds later. So the phase deadline always passes
+ // first, and concluding here would kill customers who still had time to pay — and
+ // leave no cycle for the waiting-list top-up to run in.
+ batch.hasLiveReservations.mockResolvedValue(true);
+ const s = baseSchedule({
+ windowPhase: 'PAYMENT',
+ paymentPhaseEndsAt: new Date('2026-07-01T02:30:00.000Z'),
+ });
+
+ const advanced = await advanceImport(s, new Date('2026-07-01T02:30:01.000Z'));
+
+ expect(advanced).toBe(true);
+ expect(batch.settleDueReservations).toHaveBeenCalledWith(scheduleId);
+ // Still PAYMENT — the cycle was NOT concluded and the window did not reopen.
+ expect(s.windowPhase).toBe('PAYMENT');
+ expect(batch.isScheduleFull).not.toHaveBeenCalled();
+ });
+
it('conclude: train FULL → window FULL + phase DONE + auto-finalize', async () => {
batch.isScheduleFull.mockResolvedValue(true);
const s = baseSchedule({ windowPhase: 'PAYMENT' });
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.ts b/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.ts
index f1978b762..a730b6aa6 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/booking-window.service.ts
@@ -304,6 +304,38 @@ export class BookingWindowService implements OnModuleInit {
`(allocate paid / expire unpaid) then concluding the cycle`,
);
await this.bookingBatchService.settleDueReservations(schedule.id);
+
+ // The settle expires unpaid reservations and promotes the waiting list into
+ // the wagons they free. Those promoted customers get a fresh pay window, and
+ // `extendPaymentPhaseForTopUp` pushes `paymentPhaseEndsAt` past `now` to
+ // cover it. Concluding here on the STALE in-memory timestamp would end the
+ // cycle the top-up just extended and expire them before they could pay — so
+ // re-read, and stay in PAYMENT if the deadline moved.
+ const settled = await this.trainSchedulesRepository.findById(schedule.id);
+ if (settled?.paymentPhaseEndsAt && now < settled.paymentPhaseEndsAt) {
+ schedule.paymentPhaseEndsAt = settled.paymentPhaseEndsAt;
+ this.logger.log(
+ `[WINDOW] ${schedule.id} PAYMENT extended to ` +
+ `${settled.paymentPhaseEndsAt.toISOString()} — waiting-list bookings were ` +
+ `promoted into the freed wagons; not concluding this cycle yet`,
+ );
+ return true;
+ }
+
+ // `paymentPhaseEndsAt` is stamped when the phase starts; each reservation's own
+ // deadline is set milliseconds later, per booking, so the phase always expires
+ // a fraction before the reservations it opened. Concluding here would end the
+ // cycle while customers still had time to pay, and the settle that finally
+ // expires them (next tick) would have no cycle left to promote the waiting
+ // list into. Hold in PAYMENT until every reservation has actually resolved.
+ if (await this.bookingBatchService.hasLiveReservations(schedule.id)) {
+ this.logger.log(
+ `[WINDOW] ${schedule.id} PAYMENT phase past its deadline but reservations ` +
+ `are still within their pay windows — holding the cycle open`,
+ );
+ return true;
+ }
+
await this.concludeCycle(schedule, cfg, now);
return true;
}
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.spec.ts
new file mode 100644
index 000000000..15d065d09
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.spec.ts
@@ -0,0 +1,120 @@
+import { Capacity, CorridorBudget } from './corridor-capacity.util';
+import { sizePartialOfferWagons } from './train-capacity.util';
+
+describe('corridor-capacity.util — overage tolerance', () => {
+ const pw2 = { lengthMeters: 17.066, capacityTons: 70, tareWeightTons: 25.2 };
+ const stops = ['yard-a', 'yard-b'];
+ const base: Capacity = { wagons: 44, weightTons: 3500, lengthMeters: 760 };
+ const tolerance = { weightTons: 90, lengthMeters: 0 };
+
+ const need = (weightTons: number, wagons = 1, lengthMeters = 17): Capacity => ({
+ wagons,
+ weightTons,
+ lengthMeters,
+ });
+
+ const budgetAt = (usedWeightTons: number): CorridorBudget => {
+ const budget = new CorridorBudget(stops, base, tolerance);
+ budget.subtract(need(usedWeightTons, 10, 170), budget.fullLeg());
+ return budget;
+ };
+
+ it('admits a whole booking that overflows the base cap by less than the tolerance', () => {
+ // 3500T train, 90T tolerance, 3560T committed: a 25T booking still boards
+ // entire (3585 ≤ 3590).
+ const budget = budgetAt(3560);
+ expect(budget.fits(need(25), budget.fullLeg())).toBe(true);
+ });
+
+ it('rejects a whole booking that overflows past the tolerance — no partial admission', () => {
+ // Same train at 3560T: a 210T booking would need 3770 > 3590 — skipped.
+ const budget = budgetAt(3560);
+ expect(budget.fits(need(210), budget.fullLeg())).toBe(false);
+ });
+
+ it('caps stacked overage admissions at base + tolerance', () => {
+ // Small units may keep boarding inside the overage zone, but never past it.
+ const budget = budgetAt(3560);
+ budget.subtract(need(25), budget.fullLeg()); // now 3585 committed
+ expect(budget.fits(need(5), budget.fullLeg())).toBe(true); // 3590 exactly
+ expect(budget.fits(need(6), budget.fullLeg())).toBe(false); // 3591 > 3590
+ });
+
+ it('excludes the tolerance from remainingFor, so split room never reaches into it', () => {
+ const budget = budgetAt(3400);
+ expect(budget.remainingFor(budget.fullLeg()).weightTons).toBe(100);
+ // Once a whole-unit admission spends the tolerance, base room goes negative.
+ const over = budgetAt(3560);
+ expect(over.remainingFor(over.fullLeg()).weightTons).toBe(-60);
+ });
+
+ it('yields no split offer once the base cap is spent — tolerance is whole-bookings-only', () => {
+ // The batch engine sizes splits from remainingFor; at/over base capacity
+ // that room cannot carry even one part-loaded wagon, so no offer opens.
+ const over = budgetAt(3560);
+ const room = over.remainingFor(over.fullLeg());
+ expect(sizePartialOfferWagons(room, 15, pw2)).toBeNull();
+ });
+
+ it('still offers a split while committed weight is under the base cap', () => {
+ // 744T of base room left: the boundary booking is offered the part that
+ // fits up to 3500, not up to 3590.
+ const budget = budgetAt(2756);
+ const room = budget.remainingFor(budget.fullLeg());
+ expect(sizePartialOfferWagons(room, 15, pw2)).toEqual({
+ wagons: 8,
+ maxCargoTons: 542.4,
+ });
+ });
+
+ it('leaves fits() strict when no tolerance is configured', () => {
+ const strict = new CorridorBudget(stops, base);
+ strict.subtract(need(3500, 10, 170), strict.fullLeg());
+ expect(strict.fits(need(1), strict.fullLeg())).toBe(false);
+ });
+
+ describe('isExhausted — train-wide FULL across all axes', () => {
+ // Lightest wagon at rated payload: PW2 25.2T tare + 70T = 95.2T gross.
+ const perWagon = {
+ grossWeightTons: pw2.tareWeightTons + pw2.capacityTons,
+ lengthMeters: pw2.lengthMeters,
+ };
+
+ it('reports FULL when weight binds first, with wagon slots still free', () => {
+ // 37 loaded PW2 wagons = 3522.4T of 3500+90T. 7 length-derived slots
+ // remain, but wagon 38 would need 95.2T against 67.6T of room — the
+ // schedule must finalize and its window must disappear.
+ const budget = new CorridorBudget(stops, base, tolerance);
+ budget.subtract(need(3522.4, 37, 631.442), budget.fullLeg());
+ expect(budget.maxRemaining().wagons).toBeGreaterThan(0); // slot check alone says "not full"
+ expect(budget.isExhausted(perWagon)).toBe(true);
+ });
+
+ it('is not FULL while one more loaded wagon still fits within base + tolerance', () => {
+ const budget = budgetAt(3300); // 200T base room + 90T tolerance ≥ 95.2T
+ expect(budget.isExhausted(perWagon)).toBe(false);
+ });
+
+ it('reports FULL when wagon slots run out regardless of weight room', () => {
+ const budget = new CorridorBudget(stops, base, tolerance);
+ budget.subtract(need(1000, 44, 700), budget.fullLeg());
+ expect(budget.isExhausted(perWagon)).toBe(true);
+ });
+
+ it('reports FULL when length room cannot take one more wagon', () => {
+ const budget = new CorridorBudget(stops, base, tolerance);
+ budget.subtract(need(1000, 30, 750), budget.fullLeg()); // 10m left < 17.066m
+ expect(budget.isExhausted(perWagon)).toBe(true);
+ });
+
+ it('only counts an edge as open when EVERY axis has room on that same edge', () => {
+ // Three stops → two edges. Edge 0 has weight but no slots; edge 1 has
+ // slots but no weight. Neither can board a wagon, so the train is FULL
+ // even though the per-axis maxima both look open.
+ const budget = new CorridorBudget(['a', 'b', 'c'], base, tolerance);
+ budget.subtract(need(0, 44, 0), { fromEdge: 0, toEdge: 1 });
+ budget.subtract(need(3522.4, 0, 0), { fromEdge: 1, toEdge: 2 });
+ expect(budget.isExhausted(perWagon)).toBe(true);
+ });
+ });
+});
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.ts b/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.ts
index b16b25179..f2602a157 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/corridor-capacity.util.ts
@@ -63,18 +63,40 @@ export function stopYardsFor(
return [originStationId, destinationStationId];
}
-/** Per-edge capacity budget along a schedule's stop list. */
+/** Overage a locomotive may absorb beyond its base caps. */
+export interface OverageTolerance {
+ weightTons: number;
+ lengthMeters: number;
+}
+
+/**
+ * Per-edge capacity budget along a schedule's stop list.
+ *
+ * `initial` must be the BASE caps (locomotive floored by rule caps, WITHOUT the
+ * overage tolerance). The tolerance is passed separately and is spendable only
+ * by admitting a unit WHOLE via {@link fits} — e.g. base 3500T + 90T tolerance,
+ * 3560T already committed: a 25T booking still boards entire (3585 ≤ 3590), a
+ * 210T booking does not. {@link remainingFor} deliberately excludes the
+ * tolerance (and goes negative once it is consumed), so split/partial offers
+ * sized from it can only fill up to the base cap and never spend the tolerance.
+ */
export class CorridorBudget {
private readonly edges: Capacity[];
private readonly stopIndex: Map;
+ private readonly tolerance: OverageTolerance;
constructor(
readonly stops: string[],
initial: Capacity,
+ tolerance?: Partial | null,
) {
const edgeCount = Math.max(1, stops.length - 1);
this.edges = Array.from({ length: edgeCount }, () => ({ ...initial }));
this.stopIndex = new Map(stops.map((yardId, i) => [yardId, i]));
+ this.tolerance = {
+ weightTons: tolerance?.weightTons ?? 0,
+ lengthMeters: tolerance?.lengthMeters ?? 0,
+ };
}
/** The leg between two stops, or null when they aren't on this corridor in order. */
@@ -99,7 +121,12 @@ export class CorridorBudget {
return this.legOf(originYardId, destinationYardId) ?? this.fullLeg();
}
- /** Remaining capacity usable by this leg = min across its edges. */
+ /**
+ * Remaining BASE capacity usable by this leg = min across its edges. Excludes
+ * the overage tolerance and goes negative once a whole-unit admission has
+ * spent it — sizing a split from this can therefore never reach into the
+ * tolerance, and yields nothing at all once the base cap is exhausted.
+ */
remainingFor(leg: CorridorLeg): Capacity {
let min = { ...this.edges[leg.fromEdge] };
for (let i = leg.fromEdge + 1; i < leg.toEdge; i++) {
@@ -113,8 +140,20 @@ export class CorridorBudget {
return min;
}
+ /**
+ * Whether a unit fits WHOLE on this leg. This is the only place the overage
+ * tolerance may be spent: the unit boards entirely or not at all, so weight
+ * and length may dip into the tolerance. Admission keeps the invariant
+ * `remaining ≥ -tolerance` on every edge, i.e. the train never exceeds
+ * base + tolerance no matter how many small units board in the overage zone.
+ */
fits(need: Capacity, leg: CorridorLeg): boolean {
- return capacityFits(need, this.remainingFor(leg));
+ const remaining = this.remainingFor(leg);
+ return (
+ need.wagons <= remaining.wagons &&
+ need.weightTons <= remaining.weightTons + this.tolerance.weightTons &&
+ need.lengthMeters <= remaining.lengthMeters + this.tolerance.lengthMeters
+ );
}
subtract(need: Capacity, leg: CorridorLeg): void {
@@ -129,6 +168,25 @@ export class CorridorBudget {
}
}
+ /**
+ * Train-wide FULL across ALL capacity axes: true when no edge can board even
+ * one more loaded wagon. `perWagon` is the smallest gross weight and length
+ * a future wagon could add (lightest wagon type at rated payload); weight and
+ * length may dip into the overage tolerance, mirroring {@link fits}. Checked
+ * per edge — an edge with slots free but no pull weight is just as closed as
+ * one with no slots. A slot-only check misses weight-bound trains: PW2 at
+ * 37 × 95.2T = 3522.4T of 3500+90T has 7 length-derived slots free but no
+ * weight room for wagon 38, and its window must read FULL.
+ */
+ isExhausted(perWagon: { grossWeightTons: number; lengthMeters: number }): boolean {
+ return this.edges.every(
+ (e) =>
+ e.wagons <= 0 ||
+ e.weightTons + this.tolerance.weightTons < perWagon.grossWeightTons ||
+ e.lengthMeters + this.tolerance.lengthMeters < perWagon.lengthMeters,
+ );
+ }
+
/**
* The most open edge — when even this has no wagon slots left, nothing can
* board anywhere and the schedule's window is genuinely FULL. (A train can be
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/dto/assign-bookings.dto.ts b/apps/edr-freight-api/src/modules/train-scheduling/dto/assign-bookings.dto.ts
index b5e93f5da..1fd1e9a08 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/dto/assign-bookings.dto.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/dto/assign-bookings.dto.ts
@@ -51,7 +51,7 @@ export class AssignBookingsDto {
@IsUUID('4', { each: true })
bookingIds!: string[];
- @ApiPropertyOptional({ description: 'Bypass soft hold and overweight warnings' })
+ @ApiPropertyOptional({ description: 'Suppress soft hold and overweight warnings' })
@IsOptional()
@IsBoolean()
forceAssign?: boolean;
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/dto/batch-board-query.dto.ts b/apps/edr-freight-api/src/modules/train-scheduling/dto/batch-board-query.dto.ts
new file mode 100644
index 000000000..11bc8ceb5
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/train-scheduling/dto/batch-board-query.dto.ts
@@ -0,0 +1,99 @@
+import { ApiPropertyOptional } from '@nestjs/swagger';
+import { Type } from 'class-transformer';
+import {
+ IsIn,
+ IsInt,
+ IsISO8601,
+ IsOptional,
+ IsString,
+ Max,
+ MaxLength,
+ Min,
+} from 'class-validator';
+
+export const BATCH_BOARD_STATUSES = [
+ 'DRAFT',
+ 'SCHEDULED',
+ 'DISPATCHED',
+ 'ARRIVED',
+ 'CANCELLED',
+] as const;
+
+export const BATCH_BOARD_SORT_FIELDS = [
+ 'createdAt',
+ 'scheduledDepartureDate',
+ 'trainNumber',
+ 'status',
+] as const;
+export type BatchBoardSortField = (typeof BATCH_BOARD_SORT_FIELDS)[number];
+
+/** Filters for the batch monitoring board list (import schedules, all statuses). */
+export class BatchBoardQueryDto {
+ @ApiPropertyOptional({ default: 1, minimum: 1 })
+ @IsOptional()
+ @Type(() => Number)
+ @IsInt()
+ @Min(1)
+ page?: number;
+
+ @ApiPropertyOptional({ default: 12, minimum: 1, maximum: 100 })
+ @IsOptional()
+ @Type(() => Number)
+ @IsInt()
+ @Min(1)
+ @Max(100)
+ pageSize?: number;
+
+ @ApiPropertyOptional({
+ description:
+ 'Comma-separated schedule statuses (DRAFT,SCHEDULED,DISPATCHED,ARRIVED,CANCELLED). Omit for all.',
+ example: 'DISPATCHED,ARRIVED',
+ })
+ @IsOptional()
+ @IsString()
+ statuses?: string;
+
+ @ApiPropertyOptional({ enum: ['OPEN', 'FULL', 'CLOSED'] })
+ @IsOptional()
+ @IsIn(['OPEN', 'FULL', 'CLOSED'])
+ bookingWindowStatus?: 'OPEN' | 'FULL' | 'CLOSED';
+
+ @ApiPropertyOptional({
+ description:
+ 'Case-insensitive match on train number, route yards, stations, or locomotive code.',
+ })
+ @IsOptional()
+ @IsString()
+ @MaxLength(120)
+ search?: string;
+
+ @ApiPropertyOptional({ description: 'Departure date lower bound (ISO 8601).' })
+ @IsOptional()
+ @IsISO8601()
+ departureFrom?: string;
+
+ @ApiPropertyOptional({ description: 'Departure date upper bound (ISO 8601).' })
+ @IsOptional()
+ @IsISO8601()
+ departureTo?: string;
+
+ @ApiPropertyOptional({ description: 'Created-at lower bound (ISO 8601).' })
+ @IsOptional()
+ @IsISO8601()
+ createdFrom?: string;
+
+ @ApiPropertyOptional({ description: 'Created-at upper bound (ISO 8601).' })
+ @IsOptional()
+ @IsISO8601()
+ createdTo?: string;
+
+ @ApiPropertyOptional({ enum: BATCH_BOARD_SORT_FIELDS, default: 'createdAt' })
+ @IsOptional()
+ @IsIn(BATCH_BOARD_SORT_FIELDS as unknown as string[])
+ sortBy?: BatchBoardSortField;
+
+ @ApiPropertyOptional({ enum: ['ASC', 'DESC'], default: 'DESC' })
+ @IsOptional()
+ @IsIn(['ASC', 'DESC'])
+ sortOrder?: 'ASC' | 'DESC';
+}
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/gatepass-payment-gate.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/gatepass-payment-gate.spec.ts
new file mode 100644
index 000000000..912f437f4
--- /dev/null
+++ b/apps/edr-freight-api/src/modules/train-scheduling/gatepass-payment-gate.spec.ts
@@ -0,0 +1,118 @@
+import { TrainSchedulingService } from './train-scheduling.service';
+import { Booking } from '../bookings/entities/booking.entity';
+import { ClearanceMilestone } from '../contracts/entities/clearance-milestone.entity';
+
+type Row = Pick & {
+ metadata?: Record | null;
+ triggeredAt?: Date | null;
+};
+
+/**
+ * The gate pass is secured once per train schedule, but each booking only earns
+ * its GATEPASS_GRANTED milestone after settling freight payment. An unpaid
+ * booking must not ride a paid neighbour's grant — the train proceeds, that
+ * booking stays pending.
+ */
+function makeService(bookings: Array>, rows: Row[]) {
+ const milestoneRepo = {
+ find: jest.fn().mockResolvedValue(rows),
+ save: jest.fn((row: Row) => Promise.resolve(row)),
+ };
+ const bookingRepo = { find: jest.fn().mockResolvedValue(bookings) };
+ const dataSource = {
+ getRepository: (entity: unknown) =>
+ entity === Booking ? bookingRepo : milestoneRepo,
+ };
+
+ const service = Object.create(
+ TrainSchedulingService.prototype,
+ ) as TrainSchedulingService;
+ Object.assign(service, {
+ dataSource,
+ logger: { warn: jest.fn(), log: jest.fn() },
+ });
+ return { service, milestoneRepo };
+}
+
+/** Reach the private bridge write under test. */
+function grant(service: TrainSchedulingService, at: Date): Promise {
+ return (
+ service as unknown as {
+ completeGatepassMilestoneForSchedule(id: string, at: Date): Promise;
+ }
+ ).completeGatepassMilestoneForSchedule('sched-1', at);
+}
+
+const securedAt = new Date('2026-07-09T08:00:00.000Z');
+
+describe('gate pass is withheld from bookings that have not paid freight', () => {
+ it('grants the paid booking and leaves the unpaid one pending', async () => {
+ const rows: Row[] = [
+ { bookingId: 'paid', milestoneCode: 'FREIGHT_PAYMENT_SETTLED', status: 'COMPLETED' },
+ { bookingId: 'paid', milestoneCode: 'GATEPASS_GRANTED', status: 'PENDING' },
+ { bookingId: 'unpaid', milestoneCode: 'FREIGHT_PAYMENT_SETTLED', status: 'PENDING' },
+ { bookingId: 'unpaid', milestoneCode: 'GATEPASS_GRANTED', status: 'PENDING' },
+ ];
+ const { service, milestoneRepo } = makeService(
+ [
+ { id: 'paid', status: 'CONFIRMED', paymentStatus: 'PENDING' },
+ { id: 'unpaid', status: 'CONFIRMED', paymentStatus: 'PENDING' },
+ ],
+ rows,
+ );
+
+ await grant(service, securedAt);
+
+ const saved = milestoneRepo.save.mock.calls.map(([r]: [Row]) => r);
+ expect(saved).toHaveLength(1);
+ expect(saved[0]!.bookingId).toBe('paid');
+ expect(saved[0]!.status).toBe('COMPLETED');
+ expect(saved[0]!.triggeredAt).toBe(securedAt);
+
+ const unpaid = rows.find(
+ (r) => r.bookingId === 'unpaid' && r.milestoneCode === 'GATEPASS_GRANTED',
+ );
+ expect(unpaid!.status).toBe('PENDING');
+ });
+
+ it('treats a booking paid outside the milestone path as paid', async () => {
+ // Some payment paths settle the invoice without writing the milestone; the
+ // clearance views self-heal it on read, so the gate pass must not lag.
+ const rows: Row[] = [
+ { bookingId: 'b-1', milestoneCode: 'FREIGHT_PAYMENT_SETTLED', status: 'PENDING' },
+ { bookingId: 'b-1', milestoneCode: 'GATEPASS_GRANTED', status: 'PENDING' },
+ ];
+ const { service, milestoneRepo } = makeService(
+ [{ id: 'b-1', status: 'CONFIRMED', paymentStatus: 'PAID' }],
+ rows,
+ );
+
+ await grant(service, securedAt);
+
+ expect(milestoneRepo.save).toHaveBeenCalledTimes(1);
+ expect(milestoneRepo.save.mock.calls[0]![0].bookingId).toBe('b-1');
+ });
+
+ it('leaves an already-granted milestone untouched', async () => {
+ const rows: Row[] = [
+ { bookingId: 'b-1', milestoneCode: 'FREIGHT_PAYMENT_SETTLED', status: 'COMPLETED' },
+ { bookingId: 'b-1', milestoneCode: 'GATEPASS_GRANTED', status: 'COMPLETED' },
+ ];
+ const { service, milestoneRepo } = makeService(
+ [{ id: 'b-1', status: 'PAID', paymentStatus: 'PAID' }],
+ rows,
+ );
+
+ await grant(service, securedAt);
+
+ expect(milestoneRepo.save).not.toHaveBeenCalled();
+ });
+
+ it('does nothing when the schedule carries no customs bookings', async () => {
+ const { service, milestoneRepo } = makeService([], []);
+
+ await grant(service, securedAt);
+
+ expect(milestoneRepo.save).not.toHaveBeenCalled();
+ });
+});
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/intercity.service.ts b/apps/edr-freight-api/src/modules/train-scheduling/intercity.service.ts
index bce4207d3..d2f1dd7b1 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/intercity.service.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/intercity.service.ts
@@ -107,7 +107,13 @@ export class IntercityService {
for (const bookingId of bookingIds) {
const booking = await this.dataSource
.getRepository(Booking)
- .findOne({ where: { id: bookingId }, relations: { bookingContainers: true } });
+ .findOne({
+ where: { id: bookingId },
+ relations: {
+ bookingContainers: { containerType: true },
+ cargoType: true,
+ },
+ });
if (!booking) {
rejected.push({ bookingId, reason: 'Booking not found' });
continue;
@@ -205,6 +211,8 @@ export class IntercityService {
.createQueryBuilder('booking')
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
+ .leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.leftJoinAndSelect('booking.originYard', 'originYard')
.leftJoinAndSelect('booking.destinationYard', 'destinationYard')
.where(`booking.trade_direction = 'DOMESTIC'`)
@@ -230,6 +238,8 @@ export class IntercityService {
.createQueryBuilder('booking')
.leftJoinAndSelect('booking.company', 'company')
.leftJoinAndSelect('booking.bookingContainers', 'bookingContainer')
+ .leftJoinAndSelect('bookingContainer.containerType', 'containerType')
+ .leftJoinAndSelect('booking.cargoType', 'cargoType')
.leftJoinAndSelect('booking.originYard', 'originYard')
.leftJoinAndSelect('booking.destinationYard', 'destinationYard')
.where(`booking.trade_direction = 'DOMESTIC'`)
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.spec.ts
index e1b4064bb..dd9234bdb 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.spec.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.spec.ts
@@ -6,6 +6,7 @@ import {
deriveTrainCapacityFromLocomotive,
grossWagonWeightTons,
minLocomotiveLimits,
+ sizePartialOfferWagons,
} from './train-capacity.util';
describe('train-capacity.util', () => {
@@ -73,6 +74,24 @@ describe('train-capacity.util', () => {
expect(derived.maxWeightTons).toBe(3590);
});
+ it('reports the base caps and tolerance separately so filling can budget on base', () => {
+ const derived = deriveTrainCapacityFromLocomotive(
+ {
+ maxPullWeightTons: 3500,
+ maxTrainLengthMeters: 760,
+ overageToleranceTons: 90,
+ overageToleranceMeters: 20,
+ },
+ [pw2],
+ );
+ expect(derived.baseWeightTons).toBe(3500);
+ expect(derived.baseLengthMeters).toBe(760);
+ expect(derived.toleranceTons).toBe(90);
+ expect(derived.toleranceMeters).toBe(20);
+ expect(derived.baseWeightTons + derived.toleranceTons).toBe(derived.maxWeightTons);
+ expect(derived.baseLengthMeters + derived.toleranceMeters).toBe(derived.maxLengthMeters);
+ });
+
it('ignores overage tolerance when unset (strict cap)', () => {
const derived = deriveTrainCapacityFromLocomotive(
{ maxPullWeightTons: 3500, maxTrainLengthMeters: 760 },
@@ -185,4 +204,96 @@ describe('train-capacity.util', () => {
expect(limits?.maxPullWeightTons).toBe(3500);
expect(limits?.overageToleranceTons).toBe(20);
});
+
+ describe('sizePartialOfferWagons', () => {
+ it('sizes a bulk split by the WEIGHT axis when the pull limit binds, not wagon slots', () => {
+ // The 3500T-train scenario: two 1000T bookings boarded gross (each 15 PW2
+ // wagons: 1000 + 378 tare = 1378), leaving 744T of pull weight but plenty
+ // of slots/length. The boundary 1000T booking (15 wagons) must be offered
+ // the largest part 744T can carry: 8 wagons whose tare is 201.6T, hauling
+ // 542.4T of cargo — gross exactly 744.
+ const offer = sizePartialOfferWagons(
+ { wagons: 40, weightTons: 744, lengthMeters: 500 },
+ 15,
+ pw2,
+ );
+ expect(offer).toEqual({ wagons: 8, maxCargoTons: 542.4 });
+ });
+
+ it('still sizes by wagon slots when they bind first (legacy behavior)', () => {
+ const offer = sizePartialOfferWagons(
+ { wagons: 3, weightTons: 100000, lengthMeters: 100000 },
+ 15,
+ pw2,
+ );
+ expect(offer?.wagons).toBe(3);
+ });
+
+ it('sizes by the LENGTH axis when it binds first', () => {
+ // 60m of train left → 3 PW2 (17.066m) fit, the 4th does not.
+ const offer = sizePartialOfferWagons(
+ { wagons: 40, weightTons: 100000, lengthMeters: 60 },
+ 15,
+ pw2,
+ );
+ expect(offer?.wagons).toBe(3);
+ });
+
+ it('never offers all of the booking — a split is a strict subset', () => {
+ const offer = sizePartialOfferWagons(
+ { wagons: 40, weightTons: 100000, lengthMeters: 100000 },
+ 15,
+ pw2,
+ );
+ expect(offer?.wagons).toBe(14);
+ });
+
+ it('returns null when not even one part-loaded wagon fits the weight room', () => {
+ expect(
+ sizePartialOfferWagons({ wagons: 5, weightTons: 20, lengthMeters: 500 }, 15, pw2),
+ ).toBeNull();
+ });
+
+ describe('fullWagonsOnly (bulk)', () => {
+ it('offers only whole full wagons — each costs capacity + tare of gross room', () => {
+ // 704T of pull weight left. A full PW2 wagon is 70 + 25.2 = 95.2T gross,
+ // so 7 fit (666.4T) and the 8th (761.6T) does not. Cargo is exactly
+ // 7 × 70 = 490T — the last wagon is never part-loaded into the leftover.
+ const offer = sizePartialOfferWagons(
+ { wagons: 40, weightTons: 704, lengthMeters: 500 },
+ 9,
+ pw2,
+ { fullWagonsOnly: true },
+ );
+ expect(offer).toEqual({ wagons: 7, maxCargoTons: 490 });
+ });
+
+ it('never squeezes a part-loaded wagon into leftover weight room', () => {
+ // Same 744T room as the part-load scenario above: the scan would pick
+ // 8 wagons hauling 542.4T (last wagon at 52.4/70). Full-wagon sizing
+ // stops at 7 fully loaded wagons.
+ const offer = sizePartialOfferWagons(
+ { wagons: 40, weightTons: 744, lengthMeters: 500 },
+ 15,
+ pw2,
+ { fullWagonsOnly: true },
+ );
+ expect(offer).toEqual({ wagons: 7, maxCargoTons: 490 });
+ });
+
+ it('returns null when the room cannot take even one FULL wagon', () => {
+ // 67.6T left (3590 cap − 3522.4 boarded): a part-loaded wagon would fit
+ // (25.2 tare + 42.4 cargo) but a full one (95.2 gross) does not — the
+ // booking must be skipped entirely, not trimmed onto the train.
+ expect(
+ sizePartialOfferWagons(
+ { wagons: 40, weightTons: 67.6, lengthMeters: 500 },
+ 3,
+ pw2,
+ { fullWagonsOnly: true },
+ ),
+ ).toBeNull();
+ });
+ });
+ });
});
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.ts b/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.ts
index 79adf8d8f..463ae7ea8 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/train-capacity.util.ts
@@ -52,6 +52,12 @@ export type DerivedTrainCapacity = {
maxLengthMeters: number;
/** Length-derived slot count. Weight is enforced separately against real cargo. */
maxWagonSlots: number;
+ /** Caps WITHOUT the overage tolerance — what batch filling budgets against. */
+ baseWeightTons: number;
+ baseLengthMeters: number;
+ /** Overage spendable only by admitting a booking whole, never by a split. */
+ toleranceTons: number;
+ toleranceMeters: number;
};
/** What a consist currently uses, and what is left on each axis. */
@@ -88,28 +94,48 @@ export function grossWagonWeightTons(slot: Pick num(w.lengthMeters))
@@ -137,9 +163,9 @@ export function deriveTrainCapacityFromLocomotive(
const minLength = lengths.length ? Math.min(...lengths) : DEFAULT_WAGON_LENGTH_M;
const maxWagonSlots =
- minLength > 0 ? Math.max(0, Math.floor(maxLengthMeters / minLength)) : 0;
+ minLength > 0 ? Math.max(0, Math.floor(caps.maxLengthMeters / minLength)) : 0;
- return { maxWeightTons, maxLengthMeters, maxWagonSlots };
+ return { ...caps, maxWagonSlots };
}
/**
@@ -256,6 +282,58 @@ export function bookingGrossWeightTons(
return round3(num(cargoTons) + wagonCount * num(tarePerWagonTons));
}
+/**
+ * Size a partial (split-on-payment) offer against the room left on a train,
+ * across ALL THREE capacity axes — not just wagon slots. Each wagon adds
+ * `capacityTons` of payload headroom but its own tare spends the same weight
+ * room the cargo needs, so on a weight-limited train more wagons is not always
+ * more cargo. Scans wagon counts (the last wagon may run part-loaded) and
+ * returns the count that maximizes the cargo carried, with the cargo cap the
+ * caller should apply. Null when not even one part-loaded wagon fits. The
+ * offer is a strict subset of the booking: never all `bookingWagons`.
+ *
+ * `fullWagonsOnly` (bulk): every offered wagon rides at its full rated payload,
+ * so each wagon costs `capacityTons + tareWeightTons` of gross weight room and
+ * the offer is the largest whole-wagon count whose gross fits — never a
+ * part-loaded last wagon squeezed into leftover pull weight.
+ */
+export function sizePartialOfferWagons(
+ room: { wagons: number; weightTons: number; lengthMeters: number },
+ bookingWagons: number,
+ perWagon: { capacityTons: number; tareWeightTons: number; lengthMeters: number },
+ opts?: { fullWagonsOnly?: boolean },
+): { wagons: number; maxCargoTons: number } | null {
+ const maxByLength =
+ perWagon.lengthMeters > 0
+ ? Math.floor(room.lengthMeters / perWagon.lengthMeters)
+ : room.wagons;
+ const ceiling = Math.min(room.wagons, maxByLength, bookingWagons - 1);
+
+ if (opts?.fullWagonsOnly) {
+ const grossPerWagon = perWagon.capacityTons + perWagon.tareWeightTons;
+ const maxByWeight =
+ grossPerWagon > 0 ? Math.floor(room.weightTons / grossPerWagon) : 0;
+ const wagons = Math.min(ceiling, maxByWeight);
+ if (wagons < 1) return null;
+ return { wagons, maxCargoTons: round3(wagons * perWagon.capacityTons) };
+ }
+
+ let wagons = 0;
+ let bestCargoTons = 0;
+ for (let w = 1; w <= ceiling; w += 1) {
+ const cargoAt = Math.min(
+ w * perWagon.capacityTons,
+ room.weightTons - w * perWagon.tareWeightTons,
+ );
+ if (cargoAt > bestCargoTons) {
+ bestCargoTons = cargoAt;
+ wagons = w;
+ }
+ }
+ if (wagons < 1) return null;
+ return { wagons, maxCargoTons: round3(room.weightTons - wagons * perWagon.tareWeightTons) };
+}
+
export function wagonTypeDimensionsFromEntity(wt: {
lengthMeters?: number | string | null;
capacityTons?: number | string | null;
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.controller.ts b/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.controller.ts
index 7dba44f83..fd41d4a29 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.controller.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.controller.ts
@@ -39,6 +39,7 @@ import {
UploadImportDjiboutiDocumentDto,
} from "./dto/import-djibouti-operation.dto";
import { AvailableLocomotivesQueryDto } from "./dto/available-locomotives-query.dto";
+import { BatchBoardQueryDto } from "./dto/batch-board-query.dto";
import { BookableSchedulesQueryDto } from "./dto/bookable-schedules-query.dto";
import { AvailableDaysQueryDto } from "./dto/available-days-query.dto";
import { AvailableDaysForCargoQueryDto } from "./dto/available-days-for-cargo-query.dto";
@@ -124,10 +125,11 @@ export class TrainSchedulingController {
@Get("batch-board")
@TrainSchedulingView()
@ApiOperation({
- summary: "Batch monitoring board: schedules with bookings grouped by state",
+ summary:
+ "Batch monitoring board: paginated import schedules (all statuses) with bookings grouped by state",
})
- getBatchBoard() {
- return this.bookingBatchService.getBatchBoard();
+ getBatchBoard(@Query() query: BatchBoardQueryDto) {
+ return this.bookingBatchService.getBatchBoard(query);
}
@Get("batch-board/:scheduleId")
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.spec.ts
index b7938857f..e97b3de56 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.spec.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.spec.ts
@@ -72,7 +72,7 @@ const makeBooking = (
wagonsRequired,
vgmPerUnitTons: weight / quantity,
isOverweight: false,
- containerType: { code: containerCode, label: containerCode },
+ containerType: { code: containerCode, label: containerCode, wagonTypeId: nw5.id },
},
],
...extra,
@@ -282,7 +282,7 @@ describe('TrainSchedulingService', () => {
expect(result.warnings[0]).toContain('soft hold window');
});
- it('flags the overweight booking as invalid', async () => {
+ it('warns on the overweight booking but still allows scheduling', async () => {
const bookings = [
makeBooking('b6', 'BKG-CONT-006', 3600, 80, '40FT', 80, undefined, undefined, undefined, {
bookingContainers: [
@@ -293,7 +293,7 @@ describe('TrainSchedulingService', () => {
wagonsRequired: 80,
vgmPerUnitTons: 45,
isOverweight: true,
- containerType: { code: '40FT', label: '40FT' },
+ containerType: { code: '40FT', label: '40FT', wagonTypeId: nw5.id },
},
],
}),
@@ -311,8 +311,8 @@ describe('TrainSchedulingService', () => {
destinationStationId: 'yard-destination',
});
- expect(result.valid).toBe(false);
- expect(result.violations.some((v) => v.includes('overweight'))).toBe(true);
+ expect(result.violations.some((v) => v.includes('overweight'))).toBe(false);
+ expect(result.warnings.some((w) => w.includes('overweight'))).toBe(true);
});
it('allows preview when bookings are already on the target schedule', async () => {
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.ts b/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.ts
index 0c366ed05..f53af2a93 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/train-scheduling.service.ts
@@ -1073,12 +1073,17 @@ export class TrainSchedulingService {
containerPlacements ?? [],
);
+ // The link above puts these bookings on the train: they are SCHEDULED, not
+ // ELIGIBLE. Leaving them ELIGIBLE re-offers an allocated booking to the next
+ // batch fill, which unlinks it and frees its wagons on the next window cycle.
+ const scheduledAt = new Date();
for (const booking of bookings) {
await this.bookingsRepository.updateSchedulingFields(
booking.id,
{
- schedulingStatus: SchedulingStatus.Eligible,
- wagonsRequired: sumWagonsRequired(booking),
+ schedulingStatus: SchedulingStatus.Scheduled,
+ scheduledAt,
+ wagonsRequired: sumWagonsRequired(booking, wagonPlan),
},
manager,
);
@@ -1655,6 +1660,13 @@ export class TrainSchedulingService {
* clearance views still reading that milestone (older deployed builds) see
* the gate pass as done. Drop once every clearance-api deployment reads
* ImportDjiboutiOperation.gatepassGrantedAt directly.
+ *
+ * A booking only earns its gate pass once the customer has settled the freight
+ * charges (FREIGHT_PAYMENT_SETTLED). The gate pass itself is secured per train
+ * schedule, so an unpaid booking must not ride a paid neighbour's grant: it
+ * keeps GATEPASS_GRANTED pending — and therefore cannot upload T1 — while the
+ * train and its paid bookings proceed. Re-securing the gate pass after payment
+ * settles picks the booking up; so does any later call to this bridge.
*/
private async completeGatepassMilestoneForSchedule(
scheduleId: string,
@@ -1666,20 +1678,49 @@ export class TrainSchedulingService {
if (bookings.length === 0) return;
const milestoneRepo = this.dataSource.getRepository(ClearanceMilestone);
+ const bookingIds = bookings.map((b) => b.id);
const rows = await milestoneRepo.find({
where: {
- bookingId: In(bookings.map((b) => b.id)),
- milestoneCode: 'GATEPASS_GRANTED',
+ bookingId: In(bookingIds),
+ milestoneCode: In(['GATEPASS_GRANTED', 'FREIGHT_PAYMENT_SETTLED']),
},
});
+ const paidBookingIds = new Set(
+ rows
+ .filter(
+ (r) => r.milestoneCode === 'FREIGHT_PAYMENT_SETTLED' && r.status === 'COMPLETED',
+ )
+ .map((r) => r.bookingId),
+ );
+ // A booking whose payment settled through a path that never wrote the
+ // milestone still counts as paid — the clearance views self-heal the row on
+ // read, and the gate pass must not lag behind that.
+ for (const booking of bookings) {
+ if (booking.paymentStatus === 'PAID' || booking.status === 'PAID') {
+ paidBookingIds.add(booking.id);
+ }
+ }
+
+ const skipped: string[] = [];
for (const row of rows) {
+ if (row.milestoneCode !== 'GATEPASS_GRANTED') continue;
if (row.status === 'COMPLETED') continue;
+ if (!row.bookingId || !paidBookingIds.has(row.bookingId)) {
+ skipped.push(row.bookingId ?? '(unknown)');
+ continue;
+ }
row.status = 'COMPLETED';
row.triggeredAt = securedAt;
row.metadata = { ...(row.metadata ?? {}), gatepassAt: securedAt.toISOString() };
await milestoneRepo.save(row);
}
+
+ if (skipped.length > 0) {
+ this.logger.warn(
+ `Gate pass secured for schedule ${scheduleId}, but ${skipped.length} booking(s) have not settled freight payment and stay pending: ${skipped.join(', ')}`,
+ );
+ }
}
async markImportReadyForLoading(scheduleId: string, dto: ImportDjiboutiActionDto = {}) {
@@ -1864,7 +1905,7 @@ export class TrainSchedulingService {
@@ -2473,6 +2514,12 @@ export class TrainSchedulingService {
if (dto.sequenceNo === finalSeq) {
await this.arriveSchedule(scheduleId);
+ } else {
+ // Mid-corridor auto-unload: bookings destined for this yard alight the
+ // moment the train is recorded here — the yard operator no longer has to
+ // unload each one by hand. The final station is covered by
+ // arriveSchedule's bulk fallback above.
+ await this.bookingJourneyService.autoUnloadAtYard(scheduleId, station.yardId);
}
return this.getScheduleCheckpoints(scheduleId);
@@ -2598,7 +2645,8 @@ export class TrainSchedulingService {
const schedules = await this.trainSchedulesRepository.findAll({
relations: {
trainSet: { locomotive: true, locomotives: { locomotive: true } },
- route: true,
+ // Yards carry the route's display name used by mapScheduleListItem.
+ route: { originYard: true, destinationYard: true },
originStation: true,
destinationStation: true,
scheduleBookings: { booking: true },
@@ -2765,10 +2813,14 @@ export class TrainSchedulingService {
`Booking ${booking.reference} is within the soft hold window (expires ${booking.holdExpiresAt?.toISOString()})`,
);
}
+ // Overweight is the soft threshold (maxVgmTons): the customer already
+ // paid the overweight surcharge at booking. The hard ceiling
+ // (maxCapacityTons) blocks booking creation, so anything reaching
+ // scheduling is shippable — warn the planner, never block allocation.
const overweightLines = (booking.bookingContainers ?? []).filter((c) => c.isOverweight);
if (overweightLines.length) {
- violations.push(
- `Booking ${booking.reference} has overweight container lines; use forceAssign to override`,
+ warnings.push(
+ `Booking ${booking.reference} has ${overweightLines.length} overweight container line(s); overweight surcharge applied`,
);
}
}
@@ -4472,6 +4524,11 @@ export class TrainSchedulingService {
capacityTons: roundTons(Number(wagon.capacityTons)),
lengthMeters: roundTons(Number(wagon.lengthMeters)),
assignedWeightTons: roundTons(Number(wagon.assignedWeightTons)),
+ // Empty-wagon weight — the pull limit hauls tare + cargo, so the
+ // frontend needs it to show the gross train weight.
+ tareWeightTons: wagon.wagonType
+ ? roundTons(Number(wagon.wagonType.tareWeightTons))
+ : null,
status: wagon.status,
physicalWagonId: wagon.physicalWagonId ?? null,
physicalWagonNumber: wagon.physicalWagon?.wagonNumber ?? null,
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.spec.ts b/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.spec.ts
index e180b482b..19e19dca3 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.spec.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.spec.ts
@@ -82,6 +82,29 @@ describe('wagon-plan.util', () => {
expect(plan).toHaveLength(2);
});
+ it('counts a bulk booking\'s wagons from the plan, not a flat 1', () => {
+ // 700T of sugar on 60T CW3 gondolas = 12 wagons; the stored wagonsRequired
+ // must carry all of them so gross weight charges 12 tares downstream.
+ const booking = {
+ id: 'bulk-700',
+ reference: 'bulk-700',
+ freightType: 'BULK',
+ cargoTotalWeightVgm: 700,
+ bookingContainers: [],
+ } as unknown as Booking;
+ const plan = buildBulkWagonPlan([booking], cw3);
+ expect(plan).toHaveLength(12);
+ expect(sumWagonsRequired(booking, plan)).toBe(12);
+ // Without a plan the pre-plan fallback still applies.
+ expect(sumWagonsRequired(booking)).toBe(1);
+ });
+
+ it('counts container wagons from the plan TEU packing', () => {
+ const booking = makeContainerBooking('c-plan', [{ quantity: 6, wagonsRequired: 3 }]);
+ const plan = buildContainerWagonPlan([booking], nw5);
+ expect(sumWagonsRequired(booking, plan)).toBe(3);
+ });
+
it('6×20ft containers = 3 wagon slots (2 per wagon)', () => {
// 20ft containers have wagonsPerUnit = 0.5, so 6 * 0.5 = 3 wagons
const booking = makeContainerBooking('b6x20', [{ quantity: 6, wagonsRequired: 3 }]);
diff --git a/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.ts b/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.ts
index 30a46a099..2af606cdc 100644
--- a/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.ts
+++ b/apps/edr-freight-api/src/modules/train-scheduling/wagon-plan.util.ts
@@ -436,7 +436,21 @@ export function expandContainerItems(
return items;
}
-export function sumWagonsRequired(booking: Booking): number {
+/**
+ * Wagons a booking actually occupies. Prefer counting the built wagon plan's
+ * slots that carry one of the booking's allocations — for BULK that is its
+ * tonnage spread over real wagons (a 700T booking on 70T wagons rides 10
+ * wagons, and downstream gross-weight math charges 10 tares, not 1). Without
+ * a plan there is no capacity to divide by, so fall back to the pre-plan
+ * estimates: 1 for bulk, the lines' stored counts for containers.
+ */
+export function sumWagonsRequired(booking: Booking, wagonPlan?: WagonPlanSlot[]): number {
+ const occupiedSlots = (wagonPlan ?? []).filter((slot) =>
+ slot.allocations.some((allocation) => allocation.bookingId === booking.id),
+ ).length;
+ if (occupiedSlots > 0) {
+ return occupiedSlots;
+ }
if (booking.freightType === 'BULK') {
return 1;
}
diff --git a/apps/edr-freight-api/src/modules/wagons/dto/create-wagon.dto.ts b/apps/edr-freight-api/src/modules/wagons/dto/create-wagon.dto.ts
index 03a930b11..d1939c9f5 100644
--- a/apps/edr-freight-api/src/modules/wagons/dto/create-wagon.dto.ts
+++ b/apps/edr-freight-api/src/modules/wagons/dto/create-wagon.dto.ts
@@ -1,5 +1,5 @@
import { WagonStatus } from '@edr/types';
-import { IsString, IsUUID, IsOptional, IsInt, Min, IsNumber, IsEnum } from 'class-validator';
+import { IsString, IsUUID, IsOptional, IsInt, Min, IsEnum } from 'class-validator';
export class CreateWagonDto {
@IsString()
@@ -17,13 +17,8 @@ export class CreateWagonDto {
@Min(1)
sequenceNumber?: number;
- @IsNumber()
- @Min(0)
- tareWeight!: number;
-
- @IsNumber()
- @Min(0)
- maxPayloadWeight!: number;
+ // Tare weight and payload capacity are not accepted here: they belong to the
+ // wagon type and are resolved through wagonTypeId.
@IsOptional()
@IsEnum(WagonStatus)
diff --git a/apps/edr-freight-api/src/modules/wagons/entities/wagon.entity.ts b/apps/edr-freight-api/src/modules/wagons/entities/wagon.entity.ts
index 195b4932b..9f2d41416 100644
--- a/apps/edr-freight-api/src/modules/wagons/entities/wagon.entity.ts
+++ b/apps/edr-freight-api/src/modules/wagons/entities/wagon.entity.ts
@@ -7,6 +7,7 @@ import { TrainSchedule } from '../../train-schedules/entities/train-schedule.ent
import { TrainSetWagon } from '../../train-sets/entities/train-set-wagon.entity';
import { Container } from '../../container-management/entities/container.entity';
import { Yard } from '../../rule-engine/entities/yard.entity';
+import { WagonType } from '../../wagon-types/entities/wagon-type.entity';
export const WAGON_STATUSES = [
WagonStatus.Available,
@@ -28,17 +29,19 @@ export class Wagon extends BaseEntity {
@Column({ name: 'wagon_type_id', type: 'uuid' })
wagonTypeId!: string;
+ /** Owns this wagon's spec: tare weight, payload capacity, length. */
+ @ManyToOne(() => WagonType)
+ @JoinColumn({ name: 'wagon_type_id' })
+ wagonType?: WagonType;
+
@Column({ name: 'train_id', type: 'uuid', nullable: true })
trainId!: string | null;
@Column({ name: 'sequence_number', type: 'int', nullable: true })
sequenceNumber!: number | null;
- @Column({ name: 'tare_weight', type: 'decimal', precision: 10, scale: 2 })
- tareWeight!: number;
-
- @Column({ name: 'max_payload_weight', type: 'decimal', precision: 10, scale: 2 })
- maxPayloadWeight!: number;
+ // Tare weight and payload capacity are properties of the wagon TYPE — read them
+ // through `wagonType`, never off the individual wagon.
@Column({ type: 'varchar', length: 20, default: WagonStatus.Available })
status!: WagonStatusType;
diff --git a/apps/edr-freight-api/src/modules/wagons/wagons.service.ts b/apps/edr-freight-api/src/modules/wagons/wagons.service.ts
index 9d1f1b41f..b010c0351 100644
--- a/apps/edr-freight-api/src/modules/wagons/wagons.service.ts
+++ b/apps/edr-freight-api/src/modules/wagons/wagons.service.ts
@@ -52,14 +52,23 @@ export class WagonsService {
});
}
- const sortBy = ['wagonNumber', 'tareWeight', 'maxPayloadWeight', 'status', 'currentYardId', 'sequenceNumber'].includes(query.sortBy ?? '')
+ // Spec columns (tare, payload) are no longer sortable here — they live on the
+ // wagon type, so sorting by them is sorting by wagonTypeId.
+ const sortable: Array = [
+ 'wagonNumber',
+ 'status',
+ 'currentYardId',
+ 'sequenceNumber',
+ 'wagonTypeId',
+ ];
+ const sortBy = sortable.includes((query.sortBy ?? '') as keyof Wagon)
? (query.sortBy as keyof Wagon)
: 'wagonNumber';
const sortOrder = query.sortOrder?.toUpperCase() === 'DESC' ? 'DESC' : 'ASC';
return this.wagonRepo.find({
where: search ? where : filters,
- relations: { currentYard: true },
+ relations: { currentYard: true, wagonType: true },
order: { [sortBy]: sortOrder } as FindOptionsOrder,
skip: query.page && query.limit ? (Number(query.page) - 1) * Number(query.limit) : undefined,
take: query.limit ? Number(query.limit) : undefined,
@@ -69,7 +78,7 @@ export class WagonsService {
async findById(id: string): Promise {
const wagon = await this.wagonRepo.findOne({
where: { id },
- relations: { currentYard: true },
+ relations: { currentYard: true, wagonType: true },
});
if (!wagon) throw new NotFoundException(`Wagon ${id} not found`);
return wagon;
diff --git a/apps/edr-freight-api/src/modules/warehouses/dto/release-order.dto.ts b/apps/edr-freight-api/src/modules/warehouses/dto/release-order.dto.ts
index 681b30284..17b75b424 100644
--- a/apps/edr-freight-api/src/modules/warehouses/dto/release-order.dto.ts
+++ b/apps/edr-freight-api/src/modules/warehouses/dto/release-order.dto.ts
@@ -1,5 +1,5 @@
import { ApiPropertyOptional } from '@nestjs/swagger';
-import { IsDateString, IsNumber, IsOptional, IsString, Min } from 'class-validator';
+import { IsBoolean, IsDateString, IsNumber, IsOptional, IsString, Min } from 'class-validator';
/** Records a DO / release order being sent to the customer for import pickup. */
export class ReleaseOrderDto {
@@ -90,4 +90,13 @@ export class ReleaseOrderDto {
@IsOptional()
@IsDateString()
gateOutTime?: string;
+
+ @ApiPropertyOptional({
+ description:
+ 'Container bookings only: the operator chose not to weigh this truck. ' +
+ 'Tare/gross become optional and the container weight match is skipped. Bulk always weighs.',
+ })
+ @IsOptional()
+ @IsBoolean()
+ weighingSkipped?: boolean;
}
diff --git a/apps/edr-freight-api/src/modules/warehouses/entities/warehouse-inventory.entity.ts b/apps/edr-freight-api/src/modules/warehouses/entities/warehouse-inventory.entity.ts
index a54f40973..b2c4ca3c4 100644
--- a/apps/edr-freight-api/src/modules/warehouses/entities/warehouse-inventory.entity.ts
+++ b/apps/edr-freight-api/src/modules/warehouses/entities/warehouse-inventory.entity.ts
@@ -36,7 +36,9 @@ export const WAREHOUSE_INVENTORY_TRANSITIONS: Record {
+ try {
+ const rows: Array<{ bookingId: string; reference: string }> = await this.dataSource.query(
+ `SELECT DISTINCT ON (booking_id)
+ booking_id AS "bookingId", reference
+ FROM freight.booking_handovers
+ WHERE signed_at IS NULL
+ AND deleted_at IS NULL
+ AND mile_type = 'SELF_HAUL'
+ ORDER BY booking_id, generated_at DESC`,
+ );
+ if (!rows.length) return;
+ this.logger.log(`Handover sign reminder: ${rows.length} booking(s) still unsigned`);
+ for (const row of rows) {
+ await this.notifySignNeeded(row.bookingId, row.reference);
+ }
+ } catch (err) {
+ this.logger.warn(`Handover sign reminder tick failed: ${(err as Error).message}`);
+ }
+ }
+
/** Sign all unsigned handovers on a booking (self-haul: before the truck leaves). */
async signForBooking(bookingId: string, userId?: string | null): Promise {
await this.dataSource
diff --git a/apps/edr-freight-api/src/modules/warehouses/warehouse-inventory.service.ts b/apps/edr-freight-api/src/modules/warehouses/warehouse-inventory.service.ts
index 9b2f53a99..2b98856d0 100644
--- a/apps/edr-freight-api/src/modules/warehouses/warehouse-inventory.service.ts
+++ b/apps/edr-freight-api/src/modules/warehouses/warehouse-inventory.service.ts
@@ -860,6 +860,25 @@ export class WarehouseInventoryService {
/** Bulk-receive eligible PAID bookings into a location. Skips duplicates / wrong direction. */
async bulkReceive(dto: BulkReceiveDto): Promise {
const result: BulkReceiveResult = { receivedCount: 0, skippedCount: 0, results: [] };
+ /** Sent after the transaction commits so the gateway never blocks the receive. */
+ const pendingNotifications: Array<{
+ owner: {
+ phone?: string | null;
+ ownerName?: string | null;
+ bookingReference?: string | null;
+ grnNumber: string;
+ direction?: string | null;
+ warehouseId?: string | null;
+ };
+ booking: {
+ companyId?: string | null;
+ reference?: string | null;
+ hasFirstMile?: boolean;
+ hasLastMile?: boolean;
+ customerTruckAssignedAt?: string | null;
+ };
+ bookingId: string;
+ }> = [];
await this.dataSource.transaction(async (manager) => {
await this.validateLocation(manager, {
@@ -1032,21 +1051,33 @@ export class WarehouseInventoryService {
manager,
);
- await this.notifyOwnerInventoryReceived({
- phone: truckEntrance?.customerPhone ?? booking.customerPhone,
- ownerName: truckEntrance?.ownerName ?? booking.customer,
- bookingReference: truckEntrance?.edrDigitalBookingId ?? booking.reference,
- grnNumber,
- direction: dto.direction,
- warehouseId: dto.warehouseId,
+ // Queued, not sent here: an SMS/email round-trip inside the transaction
+ // holds capacity/location locks open for the whole gateway latency.
+ pendingNotifications.push({
+ owner: {
+ phone: truckEntrance?.customerPhone ?? booking.customerPhone,
+ ownerName: truckEntrance?.ownerName ?? booking.customer,
+ bookingReference: truckEntrance?.edrDigitalBookingId ?? booking.reference,
+ grnNumber,
+ direction: dto.direction,
+ warehouseId: dto.warehouseId,
+ },
+ booking,
+ bookingId,
});
result.receivedCount += 1;
result.results.push({ bookingId, status: 'RECEIVED', inventoryId: saved.id, grnNumber });
- void this.notifyTruckAssignmentNeeded(booking, bookingId);
}
});
+ // Fan out after commit, un-awaited: the receive response must not wait on the
+ // SMS gateway. Both notifiers swallow their own errors.
+ for (const pending of pendingNotifications) {
+ void this.notifyOwnerInventoryReceived(pending.owner);
+ void this.notifyTruckAssignmentNeeded(pending.booking, pending.bookingId);
+ }
+
return result;
}
@@ -2326,6 +2357,27 @@ export class WarehouseInventoryService {
});
}
+ /**
+ * Self-haul = the customer's own truck collects the goods: either a truck
+ * assigned via the portal (customer_truck_assigned_at), or a walk-in truck
+ * registered at the gate on a booking with no EDR last-mile leg. EDR
+ * last-mile bookings are never self-haul.
+ */
+ private async isSelfHaulBooking(bookingId: string, manager?: EntityManager): Promise {
+ const runner = manager ?? this.dataSource;
+ const [row]: Array<{ ok: number }> = await runner.query(
+ `SELECT 1 AS ok
+ FROM freight.bookings b
+ LEFT JOIN freight.service_types st ON st.id = b.service_type_id
+ WHERE b.id = $1 AND b.deleted_at IS NULL
+ AND (b.customer_truck_assigned_at IS NOT NULL
+ OR (NULLIF(TRIM(COALESCE(b.last_mile_delivery_address, '')), '') IS NULL
+ AND COALESCE(st.includes_last_mile, false) = false))`,
+ [bookingId],
+ );
+ return Boolean(row);
+ }
+
/** Record a DO / release order sent to the customer. Item stays READY_FOR_PICKUP. */
async release(id: string, dto: ReleaseOrderDto): Promise {
const item = await this.findById(id);
@@ -2335,19 +2387,17 @@ export class WarehouseInventoryService {
);
}
- const isTruckLeaving = dto.grossWeight !== undefined && Boolean(dto.gateOutTime);
+ // Leaving = gate-out captured, with either a weighed gross or an explicit
+ // container weighing skip (bulk always weighs).
+ const isTruckLeaving =
+ Boolean(dto.gateOutTime) && (dto.grossWeight !== undefined || dto.weighingSkipped === true);
if (isTruckLeaving) {
await this.invoices.assertClearanceAllowed(id);
if (item.bookingId) {
- const [truckInfo]: Array<{ customerTruckAssignedAt: string | null }> =
- await this.dataSource.query(
- `SELECT customer_truck_assigned_at AS "customerTruckAssignedAt"
- FROM freight.bookings
- WHERE id = $1 AND deleted_at IS NULL`,
- [item.bookingId],
- );
- const usesCustomerTruck = Boolean(truckInfo?.customerTruckAssignedAt);
+ // Self-haul = customer collects: a truck assigned via the portal, OR a
+ // walk-in truck registered at the gate on a booking with no EDR last mile.
+ const usesCustomerTruck = await this.isSelfHaulBooking(item.bookingId);
// Self-haul: the handover must be signed before the exit paper is issued.
// Prefer the structured handover record; fall back to the legacy note.
const handoverSigned =
@@ -2361,7 +2411,8 @@ export class WarehouseInventoryService {
// Authoritative weight match: the truck's net (gross − tare) must equal the
// total VGM cargo weight of the containers selected as loaded on it.
- if (dto.containerNumber && dto.grossWeight != null && dto.tareWeight != null) {
+ // Skipped when the operator chose not to weigh (containers only).
+ if (!dto.weighingSkipped && dto.containerNumber && dto.grossWeight != null && dto.tareWeight != null) {
const selected = dto.containerNumber
.split(/[,;\n]+/)
.map((n) => n.trim())
@@ -2431,13 +2482,10 @@ export class WarehouseInventoryService {
[item.bookingId],
);
// Self-haul: generate the per-booking handover on first truck arrival
- // (idempotent). It must be signed before the truck leaves.
- const [selfHaul]: Array<{ ok: number }> = await manager.query(
- `SELECT 1 AS ok FROM freight.bookings
- WHERE id = $1 AND customer_truck_assigned_at IS NOT NULL AND deleted_at IS NULL`,
- [item.bookingId],
- );
- if (selfHaul) {
+ // (idempotent) and notify the customer to sign it. Covers BOTH portal-
+ // assigned trucks and walk-in trucks registered manually at the gate
+ // (no portal assignment, no EDR last mile). Must be signed before leaving.
+ if (await this.isSelfHaulBooking(item.bookingId, manager)) {
await this.handover.ensureForArrivedTruck(item.bookingId, {}, manager);
}
}
@@ -4422,14 +4470,17 @@ export class WarehouseInventoryService {
if (!dto.driverName?.trim()) {
throw new BadRequestException('Driver name is required for exit inspection');
}
- if (dto.tareWeight === undefined) {
+ // Container bookings may skip the weighbridge entirely (weighingSkipped);
+ // bulk always weighs.
+ const weighingSkipped = dto.weighingSkipped === true;
+ if (dto.tareWeight === undefined && !weighingSkipped) {
throw new BadRequestException('Tare weight is required for truck arrival');
}
- const tareWeight = Number(dto.tareWeight);
+ const tareWeight = dto.tareWeight === undefined ? null : Number(dto.tareWeight);
const grossWeight = dto.grossWeight === undefined ? null : Number(dto.grossWeight);
const computedNetWeight =
- grossWeight == null ? null : Number((grossWeight - tareWeight).toFixed(3));
+ grossWeight == null || tareWeight == null ? null : Number((grossWeight - tareWeight).toFixed(3));
const submittedNetWeight =
dto.netWeight === undefined || computedNetWeight == null ? computedNetWeight : Number(dto.netWeight);
@@ -4441,7 +4492,11 @@ export class WarehouseInventoryService {
throw new BadRequestException('Weight mismatch: net weight must equal gross weight minus tare weight.');
}
}
- if ((dto.grossWeight !== undefined || dto.gateOutTime || dto.netWeight !== undefined) && grossWeight == null) {
+ if (
+ !weighingSkipped &&
+ (dto.grossWeight !== undefined || dto.gateOutTime || dto.netWeight !== undefined) &&
+ grossWeight == null
+ ) {
throw new BadRequestException('Gross weight is required for truck exit');
}
@@ -4457,7 +4512,8 @@ export class WarehouseInventoryService {
dto.truckType?.trim() ? `Truck Type: ${dto.truckType.trim()}` : null,
dto.containerNumber?.trim() ? `Container Number: ${dto.containerNumber.trim()}` : null,
dto.gateInTime ? `Gate In Time: ${dto.gateInTime}` : null,
- `Tare Weight: ${tareWeight} t`,
+ weighingSkipped ? 'Weighing: SKIPPED' : null,
+ tareWeight == null ? null : `Tare Weight: ${tareWeight} t`,
grossWeight == null ? null : `Gross Weight: ${grossWeight} t`,
computedNetWeight == null ? null : `Net Weight: ${computedNetWeight} t`,
dto.gateOutTime ? `Gate Out Time: ${dto.gateOutTime}` : null,
@@ -4481,6 +4537,8 @@ export class WarehouseInventoryService {
containerNumber: this.extractExitInspectionLine(inspection, 'Container Number') || dto.containerNumber,
gateInTime: this.extractExitInspectionLine(inspection, 'Gate In Time') || dto.gateInTime,
tareWeight: this.extractExitInspectionNumber(inspection, 'Tare Weight') ?? dto.tareWeight,
+ // The weigh/skip decision is made at arrival and sticks for the exit.
+ weighingSkipped: dto.weighingSkipped || /^Weighing:\s*SKIPPED/im.test(inspection) || undefined,
};
}
diff --git a/apps/edr-freight-api/src/scripts/seed-gate-pass-train-scenarios.ts b/apps/edr-freight-api/src/scripts/seed-gate-pass-train-scenarios.ts
index 4b3479327..a8abee67b 100644
--- a/apps/edr-freight-api/src/scripts/seed-gate-pass-train-scenarios.ts
+++ b/apps/edr-freight-api/src/scripts/seed-gate-pass-train-scenarios.ts
@@ -419,8 +419,6 @@ async function ensureWagon(manager: any, scenario: ScenarioTrain, sequenceNo: nu
wagonTypeId,
trainId: null,
sequenceNumber: sequenceNo,
- tareWeight: 20,
- maxPayloadWeight: 70,
status: WagonStatus.Assigned,
currentYardId: yardId,
currentTrainScheduleId: scheduleId,
diff --git a/apps/edr-freight-api/src/scripts/seed-negad-indode-arrived-train.ts b/apps/edr-freight-api/src/scripts/seed-negad-indode-arrived-train.ts
index 35e098f91..4f801330a 100644
--- a/apps/edr-freight-api/src/scripts/seed-negad-indode-arrived-train.ts
+++ b/apps/edr-freight-api/src/scripts/seed-negad-indode-arrived-train.ts
@@ -306,8 +306,6 @@ async function main() {
wagonTypeId: wagonType.id,
trainId: null,
sequenceNumber: sequenceNo,
- tareWeight: 20,
- maxPayloadWeight: 70,
status: WagonStatus.Assigned,
currentYardId: indode.id,
notes: 'Demo wagon for Negad to Indode marshalling',
diff --git a/apps/edr-freight-api/src/seed/batch5-test-data.seeder.ts b/apps/edr-freight-api/src/seed/batch5-test-data.seeder.ts
index c5a49e629..ebee2a547 100644
--- a/apps/edr-freight-api/src/seed/batch5-test-data.seeder.ts
+++ b/apps/edr-freight-api/src/seed/batch5-test-data.seeder.ts
@@ -2,6 +2,7 @@ import { Injectable, Logger } from '@nestjs/common';
import { DataSource } from 'typeorm';
import { Booking } from '../modules/bookings/entities/booking.entity';
+import { CompanyProfile } from '../modules/companies/entities/company-profile.entity';
import { ServiceType } from '../modules/rule-engine/entities/service-type.entity';
import { Yard } from '../modules/rule-engine/entities/yard.entity';
import { Warehouse } from '../modules/warehouses/entities/warehouse.entity';
@@ -91,12 +92,26 @@ export class Batch5TestDataSeeder {
return;
}
+ // bookings.company_id AND bookings.company_profile_id are both NOT NULL, so a
+ // seed booking needs an owning company profile. Resolve the profile and take
+ // its company from it, so the two columns can never disagree. Without this the
+ // seeder aborted on its first insert.
+ const companyProfile = await this.dataSource
+ .getRepository(CompanyProfile)
+ .findOne({ where: {} });
+ if (!companyProfile) {
+ this.logger.warn('No company profile found; skipping Batch 5 seed');
+ return;
+ }
+
const now = new Date();
for (const seed of SEEDS) {
const booking = await bookingRepo.save(
bookingRepo.create({
reference: seed.ref,
+ companyId: companyProfile.companyId,
+ companyProfileId: companyProfile.id,
originYardId: originYard.id,
destinationYardId: destYard.id,
serviceTypeId: serviceType.id,
diff --git a/apps/edr-freight-api/src/seed/data/contract-template-defaults.ts b/apps/edr-freight-api/src/seed/data/contract-template-defaults.ts
new file mode 100644
index 000000000..6fba64010
--- /dev/null
+++ b/apps/edr-freight-api/src/seed/data/contract-template-defaults.ts
@@ -0,0 +1,873 @@
+import type {
+ ContractTemplateArticle,
+ ContractTemplateCode,
+} from "../../modules/contract-templates/entities/contract-template.entity";
+
+/**
+ * Default article packs for the six contract templates, transcribed from the
+ * signed EDR contract documents (test/contrat_docs). Article bodies use the
+ * dynamic-article text format: one clause per line, "- " prefix for bullets
+ * nested under the previous clause, single-line body = plain paragraph.
+ * Handlebars placeholders ({{client.companyName}}, {{contractDate}},
+ * {{contractYear}}, {{reference}}) interpolate at render time.
+ */
+export interface ContractTemplateSeed {
+ code: ContractTemplateCode;
+ name: string;
+ description: string;
+ documentTitle: string;
+ whereasClauses: string[];
+ articles: Array>;
+}
+
+const a = (id: string, title: string, body: string): Omit => ({
+ id,
+ title,
+ body: body.trim(),
+});
+
+/* ────────────────────────────── IMPORT / BULK ────────────────────────────── */
+
+const IMPORT_BULK: ContractTemplateSeed = {
+ code: "IMPORT_BULK",
+ name: "Bulk Import Contract",
+ description:
+ "Import of bulk cargo (e.g. steel billets) from Djibouti (DMP/Nagad) to Galaan Multipurpose Port with customs clearance and optional last-mile delivery.",
+ documentTitle: "Bulk Cargo Transportation and Customs Clearance Services",
+ whereasClauses: [
+ "The Client has agreed to engage the Service Provider for transportation and customs clearance services for bulk cargo, including first-mile transport to the railway station at Djibouti, loading at either DMP or Nagad Railway Station (Djibouti), port/rail terminal handling, loading onto the train, railway transport to Galaan Multipurpose Port (GMP) in Ethiopia, unloading at the destination port from train to load directly on truck, onward transportation to the Client's site (excluding truck loading at Djibouti and truck unloading at the Client destination where last-mile service is undertaken by the Service Provider), and all related documentation.",
+ "The Service Provider has agreed to provide the requested services in accordance with the terms and conditions of this Agreement.",
+ ],
+ articles: [
+ a(
+ "objective",
+ "Objective of the Services",
+ `The objective of this contract is to provide the Client with integrated logistics services for the transportation of bulk cargo, including:
+- First-mile transportation in Djibouti from the Client's designated cargo location to the selected railway station (DMP or Nagad).
+- Port handling and loading onto railway wagons.
+- Railway transport from DMP and/or Nagad Railway freight station (Djibouti) to Galaan Multipurpose Port.
+- Customs clearance in Djibouti and Ethiopia.
+- Unloading from train at the destination port to load directly on truck.
+- Last-mile delivery by truck to the Client's delivery site where the last-mile service is undertaken by the Service Provider.
+The truck loading at Djibouti and the truck unloading at the Client's delivery site shall be the responsibility of the Client.`,
+ ),
+ a(
+ "client-obligations",
+ "Obligations of the Client",
+ `Provide written/email/electronic instructions specifying the cargo volume and the selected loading station (DMP or Nagad) for each shipment.
+Prepare and submit all necessary documents and permits to enable smooth service execution.
+Ensure cargo readiness in compliance with specifications (including weight, size, and contour restrictions).
+Handle truck loading at Djibouti Free Zone/Old Port/DMP and any other designated cargo location at Djibouti, and truck unloading at the delivery site.
+Ensure safety and proper securing of cargo during truck handling.
+Submit all required documents necessary for customs clearance and cargo release within one (1) calendar day from the date of request or notification by the Service Provider.
+Upon receipt of the wagon allocation list and train schedule from the Service Provider, ensure that the cargo is transferred to the designated loading freight station and made ready for loading within two (2) days prior to wagon arrival. Any delay beyond this period resulting from Client-related issues shall be subject to a charge of USD 56 per wagon per day, or part thereof, until the cargo is made available for loading.
+Upon arrival of the train at Galaan Multipurpose Port (GMP), offload cargo from wagons within twenty-four (24) hours of train arrival. Where the Client undertakes last-mile transportation, the Client may arrange sufficient trucks at the time of train arrival to enable direct loading of cargo from wagons to trucks.
+In the event the Client is unable to provide trucks for the collection of cargo within twenty-four (24) hours of train arrival, the Service Provider shall have the right to handle and reposition the cargo to any location it deems appropriate, and shall not be held responsible for any loss, shortage, or damage arising from such repositioning.
+Any additional handling, re-handling, or repeated loading operations performed by the Service Provider shall be charged as double handling fees at a rate of USD 4 per ton, payable by the Client.
+If stored, the full cargo must be collected from the Galaan Multipurpose Port compound within three (3) days from the time of train arrival at the port.
+If the Client fails to collect the cargo within the specified period, the Client shall be liable to pay demurrage charges of USD 2 per day per ton, calculated based on the Commercial Bank of Ethiopia's daily selling exchange rate on the date of payment.
+Where the last-mile service is provided by the Service Provider, unload the cargo from the truck at the delivery site within the agreed time frame.
+Designate authorized representatives (with valid power of attorney) for handover at origin and destination.
+Settle demurrage payments within ten (10) calendar days from the date the Service Provider issues a claim.
+Pay the Service Provider one hundred percent (100%) of the contract price in advance for each train set in accordance with the pricing article of this Agreement.
+Contact the Service Provider to obtain confirmation prior to booking and proceeding with payment.`,
+ ),
+ a(
+ "provider-obligations",
+ "Obligations of the Service Provider",
+ `Provide first-mile transportation in Djibouti from the Client's designated location to the selected railway station (DMP or Nagad).
+Carry out port handling and loading onto railway wagons.
+Provide railway transportation from DMP/Nagad (Djibouti) railway freight station to Galaan Multipurpose Port.
+Perform unloading at Galaan Multipurpose Port (GMP) to load directly on truck.
+Perform customs clearance in Djibouti and Ethiopia, including border station procedures.
+Prepare and submit all required transport documentation.
+Provide cargo insurance coverage for each supplied wagon.
+Notify the Client of train schedules, wagon numbers, and expected arrival times in advance.`,
+ ),
+ a(
+ "force-majeure",
+ "Force Majeure",
+ `Neither party shall be liable for delays or non-performance caused by force majeure events beyond their reasonable control.
+Force majeure shall be interpreted in accordance with the Ethiopian Civil Code.`,
+ ),
+ a(
+ "liability",
+ "Liabilities Related to Damages and Losses",
+ `The Service Provider shall be fully responsible for any loss, shortage, or damage to cargo that occurs after it has been taken over until delivery to the Client's delivery site.
+Compensation shall be based on the market value of the cargo, in accordance with applicable laws.`,
+ ),
+ a(
+ "pricing",
+ "Contract Price and Payment Terms",
+ `Rail transport to Galaan Multipurpose Port: USD 59.4 per metric ton.
+Djibouti handling (first-mile, port handling and loading, and documentation): USD 18 (eighteen) per metric ton for cargo from the Free Zone; USD 20 (twenty) per metric ton for cargo from the Old Port or DMP.
+Lashing materials shall be charged at USD 150 (one hundred fifty) per wagon and wood at USD 50 (fifty) per wagon when provided by the Service Provider; the provision continues until the cargo reaches and is fully unloaded at the designated destination station.
+Each wagon shall be loaded up to a maximum of seventy (70) metric tons; for billing purposes one full wagon shall be deemed equivalent to this volume.
+The price for last-mile delivery shall be determined once the cargo departs from the loading point and shall be communicated to the Client by official email upon the Client's request.
+Payments shall be made 100% in advance in USD.`,
+ ),
+ a(
+ "contract-documents",
+ "Contract Documents",
+ `The following documents form part of this contract:
+- This Contract Agreement.
+- Any amendments made to this Agreement.
+- Minutes of negotiation (if any).`,
+ ),
+ a(
+ "documentation",
+ "Documentation Requirements",
+ `The Service Provider shall deliver the following to the Client:
+- Freight Carriage Acceptance Sheet of the Addis Ababa–Djibouti Railway.
+- Notice of transportation and miscellaneous charges.
+- Summary of payment request as per the agreed tariff, if required.`,
+ ),
+ a(
+ "consignment-notes",
+ "Consignment Notes",
+ `The Service Provider shall certify the taking over of goods in the Freight Carriage Acceptance Sheet.
+This document shall serve as prima facie evidence of receipt of the cargo.
+Upon delivery of the cargo to the Client, the Cargo Handover Out Voucher signed by both parties shall serve as evidence of cargo receipt.`,
+ ),
+ a(
+ "termination",
+ "Termination of Contract",
+ `This contract may be terminated:
+- By mutual consent.
+- Upon completion of the agreed contract period or cargo volume.
+- For breach of fundamental provisions, with one-week prior written notice.`,
+ ),
+ a(
+ "effectiveness",
+ "Contract Effectiveness",
+ `This Agreement becomes effective on the date it is signed by both parties.`,
+ ),
+ a(
+ "duration",
+ "Duration",
+ `The contract is valid until August 31, {{contractYear}} from the date of effectiveness, extendable by mutual agreement.`,
+ ),
+ a(
+ "disputes",
+ "Settlement of Disputes",
+ `Disputes shall first be settled amicably.
+If unresolved, disputes shall be referred to the competent Federal Court of Ethiopia in Addis Ababa.
+The governing law shall be the laws of the Federal Democratic Republic of Ethiopia.`,
+ ),
+ ],
+};
+
+/* ────────────────────────────── EXPORT / BULK ────────────────────────────── */
+
+const EXPORT_BULK: ContractTemplateSeed = {
+ code: "EXPORT_BULK",
+ name: "Bulk Export Contract",
+ description:
+ "Export of bulk cargo (e.g. livestock) by railway from Ethiopian loading stations to Nagad railway freight yard, Djibouti.",
+ documentTitle: "Bulk Cargo Transportation Service by Railway",
+ whereasClauses: [
+ "The Client has agreed to deliver bulk cargo to the Service Provider for transport from the agreed Ethiopian loading station to Nagad railway freight yard using the Addis Ababa–Djibouti railway line.",
+ "The Service Provider has agreed to provide the service to transport the bulk cargo from the agreed loading station to Nagad railway freight yard.",
+ ],
+ articles: [
+ a(
+ "objective",
+ "Objective of the Service",
+ `To undertake the railway transportation of bulk cargo from the agreed Ethiopian loading station to Nagad railway freight yard.`,
+ ),
+ a(
+ "client-obligations",
+ "Obligations of the Client",
+ `Give written instruction to the Service Provider to transport a minimum of one wagon of cargo; the wagon request shall be made at least five (5) days in advance for each wagon.
+Maintain detailed information incorporating type, weight, and destination of the cargo ready for shipment, and notify the Service Provider or its nominated agent by notice, email, or fax.
+Prepare the necessary documents and facilities to make the cargo ready for transport.
+Note the allowable transport period of the cargo: the maximum time range during which the goods maintain their condition without any problem. The allowable transport period must be at least two (2) days longer than the delivery period.
+Ensure cargo is properly loaded and fastened in the wagons, provide the necessary lashing and barriers for loading as per the instruction of the departure station, and bear responsibility for the condition of the cargo during the transport period.
+Supply the necessary provisions for the cargo for each wagon and assign a responsible person to travel with the train to check the status of the cargo during transport, where the nature of the cargo so requires.
+Supply the minimum amount of cargo available for at least one wagon.
+Execute loading, lashing, and preparing barriers on wagons at the loading station and provide the complete documents/bill to the Service Provider within one (1) calendar day.
+For each extra calendar day used for loading cargo and completing documents at the loading station, pay the wagon-occupied fee per the pricing article; the fee shall be paid within ten (10) calendar days from the date the Service Provider claims it, failing which compensation is payable calculated on the basis of the Commercial Bank of Ethiopia interest rate for the delay period.
+Be responsible for safety matters, and indemnify and hold the Service Provider harmless against all consequences resulting from accidents arising from or associated with the loading and unloading process.
+Execute and cover the cost of loading and unloading of cargo at both the loading station and Nagad railway freight yard.
+Follow up that the cargo is loaded and unloaded on time.
+Delegate representatives at both ends to consign and receive cargo with signature and stamp. Representatives shall hold a duly signed and stamped power of attorney and shall produce their ID or passport when consigning or receiving the cargo.
+Prepare the necessary facilities to take over the transported cargo at Nagad freight yard upon arrival by issuing handover documents.
+Take the transported cargo out of the wagons at Nagad freight yard within one (1) calendar day starting from the day following the notice of arrival.
+Pay the wagon-occupied fee per the pricing article for delays of more than one (1) calendar day at Nagad railway freight yard due to the fault of the Client in resolving customs or third-party claims or any other causes.
+After the wagon list is submitted to the Client, if a wagon is not loaded due to the fault of the Client, pay 100% of the transportation price per wagon for each unloaded wagon.
+Pay the Service Provider 100% of the contract price in advance for each wagon.`,
+ ),
+ a(
+ "provider-obligations",
+ "Obligations of the Service Provider",
+ `Provide the list and identification numbers of wagons with sequence and locomotives at least twenty-four (24) hours in advance to the Client, with any correction at least twelve (12) hours before arrival at destination.
+Transport the cargo from the loading station to Nagad railway freight yard.
+Provide safe transportation of the cargo throughout the transit.
+Present customs clearance documents and mobilize the rolling stock as needed.
+Provide the wagons assigned for the freight at the agreed place and time, and follow up that the cargo is loaded on time.
+Transport and deliver the cargo taken over, in the condition received, within two (2) calendar days to Nagad railway freight yard.
+Where a wagon carrying cargo stops due to accident or mechanical problem, promptly notify the nearby customs station, police office, and the Client. A wagon stopped in Ethiopia due to mechanical defect shall be maintained within four (4) calendar days; within Nagad (Djibouti) territory within twelve (12) calendar days. In case of accident where the problem cannot be solved within one (1) calendar day and the wagon is not operational, the Service Provider shall have the cargo carried and delivered by another wagon, and shall provide an accident or defect report issued by the local police office regarding the sustained damage.
+Buy a cargo liability insurance policy for each supplied wagon.
+Provide wagon cleaning service and charge the cleaning fee based on actual expenditure.
+If the Client fails or refuses to receive the cargo beyond the allowable transport period, the Service Provider has the right to handle the cargo.
+Neither party shall be liable for any indirect or consequential loss sustained by the other in connection with this Agreement.`,
+ ),
+ a(
+ "force-majeure",
+ "Force Majeure",
+ `The parties have no obligation to pay demurrage or any other compensation if they have failed to discharge their obligations due to force majeure.
+Force majeure shall be deemed to exist when the contract is not performed due to any event beyond the reasonable control of a party which prevents that party from complying with its obligations under this Agreement, including but not limited to:
+- Acts of God (such as, but not limited to, fires, explosions, earthquakes, drought, tidal waves, and floods).
+- War, hostilities (whether war is declared or not), invasion, acts of foreign enemies, mobilization, requisition, or embargo.
+- Rebellion, revolution, insurrection, military or usurped power, or civil war.
+- Contamination by radioactivity from any nuclear fuel or nuclear waste.
+- Riot, commotion, strikes, go-slows, lockouts, or disorder.
+- Acts of terrorism.
+A party wishing to claim protection in respect of a force majeure event shall, as soon as possible following the occurrence or commencement of the event, notify the other party of its nature and expected duration, and shall thereafter keep the other party informed until it is able to perform its obligations under this Agreement.`,
+ ),
+ a(
+ "pricing",
+ "Contract Price and Terms of Payment",
+ `The price of bulk cargo transportation from the loading station to Nagad shall be USD 696 (six hundred ninety-six) per wagon.
+Payment for transport services shall be made in Birr based on the selling price of USD to Birr on the date of payment set by the Commercial Bank of Ethiopia.
+If there is an increment or decrement of the USD exchange rate to Birr between the date of payment and the date the wagon/train number is provided to the Client, either the Client shall make the additional payment to the Service Provider or the Service Provider shall refund the difference from the initial payment to the Client.
+The cost of loading at the loading station and unloading at Nagad shall be covered by the Client and is not part of this contract agreement.
+The Client shall pay 100% of the contract price in advance.
+The Client shall pay a demurrage fee for occupied wagons as follows:
+- Wagons occupied between 1 and 3 days: USD 193 per wagon per day.
+- Wagons occupied between 4 and 7 days: USD 290 per wagon per day.
+- Wagons occupied 8 days and above: USD 590 per wagon per day.
+Demurrage payment shall be made in Birr based on the selling price of USD to Birr set by the Commercial Bank of Ethiopia on the date of the demurrage occurrence.`,
+ ),
+ a(
+ "contract-documents",
+ "Contract Documents",
+ `The following documents shall constitute the contract between the Client and the Service Provider:
+- Amendments made to this contract (if any).
+- This Contract Agreement.
+- Final minutes of negotiation (if any).
+If there is any discrepancy between the documents, they shall be interpreted with priority in the order listed above.`,
+ ),
+ a(
+ "documentation",
+ "Documentation Requirements",
+ `The following documents shall be delivered to the Client upon request for settlement:
+- Consignment Note (cargo handover document to the Client).
+- Summary of payment request of the Service Provider prepared as per the agreed tariff.`,
+ ),
+ a(
+ "consignment-notes",
+ "Consignment Notes",
+ `The Service Provider must certify the taking over of the goods on the duplicates of the consignment note in an appropriate manner and return the duplicate to the Client.
+A consignment note shall be prima facie evidence of the receipt of the goods by the Service Provider and of the kind, number, and weight of the goods.`,
+ ),
+ a(
+ "termination",
+ "Termination of Contract",
+ `The contract may be terminated:
+- Upon mutual consent of the parties.
+- Upon completion of the contract period.
+- If either or both parties breach a fundamental provision of the contract, upon prior legal notice delivered by either party.`,
+ ),
+ a(
+ "effectiveness",
+ "Contract Effectiveness",
+ `The contract shall come into full force and effect on the date when all of the following are accomplished:
+- The contract is signed by the Client and the Service Provider.
+- The Service Provider has received the advance payment of 100% of the contract price for each train set of cargo.`,
+ ),
+ a(
+ "cargo-amount",
+ "Cargo Amount",
+ `The minimum cargo to be transported shall be one wagon.`,
+ ),
+ a(
+ "duration",
+ "Duration of Contract",
+ `The contract shall last for three (3) months starting from the date of contract signing, with possible extension upon mutual agreement.`,
+ ),
+ a(
+ "disputes",
+ "Settlement of Disputes",
+ `If a dispute arises between the parties, they shall exert efforts to settle their differences amicably.
+If the parties fail to settle their disputes amicably, the case shall be taken to the competent Federal Court of law presiding in Addis Ababa.
+The governing law shall be the laws of the Federal Democratic Republic of Ethiopia.`,
+ ),
+ ],
+};
+
+/* ──────────────────────────── INTERCITY / BULK ───────────────────────────── */
+
+const INTERCITY_BULK: ContractTemplateSeed = {
+ code: "INTERCITY_BULK",
+ name: "Bulk Intercity Contract",
+ description:
+ "Domestic (intercity) bulk cargo transportation by railway between Ethiopian freight yards, e.g. Dire Dawa to Sebeta.",
+ documentTitle: "Bulk Cargo Transportation Service by Railway (Intercity)",
+ whereasClauses: [
+ "The Client has requested the Service Provider to transport bulk cargo between the agreed Ethiopian railway freight yards using the Ethio–Djibouti Railway.",
+ "The Service Provider has accepted the Client's request to render the said transportation service.",
+ ],
+ articles: [
+ a(
+ "objective",
+ "Objective of the Contract",
+ `The Service Provider shall undertake the railway transportation of bulk cargo from the agreed origin railway freight yard to the agreed destination railway freight yard.`,
+ ),
+ a(
+ "client-obligations",
+ "Obligations of the Client",
+ `Provide written instructions to the Service Provider to transport a minimum of sixteen (16) wagons of cargo per consignment.
+Prepare all necessary documents, including laboratory tests from the pertinent organ and off-taking contract where applicable, and the facilities required to sign the contract and make the cargo ready for transport.
+Assign representatives at the origin yard and other stations, as required, to hand over the cargo to the Service Provider and handle transit clearance if required.
+Transport the cargo to the designated loading points at the origin yard.
+Be responsible for cargo handling: loading at the origin yard and unloading at the destination yard, in accordance with the standards set by the EDR operations and technical terms.
+Make advance payment to the Service Provider for services in accordance with the payment terms and conditions of this contract.
+Follow up to ensure that the cargo is loaded and unloaded on time.
+Delegate representatives at the cargo destination to immediately receive the transported cargo.
+Ensure representatives are duly authorized with a power of attorney, signed and stamped by the Client, and present valid identification (ID or passport) when consigning or receiving cargo.
+Maintain detailed information including item, weight, and destination of the cargo, and communicate the same to the Service Provider or its nominated agent via written notice, email, or fax.
+Prepare the necessary facilities to immediately take over the transported cargo at the destination upon arrival and provide sufficient trucks at the destination freight yard for unloading from railway wagons.
+Upon arrival of the train/wagon at the unloading site, sign the train arrival confirmation sheet to acknowledge the arrival time.
+Inspect the loaded wagons jointly with the Service Provider and EDR at the loading yard, and again with the customs agent (if required) and the Service Provider at the destination yard.
+After receiving the cargo, sign the Freight Carriage Acceptance Sheet (copies II, III, and IV) immediately to confirm delivery.
+Compensate the Service Provider or any third party for actual loss or damage caused to persons, property, or wagons during unloading where such damage is attributable to the Client's fault.
+Each consignment (train) shall be granted three (3) hours of free time at the loading station and one (1) day at the unloading station. For each additional 3 hours of loading or parking the Client shall pay ETB 5,000 (five thousand) per wagon, and for each additional day of unloading ETB 5,000 (five thousand) per wagon per day.
+Bear demurrage charges of ETB 5,000 (five thousand) per wagon per 3 hours for delays exceeding three (3) hours at any station resulting from the Client's failure to resolve customs or third-party claims.
+Pay 100% of the transport price in advance. Any additional charges or fees shall be paid within ten (10) calendar days after submission of the Service Provider's payment request.`,
+ ),
+ a(
+ "provider-obligations",
+ "Obligations of the Service Provider",
+ `Provide the necessary train(s) to execute the transportation service under this contract, and furnish the Client with the list and identification numbers of wagons and locomotives at least 24 hours in advance, with corrections (if any) communicated at least 12 hours before the expected time of arrival at destination.
+Provide pre-arrival notification including the train number to the discharging terminal and customs at least 24/12 hours before train arrival.
+Transport the cargo from origin to destination within two (2) days from completion of loading (time counting starts upon completion of documentation and loading).
+Provide safe transportation of the cargo throughout transit.
+Deliver the cargo to the Client at the destination railway freight yard in the same condition as received.
+Purchase a cargo liability insurance policy for each wagon transported.`,
+ ),
+ a(
+ "force-majeure",
+ "Force Majeure",
+ `Neither party shall be liable due to a force majeure event.
+For the purposes of this contract, force majeure shall mean any unforeseeable event or circumstance beyond the reasonable control of the affected party which absolutely prevents the performance of the contract, including but not limited to natural disasters, war, civil commotion, strikes, government actions, epidemics, or interruption of railway operations due to accidents or infrastructure failure.
+The affected party shall notify the other party in writing within a reasonable period not exceeding two (2) hours after the occurrence of the force majeure event, providing evidence and details of the impact on performance and the mitigating steps taken.`,
+ ),
+ a(
+ "liability",
+ "Liabilities Related to Damages and Losses",
+ `The Service Provider will be responsible for any loss, shortage, or damage occurring to the cargo it has received.`,
+ ),
+ a(
+ "pricing",
+ "Contract Price",
+ `The price for transporting cargo from the origin freight yard to the destination freight yard shall be USD 400 (four hundred) per wagon.
+Each wagon shall be loaded with a maximum of 70 (seventy) metric tons.
+Payment for transport services may be made in Ethiopian Birr, based on the Commercial Bank of Ethiopia's official selling exchange rate of USD to Birr on the date of payment.
+If the exchange rate changes between the payment and the wagon assignment date, payment adjustments will be made accordingly.
+The contract price shall include the cost of railway transportation from the origin freight yard to the destination freight yard.
+Excluded cost: cargo handling (loading and unloading) is not included in the contract price and shall remain the sole responsibility of the Client.`,
+ ),
+ a(
+ "contract-documents",
+ "Contract Documents",
+ `The following documents shall constitute the contract between the Client and the Service Provider:
+- Amendments made to this contract (if any).
+- This Contract Agreement.
+- Final minutes of negotiation (if any).
+If there is any discrepancy between the documents, they shall be interpreted with priority in the order listed above.`,
+ ),
+ a(
+ "documentation",
+ "Documentation Requirements",
+ `The following documents shall be delivered to the Client by the Service Provider to collect and settle payment:
+- Freight Carriage Acceptance Sheet of the Ethio-Djibouti Railway.
+- Notice of collecting transportation and miscellaneous charges of the Ethio-Djibouti Railway (if any).
+- Summary of payment request of the Service Provider prepared as per the agreed tariff.
+- Railway Waybill.`,
+ ),
+ a(
+ "consignment-notes",
+ "Consignment Notes",
+ `The Service Provider must certify the taking over of the goods on copy III (kept by the consignee for future reference) of the Freight Carriage Acceptance Sheet of the Ethio-Djibouti Railway in an appropriate manner and provide it to the Client.
+The Freight Carriage Acceptance Sheet shall be prima facie evidence of the receipt of the goods by the Service Provider and of the kind, number, and weight of the goods.`,
+ ),
+ a(
+ "termination",
+ "Termination of Contract",
+ `The contract may be terminated:
+- Upon mutual consent of the parties.
+- Upon completion of the contract period or amount of cargo, whichever comes first.
+- If either or both parties breach a fundamental provision of the contract, upon one-week prior legal notice delivered by either party.`,
+ ),
+ a(
+ "duration",
+ "Duration of Contract",
+ `The contract duration shall be three (3) months from the date of effectiveness of the contract, with possible extension upon mutual agreement of the parties.`,
+ ),
+ a(
+ "disputes",
+ "Settlement of Disputes",
+ `If a dispute arises between the parties, they shall exert efforts to settle their differences amicably.
+If the parties fail to settle their dispute amicably, the case shall be taken to the competent Federal Court of law presiding in Addis Ababa.
+The governing law shall be the laws of the Federal Democratic Republic of Ethiopia.`,
+ ),
+ a(
+ "effectiveness",
+ "Contract Effectiveness",
+ `The contract shall come into full force and effect on the date when the contract is signed by the parties and witnesses.`,
+ ),
+ ],
+};
+
+/* ──────────────────────────── IMPORT / CONTAINER ─────────────────────────── */
+
+const IMPORT_CONTAINER: ContractTemplateSeed = {
+ code: "IMPORT_CONTAINER",
+ name: "Container Import Contract",
+ description:
+ "Import container transport by railway from SGTD (Djibouti) to Dire Dawa, Modjo dry port, or Galaan Multipurpose Port, with empty-container return.",
+ documentTitle: "Import Container Transport Service by Railway",
+ whereasClauses: [
+ "The Client has requested and agreed to the transportation of container cargo from SGTD railway freight station at Djibouti to Dire Dawa, Modjo dry port, and Galaan Multipurpose Port (GMP), and the return of empty containers from Dire Dawa, Modjo dry port, and Galaan Multipurpose Port (GMP) to SGTD railway freight station using the Addis Ababa–Djibouti railway line.",
+ "The Service Provider has agreed to transport the container cargo as per the terms of this contract.",
+ ],
+ articles: [
+ a(
+ "objective",
+ "Objective and Scope of the Services",
+ `To provide railway transportation services for 40ft and/or 20ft full containers from SGTD to Dire Dawa, Modjo dry port, and/or Galaan Multipurpose Port (GMP), and empty container return from Dire Dawa, Modjo dry port, and Galaan Multipurpose Port (GMP) to SGTD.
+The scope of the services comprises:
+- Railway transport service.
+- Cargo handling at Galaan Multipurpose Port (GMP).`,
+ ),
+ a(
+ "client-obligations",
+ "Obligations of the Client",
+ `Give written/email/electronic shipment instructions to the Service Provider for transportation of container cargo from SGTD to Dire Dawa, Modjo dry port, and/or Galaan Multipurpose Port (GMP).
+Prepare all necessary documents and facilities for shipment.
+Ensure the following minimum supply of containers per shipment based on the loading terminal and destination:
+- Minimum of twenty-five (25) 40ft containers or fifty (50) 20ft containers to Modjo dry port.
+- Minimum of ten (10) 40ft containers or twenty (20) 20ft containers to Dire Dawa dry port.
+- Minimum of one (1) 40ft container or two (2) TEU to Galaan Multipurpose Port (GMP).
+One flat wagon must carry either one 40ft container or two 20ft containers.
+If two 20ft containers are loaded on one flat wagon, their weight difference must not exceed 10 tons.
+Ensure timely loading and unloading of cargo.
+Assign representatives at both ends to oversee container handover and ensure the necessary arrangements for cargo reception at the destination upon arrival.
+Maintain and provide detailed cargo information (type, weight, destination, etc.).
+Be responsible for cargo handling, loading, and unloading of both empty and full containers at Modjo, Dire Dawa dry port, and SGTD.
+Book wagons at least five (5) days in advance.
+Ensure containers are ready one day before the planned loading date.
+Submit all required documents to the Djibouti Nagad station at least 24 hours in advance before starting to load. Failure to submit the documents within the stipulated time shall result in the following demurrage charges, calculated as a percentage of the booked wagon price:
+- Delay of up to twelve (12) hours: 20% of the booked wagon price.
+- Delay exceeding twelve (12) hours but not more than one (1) day: 50% of the booked wagon price.
+- Delay of more than one (1) day: 100% of the booked wagon price.
+Collect the full container from Galaan Multipurpose Port (GMP) within three (3) calendar days from the day following the arrival notice.
+If the Client fails to collect the container within the specified period, the Service Provider shall have the right to reposition the container to any location it deems appropriate; in such case, the Service Provider shall not be held responsible for any damage or loss arising from such repositioning.
+If the Client fails to collect the container from Galaan Multipurpose Port within the specified period, the Client shall be liable to pay demurrage charges of 15 USD per day per 20ft container and 27 USD per day per 40ft container, calculated based on the Commercial Bank of Ethiopia's daily selling exchange rate on the date of payment.
+In the event the Client fails to collect the container(s) within the specified period, the Client shall be liable to pay double handling charges of 27 USD per 20ft container per handling or 40 USD per 40ft container per handling, calculated based on the Commercial Bank of Ethiopia's daily selling exchange rate on the date of payment.
+If empty containers cannot be offloaded from the train upon arrival at SGTD due to any Client-related issue, the Client shall be liable for the applicable penalty charges.
+Penalty charges for delay at SGTD/Nagad upon train arrival: 20 USD per day per 20ft container; 33 USD per day per 40ft container.
+Collect the containers within one day at Dire Dawa and Modjo dry port, or make the necessary payment to the dry port as per the standard of the dry port.
+For returning empty containers, deliver to Dire Dawa dry port, Modjo dry port, or Galaan Multipurpose Port.
+Once the empty containers are returned from the Client's premises and stored at Dire Dawa/Modjo dry port while awaiting train allocation for return to SGTD, any demurrage and/or storage charges incurred from the dry port thereafter shall not be the responsibility or liability of the Service Provider; the Client shall be solely responsible for settling such charges.
+Provide clean empty containers that meet SGTD standards. If the port refuses to take over an empty container because of inside cleanliness problems, additional cleaning costs incurred due to non-compliance will be borne by the Client.
+Ensure containers are structurally intact and meet weight distribution requirements.
+Prohibited cargo: cargo covered with tarpaulin is not allowed due to safety risks.
+Notify the Service Provider forty-eight (48) hours in advance before wagon booking if transporting hazardous or valuable goods.
+If a booked wagon is not loaded due to Client-related issues, including but not limited to a damaged container, missing lock, unpaid demurrage, port system errors, or incomplete documentation and submission, the Client shall be charged 100% of the total price of the reserved wagon.
+Refund requests before wagon booking require an official request, with a 3% administrative fee deducted. If the refund is due to the Service Provider, the Client shall receive a full refund. Refunds not requested and completed within six months shall be considered waived.
+Pay 100% of the transportation fee in advance for each train set.
+Settle additional penalties due to non-compliance within ten (10) days of invoice issuance.
+Late payment incurs a penalty of an additional 10%.`,
+ ),
+ a(
+ "provider-obligations",
+ "Obligations of the Service Provider",
+ `Assign the necessary voyage based on the operational schedule and cargo demand, and notify the train schedule 48 hours in advance.
+Provide a list of wagons/voyage or train number 24 hours in advance and update corrections 12 hours before arrival.
+Provide safe transportation of the containers.
+Deliver the cargo within two (2) days after train departure, provided that all required documents are submitted on time and no unforeseen circumstances or events occur.
+Return empty containers from Dire Dawa, Modjo, and Galaan Multipurpose Port to SGTD within seven (7) calendar days of receipt.
+In the event of export cargo operations, the Service Provider may prioritize the loading of export containers during the loading of empty containers and the unloading of import containers from the train at Galaan Multipurpose Port.
+The Service Provider reserves the right to refuse the transportation of any cargo classified as dangerous goods.
+If any operational, technical, or mechanical problem occurs throughout the transit, notify customs and arrange cargo transfer within 4 days if the incident occurs in Ethiopia, or within 6 days if it occurs in Djibouti.
+Provide accident or defect reports if needed.
+Buy cargo liability insurance for each wagon.`,
+ ),
+ a(
+ "force-majeure",
+ "Force Majeure",
+ `Neither party shall be liable for delays or non-performance caused by force majeure events beyond their reasonable control.
+Force majeure shall be interpreted in accordance with the Ethiopian Civil Code.`,
+ ),
+ a(
+ "pricing",
+ "Contract Price and Terms of Payment",
+ `From SGTD to Dire Dawa dry port, the rate is USD 919 per one 40ft or USD 942 per two 20ft containers with empty return; USD 762 per one 40ft or USD 780 per two 20ft containers without empty return.
+From SGTD to Modjo, the rate is USD 1,781 per one 40ft or USD 1,808 per two 20ft containers with empty return, and USD 1,507 per one 40ft or two 20ft containers without empty return.
+From SGTD to Galaan Multipurpose Port, the rate is USD 1,916 per one 40ft or USD 1,944 per two 20ft containers with empty return, and USD 1,676 per one 40ft or USD 1,690 per two 20ft containers without empty return.
+If cargo exceeds 40 tons per two 20ft containers of gross weight, additional charges apply proportionally.
+Gross weight shall be the total sum of cargo, packing, and container tare weight.
+Payment for any additional tonnage shall be made in advance before the container is loaded onto the wagon.
+The price of loading and unloading and container handling at Modjo, Dire Dawa dry port, and SGTD container railway freight yard is not part of this contract; it is the Client's responsibility.
+Additional costs (if applicable):
+- Last-mile delivery service by truck from Galaan Multipurpose Port or Modjo to Addis Ababa or Modjo and surrounding areas shall incur an additional cost, fully covered by the Client.
+- For clients utilizing EDR's last-mile logistics services, the applicable charges shall vary based on the cargo movement route.
+- The charge for last-mile delivery from Galaan Multipurpose Port and Modjo dry port shall be communicated to the Client by the Service Provider after receiving the necessary details regarding the cargo destination, type, and weight.
+All payments shall be made one hundred percent (100%) in advance in United States Dollars (USD).`,
+ ),
+ a(
+ "contract-documents",
+ "Contract Documents",
+ `The following documents constitute this contract:
+- Amendments (if any).
+- This Contract Agreement.
+- Final minutes of negotiation (if any).
+If there is any discrepancy between the documents, they shall be interpreted with priority in the order listed above.`,
+ ),
+ a(
+ "documentation",
+ "Documentation Requirements",
+ `Equipment Interchange Receipt of SGTD, Railway Waybill, Container Carriage Acceptance Sheet, and incidental charges (if any).
+Payment summary as per the agreed contract price (if required).`,
+ ),
+ a(
+ "consignment-notes",
+ "Consignment Notes",
+ `The Service Provider must certify the taking over and handing over of the container cargo on the Freight Carriage Acceptance Sheet of EDR in an appropriate manner and provide it to the Client.
+The Freight Carriage Acceptance Sheet shall be prima facie evidence of the receipt of the container cargo by the Service Provider and of the kind, number, and weight of the goods.
+Upon delivery of the cargo to the Client, the Cargo Handover Out Voucher signed by both parties shall serve as evidence of cargo receipt.`,
+ ),
+ a(
+ "amendment",
+ "Amendment",
+ `This contract can be amended by mutual agreement.
+Notwithstanding the above, the Service Provider may revise transport tariffs due to operational and regulatory changes by providing at least five (5) working days' prior written notice to the Client.`,
+ ),
+ a(
+ "termination",
+ "Termination of Contract",
+ `The contract may be terminated:
+- By mutual agreement.
+- Upon completion of the contract period or agreed cargo shipments.
+- If either party breaches fundamental terms.`,
+ ),
+ a(
+ "effectiveness",
+ "Contract Effectiveness",
+ `The contract is valid once signed by both parties and witnesses.`,
+ ),
+ a(
+ "duration",
+ "Contract Period",
+ `Valid until August 31, {{contractYear}}, with a possible extension upon mutual agreement.`,
+ ),
+ a(
+ "disputes",
+ "Settlement of Disputes",
+ `Disputes shall be settled amicably.
+If unresolved, disputes shall be taken to the Federal Court in Addis Ababa.`,
+ ),
+ ],
+};
+
+/* ──────────────────────────── EXPORT / CONTAINER ─────────────────────────── */
+
+const EXPORT_CONTAINER: ContractTemplateSeed = {
+ code: "EXPORT_CONTAINER",
+ name: "Container Export Contract",
+ description:
+ "Export container transport, freight forwarding, and customs clearing from Galaan Multipurpose Port or Modjo dry port to SGTD container freight station (Djibouti).",
+ documentTitle: "Export Container Transport, Freight Forwarding and Customs Clearing Service",
+ whereasClauses: [
+ "The parties have agreed on the following services: rail transport, customs clearance, transit work, freight forwarding, and handling of container cargo.",
+ ],
+ articles: [
+ a(
+ "objective",
+ "Objective and Scope of the Services",
+ `Customs clearance (Ethiopia side):
+- Processing of export declarations.
+- Coordination with the Ethiopian Customs Authority for clearance.
+- Ensuring compliance with all export regulations.
+Rail transport:
+- Transportation of containers from Galaan Multipurpose Port (GMP) or Modjo dry port to SGTD container freight station.
+Djibouti transit and handling:
+- Customs clearance in Djibouti.
+- Coordination with Djibouti port and transit authorities.
+- Freight forwarding and last-mile facilitation as required.
+Excluded costs:
+- Shore handling.
+- Shifting of containers from SGTD to DMP or DMP to SGTD port.`,
+ ),
+ a(
+ "client-obligations",
+ "Obligations of the Client",
+ `Give written/email instructions to the Service Provider for transportation of containers from Galaan Multipurpose Port (GMP) and/or Modjo to Djibouti.
+Supply a minimum of two (2) 20ft containers (or an equivalent load to fill one flat wagon).
+Submit all forwarding service booking requests at least seventy-two (72) hours prior to the scheduled train departure and no later than 7 days before the vessel cut-off time, whichever is applicable.
+For clients requiring first-mile service, submit a first-mile service request notice no less than seventy-two (72) hours in advance.
+Complete and submit accurate export documents as per the request of the Service Provider; payment must be submitted at least 36 hours before train departure.
+Deliver all cargo to the designated loading port or freight station at least three (3) hours prior to the scheduled train loading time.
+Failure to meet the stated deadlines may result in cancellation of the booking and transfer arrangements; any resulting delays, penalties, or additional costs shall be the sole responsibility of the Client.
+If the Client fails to deliver the container, fails to provide the requested documents for completing export documents as instructed above, or cancels after wagon reservation, the Client shall pay USD 150.00 per wagon as a penalty, after notification.
+Containers must have four (4) undamaged corners.
+One flat wagon must carry either one 40ft container or two 20ft containers.
+If two 20ft containers are loaded on one flat wagon, their weight difference must not exceed 10 tons.
+The gross weight of the container must not exceed the standard loading capacity indicated on the container; the Client is responsible for ensuring full compliance with the maximum allowable load.
+Prohibited cargo: cargo covered with tarpaulin is not allowed due to safety risks.
+If the cargo to be transported is dangerous and/or valuable goods, notify the Service Provider 48 (forty-eight) hours before the wagon booking for further discussion and decision.
+Refund requests before wagon booking require an official request, with a 3% administrative fee deducted. If the refund is due to the Service Provider, the Client shall receive a full refund. Refunds not requested and completed within six months shall be considered waived.
+Any delay caused by missing or incorrect documents shall be the Client's responsibility.
+100% of the transportation and customs clearance fee must be paid in advance.`,
+ ),
+ a(
+ "provider-obligations",
+ "Obligations of the Service Provider",
+ `Complete gate pass processing and submit to Nagad Station for each shipment within eighteen (18) hours after train departure.
+The Service Provider reserves the right to refuse the transportation of any cargo classified as dangerous goods.
+Maintain cargo liability insurance for railway transport; additional insurance for port handling or last-mile transport shall be the Client's responsibility.
+The Service Provider is not liable for customs penalties or demurrage due to delays beyond its control.
+Notify the Client immediately, in writing, of any delays, port issues, or customs holds.
+The Service Provider shall not be liable for:
+- Inherent defects of the cargo.
+- Improper packing or loading conducted by the Client.
+- Customs-related delays.
+- Delays caused by force majeure events.`,
+ ),
+ a(
+ "force-majeure",
+ "Force Majeure",
+ `Neither party shall be liable for delays or non-performance caused by force majeure events beyond their reasonable control.
+Force majeure shall be interpreted in accordance with the Ethiopian Civil Code.`,
+ ),
+ a(
+ "pricing",
+ "Pricing and Payment Terms",
+ `Railway transportation charges from GMP to SGTD: USD 819 (eight hundred nineteen) per 40ft container; USD 834 (eight hundred thirty-four) per two (2) 20ft containers.
+Railway transportation charges from Modjo to SGTD: USD 725 (seven hundred twenty-five) per 40ft container; USD 725 (seven hundred twenty-five) per two (2) 20ft containers.
+Where the total cargo weight exceeds fifty (50) metric tons per two (2) 20ft containers, an additional charge of USD 10 (ten) shall apply for each excess metric ton.
+Freight forwarding and customs clearance charges from GMP to SGTD: USD 540 (five hundred forty) per 40ft container; USD 349 (three hundred forty-nine) per 20ft container.
+Freight forwarding and customs clearance charges from Modjo to SGTD: USD 569 (five hundred sixty-nine) per 40ft container; USD 389 (three hundred eighty-nine) per 20ft container.
+For consolidated containers containing more than one (1) shipping document, the first document shall be included under the agreed contract rate; any additional document within the same container shall be subject to an extra charge of USD 50 per document.
+Payment must be supported by an official receipt before cargo departs from Galaan Multipurpose Port/Modjo.
+If the Client uses PIL Shipping Line, any local charge incurred will be covered by the Client as per the invoice issued by the shipping line.
+If storage or demurrage occurs due to Client-related issues (delay in document submission, payment delay, or any other Client-related reason), the Client shall pay the corresponding charges; charges apply per day after the free storage period, based on the invoice and SGTD tariff.
+During export season, EDR may provide seasonal export support through the facilitation of empty containers.
+Additional costs (if applicable):
+- First-mile delivery service by truck within Addis Ababa or Modjo and surrounding areas, originating from warehouses or any other places designated by the Client, shall incur an additional cost fully covered by the Client.
+- For clients utilizing EDR's first- or last-mile logistics services, the applicable charges shall vary based on the cargo movement route.
+- The charge for first-mile delivery to Galaan Multipurpose Port and Modjo dry port shall be communicated to the Client by the Service Provider after receiving the necessary details regarding the cargo origin, type, and weight.
+- For any vessel outbound charges, IMO charges, or other fees not included in the port handling payment, the Service Provider shall request the Client to settle the required amount based on the official receipt issued by the port or the shipping line.
+Payment terms:
+- All charges, including rail transport and customs clearance charges, remain 100% payable in advance.
+- Payments shall be calculated based on the Commercial Bank of Ethiopia's daily selling exchange rate on the date the wagon or train number is provided.
+- If the exchange rate changes between the payment and the wagon assignment date, adjustments will be made accordingly.
+- Any additional costs incurred due to customs issues or port delays shall be borne by the Client and paid based on actual costs, supported by official receipts, within 10 days.
+- Late payment incurs a penalty of 10%.`,
+ ),
+ a(
+ "contract-documents",
+ "Contract Documents",
+ `The following documents shall constitute the contract between the Client and the Service Provider:
+- Any amendments made to this contract (if applicable).
+- This Contract Agreement.
+- Final minutes of negotiation (if applicable).
+In the event of any discrepancy between these documents, they shall be interpreted with priority in the order listed above.`,
+ ),
+ a(
+ "documentation",
+ "Documentation Requirements",
+ `Consignment Note (cargo handover document).
+Payment summary prepared as per the agreed tariff, if required.`,
+ ),
+ a(
+ "consignment-notes",
+ "Consignment Notes",
+ `The Service Provider must certify the taking over and handing over of the container cargo on the Freight Carriage Acceptance Sheet of EDR in an appropriate manner and provide it to the Client.
+The Freight Carriage Acceptance Sheet shall be prima facie evidence of the receipt of the container cargo by the Service Provider and of the kind, number, and weight of the goods.
+Upon delivery of the cargo to the Client, the Cargo Handover Out Voucher signed by both parties shall serve as evidence of cargo receipt.`,
+ ),
+ a(
+ "amendment",
+ "Amendment",
+ `This contract can be amended by mutual agreement.
+Notwithstanding the above, the Service Provider may revise transport tariffs due to operational and regulatory changes by providing at least five (5) working days' prior written notice to the Client.`,
+ ),
+ a(
+ "termination",
+ "Termination of Contract",
+ `The contract may be terminated:
+- By mutual agreement.
+- Upon completion of the contract period or agreed cargo shipments.
+- If either party breaches fundamental terms.
+If terminated for cause, the terminating party must issue a 15-day written notice specifying the breach and allow an opportunity to cure, if applicable.`,
+ ),
+ a(
+ "effectiveness",
+ "Contract Effectiveness",
+ `The contract is valid once signed by both parties and witnesses.`,
+ ),
+ a(
+ "duration",
+ "Contract Period",
+ `Valid until August 31, {{contractYear}}, with a possible extension upon mutual agreement.`,
+ ),
+ a(
+ "disputes",
+ "Settlement of Disputes",
+ `Disputes shall be settled amicably.
+If amicable settlement fails, disputes shall be submitted to the Federal Court located in Addis Ababa.
+The signatories confirm that they are fully authorized to sign and execute this Contract Agreement; the power of attorney of the signatories for the parties is enclosed with this contract agreement.`,
+ ),
+ ],
+};
+
+/* ─────────────────────────── INTERCITY / CONTAINER ───────────────────────── */
+
+const INTERCITY_CONTAINER: ContractTemplateSeed = {
+ code: "INTERCITY_CONTAINER",
+ name: "Container Intercity Contract",
+ description:
+ "Domestic (intercity) container transport by railway between Ethiopian terminals — Galaan Multipurpose Port, Modjo dry port, and Dire Dawa — including empty repositioning.",
+ documentTitle: "Intercity Container Transport Service by Railway",
+ whereasClauses: [
+ "The Client has requested and agreed to the transportation of container cargo between the agreed Ethiopian railway terminals (Galaan Multipurpose Port (GMP), Modjo dry port, and Dire Dawa), including the repositioning of empty containers between those terminals, using the Addis Ababa–Djibouti railway line within Ethiopia.",
+ "The Service Provider has agreed to transport the container cargo as per the terms of this contract.",
+ ],
+ articles: [
+ a(
+ "objective",
+ "Objective and Scope of the Services",
+ `To provide domestic railway transportation services for 40ft and/or 20ft full containers between the agreed Ethiopian terminals (Galaan Multipurpose Port (GMP), Modjo dry port, and Dire Dawa), and the repositioning of empty containers between those terminals.
+The scope of the services comprises:
+- Railway transport service between the agreed origin and destination terminals.
+- Cargo handling at Galaan Multipurpose Port (GMP).`,
+ ),
+ a(
+ "client-obligations",
+ "Obligations of the Client",
+ `Give written/email/electronic shipment instructions to the Service Provider for transportation of container cargo between the agreed terminals.
+Prepare all necessary documents and facilities for shipment.
+Ensure the minimum supply of containers per shipment agreed with the Service Provider for the selected loading terminal and destination.
+One flat wagon must carry either one 40ft container or two 20ft containers.
+If two 20ft containers are loaded on one flat wagon, their weight difference must not exceed 10 tons.
+Ensure timely loading and unloading of cargo.
+Assign representatives at both ends to oversee container handover and ensure the necessary arrangements for cargo reception at the destination upon arrival.
+Maintain and provide detailed cargo information (type, weight, destination, etc.).
+Be responsible for cargo handling, loading, and unloading of both empty and full containers at Modjo and Dire Dawa dry port.
+Book wagons at least five (5) days in advance.
+Ensure containers are ready one day before the planned loading date.
+Collect the full container from Galaan Multipurpose Port (GMP) within three (3) calendar days from the day following the arrival notice.
+If the Client fails to collect the container within the specified period, the Service Provider shall have the right to reposition the container to any location it deems appropriate; in such case, the Service Provider shall not be held responsible for any damage or loss arising from such repositioning.
+If the Client fails to collect the container from Galaan Multipurpose Port within the specified period, the Client shall be liable to pay demurrage charges of 15 USD per day per 20ft container and 27 USD per day per 40ft container, calculated based on the Commercial Bank of Ethiopia's daily selling exchange rate on the date of payment.
+In the event the Client fails to collect the container(s) within the specified period, the Client shall be liable to pay double handling charges of 27 USD per 20ft container per handling or 40 USD per 40ft container per handling.
+Collect the containers within one day at Dire Dawa and Modjo dry port, or make the necessary payment to the dry port as per the standard of the dry port.
+Once empty containers are returned from the Client's premises and stored at a dry port while awaiting train allocation, any demurrage and/or storage charges incurred from the dry port thereafter shall be the sole responsibility of the Client.
+Provide clean empty containers that meet the receiving terminal's standards; additional cleaning costs incurred due to non-compliance will be borne by the Client.
+Ensure containers are structurally intact and meet weight distribution requirements.
+Prohibited cargo: cargo covered with tarpaulin is not allowed due to safety risks.
+Notify the Service Provider forty-eight (48) hours in advance before wagon booking if transporting hazardous or valuable goods.
+If a booked wagon is not loaded due to Client-related issues, including but not limited to a damaged container, missing lock, unpaid demurrage, port system errors, or incomplete documentation and submission, the Client shall be charged 100% of the total price of the reserved wagon.
+Refund requests before wagon booking require an official request, with a 3% administrative fee deducted. If the refund is due to the Service Provider, the Client shall receive a full refund. Refunds not requested and completed within six months shall be considered waived.
+Pay 100% of the transportation fee in advance for each train set.
+Settle additional penalties due to non-compliance within ten (10) days of invoice issuance.
+Late payment incurs a penalty of an additional 10%.`,
+ ),
+ a(
+ "provider-obligations",
+ "Obligations of the Service Provider",
+ `Assign the necessary voyage based on the operational schedule and cargo demand, and notify the train schedule 48 hours in advance.
+Provide a list of wagons/voyage or train number 24 hours in advance and update corrections 12 hours before arrival.
+Provide safe transportation of the containers.
+Deliver the cargo within two (2) days after train departure, provided that all required documents are submitted on time and no unforeseen circumstances or events occur.
+In the event of export cargo operations, the Service Provider may prioritize the loading of export containers during the loading of empty containers and the unloading of containers from the train at Galaan Multipurpose Port.
+The Service Provider reserves the right to refuse the transportation of any cargo classified as dangerous goods.
+If any operational, technical, or mechanical problem occurs throughout the transit, notify the Client and the relevant authorities and arrange cargo transfer within four (4) days.
+Provide accident or defect reports if needed.
+Buy cargo liability insurance for each wagon.`,
+ ),
+ a(
+ "force-majeure",
+ "Force Majeure",
+ `Neither party shall be liable for delays or non-performance caused by force majeure events beyond their reasonable control.
+Force majeure shall be interpreted in accordance with the Ethiopian Civil Code.`,
+ ),
+ a(
+ "pricing",
+ "Contract Price and Terms of Payment",
+ `The applicable rate per 40ft container or per two (2) 20ft containers for the agreed route shall be as per the prevailing EDR domestic container tariff, as set out in the commercial schedule of this contract.
+If cargo exceeds 40 tons per two 20ft containers of gross weight, additional charges apply proportionally.
+Gross weight shall be the total sum of cargo, packing, and container tare weight.
+Payment for any additional tonnage shall be made in advance before the container is loaded onto the wagon.
+The price of loading and unloading and container handling at Modjo and Dire Dawa dry port is not part of this contract; it is the Client's responsibility.
+Additional costs (if applicable):
+- Last-mile delivery service by truck from the destination terminal to the Client's premises shall incur an additional cost, fully covered by the Client.
+- For clients utilizing EDR's last-mile logistics services, the applicable charges shall vary based on the cargo movement route and shall be communicated to the Client by the Service Provider after receiving the necessary details regarding the cargo destination, type, and weight.
+All payments shall be made one hundred percent (100%) in advance.
+Payment may be made in Ethiopian Birr based on the Commercial Bank of Ethiopia's daily selling exchange rate on the date the wagon or train number is provided; if the exchange rate changes between the payment and the wagon assignment date, adjustments will be made accordingly.`,
+ ),
+ a(
+ "contract-documents",
+ "Contract Documents",
+ `The following documents constitute this contract:
+- Amendments (if any).
+- This Contract Agreement.
+- Final minutes of negotiation (if any).
+If there is any discrepancy between the documents, they shall be interpreted with priority in the order listed above.`,
+ ),
+ a(
+ "documentation",
+ "Documentation Requirements",
+ `Equipment Interchange Receipt, Railway Waybill, Container Carriage Acceptance Sheet, and incidental charges (if any).
+Payment summary as per the agreed contract price (if required).`,
+ ),
+ a(
+ "consignment-notes",
+ "Consignment Notes",
+ `The Service Provider must certify the taking over and handing over of the container cargo on the Freight Carriage Acceptance Sheet of EDR in an appropriate manner and provide it to the Client.
+The Freight Carriage Acceptance Sheet shall be prima facie evidence of the receipt of the container cargo by the Service Provider and of the kind, number, and weight of the goods.
+Upon delivery of the cargo to the Client, the Cargo Handover Out Voucher signed by both parties shall serve as evidence of cargo receipt.`,
+ ),
+ a(
+ "amendment",
+ "Amendment",
+ `This contract can be amended by mutual agreement.
+Notwithstanding the above, the Service Provider may revise transport tariffs due to operational and regulatory changes by providing at least five (5) working days' prior written notice to the Client.`,
+ ),
+ a(
+ "termination",
+ "Termination of Contract",
+ `The contract may be terminated:
+- By mutual agreement.
+- Upon completion of the contract period or agreed cargo shipments.
+- If either party breaches fundamental terms.`,
+ ),
+ a(
+ "effectiveness",
+ "Contract Effectiveness",
+ `The contract is valid once signed by both parties and witnesses.`,
+ ),
+ a(
+ "duration",
+ "Contract Period",
+ `Valid until August 31, {{contractYear}}, with a possible extension upon mutual agreement.`,
+ ),
+ a(
+ "disputes",
+ "Settlement of Disputes",
+ `Disputes shall be settled amicably.
+If unresolved, disputes shall be taken to the Federal Court in Addis Ababa.`,
+ ),
+ ],
+};
+
+export const CONTRACT_TEMPLATE_DEFAULTS: ContractTemplateSeed[] = [
+ IMPORT_BULK,
+ EXPORT_BULK,
+ INTERCITY_BULK,
+ IMPORT_CONTAINER,
+ EXPORT_CONTAINER,
+ INTERCITY_CONTAINER,
+];
diff --git a/apps/edr-freight-api/src/seed/demo-bookings.seeder.ts b/apps/edr-freight-api/src/seed/demo-bookings.seeder.ts
index 570036f24..3720c0e2a 100644
--- a/apps/edr-freight-api/src/seed/demo-bookings.seeder.ts
+++ b/apps/edr-freight-api/src/seed/demo-bookings.seeder.ts
@@ -504,8 +504,6 @@ export class DemoBookingsSeeder {
wagonTypeId: nw5.id,
trainId: null,
sequenceNumber: null,
- tareWeight: 20,
- maxPayloadWeight: 70,
status: WagonStatus.Available,
currentYardId: index % 2 === 0 ? djibouti.id : addis.id,
notes: "Demo wagon for train scheduling",
diff --git a/apps/edr-freight-api/src/seed/demo-freight-data.seeder.ts b/apps/edr-freight-api/src/seed/demo-freight-data.seeder.ts
index da2da818f..45c374332 100644
--- a/apps/edr-freight-api/src/seed/demo-freight-data.seeder.ts
+++ b/apps/edr-freight-api/src/seed/demo-freight-data.seeder.ts
@@ -76,15 +76,11 @@ export class DemoFreightDataSeeder {
}
const toCreate = MIN_WAGONS_PER_TYPE - existing;
- const tare = Number(type.tareWeightTons ?? 20);
- const maxPayload = Number(type.capacityTons ?? 60);
const rows = Array.from({ length: toCreate }, (_, i) => {
const seq = existing + i + 1;
return wagonRepo.create({
wagonNumber: `${type.code}-${String(seq).padStart(4, '0')}`,
wagonTypeId: type.id,
- tareWeight: tare,
- maxPayloadWeight: maxPayload,
status: WagonStatus.Available,
});
});
diff --git a/apps/edr-freight-api/src/seed/file-upload-settings.seeder.ts b/apps/edr-freight-api/src/seed/file-upload-settings.seeder.ts
index 1aef33801..99dae5974 100644
--- a/apps/edr-freight-api/src/seed/file-upload-settings.seeder.ts
+++ b/apps/edr-freight-api/src/seed/file-upload-settings.seeder.ts
@@ -33,8 +33,9 @@ const ETHIOPIAN_ONBOARDING_FIELDS: OnboardingField[] = [
},
{
fileKey: "commercial_license",
- fileLabel: "Commercial License",
- helpText: "Verified against the government trade system during registration.",
+ fileLabel: "Commercial Registration",
+ helpText:
+ "Verified against the government trade system during registration.",
isRequired: true,
isMultiple: false,
maxFiles: 1,
@@ -108,7 +109,8 @@ const LEGACY_ONBOARDING_FIELDS: OnboardingField[] = [
{
fileKey: "business_license",
fileLabel: "Business License / Trade License",
- helpText: "Verified against the government trade system during registration.",
+ helpText:
+ "Verified against the government trade system during registration.",
isRequired: true,
isMultiple: false,
maxFiles: 1,
@@ -489,9 +491,14 @@ const SELF_CLEARANCE_SETTINGS: OnboardingDocumentSetting[] = [
const CONTRACT_INTAKE_ENTITY = "contract_intake";
const CONTRACT_INTAKE_FIELDS: OnboardingField[] = [
- clearanceField("commercial_framework", "Commercial Framework / Agreement", 1, {
- required: false,
- }),
+ clearanceField(
+ "commercial_framework",
+ "Commercial Framework / Agreement",
+ 1,
+ {
+ required: false,
+ },
+ ),
clearanceField("onboarding_attachment", "Onboarding Attachment", 2, {
required: false,
}),
@@ -542,7 +549,7 @@ const DRIVER_DOCUMENT_SETTINGS: OnboardingDocumentSetting[] = [
export class FileUploadSettingsSeeder {
private readonly logger = new Logger(FileUploadSettingsSeeder.name);
- constructor(private readonly dataSource: DataSource) {}
+ constructor(private readonly dataSource: DataSource) { }
async run() {
await this.dataSource.transaction(async (manager) => {
@@ -552,35 +559,35 @@ export class FileUploadSettingsSeeder {
const allSettings: Array<
OnboardingDocumentSetting & { description: string }
> = [
- ...COMPANY_ONBOARDING_DOCUMENTS.map((s) => ({
- ...s,
- description: COMPANY_ONBOARDING_DESCRIPTION,
- })),
- ...CLEARANCE_DOCUMENT_SETTINGS.map((s) => ({
- ...s,
- description: CLEARANCE_DESCRIPTION,
- })),
- ...CONTRACT_CLEARANCE_SETTINGS.map((s) => ({
- ...s,
- description:
- "Pre-booking clearance documents collected on the contract (Path B), by operation and freight type.",
- })),
- ...SELF_CLEARANCE_SETTINGS.map((s) => ({
- ...s,
- description:
- "Customer self-clearance documents (Path A, no EDR customs service), reviewed by Operations.",
- })),
- ...CONTRACT_INTAKE_SETTINGS.map((s) => ({
- ...s,
- description:
- "Commercial/framework documents attached at contract submission.",
- })),
- ...DRIVER_DOCUMENT_SETTINGS.map((s) => ({
- ...s,
- description:
- "Documents uploaded against a driver profile (license, ID, contracts, etc.).",
- })),
- ];
+ ...COMPANY_ONBOARDING_DOCUMENTS.map((s) => ({
+ ...s,
+ description: COMPANY_ONBOARDING_DESCRIPTION,
+ })),
+ ...CLEARANCE_DOCUMENT_SETTINGS.map((s) => ({
+ ...s,
+ description: CLEARANCE_DESCRIPTION,
+ })),
+ ...CONTRACT_CLEARANCE_SETTINGS.map((s) => ({
+ ...s,
+ description:
+ "Pre-booking clearance documents collected on the contract (Path B), by operation and freight type.",
+ })),
+ ...SELF_CLEARANCE_SETTINGS.map((s) => ({
+ ...s,
+ description:
+ "Customer self-clearance documents (Path A, no EDR customs service), reviewed by Operations.",
+ })),
+ ...CONTRACT_INTAKE_SETTINGS.map((s) => ({
+ ...s,
+ description:
+ "Commercial/framework documents attached at contract submission.",
+ })),
+ ...DRIVER_DOCUMENT_SETTINGS.map((s) => ({
+ ...s,
+ description:
+ "Documents uploaded against a driver profile (license, ID, contracts, etc.).",
+ })),
+ ];
for (const documentSetting of allSettings) {
await settingRepository.upsert(
@@ -601,7 +608,9 @@ export class FileUploadSettingsSeeder {
});
if (!setting) {
- throw new Error(`file_upload_setting_seed_failed:${documentSetting.code}`);
+ throw new Error(
+ `file_upload_setting_seed_failed:${documentSetting.code}`,
+ );
}
await fieldRepository.delete({ settingId: setting.id });
diff --git a/apps/edr-freight-api/src/seed/freight-permissions.registry.ts b/apps/edr-freight-api/src/seed/freight-permissions.registry.ts
index 8d70bc61c..e281e6464 100644
--- a/apps/edr-freight-api/src/seed/freight-permissions.registry.ts
+++ b/apps/edr-freight-api/src/seed/freight-permissions.registry.ts
@@ -131,6 +131,7 @@ export const CUSTOMER_PERMISSIONS: FreightPermissionSeed[] = [
perm('d1a00001-0001-4000-8000-000000000003', 'edr_freight_app:customers:update', 'Update customer'),
perm('d1a00001-0001-4000-8000-000000000004', 'edr_freight_app:customers:deactivate', 'Deactivate customer'),
perm('d1a00001-0001-4000-8000-000000000005', 'edr_freight_app:customers:verify', 'Verify customer (KYC/Fayda)'),
+ perm('d1a00001-0001-4000-8000-000000000006', 'edr_freight_app:customers:reset-password', 'Trigger customer password reset'),
];
// D. Finance — payments + invoices
@@ -395,6 +396,7 @@ export const FREIGHT_PERMS = {
update: 'edr_freight_app:customers:update',
deactivate: 'edr_freight_app:customers:deactivate',
verify: 'edr_freight_app:customers:verify',
+ resetPassword: 'edr_freight_app:customers:reset-password',
},
payments: {
view: 'edr_freight_app:payments:view',
@@ -662,9 +664,13 @@ export const ROLE_PERMISSION_PRESETS = {
FREIGHT_PERMS.fleet.view,
FREIGHT_PERMS.fleet.manage,
// Path A (no customs): Operations reviews the customer's self-clearance docs
- // on the contract before the customer may create a shipment booking.
+ // — on the contract for ONE_TIME contracts, and PER BOOKING for GENERAL
+ // contracts (booking-level document review → finalize → CLEARANCE_READY).
FREIGHT_PERMS.contracts.view,
FREIGHT_PERMS.contracts.opsClearanceReview,
+ FREIGHT_PERMS.bookings.clearanceView,
+ FREIGHT_PERMS.bookings.reviewDocuments,
+ FREIGHT_PERMS.bookings.finalizeClearance,
...allRuleEngineViewKeys(),
],
director: [
diff --git a/apps/edr-freight-api/src/seed/marshalling-demo-trains.seeder.ts b/apps/edr-freight-api/src/seed/marshalling-demo-trains.seeder.ts
index 53d6c9eec..eec158856 100644
--- a/apps/edr-freight-api/src/seed/marshalling-demo-trains.seeder.ts
+++ b/apps/edr-freight-api/src/seed/marshalling-demo-trains.seeder.ts
@@ -203,7 +203,6 @@ export class MarshallingDemoTrainsSeeder {
const totalWeight = bookingWeights.reduce((sum, weight) => sum + weight, 0);
const wagonCapacity = Number(refs.wagonType.capacityTons) || 70;
const wagonLength = Number(refs.wagonType.lengthMeters) || 14;
- const tareWeight = Number(refs.wagonType.tareWeightTons) || 14;
const trainSet = await trainSetRepo.save(
trainSetRepo.create({
@@ -275,8 +274,6 @@ export class MarshallingDemoTrainsSeeder {
wagonTypeId: refs.wagonType.id,
yardId: originYard.id,
trainScheduleId: schedule.id,
- tareWeight,
- capacityTons: wagonCapacity,
dispatched: hasDeparted,
});
@@ -420,8 +417,6 @@ export class MarshallingDemoTrainsSeeder {
wagonTypeId: string;
yardId: string;
trainScheduleId: string;
- tareWeight: number;
- capacityTons: number;
dispatched: boolean;
}): Promise {
const repo = this.dataSource.getRepository(Wagon);
@@ -433,8 +428,6 @@ export class MarshallingDemoTrainsSeeder {
wagonTypeId: input.wagonTypeId,
currentYardId: input.yardId,
currentTrainScheduleId: input.trainScheduleId,
- tareWeight: input.tareWeight,
- maxPayloadWeight: input.capacityTons,
status: WagonStatus.Assigned,
notes: 'Marshalling demo seed wagon',
}),
diff --git a/apps/edr-freight-api/src/seed/warehouse-demo.seeder.ts b/apps/edr-freight-api/src/seed/warehouse-demo.seeder.ts
index fbc19100a..d8e585a35 100644
--- a/apps/edr-freight-api/src/seed/warehouse-demo.seeder.ts
+++ b/apps/edr-freight-api/src/seed/warehouse-demo.seeder.ts
@@ -3,6 +3,7 @@ import { DataSource } from 'typeorm';
import { Booking } from '../modules/bookings/entities/booking.entity';
import { CargoType } from '../modules/rule-engine/entities/cargo-type.entity';
+import { CompanyProfile } from '../modules/companies/entities/company-profile.entity';
import { Locomotive } from '../modules/locomotives/entities/locomotive.entity';
import { ServiceType } from '../modules/rule-engine/entities/service-type.entity';
import { Yard } from '../modules/rule-engine/entities/yard.entity';
@@ -60,10 +61,16 @@ export class WarehouseDemoSeeder {
(await serviceTypeRepo.findOne({ where: { code: 'RAIL_CONTAINER' } })) ??
(await serviceTypeRepo.findOne({ where: { isActive: true } }));
const cargoType = await cargoTypeRepo.findOne({ where: { isActive: true } });
+ // bookings.company_id AND company_profile_id are both NOT NULL — a demo booking
+ // still needs an owner. Take the company from the profile so they always agree.
+ const companyProfile = await this.dataSource
+ .getRepository(CompanyProfile)
+ .findOne({ where: {} });
- if (!djibYard || !ethYard || !serviceType) {
+ if (!djibYard || !ethYard || !serviceType || !companyProfile) {
this.logger.warn(
- `Missing yards/service type (djib=${djibYard?.code}, eth=${ethYard?.code}, svc=${serviceType?.code}); skipping`,
+ `Missing yards/service type/company profile (djib=${djibYard?.code}, eth=${ethYard?.code}, ` +
+ `svc=${serviceType?.code}, companyProfile=${companyProfile?.id ?? 'none'}); skipping`,
);
return;
}
@@ -89,7 +96,7 @@ export class WarehouseDemoSeeder {
): Promise =>
bookingRepo.save(
bookingRepo.create({
- ...this.demoBookingDefaults(),
+ ...this.demoBookingDefaults(companyProfile),
reference,
originYardId: direction === 'EXPORT' ? ethYard.id : djibYard.id,
destinationYardId: direction === 'EXPORT' ? djibYard.id : ethYard.id,
@@ -182,7 +189,15 @@ export class WarehouseDemoSeeder {
}
// 6) Import Arrive Queue — an ARRIVED import train with IN_TRANSIT bookings, no inventory yet.
- await this.seedArrivedImportTrain(djibYard, ethYard, serviceType, cargoType, ago(60), ago(360));
+ await this.seedArrivedImportTrain(
+ djibYard,
+ ethYard,
+ serviceType,
+ cargoType,
+ companyProfile,
+ ago(60),
+ ago(360),
+ );
created += 1;
this.logger.log(`✅ Warehouse demo seeded: ${created} buckets populated across every queue`);
@@ -199,6 +214,7 @@ export class WarehouseDemoSeeder {
ethYard: Yard,
serviceType: ServiceType,
cargoType: CargoType | null,
+ owner: CompanyProfile,
arrival: Date,
departure: Date,
): Promise {
@@ -238,7 +254,7 @@ export class WarehouseDemoSeeder {
for (let i = 1; i <= 3; i++) {
const b = await bookingRepo.save(
bookingRepo.create({
- ...this.demoBookingDefaults(),
+ ...this.demoBookingDefaults(owner),
reference: `WH-DEMO-ARR-${i}`,
originYardId: djibYard.id,
destinationYardId: ethYard.id,
@@ -258,8 +274,10 @@ export class WarehouseDemoSeeder {
}
}
- private demoBookingDefaults(): Partial {
+ private demoBookingDefaults(owner: CompanyProfile): Partial {
return {
+ companyId: owner.companyId,
+ companyProfileId: owner.id,
scheduledDate: new Date(),
contractType: 'SPOT',
equipmentReturn: 'TERMINAL',
diff --git a/apps/edr-freight-web/backoffice/package.json b/apps/edr-freight-web/backoffice/package.json
index b89807b72..140bc1d01 100644
--- a/apps/edr-freight-web/backoffice/package.json
+++ b/apps/edr-freight-web/backoffice/package.json
@@ -39,6 +39,7 @@
"stream-browserify": "^3.0.0",
"tailwind-merge": "^3.6.0",
"tinymce": "^8.6.0",
+ "xlsx": "^0.18.5",
"zustand": "^5.0.0"
},
"devDependencies": {
diff --git a/apps/edr-freight-web/backoffice/src/App.tsx b/apps/edr-freight-web/backoffice/src/App.tsx
index df8db49d4..15c8cf19c 100644
--- a/apps/edr-freight-web/backoffice/src/App.tsx
+++ b/apps/edr-freight-web/backoffice/src/App.tsx
@@ -13,6 +13,7 @@ import {
PackageOpen,
Paperclip,
Receipt,
+ ScrollText,
Send,
Settings,
ShieldCheck,
@@ -53,11 +54,11 @@ import ContractClearanceListPage from "./pages/contracts/ContractClearanceListPa
import ContractClearanceDetailPage from "./pages/contracts/ContractClearanceDetailPage";
import GlDjiboutiClearanceListPage from "./pages/contracts/GlDjiboutiClearanceListPage";
import GlClearanceDetailPage from "./pages/contracts/GlClearanceDetailPage";
-// Hidden for now — Shipment Requests pages disabled (imports kept commented).
-// import ShipmentRequestsPage from "./pages/contracts/ShipmentRequestsPage";
-// import ShipmentRequestDetailPage from "./pages/contracts/ShipmentRequestDetailPage";
+import ShipmentRequestsPage from "./pages/contracts/ShipmentRequestsPage";
+import ShipmentRequestDetailPage from "./pages/contracts/ShipmentRequestDetailPage";
import GlCreateBookingForm from "./components/contracts/GlCreateBookingForm";
import DocumentClearanceDetailPage from "./pages/bookings/DocumentClearanceDetailPage";
+import DocumentClearanceListPage from "./pages/bookings/DocumentClearanceListPage";
import CustomerDetailPage from "./pages/customers/CustomerDetailPage";
import CustomersPage from "./pages/customers/CustomersPage";
import InvoiceDetailPage from "./pages/invoices/InvoiceDetailPage";
@@ -84,6 +85,8 @@ import UserManagementPage from "./pages/dashboard/user-management/UserManagement
import UsersPage from "./pages/dashboard/user-management/UsersPage";
import FileUploadSettingsPage from "./pages/documents/FileUploadSettingsPage";
import DropdownSettingsPage from "./pages/dropdown_settings/DropdownSettingsPage";
+import ContractTemplatesPage from "./pages/contract_templates/ContractTemplatesPage";
+import ContractTemplateEditorPage from "./pages/contract_templates/ContractTemplateEditorPage";
import FleetResourcePage from "./pages/fleet/FleetResourcePage";
import VehicleDetailPage from "./pages/fleet/VehicleDetailPage";
import DriverDetailPage from "./pages/fleet/DriverDetailPage";
@@ -187,13 +190,18 @@ const buildSidebarSections = (demoItems: SidebarItem[]): SidebarSection[] => [
FREIGHT_PERMS.contracts.clearanceEtActions,
],
},
- // Hidden for now — Shipment Requests nav item disabled.
- // {
- // label: "Shipment Requests",
- // href: "/dashboard/shipment-requests",
- // icon: ,
- // permission: FREIGHT_PERMS.contracts.createBooking,
- // },
+ {
+ label: "Shipment Requests",
+ href: "/dashboard/shipment-requests",
+ icon: ,
+ permission: FREIGHT_PERMS.contracts.createBooking,
+ },
+ {
+ label: "Self-Clearance Review",
+ href: "/dashboard/contracts/ops-clearance",
+ icon: ,
+ permission: FREIGHT_PERMS.contracts.opsClearanceReview,
+ },
{
label: "GL Djibouti Clearance",
href: "/dashboard/gl-djibouti/clearance",
@@ -456,6 +464,12 @@ const buildSidebarSections = (demoItems: SidebarItem[]): SidebarSection[] => [
icon: ,
permission: FREIGHT_PERMS.admin,
},
+ {
+ label: "Contract templates",
+ href: "/dashboard/contract-templates",
+ icon: ,
+ permission: FREIGHT_PERMS.admin,
+ },
],
},
{
@@ -752,7 +766,6 @@ const App = () => {
}
/>
- {/* Hidden for now — Shipment Requests pages disabled.
{
}
/>
- */}
{/* GL (Path B) contract clearance review hub */}
{
}
/>
- {/* Path A ops queue out of scope for now → fold into the GL hub. */}
+ {/* Path A — Operations reviews per-booking self-clearance documents
+ (GENERAL contracts without customs). */}
}
+ element={
+
+
+
+ }
/>
{
}
/>
+
+
+
+ }
+ />
+
+
+
+ }
+ />
>({});
@@ -240,7 +247,7 @@ export function ClearanceReviewSection({
- {clearance.outputCode && (
+ {clearance.outputCode && !phasedCustoms && (
)}
- {finalizeMutation.isError && (
+ {!phasedCustoms && finalizeMutation.isError && (
}>
{finalizeMutation.error instanceof Error
? finalizeMutation.error.message
@@ -349,8 +356,10 @@ export function ClearanceReviewSection({
)}
-
-
+ {phasedCustoms ? (
+ // Phased (GENERAL customs) — no legacy finalize; the milestone steps in
+ // the action panel drive the workflow, same as ONE_TIME contracts.
+
-
+ {clearance.allApproved ? (
+
+ ) : (
+
+ )}
{clearance.allApproved
- ? "All required documents are approved — you can finalize."
- : "Approve every required document to unlock finalization."}
+ ? "All required documents are approved. Continue declaration, duty, and transit in the action panel."
+ : "Approve every required document to unlock the customs milestone steps."}
- }
- disabled={!clearance.allApproved}
- loading={finalizeMutation.isPending}
- onClick={() => finalizeMutation.mutate()}
- >
- Finalize clearance
-
-
-
+
+ ) : (
+
+
+
+
+
+
+
+ {clearance.allApproved
+ ? "All required documents are approved — you can finalize."
+ : "Approve every required document to unlock finalization."}
+
+
+ }
+ disabled={!clearance.allApproved}
+ loading={finalizeMutation.isPending}
+ onClick={() => finalizeMutation.mutate()}
+ >
+ Finalize clearance
+
+
+
+ )}
{viewer}
);
diff --git a/apps/edr-freight-web/backoffice/src/components/contracts/GlCreateBookingForm.tsx b/apps/edr-freight-web/backoffice/src/components/contracts/GlCreateBookingForm.tsx
index 547e9ce9f..33254d3ce 100644
--- a/apps/edr-freight-web/backoffice/src/components/contracts/GlCreateBookingForm.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/contracts/GlCreateBookingForm.tsx
@@ -12,6 +12,7 @@ import {
Button,
Center,
Divider,
+ FileButton,
Group,
Loader,
Modal,
@@ -31,7 +32,9 @@ import {
CalendarDays,
CheckCircle2,
ChevronLeft,
+ FileDown,
FileText,
+ FileUp,
MapPin,
Package,
Receipt,
@@ -54,6 +57,10 @@ import {
type GlShipmentQuantities,
} from "./gl-booking-form/total";
import { ContractCapacityNotice } from "./gl-booking-form/ContractCapacityNotice";
+import {
+ downloadContainerImportTemplate,
+ parseContainerExcel,
+} from "./gl-booking-form/container-excel";
import {
fieldStyles,
StepCard,
@@ -64,6 +71,21 @@ import {
/** All booking-window times are communicated in East Africa Time. */
const EAT_TZ = "Africa/Addis_Ababa";
+// ISO 6346: 4-letter owner/category code + 6-digit serial + check digit.
+// Same rule the customer portal shipment form enforces.
+const ISO_CONTAINER_NUMBER_REGEX = /^[A-Z]{4}\d{7}$/;
+
+interface UnitErrors {
+ containerNumber?: string;
+ vgmTons?: string;
+}
+
+interface BulkErrors {
+ quantity?: string;
+ hazardous?: string;
+ reefer?: string;
+}
+
function fmtWindowOpensAt(iso: string): string {
const date = new Date(iso).toLocaleDateString("en-GB", {
weekday: "short",
@@ -372,6 +394,123 @@ export default function GlCreateBookingForm() {
prev.map((l, i) => (i === idx ? { ...l, ...patch } : l)),
);
+ // Same client-side validation as the customer portal shipment form: ISO
+ // container numbers (unique within the shipment) and a positive VGM per unit;
+ // bulk needs a positive quantity with hazardous/reefer portions bounded by it.
+ const [showErrors, setShowErrors] = useState(false);
+
+ // Excel import: one row per container. All-or-nothing — a file with any bad
+ // row is rejected with row-numbered errors so nothing is silently dropped.
+ const [importErrors, setImportErrors] = useState([]);
+ const [importSummary, setImportSummary] = useState(null);
+ const importResetRef = useRef<(() => void) | null>(null);
+ const excelOpts = {
+ allowedSizes: containerSizes,
+ includeHazardous: contract?.isHazardous ?? false,
+ includeReefer: contract?.isReefer ?? false,
+ };
+
+ const handleImportFile = async (file: File | null) => {
+ // Reset the hidden input so re-picking the same (fixed) file re-fires.
+ importResetRef.current?.();
+ if (!file) return;
+ const { rows, errors } = await parseContainerExcel(file, excelOpts);
+ if (errors.length > 0) {
+ setImportSummary(null);
+ setImportErrors(errors);
+ return;
+ }
+ // Replace only the lines for sizes present in the file; a contracted size
+ // the file omits keeps whatever was already entered for it.
+ setContainerLines((prev) =>
+ containerSizes.map((size) => {
+ const imported = rows.filter((r) => r.containerSize === size);
+ if (imported.length === 0) {
+ return (
+ prev.find((l) => l.containerSize === size) ?? {
+ containerSize: size,
+ units: [emptyUnit()],
+ }
+ );
+ }
+ return {
+ containerSize: size,
+ units: imported.map((r) => ({
+ containerNumber: r.containerNumber,
+ sealNumber: r.sealNumber,
+ vgmTons: r.vgmTons,
+ hazardous: r.hazardous,
+ reefer: r.reefer,
+ })),
+ };
+ }),
+ );
+ setImportErrors([]);
+ setShowErrors(false);
+ setImportSummary(`Imported ${rows.length} container(s) from ${file.name}.`);
+ };
+
+ const unitErrors = useMemo(() => {
+ if (!isContainer) return [];
+ const numberCounts = new Map();
+ containerLines.forEach((line) =>
+ line.units.forEach((u) => {
+ const key = u.containerNumber.trim().toUpperCase();
+ if (!key) return;
+ numberCounts.set(key, (numberCounts.get(key) ?? 0) + 1);
+ }),
+ );
+ return containerLines.map((line) =>
+ line.units.map((u) => {
+ const errs: UnitErrors = {};
+ const key = u.containerNumber.trim().toUpperCase();
+ if (!key) {
+ errs.containerNumber = "Container number is required.";
+ } else if (!ISO_CONTAINER_NUMBER_REGEX.test(key)) {
+ errs.containerNumber =
+ "Enter a valid ISO container number (e.g. ABCD1234567).";
+ } else if ((numberCounts.get(key) ?? 0) > 1) {
+ errs.containerNumber = "Duplicate container number in this shipment.";
+ }
+ const vgm = Number(u.vgmTons);
+ if (String(u.vgmTons).trim() === "" || Number.isNaN(vgm) || vgm <= 0) {
+ errs.vgmTons = "Enter a valid VGM.";
+ }
+ return errs;
+ }),
+ );
+ }, [isContainer, containerLines]);
+
+ const bulkErrors = useMemo(() => {
+ if (isContainer) return [];
+ return bulkLines.map((line) => {
+ const errs: BulkErrors = {};
+ const qty = Number(line.cargoWeightTons || line.itemCount || 0);
+ if (Number.isNaN(qty) || qty <= 0) {
+ errs.quantity = "Enter a quantity greater than 0.";
+ }
+ const h = Number(line.hazardousQuantity || 0);
+ if (Number.isNaN(h) || h < 0) {
+ errs.hazardous = "Enter a valid hazardous quantity.";
+ } else if (qty > 0 && h > qty) {
+ errs.hazardous = `Can't exceed the cargo quantity (${qty}).`;
+ }
+ const r = Number(line.reeferQuantity || 0);
+ if (Number.isNaN(r) || r < 0) {
+ errs.reefer = "Enter a valid refrigerated quantity.";
+ } else if (qty > 0 && r > qty) {
+ errs.reefer = `Can't exceed the cargo quantity (${qty}).`;
+ }
+ return errs;
+ });
+ }, [isContainer, bulkLines]);
+
+ const cargoValid = isContainer
+ ? unitErrors.every((line) =>
+ line.every((e) => !e.containerNumber && !e.vgmTons),
+ )
+ : bulkErrors.every((e) => !e.quantity && !e.hazardous && !e.reefer);
+
const canSubmit =
windowOpen &&
Boolean(scheduledDate) &&
@@ -401,7 +540,7 @@ export default function GlCreateBookingForm() {
hazardousQuantity: l.units.filter((u) => u.hazardous).length,
reeferQuantity: l.units.filter((u) => u.reefer).length,
units: l.units.map((u) => ({
- containerNumber: u.containerNumber,
+ containerNumber: u.containerNumber.trim().toUpperCase(),
...(u.sealNumber ? { sealNumber: u.sealNumber } : {}),
vgmTons: Number(u.vgmTons) || 0,
})),
@@ -458,6 +597,13 @@ export default function GlCreateBookingForm() {
const overweightLines = validation?.overweightLines ?? [];
const openPriceModal = () => {
+ // Surface the per-field errors (portal-parity validation) instead of
+ // sending an invalid payload to the price preview.
+ if (!cargoValid) {
+ setShowErrors(true);
+ return;
+ }
+ setShowErrors(false);
setPriceOpen(true);
const payload = buildPayload();
if (payload) {
@@ -467,7 +613,7 @@ export default function GlCreateBookingForm() {
};
const handleSubmit = () => {
- if (!contract || !windowOpen) return;
+ if (!contract || !windowOpen || !cargoValid) return;
// Never book past unresolved 20ft pairing hard-blocks.
if (pairingErrors.length > 0) return;
// A line above the container type's max capacity can never book.
@@ -483,8 +629,13 @@ export default function GlCreateBookingForm() {
} catch {
// Non-fatal
}
- navigate(`/dashboard/bookings/${booking.id}/clearance`);
+ }
+ if (contract.contractKind === "GENERAL") {
+ // GENERAL per-booking clearance: land on the booking's clearance
+ // detail — the same page the Shipments tab on the hub opens.
+ navigate(`/dashboard/clearance/${booking.id}`);
} else {
+ // ONE_TIME customs keeps its clearance on the contract.
navigate(`/dashboard/contracts/clearance/${contract.id}`);
}
},
@@ -647,6 +798,83 @@ export default function GlCreateBookingForm() {
description="Enter the quantity and per-container details for each size in the contract scope."
/>
+ {containerSizes.length > 0 && (
+
+
+
+
+ Import containers from Excel
+
+
+ One row per container. Importing fills the lines below
+ for the sizes in the file.
+
+
+
+ }
+ onClick={() => downloadContainerImportTemplate(excelOpts)}
+ >
+ Download template
+
+
+ {(props) => (
+ }
+ >
+ Import Excel
+
+ )}
+
+
+
+ {importErrors.length > 0 && (
+ }
+ title="Import failed — fix the file and try again"
+ mt="sm"
+ >
+
+ {importErrors.slice(0, 8).map((msg, i) => (
+
+ {msg}
+
+ ))}
+ {importErrors.length > 8 && (
+
+ …and {importErrors.length - 8} more.
+
+ )}
+
+
+ )}
+ {importSummary && (
+ }
+ mt="sm"
+ >
+ {importSummary}
+
+ )}
+
+ )}
{containerLines.length === 0 ? (
@@ -692,6 +920,11 @@ export default function GlCreateBookingForm() {
label={unitIdx === 0 ? "Container number *" : undefined}
placeholder="e.g. MSCU1234567"
value={unit.containerNumber}
+ error={
+ showErrors
+ ? unitErrors[lineIdx]?.[unitIdx]?.containerNumber
+ : undefined
+ }
onChange={(e) =>
patchUnit(lineIdx, unitIdx, {
containerNumber: e.currentTarget.value,
@@ -720,6 +953,11 @@ export default function GlCreateBookingForm() {
min={0}
decimalScale={2}
value={unit.vgmTons}
+ error={
+ showErrors
+ ? unitErrors[lineIdx]?.[unitIdx]?.vgmTons
+ : undefined
+ }
onChange={(v) =>
patchUnit(lineIdx, unitIdx, { vgmTons: v })
}
@@ -808,6 +1046,7 @@ export default function GlCreateBookingForm() {
min={0}
decimalScale={2}
value={line.cargoWeightTons}
+ error={showErrors ? bulkErrors[idx]?.quantity : undefined}
onChange={(v) => patchBulk(idx, { cargoWeightTons: v })}
radius={10}
styles={fieldStyles}
@@ -818,6 +1057,7 @@ export default function GlCreateBookingForm() {
placeholder="e.g. 500"
min={0}
value={line.itemCount}
+ error={showErrors ? bulkErrors[idx]?.quantity : undefined}
onChange={(v) => patchBulk(idx, { itemCount: v })}
radius={10}
styles={fieldStyles}
@@ -828,6 +1068,7 @@ export default function GlCreateBookingForm() {
label="Hazardous quantity"
min={0}
value={line.hazardousQuantity}
+ error={showErrors ? bulkErrors[idx]?.hazardous : undefined}
onChange={(v) => patchBulk(idx, { hazardousQuantity: v })}
radius={10}
styles={fieldStyles}
@@ -838,6 +1079,7 @@ export default function GlCreateBookingForm() {
label="Refrigerated quantity"
min={0}
value={line.reeferQuantity}
+ error={showErrors ? bulkErrors[idx]?.reefer : undefined}
onChange={(v) => patchBulk(idx, { reeferQuantity: v })}
radius={10}
styles={fieldStyles}
@@ -905,26 +1147,39 @@ export default function GlCreateBookingForm() {
marginTop: 24,
}}
>
-
-
- }
- disabled={!canSubmit}
- onClick={openPriceModal}
- >
- Review price & book
-
-
+
+ {showErrors && !cargoValid ? (
+ }
+ mb="sm"
+ >
+ Fix the highlighted cargo fields before reviewing the price.
+
+ ) : null}
+
+
+ }
+ disabled={!canSubmit}
+ onClick={openPriceModal}
+ >
+ Review price & book
+
+
+
isImport
@@ -251,9 +262,17 @@ export function PhasedClearanceActionPanel({
effectiveBookingCreated,
bookingMilestones,
t1Uploaded,
+ freightPaid,
)
: 0,
- [clearance, isImport, effectiveBookingCreated, bookingMilestones, t1Uploaded],
+ [
+ clearance,
+ isImport,
+ effectiveBookingCreated,
+ bookingMilestones,
+ t1Uploaded,
+ freightPaid,
+ ],
);
if (isImport) {
@@ -554,14 +573,26 @@ export function PhasedClearanceActionPanel({
)}
+ : }
+ >
+
+
+
:
}
>
-
+
+ );
+ }
+
const wagonAllocated = Boolean(clearance.train?.wagonAllocated);
return (
@@ -1015,6 +1064,18 @@ function RiskStep({
);
}
+ // Customs cannot rate cargo still under transit — the server rejects the
+ // assignment until the T1 is closed, so do not offer the control yet.
+ if (!clearance.t1?.closed) {
+ return (
+
+ );
+ }
+
if (!canAct || !bookingId) {
return (
s.replace(/[^0-9]/g, "") === digits) ?? null;
+}
+
+function parseFlag(raw: string): boolean {
+ const v = raw.trim().toLowerCase();
+ return v === "yes" || v === "y" || v === "true" || v === "1" || v === "x";
+}
+
+/**
+ * Parse an uploaded workbook into one row per container. Returns either the
+ * full row set or the list of row-numbered problems (never both).
+ */
+export async function parseContainerExcel(
+ file: File,
+ opts: ContainerExcelOptions,
+): Promise {
+ let sheet: XLSX.WorkSheet | undefined;
+ try {
+ const workbook = XLSX.read(await file.arrayBuffer(), { type: "array" });
+ sheet = workbook.Sheets[workbook.SheetNames[0]];
+ } catch {
+ return { rows: [], errors: ["Could not read the file — is it a valid Excel file?"] };
+ }
+ if (!sheet) {
+ return { rows: [], errors: ["The file has no sheets."] };
+ }
+
+ const grid = XLSX.utils.sheet_to_json(sheet, {
+ header: 1,
+ raw: false,
+ defval: "",
+ });
+
+ // First row with a recognizable column is the header; everything above
+ // (titles, blank rows) is ignored.
+ let headerRowIdx = -1;
+ let columns: Array = [];
+ for (let i = 0; i < grid.length; i++) {
+ const mapped = (grid[i] ?? []).map((c) => headerKey(String(c ?? "")));
+ if (mapped.includes("containerNumber") && mapped.includes("containerSize")) {
+ headerRowIdx = i;
+ columns = mapped;
+ break;
+ }
+ }
+ if (headerRowIdx < 0) {
+ return {
+ rows: [],
+ errors: [
+ 'Could not find the expected columns. The sheet needs at least "Container Size" and "Container Number" headers — download the template to see the format.',
+ ],
+ };
+ }
+ if (!columns.includes("vgmTons")) {
+ return {
+ rows: [],
+ errors: ['Missing a "VGM (Tons)" column — download the template to see the format.'],
+ };
+ }
+
+ const rows: ImportedContainerRow[] = [];
+ const errors: string[] = [];
+ const numberCounts = new Map();
+
+ for (let i = headerRowIdx + 1; i < grid.length; i++) {
+ const cells = grid[i] ?? [];
+ if (cells.every((c) => String(c ?? "").trim() === "")) continue;
+ const rowNo = i + 1; // 1-based, as shown in Excel
+
+ const cell = (key: ColumnKey) => {
+ const idx = columns.indexOf(key);
+ return idx >= 0 ? String(cells[idx] ?? "").trim() : "";
+ };
+
+ const size = normalizeSize(cell("containerSize"), opts.allowedSizes);
+ if (!size) {
+ errors.push(
+ `Row ${rowNo}: container size "${cell("containerSize") || "—"}" is not in this contract's scope (allowed: ${opts.allowedSizes.join(", ")}).`,
+ );
+ }
+
+ const containerNumber = cell("containerNumber").toUpperCase();
+ if (!ISO_CONTAINER_NUMBER_REGEX.test(containerNumber)) {
+ errors.push(
+ `Row ${rowNo}: "${cell("containerNumber") || "—"}" is not a valid ISO container number (e.g. MSCU1234567).`,
+ );
+ } else {
+ numberCounts.set(containerNumber, (numberCounts.get(containerNumber) ?? 0) + 1);
+ }
+
+ const vgmRaw = cell("vgmTons");
+ const vgm = Number(vgmRaw);
+ if (!vgmRaw || Number.isNaN(vgm) || vgm <= 0) {
+ errors.push(`Row ${rowNo}: VGM "${vgmRaw || "—"}" must be a number greater than 0.`);
+ }
+
+ rows.push({
+ containerSize: size ?? "",
+ containerNumber,
+ sealNumber: cell("sealNumber"),
+ vgmTons: vgmRaw,
+ hazardous: opts.includeHazardous && parseFlag(cell("hazardous")),
+ reefer: opts.includeReefer && parseFlag(cell("reefer")),
+ });
+ }
+
+ numberCounts.forEach((count, num) => {
+ if (count > 1) errors.push(`Container number ${num} appears ${count} times — numbers must be unique.`);
+ });
+
+ if (rows.length === 0 && errors.length === 0) {
+ errors.push("The sheet has no container rows below the header.");
+ }
+
+ return errors.length > 0 ? { rows: [], errors } : { rows, errors: [] };
+}
+
+/** Generate and download the simple import template with one sample row per size. */
+export function downloadContainerImportTemplate(opts: ContainerExcelOptions) {
+ const headers = ["Container Size", "Container Number", "Seal Number", "VGM (Tons)"];
+ if (opts.includeHazardous) headers.push("Hazardous (YES/NO)");
+ if (opts.includeReefer) headers.push("Reefer (YES/NO)");
+
+ const sizes = opts.allowedSizes.length > 0 ? opts.allowedSizes : ["20ft"];
+ const sampleRows = sizes.map((size, i) => {
+ const row: Array = [
+ size,
+ `MSCU${String(1234567 + i).padStart(7, "0")}`,
+ `SL${String(482910 + i)}`,
+ size.startsWith("40") ? 28 : 24.5,
+ ];
+ if (opts.includeHazardous) row.push("NO");
+ if (opts.includeReefer) row.push("NO");
+ return row;
+ });
+
+ const sheet = XLSX.utils.aoa_to_sheet([headers, ...sampleRows]);
+ sheet["!cols"] = headers.map((h) => ({ wch: Math.max(h.length + 2, 16) }));
+ const workbook = XLSX.utils.book_new();
+ XLSX.utils.book_append_sheet(workbook, sheet, "Containers");
+ XLSX.writeFile(workbook, "container-import-template.xlsx");
+}
diff --git a/apps/edr-freight-web/backoffice/src/components/customers/ResetPasswordAction.tsx b/apps/edr-freight-web/backoffice/src/components/customers/ResetPasswordAction.tsx
new file mode 100644
index 000000000..bc505a21f
--- /dev/null
+++ b/apps/edr-freight-web/backoffice/src/components/customers/ResetPasswordAction.tsx
@@ -0,0 +1,105 @@
+import { Button, Modal, Radio, Stack, Text } from "@mantine/core";
+import { useMutation } from "@tanstack/react-query";
+import { KeyRound } from "lucide-react";
+import { useState } from "react";
+
+import { useAuth } from "@/auth/useAuth";
+import { useToast } from "@/hooks/use-toast";
+import { FREIGHT_PERMS, hasPermission } from "@/lib/permissions";
+import { api } from "@/services/api";
+import type { Company, ResetChannel } from "@/types/customer";
+
+export interface ResetPasswordActionProps {
+ company: Pick;
+}
+
+/**
+ * Staff-triggered password reset. Sends a one-time code to the customer's
+ * primary contact; the customer picks their own new password. No credential is
+ * ever shown to or handled by staff.
+ */
+export default function ResetPasswordAction({ company }: ResetPasswordActionProps) {
+ const { user } = useAuth();
+ const { toast } = useToast();
+ const [opened, setOpened] = useState(false);
+ const [channel, setChannel] = useState("phone");
+
+ const { mutate, isPending } = useMutation(
+ api.customers.resetPassword.mutationOptions({
+ onSuccess: (result) => {
+ setOpened(false);
+ toast({
+ title: "Reset code sent",
+ description: `The customer can now reset their password using the code sent to ${result.maskedTarget}.`,
+ });
+ },
+ onError: (error) => {
+ toast({
+ title: "Could not send reset code",
+ description: error.message,
+ variant: "destructive",
+ });
+ },
+ }),
+ );
+
+ if (!hasPermission(user, FREIGHT_PERMS.customers.resetPassword)) return null;
+
+ return (
+ <>
+ }
+ onClick={() => setOpened(true)}
+ >
+ Reset password
+
+
+ setOpened(false)}
+ title="Send a password-reset code"
+ centered
+ >
+
+
+ We'll send a one-time code to this customer's primary contact.
+ They choose their own new password — you will not see it.
+
+
+ setChannel(v as ResetChannel)}
+ label="Send the code via"
+ >
+
+
+
+
+
+
+
+ The code goes to the primary contact's own email or phone, which
+ may differ from the company contact details shown above.
+
+
+
+
+
+ >
+ );
+}
diff --git a/apps/edr-freight-web/backoffice/src/components/customers/index.ts b/apps/edr-freight-web/backoffice/src/components/customers/index.ts
index 2a87e3b0c..d42673d2b 100644
--- a/apps/edr-freight-web/backoffice/src/components/customers/index.ts
+++ b/apps/edr-freight-web/backoffice/src/components/customers/index.ts
@@ -13,5 +13,9 @@ export {
ChangeRequestReview,
ChangeRequestPendingBadge,
} from "./ChangeRequestReview";
+export {
+ default as ResetPasswordAction,
+ type ResetPasswordActionProps,
+} from "./ResetPasswordAction";
export { formatBytes, formatDate, formatMoney, humanize } from "./format";
export { TableCard, type TableCardProps } from "./TableCard";
diff --git a/apps/edr-freight-web/backoffice/src/components/layout/FreightSidebar.tsx b/apps/edr-freight-web/backoffice/src/components/layout/FreightSidebar.tsx
index 391a8157d..698b0fc2c 100644
--- a/apps/edr-freight-web/backoffice/src/components/layout/FreightSidebar.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/layout/FreightSidebar.tsx
@@ -250,7 +250,10 @@ const FreightSidebar = ({
diff --git a/apps/edr-freight-web/backoffice/src/components/ruleEngine/RuleEngineFormDialog.tsx b/apps/edr-freight-web/backoffice/src/components/ruleEngine/RuleEngineFormDialog.tsx
index 403a98f1b..8c1aed302 100644
--- a/apps/edr-freight-web/backoffice/src/components/ruleEngine/RuleEngineFormDialog.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/ruleEngine/RuleEngineFormDialog.tsx
@@ -313,6 +313,7 @@ const RuleEngineFormDialog = ({
maxScore(ranked), [ranked]);
- // maxWagons is not on the board DTO (capacity is length/weight-based), so the
- // capacity line shows the wagons currently committed rather than a hard cap.
- const maxWagons: number | null = null;
+ // Wagon-slot cap from the board DTO (derived from train length and the
+ // shortest wagon type); null on legacy rows without a computable cap.
+ const maxWagons: number | null = data.capacity.maxWagons ?? null;
// Split the ranking at the capacity line: cumulative wagons of slot-occupying
// bookings (allocated + selected + paid-waiting) up to the train's wagon cap.
@@ -431,23 +431,31 @@ export function PriorityTrackingTab({ data, bookings }: Props) {
{data.capacity.allocatedWagons} allocated ·{" "}
{capUsed} in batch
+ {maxWagons != null ? ` · ${maxWagons} max` : ""}
+ {/* Scale against the real wagon cap when the DTO carries one; fall back
+ to the in-batch total on legacy rows without a computable cap. */}
0
- ? Math.min(100, (data.capacity.allocatedWagons / capUsed) * 100)
+ (maxWagons ?? capUsed) > 0
+ ? Math.min(
+ 100,
+ (data.capacity.allocatedWagons / (maxWagons ?? capUsed)) * 100,
+ )
: 0
}
color="edr-green"
/>
0
+ (maxWagons ?? capUsed) > 0
? Math.min(
100,
- ((capUsed - data.capacity.allocatedWagons) / capUsed) * 100,
+ ((capUsed - data.capacity.allocatedWagons) /
+ (maxWagons ?? capUsed)) *
+ 100,
)
: 0
}
diff --git a/apps/edr-freight-web/backoffice/src/components/trainScheduling/TrainCompositionDiagram.tsx b/apps/edr-freight-web/backoffice/src/components/trainScheduling/TrainCompositionDiagram.tsx
index c7530209b..6ba1a0e29 100644
--- a/apps/edr-freight-web/backoffice/src/components/trainScheduling/TrainCompositionDiagram.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/trainScheduling/TrainCompositionDiagram.tsx
@@ -16,6 +16,7 @@ type DiagramWagonInput = {
sequenceNo: number;
capacityTons: number;
assignedWeightTons: number;
+ tareWeightTons?: number | null;
slotLoadType?: string | null;
wagonType?: { code?: string | null } | null;
wagonTypeCode?: string | null;
@@ -33,6 +34,7 @@ type NormalizedWagon = {
sequenceNo: number;
capacityTons: number;
assignedWeightTons: number;
+ tareWeightTons: number;
wagonTypeCode: string | null;
physicalWagonNumber: string | null;
isEmpty: boolean;
@@ -69,6 +71,7 @@ function normalizeWagon(w: DiagramWagonInput, freightType?: string | null): Norm
sequenceNo: w.sequenceNo,
capacityTons: Number(w.capacityTons) || 0,
assignedWeightTons: Number(w.assignedWeightTons) || 0,
+ tareWeightTons: Number(w.tareWeightTons) || 0,
wagonTypeCode: w.wagonType?.code ?? w.wagonTypeCode ?? null,
physicalWagonNumber: w.physicalWagonNumber ?? null,
isEmpty: allocations.length === 0,
@@ -278,7 +281,9 @@ function WagonCar({ wagon }: { wagon: NormalizedWagon }) {
wagon.bookingRefs.length ? wagon.bookingRefs.join(", ") : ""
}${
wagon.containerNumbers.length ? `\nContainers: ${wagon.containerNumbers.join(", ")}` : ""
- }${wagon.cargoDescription ? `\n${wagon.cargoDescription}` : ""}\nLoad: ${wagon.assignedWeightTons}/${wagon.capacityTons}T (${utilization}%)`;
+ }${wagon.cargoDescription ? `\n${wagon.cargoDescription}` : ""}\nLoad: ${wagon.assignedWeightTons}/${wagon.capacityTons}T (${utilization}%)${
+ wagon.tareWeightTons ? `\nTare: ${wagon.tareWeightTons}T` : ""
+ }`;
// container blocks: one per container number (cap visual at 2 = TEU per wagon)
const blocks = wagon.containerNumbers.slice(0, 2);
@@ -523,15 +528,22 @@ export function TrainCompositionDiagram({
const assigned = normalized.filter((w) => !w.isEmpty).length;
const totalWeight = normalized.reduce((s, w) => s + w.assignedWeightTons, 0);
const totalCapacity = normalized.reduce((s, w) => s + w.capacityTons, 0);
+ // Every coupled wagon's tare is hauled — empty ones included — so the
+ // locomotive pull limit is measured against gross (tare + cargo), the same
+ // ceiling the allocation engine spends from.
+ const totalTare = normalized.reduce((s, w) => s + w.tareWeightTons, 0);
+ const grossWeight = totalWeight + totalTare;
return {
total: normalized.length,
assigned,
empty: normalized.length - assigned,
totalWeight: Math.round(totalWeight * 100) / 100,
+ totalTare: Math.round(totalTare * 100) / 100,
+ grossWeight: Math.round(grossWeight * 100) / 100,
totalCapacity,
pullUtil:
locomotive?.maxPullWeightTons && locomotive.maxPullWeightTons > 0
- ? Math.min(100, Math.round((totalWeight / locomotive.maxPullWeightTons) * 100))
+ ? Math.min(100, Math.round((grossWeight / locomotive.maxPullWeightTons) * 100))
: null,
};
}, [normalized, locomotive]);
@@ -598,12 +610,30 @@ export function TrainCompositionDiagram({
}}
>
- {stats.totalWeight}T
+ {stats.totalWeight}T cargo
of {stats.totalCapacity}T capacity
+ {stats.totalTare > 0 ? (
+
+
+ {stats.grossWeight}T gross
+
+
+ incl. {stats.totalTare}T tare
+
+
+ ) : null}
@@ -626,7 +656,10 @@ export function TrainCompositionDiagram({
- Locomotive load · {stats.totalWeight}T of {locomotive?.maxPullWeightTons}T
+ Locomotive load ·{" "}
+ {stats.totalTare > 0
+ ? `${stats.grossWeight}T of ${locomotive?.maxPullWeightTons}T (${stats.totalWeight}T cargo + ${stats.totalTare}T tare)`
+ : `${stats.totalWeight}T of ${locomotive?.maxPullWeightTons}T`}
95 ? "red.7" : "edr-green.7"}>
diff --git a/apps/edr-freight-web/backoffice/src/components/warehouses/FeePreviewModal.tsx b/apps/edr-freight-web/backoffice/src/components/warehouses/FeePreviewModal.tsx
index 78e09a7e0..5eeee7d13 100644
--- a/apps/edr-freight-web/backoffice/src/components/warehouses/FeePreviewModal.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/warehouses/FeePreviewModal.tsx
@@ -7,7 +7,7 @@ import { useMutation, useQuery } from '@tanstack/react-query';
import { api } from '@/services/api';
import { useToast } from '@/hooks/use-toast';
import { warehouseService } from '@/services/warehouse.service';
-import { extractErrorMessage } from './options';
+import { extractDownloadErrorMessage, extractErrorMessage } from './options';
import type { FeePreview, WarehouseInventoryItem, WarehouseInvoiceStatus } from '@/types/warehouse';
import { openPdfBlob } from './pdf';
@@ -157,7 +157,7 @@ export function FeePreviewModal({ opened, onClose, inventoryId }: FeePreviewModa
pdfWindow?.close();
toast({
title: 'Gate clearance recorded',
- description: `Release paper could not be opened: ${extractErrorMessage(documentError)}`,
+ description: `Release paper could not be opened: ${await extractDownloadErrorMessage(documentError)}`,
});
}
onClose();
diff --git a/apps/edr-freight-web/backoffice/src/components/warehouses/InventoryWorkbench.tsx b/apps/edr-freight-web/backoffice/src/components/warehouses/InventoryWorkbench.tsx
index b8bb43086..c4f1f5cec 100644
--- a/apps/edr-freight-web/backoffice/src/components/warehouses/InventoryWorkbench.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/warehouses/InventoryWorkbench.tsx
@@ -18,7 +18,7 @@ import { LoadInventoryModal } from './LoadInventoryModal';
import { MoveInventoryModal } from './MoveInventoryModal';
import { ReleaseOrderModal } from './ReleaseOrderModal';
import { WarehouseInventoryTable } from './WarehouseInventoryTable';
-import { extractErrorMessage } from './options';
+import { extractDownloadErrorMessage, extractErrorMessage } from './options';
import { openPdfBlob } from './pdf';
interface InventoryWorkbenchProps {
@@ -111,7 +111,7 @@ export function InventoryWorkbench({ items, isLoading, onLastMile }: InventoryWo
toast({
variant: 'destructive',
title: 'Release paper preview failed',
- description: extractErrorMessage(error),
+ description: await extractDownloadErrorMessage(error),
});
} finally {
setBusyId(null);
@@ -131,7 +131,7 @@ export function InventoryWorkbench({ items, isLoading, onLastMile }: InventoryWo
toast({
variant: 'destructive',
title: 'Handover document failed',
- description: extractErrorMessage(error),
+ description: await extractDownloadErrorMessage(error),
});
} finally {
setBusyId(null);
diff --git a/apps/edr-freight-web/backoffice/src/components/warehouses/ReceiveInventoryModal.tsx b/apps/edr-freight-web/backoffice/src/components/warehouses/ReceiveInventoryModal.tsx
index 3b4be03db..a1b91decb 100644
--- a/apps/edr-freight-web/backoffice/src/components/warehouses/ReceiveInventoryModal.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/warehouses/ReceiveInventoryModal.tsx
@@ -76,7 +76,7 @@ import { MoveInventoryModal } from './MoveInventoryModal';
import { ReleaseOrderModal } from './ReleaseOrderModal';
import { StoreInventoryModal } from './StoreInventoryModal';
import { WarehouseInquiryTable } from './WarehouseInquiryTable';
-import { extractErrorMessage, formatDate, formatNumber, inventoryStatusOptions } from './options';
+import { extractDownloadErrorMessage, extractErrorMessage, formatDate, formatNumber, inventoryStatusOptions } from './options';
import { openPdfBlob } from './pdf';
import '@/components/overview/overview.css';
@@ -112,7 +112,7 @@ function GrnDocumentButton({ inventoryId, grnNumber }: { inventoryId: string; gr
toast({ title: opened ? 'GRN document opened' : 'GRN document downloaded' });
} catch (error) {
pdfWindow?.close();
- toast({ variant: 'destructive', title: 'GRN document failed', description: extractErrorMessage(error) });
+ toast({ variant: 'destructive', title: 'GRN document failed', description: await extractDownloadErrorMessage(error) });
} finally {
setLoading(false);
}
@@ -900,7 +900,7 @@ function EligibleTab({
toast({ title: opened ? 'GRN document opened' : 'GRN document downloaded' });
} catch (error) {
pdfWindow?.close();
- toast({ variant: 'destructive', title: 'GRN document failed', description: extractErrorMessage(error) });
+ toast({ variant: 'destructive', title: 'GRN document failed', description: await extractDownloadErrorMessage(error) });
}
}
setSelected(new Set());
@@ -1697,7 +1697,6 @@ function LoadedExportTab({
WeightRouteStatus
- {dispatchable && Actions}
@@ -1739,19 +1738,6 @@ function LoadedExportTab({
{r.status}
- {dispatchable && (
-
-
-
- )}
))}
@@ -2245,6 +2231,9 @@ function ImportUnloadedQueueTab({ enabled }: { enabled: boolean }) {
handoverDocumentReference: row.handoverDocumentReference,
handoverDocumentDate: row.handoverDocumentDate,
deliveredAt: row.deliveredAt,
+ // Carries the saved [Exit Inspection] block so Truck Leaving opens with the
+ // arrival details (plate, driver, tare, gate-in) read-only instead of blank.
+ notes: row.notes,
booking: row.bookingId
? {
id: row.bookingId,
@@ -2282,7 +2271,7 @@ function ImportUnloadedQueueTab({ enabled }: { enabled: boolean }) {
void qc.invalidateQueries({ queryKey: ['warehouse-inventory'] });
} catch (error) {
pdfWindow?.close();
- toast({ variant: 'destructive', title: 'Handover document failed', description: extractErrorMessage(error) });
+ toast({ variant: 'destructive', title: 'Handover document failed', description: await extractDownloadErrorMessage(error) });
} finally {
setBusyId(null);
}
@@ -2296,7 +2285,7 @@ function ImportUnloadedQueueTab({ enabled }: { enabled: boolean }) {
openPdfBlob(response.data, `release-${row.bookingReference ?? row.id}.pdf`, pdfWindow);
} catch (error) {
pdfWindow?.close();
- toast({ variant: 'destructive', title: 'Exit paper failed', description: extractErrorMessage(error) });
+ toast({ variant: 'destructive', title: 'Exit paper failed', description: await extractDownloadErrorMessage(error) });
} finally {
setBusyId(null);
}
diff --git a/apps/edr-freight-web/backoffice/src/components/warehouses/ReleaseOrderModal.tsx b/apps/edr-freight-web/backoffice/src/components/warehouses/ReleaseOrderModal.tsx
index 5cca0d3b2..d986e2aba 100644
--- a/apps/edr-freight-web/backoffice/src/components/warehouses/ReleaseOrderModal.tsx
+++ b/apps/edr-freight-web/backoffice/src/components/warehouses/ReleaseOrderModal.tsx
@@ -1,5 +1,5 @@
import { useEffect, useState } from 'react';
-import { Alert, Button, Group, Modal, MultiSelect, NumberInput, Select, SimpleGrid, Stack, Text, TextInput } from '@mantine/core';
+import { Alert, Button, Group, Modal, MultiSelect, NumberInput, SegmentedControl, Select, SimpleGrid, Stack, Text, TextInput } from '@mantine/core';
import { Info, Scale } from 'lucide-react';
import { useMutation, useQuery } from '@tanstack/react-query';
@@ -105,6 +105,7 @@ const parseInspectionNote = (notes: string | null | undefined) => {
grossWeight: lineNumber(note, 'Gross Weight'),
netWeight: lineNumber(note, 'Net Weight'),
gateOutTime: toLocalDateTimeInput(lineValue(note, 'Gate Out Time')),
+ weighingSkipped: /^Weighing:\s*SKIPPED/im.test(note ?? ''),
};
};
@@ -135,6 +136,8 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
const [containerNumbers, setContainerNumbers] = useState(['']);
const [gateInTime, setGateInTime] = useState('');
const [tareWeight, setTareWeight] = useState('');
+ // Containers may skip the weighbridge (decided at arrival, sticks for exit). Bulk always weighs.
+ const [weighTruck, setWeighTruck] = useState<'yes' | 'no'>('yes');
const [grossWeight, setGrossWeight] = useState('');
const [netWeight, setNetWeight] = useState('');
const [gateOutTime, setGateOutTime] = useState('');
@@ -158,6 +161,7 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
setContainerNumbers(initialContainerNumbers(item, inspection.containerNumber || prefillContainerNumber || assignedContainerNumber));
setGateInTime(inspection.gateInTime);
setTareWeight(inspection.tareWeight);
+ setWeighTruck(inspection.weighingSkipped ? 'no' : 'yes');
setGrossWeight(inspection.grossWeight);
setNetWeight(item?.weight == null ? inspection.netWeight : Number(item.weight));
setGateOutTime(inspection.gateOutTime);
@@ -165,7 +169,7 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
}, [opened, item, truckPrefill]);
const savedInspection = parseInspectionNote(item?.notes);
- const isExitStep = savedInspection.tareWeight !== '';
+ const isExitStep = savedInspection.tareWeight !== '' || savedInspection.weighingSkipped;
const isEntranceLocked = isExitStep;
const isCustomerAssignedTruck = Boolean(item?.booking?.customerTruckAssignedAt);
const hasLastMileTruckPrefill = Boolean(truckPrefill?.truckPlateNumber || truckPrefill?.trailerPlateNumber);
@@ -220,7 +224,9 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
.reduce((sum, n) => sum + (containerWeightByNumber.get(n.toUpperCase()) ?? 0), 0)
.toFixed(3),
);
- const useContainerNet = hasContainerWeights && selectedContainerNumbers.length > 0;
+ // Skip is only offered for container bookings; bulk always weighs.
+ const skipWeighing = hasContainerWeights && weighTruck === 'no';
+ const useContainerNet = hasContainerWeights && selectedContainerNumbers.length > 0 && !skipWeighing;
const systemNetWeight = useContainerNet
? selectedCargoWeight
@@ -230,6 +236,7 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
const computedNetWeight =
tareWeight !== '' && grossWeight !== '' ? Number((Number(grossWeight) - Number(tareWeight)).toFixed(3)) : null;
const weightMismatch =
+ !skipWeighing &&
computedNetWeight != null && systemNetWeight !== '' && Math.abs(Number(systemNetWeight) - computedNetWeight) > 0.001;
const title = isExitStep ? 'Customer truck leaving and exit weighing' : 'Customer truck arrival weighing';
@@ -239,19 +246,25 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
toast({ variant: 'destructive', title: 'Truck plate and driver name are required' });
return;
}
- if (!gateInTime || tareWeight === '') {
- toast({ variant: 'destructive', title: 'Gate in time and tare weight are required' });
+ if (!gateInTime || (!skipWeighing && tareWeight === '')) {
+ toast({
+ variant: 'destructive',
+ title: skipWeighing ? 'Gate in time is required' : 'Gate in time and tare weight are required',
+ });
return;
}
- if (isExitStep && (!gateOutTime || grossWeight === '')) {
- toast({ variant: 'destructive', title: 'Gate out time and gross weight are required' });
+ if (isExitStep && (!gateOutTime || (!skipWeighing && grossWeight === ''))) {
+ toast({
+ variant: 'destructive',
+ title: skipWeighing ? 'Gate out time is required' : 'Gate out time and gross weight are required',
+ });
return;
}
if (isExitStep && hasContainerWeights && selectedContainerNumbers.length === 0) {
toast({ variant: 'destructive', title: 'Select the containers loaded on this truck' });
return;
}
- if (isExitStep && systemNetWeight === '') {
+ if (isExitStep && !skipWeighing && systemNetWeight === '') {
toast({ variant: 'destructive', title: 'System recorded net weight is missing' });
return;
}
@@ -279,9 +292,10 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
truckType: truckType.trim() || undefined,
containerNumber: containerNumbers.map((number) => number.trim()).filter(Boolean).join(', ') || undefined,
gateInTime: toIsoDateTime(gateInTime),
- tareWeight: Number(tareWeight),
- grossWeight: grossWeight === '' ? undefined : Number(grossWeight),
- netWeight: isExitStep && systemNetWeight !== '' ? Number(systemNetWeight) : undefined,
+ weighingSkipped: skipWeighing || undefined,
+ tareWeight: skipWeighing ? undefined : Number(tareWeight),
+ grossWeight: skipWeighing || grossWeight === '' ? undefined : Number(grossWeight),
+ netWeight: !skipWeighing && isExitStep && systemNetWeight !== '' ? Number(systemNetWeight) : undefined,
gateOutTime: isExitStep ? toIsoDateTime(gateOutTime) : undefined,
},
});
@@ -421,9 +435,24 @@ export function ReleaseOrderModal({ opened, onClose, item, truckPrefill }: Relea
)}
setGateInTime(e.currentTarget.value)} readOnly={isEntranceLocked} />
+ {hasContainerWeights && (
+
+ Weigh truck?
+ setWeighTruck((v as 'yes' | 'no') ?? 'yes')}
+ disabled={isEntranceLocked}
+ />
+ {skipWeighing && (
+ Weighbridge skipped — container passes without tare/gross.
+ )}
+
+ )}
- setTareWeight(v === '' ? '' : Number(v))} readOnly={isEntranceLocked} />
- setGrossWeight(v === '' ? '' : Number(v))} disabled={!isExitStep} />
+ setTareWeight(v === '' ? '' : Number(v))} readOnly={isEntranceLocked} disabled={skipWeighing} />
+ setGrossWeight(v === '' ? '' : Number(v))} disabled={!isExitStep || skipWeighing} />
{
const kind = itemKind(item);
const busy = busyId === item.id;
- const nextAction = getNextInventoryAction(item);
+ // Per-booking Load and Dispatch are retired: wagon loading happens in
+ // the train flow and dispatch at the train level (which already
+ // advances inventory). Only the remaining lifecycle actions render.
+ const rawNextAction = getNextInventoryAction(item);
+ const nextAction =
+ rawNextAction === 'load' || rawNextAction === 'dispatch' ? null : rawNextAction;
const canGenerateHandover =
item.inspectionStatus === 'PASSED' &&
Boolean(item.bookingId) &&
@@ -232,26 +237,15 @@ export function WarehouseInventoryTable({
)}
{item.status === 'READY_FOR_PICKUP' && (
- <>
-
-
- >
+
)}
{item.status !== 'DISPATCHED' && (
diff --git a/apps/edr-freight-web/backoffice/src/constants/QUERY_KEYS.ts b/apps/edr-freight-web/backoffice/src/constants/QUERY_KEYS.ts
index 2ceaae870..dbac021f3 100644
--- a/apps/edr-freight-web/backoffice/src/constants/QUERY_KEYS.ts
+++ b/apps/edr-freight-web/backoffice/src/constants/QUERY_KEYS.ts
@@ -103,7 +103,8 @@ export const QUERY_KEYS = {
schedules: () => ["train-scheduling", "schedules"] as const,
scheduleById: (id: string) => ["train-scheduling", "schedule", id] as const,
track: (id: string) => ["train-scheduling", "track", id] as const,
- batchBoard: () => ["train-scheduling", "batch-board"] as const,
+ batchBoard: (filters?: unknown) =>
+ ["train-scheduling", "batch-board", "list", filters ?? {}] as const,
batchBoardDetail: (scheduleId: string) =>
["train-scheduling", "batch-board", scheduleId] as const,
unassignedBookings: (id: string) =>
diff --git a/apps/edr-freight-web/backoffice/src/constants/URLS.ts b/apps/edr-freight-web/backoffice/src/constants/URLS.ts
index 77a3bc95e..c6f98c8a2 100644
--- a/apps/edr-freight-web/backoffice/src/constants/URLS.ts
+++ b/apps/edr-freight-web/backoffice/src/constants/URLS.ts
@@ -86,6 +86,8 @@ export const URL_CONSTANTS = {
`/bookings/by-company/${id}/customer-view`,
PAYMENTS_CUSTOMER_VIEW: (id: string) =>
`/payments/by-company/${id}/customer-view`,
+ RESET_PASSWORD: (companyId: string) =>
+ `/backoffice/customers/${companyId}/reset-password`,
},
BILLING: {
diff --git a/apps/edr-freight-web/backoffice/src/features/contracts/mapContractListRow.ts b/apps/edr-freight-web/backoffice/src/features/contracts/mapContractListRow.ts
index 69c394927..0cd842830 100644
--- a/apps/edr-freight-web/backoffice/src/features/contracts/mapContractListRow.ts
+++ b/apps/edr-freight-web/backoffice/src/features/contracts/mapContractListRow.ts
@@ -80,7 +80,7 @@ export function toContractListRow(contract: Freight.IContract): ContractListRow
approvalSteps: contract.approvalSteps,
customerLabel: contract.isGovernment
? (contract.governmentInstitution ?? "Government")
- : (contract.companyId ?? "—"),
+ : (contract.company?.name ?? "—"),
status: contract.status,
contractKind: contract.contractKind,
tradeDirection: contract.tradeDirection,
diff --git a/apps/edr-freight-web/backoffice/src/hooks/contract-templates/useContractTemplates.ts b/apps/edr-freight-web/backoffice/src/hooks/contract-templates/useContractTemplates.ts
new file mode 100644
index 000000000..7e01d883c
--- /dev/null
+++ b/apps/edr-freight-web/backoffice/src/hooks/contract-templates/useContractTemplates.ts
@@ -0,0 +1,98 @@
+import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
+import toast from "react-hot-toast";
+
+import {
+ contractTemplatesService,
+ type ArticlePayload,
+ type UpdateContractTemplatePayload,
+} from "@/services/contract-templates.service";
+
+const KEYS = {
+ ROOT: ["contract-templates"] as const,
+ list: () => ["contract-templates", "list"] as const,
+ byCode: (code: string) => ["contract-templates", "detail", code] as const,
+ preview: (code: string) => ["contract-templates", "preview", code] as const,
+};
+
+export function useContractTemplates() {
+ return useQuery({
+ queryKey: KEYS.list(),
+ queryFn: () => contractTemplatesService.list(),
+ });
+}
+
+export function useContractTemplate(code: string | undefined) {
+ return useQuery({
+ queryKey: KEYS.byCode(code ?? ""),
+ queryFn: () => contractTemplatesService.getByCode(code as string),
+ enabled: Boolean(code),
+ });
+}
+
+/** Rendered mock-data HTML preview of the template's saved state. */
+export function useContractTemplatePreview(code: string | undefined, enabled = true) {
+ return useQuery({
+ queryKey: KEYS.preview(code ?? ""),
+ queryFn: () => contractTemplatesService.preview(code as string),
+ enabled: Boolean(code) && enabled,
+ staleTime: 0,
+ });
+}
+
+function useTemplateMutation(
+ mutationFn: (vars: TVariables) => Promise,
+ successMessage: string,
+) {
+ const queryClient = useQueryClient();
+ return useMutation({
+ mutationFn,
+ onSuccess: () => {
+ toast.success(successMessage);
+ void queryClient.invalidateQueries({ queryKey: KEYS.ROOT });
+ },
+ onError: (error: unknown) => {
+ const message =
+ (error as { response?: { data?: { message?: string } } })?.response?.data
+ ?.message ?? "Something went wrong";
+ toast.error(Array.isArray(message) ? message.join(", ") : message);
+ },
+ });
+}
+
+export function useUpdateContractTemplate(code: string) {
+ return useTemplateMutation(
+ (payload: UpdateContractTemplatePayload) =>
+ contractTemplatesService.update(code, payload),
+ "Template updated",
+ );
+}
+
+export function useAddArticle(code: string) {
+ return useTemplateMutation(
+ (payload: ArticlePayload) => contractTemplatesService.addArticle(code, payload),
+ "Article added",
+ );
+}
+
+export function useUpdateArticle(code: string) {
+ return useTemplateMutation(
+ (vars: { articleId: string; payload: Partial }) =>
+ contractTemplatesService.updateArticle(code, vars.articleId, vars.payload),
+ "Article updated",
+ );
+}
+
+export function useRemoveArticle(code: string) {
+ return useTemplateMutation(
+ (articleId: string) => contractTemplatesService.removeArticle(code, articleId),
+ "Article removed",
+ );
+}
+
+export function useReplaceArticles(code: string) {
+ return useTemplateMutation(
+ (articles: Array<{ id?: string; title: string; body: string }>) =>
+ contractTemplatesService.replaceArticles(code, articles),
+ "Articles reordered",
+ );
+}
diff --git a/apps/edr-freight-web/backoffice/src/lib/permissions.ts b/apps/edr-freight-web/backoffice/src/lib/permissions.ts
index e0c5c3d08..92fe85ad7 100644
--- a/apps/edr-freight-web/backoffice/src/lib/permissions.ts
+++ b/apps/edr-freight-web/backoffice/src/lib/permissions.ts
@@ -62,6 +62,7 @@ export const FREIGHT_PERMS = {
update: "edr_freight_app:customers:update",
deactivate: "edr_freight_app:customers:deactivate",
verify: "edr_freight_app:customers:verify",
+ resetPassword: "edr_freight_app:customers:reset-password",
},
payments: {
view: "edr_freight_app:payments:view",
diff --git a/apps/edr-freight-web/backoffice/src/lib/queryClient.ts b/apps/edr-freight-web/backoffice/src/lib/queryClient.ts
index 781ffba74..5b2bcb255 100644
--- a/apps/edr-freight-web/backoffice/src/lib/queryClient.ts
+++ b/apps/edr-freight-web/backoffice/src/lib/queryClient.ts
@@ -28,6 +28,10 @@ export const queryClient = new QueryClient({
queries: {
retry: 1,
staleTime: 30_000,
+ // Data freshness is driven by mutation invalidation (MutationCache above),
+ // socket pushes, and explicit polling — not by tab focus. Focus refetch
+ // just re-fires every mounted query each time the window is refocused.
+ refetchOnWindowFocus: false,
},
},
});
diff --git a/apps/edr-freight-web/backoffice/src/pages/bookings/BookingRequestsPage.tsx b/apps/edr-freight-web/backoffice/src/pages/bookings/BookingRequestsPage.tsx
index 477900ee1..c406b7a4b 100644
--- a/apps/edr-freight-web/backoffice/src/pages/bookings/BookingRequestsPage.tsx
+++ b/apps/edr-freight-web/backoffice/src/pages/bookings/BookingRequestsPage.tsx
@@ -4,18 +4,21 @@ import {
Button,
Card,
Group,
+ MultiSelect,
Select,
Stack,
Tabs,
Text,
TextInput,
} from "@mantine/core";
+import { DateInput } from "@mantine/dates";
import {
AlertTriangle,
ArrowRight,
Calendar,
CheckCircle2,
Clock,
+ FilterX,
LayoutList,
Package,
Plus,
@@ -26,6 +29,7 @@ import {
} from "lucide-react";
import { useCallback, useMemo, useRef, useState } from "react";
import { useNavigate } from "react-router-dom";
+import { useQuery } from "@tanstack/react-query";
import { BookingActionsMenu } from "@/components/bookings/BookingActionsMenu";
import { BookingApprovalProgressCell } from "@/components/bookings/BookingApprovalProgressCell";
@@ -43,6 +47,7 @@ import {
useBookingList,
useBookingListSummary,
} from "@/hooks/bookings/useBookings";
+import { api } from "@/services/api";
import type { BookingListFilter } from "@/services/bookings.service";
import type { BookingListRow } from "@/types/booking";
import {
@@ -77,6 +82,33 @@ const FREIGHT_TYPE_OPTIONS = [
{ value: "BULK", label: "Bulk" },
];
+const PAYMENT_STATUS_OPTIONS = [
+ { value: "PENDING", label: "Payment pending" },
+ { value: "PNR_GENERATED", label: "PNR generated" },
+ { value: "VERIFICATION_IN_PROGRESS", label: "Verification in progress" },
+ { value: "PAID", label: "Paid" },
+ { value: "FAILED", label: "Payment failed" },
+];
+
+const OWNERSHIP_OPTIONS = [
+ { value: "true", label: "Government" },
+ { value: "false", label: "Private" },
+];
+
+/** Local start-of-day → ISO, for inclusive "from" date filters. */
+function startOfDayIso(d: Date): string {
+ const x = new Date(d);
+ x.setHours(0, 0, 0, 0);
+ return x.toISOString();
+}
+
+/** Local end-of-day → ISO, for inclusive "to" date filters. */
+function endOfDayIso(d: Date): string {
+ const x = new Date(d);
+ x.setHours(23, 59, 59, 999);
+ return x.toISOString();
+}
+
function formatDate(value: string | null | undefined): string {
if (!value) return "—";
const d = new Date(value);
@@ -95,10 +127,18 @@ export default function BookingRequestsPage() {
const [query, setQuery] = useState("");
// Booking-kind tabs (one-time vs general contract) replace the old status tabs.
const [kindTab, setKindTab] = useState("ONE_TIME");
- // Per-tab filter selects (each nullable = "all").
- const [statusFilter, setStatusFilter] = useState(null);
+ // Per-tab filter controls (empty/null = "all").
+ const [statusFilter, setStatusFilter] = useState([]);
const [directionFilter, setDirectionFilter] = useState(null);
const [freightTypeFilter, setFreightTypeFilter] = useState(null);
+ const [paymentStatusFilter, setPaymentStatusFilter] = useState(null);
+ const [ownershipFilter, setOwnershipFilter] = useState(null);
+ const [originYardFilter, setOriginYardFilter] = useState(null);
+ const [destinationYardFilter, setDestinationYardFilter] = useState(null);
+ const [createdFrom, setCreatedFrom] = useState(null);
+ const [createdTo, setCreatedTo] = useState(null);
+ const [scheduledFrom, setScheduledFrom] = useState(null);
+ const [scheduledTo, setScheduledTo] = useState(null);
const [allocateOpen, setAllocateOpen] = useState(false);
const [allocateIds, setAllocateIds] = useState([]);
const suppressRowClickRef = useRef(false);
@@ -118,9 +158,21 @@ export default function BookingRequestsPage() {
// React Query cache key per kind tab.
tab: kindTab,
bookingType: kindTab,
- ...(statusFilter ? { statuses: statusFilter } : {}),
+ ...(statusFilter.length ? { statuses: statusFilter.join(",") } : {}),
...(directionFilter ? { tradeDirection: directionFilter } : {}),
...(freightTypeFilter ? { freightType: freightTypeFilter } : {}),
+ ...(paymentStatusFilter ? { paymentStatus: paymentStatusFilter } : {}),
+ ...(ownershipFilter
+ ? { isGovernment: ownershipFilter as "true" | "false" }
+ : {}),
+ ...(originYardFilter ? { originYardId: originYardFilter } : {}),
+ ...(destinationYardFilter
+ ? { destinationYardId: destinationYardFilter }
+ : {}),
+ ...(createdFrom ? { createdFrom: startOfDayIso(createdFrom) } : {}),
+ ...(createdTo ? { createdTo: endOfDayIso(createdTo) } : {}),
+ ...(scheduledFrom ? { scheduledFrom: startOfDayIso(scheduledFrom) } : {}),
+ ...(scheduledTo ? { scheduledTo: endOfDayIso(scheduledTo) } : {}),
};
}, [
pagination.pageIndex,
@@ -129,6 +181,14 @@ export default function BookingRequestsPage() {
statusFilter,
directionFilter,
freightTypeFilter,
+ paymentStatusFilter,
+ ownershipFilter,
+ originYardFilter,
+ destinationYardFilter,
+ createdFrom,
+ createdTo,
+ scheduledFrom,
+ scheduledTo,
]);
const { data, isLoading, isError, refetch, isFetching } = useBookingList(filter);
@@ -142,6 +202,49 @@ export default function BookingRequestsPage() {
refetch: refetchSummary,
} = useBookingListSummary(filter);
+ // Yard options for the origin/destination filters (shared routes reference list).
+ const { data: yardRefs } = useQuery(
+ api.routes.yards.queryOptions({ staleTime: 5 * 60_000 }),
+ );
+ const yardOptions = useMemo(
+ () =>
+ (yardRefs ?? []).map((y) => ({
+ value: y.id,
+ label: y.label ?? y.code,
+ })),
+ [yardRefs],
+ );
+
+ const resetPage = useCallback(() => {
+ setPagination({ pageIndex: 0, pageSize: pagination.pageSize });
+ }, [setPagination, pagination.pageSize]);
+
+ const activeFilterCount =
+ (statusFilter.length ? 1 : 0) +
+ (directionFilter ? 1 : 0) +
+ (freightTypeFilter ? 1 : 0) +
+ (paymentStatusFilter ? 1 : 0) +
+ (ownershipFilter ? 1 : 0) +
+ (originYardFilter ? 1 : 0) +
+ (destinationYardFilter ? 1 : 0) +
+ (createdFrom || createdTo ? 1 : 0) +
+ (scheduledFrom || scheduledTo ? 1 : 0);
+
+ const clearFilters = useCallback(() => {
+ setStatusFilter([]);
+ setDirectionFilter(null);
+ setFreightTypeFilter(null);
+ setPaymentStatusFilter(null);
+ setOwnershipFilter(null);
+ setOriginYardFilter(null);
+ setDestinationYardFilter(null);
+ setCreatedFrom(null);
+ setCreatedTo(null);
+ setScheduledFrom(null);
+ setScheduledTo(null);
+ resetPage();
+ }, [resetPage]);
+
const rows = useMemo(() => {
const items = (data?.items ?? []).map(toBookingListRow);
const q = query.trim().toLowerCase();
@@ -415,18 +518,44 @@ export default function BookingRequestsPage() {
-
+
+ {
+ setPaymentStatusFilter(v);
+ resetPage();
+ }}
+ clearable
+ radius="lg"
+ style={{ minWidth: 180 }}
+ />
+ {
+ setOwnershipFilter(v);
+ resetPage();
+ }}
+ clearable
+ radius="lg"
+ style={{ minWidth: 140 }}
+ />
+ {
+ setCreatedFrom(v ? new Date(v) : null);
+ resetPage();
+ }}
+ maxDate={createdTo ?? undefined}
+ clearable
+ radius="lg"
+ style={{ minWidth: 140 }}
+ />
+ {
+ setCreatedTo(v ? new Date(v) : null);
+ resetPage();
+ }}
+ minDate={createdFrom ?? undefined}
+ clearable
+ radius="lg"
+ style={{ minWidth: 140 }}
+ />
+ {
+ setScheduledFrom(v ? new Date(v) : null);
+ resetPage();
+ }}
+ maxDate={scheduledTo ?? undefined}
+ clearable
+ radius="lg"
+ style={{ minWidth: 150 }}
+ />
+ {
+ setScheduledTo(v ? new Date(v) : null);
+ resetPage();
+ }}
+ minDate={scheduledFrom ?? undefined}
+ clearable
+ radius="lg"
+ style={{ minWidth: 150 }}
+ />
+ {activeFilterCount > 0 ? (
+ }
+ onClick={clearFilters}
+ >
+ Clear filters ({activeFilterCount})
+
+ ) : null}
+
diff --git a/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceDetailPage.tsx b/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceDetailPage.tsx
index a514cd3ec..2cb5404e7 100644
--- a/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceDetailPage.tsx
+++ b/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceDetailPage.tsx
@@ -176,6 +176,7 @@ export default function DocumentClearanceDetailPage() {
hideSummary
approvalsLocked={isPhasedGeneral && docsPhaseComplete}
queriesLocked={queriesLocked}
+ phasedCustoms={isPhasedGeneral}
onChanged={() => void refetch()}
/>
diff --git a/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceListPage.tsx b/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceListPage.tsx
index da93d5995..542852a5f 100644
--- a/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceListPage.tsx
+++ b/apps/edr-freight-web/backoffice/src/pages/bookings/DocumentClearanceListPage.tsx
@@ -128,7 +128,16 @@ function DirectionIcon({ direction }: { direction: string }) {
);
}
-export default function DocumentClearanceListPage() {
+export default function DocumentClearanceListPage({
+ opsMode = false,
+}: {
+ /**
+ * true → Operations self-clearance queue: NON-customs bookings whose
+ * per-booking clearance docs the operations team reviews (GENERAL Path A).
+ * false → legacy GL queue: customs bookings only.
+ */
+ opsMode?: boolean;
+}) {
const navigate = useNavigate();
const [pageTab, setPageTab] = useState("queue");
const [activeTab, setActiveTab] = useState("all");
@@ -139,7 +148,7 @@ export default function DocumentClearanceListPage() {
const isHistory = pageTab === "history";
const { data, isLoading, isError, isFetching, refetch } = useQuery({
- queryKey: ["clearance", "list", isHistory],
+ queryKey: ["clearance", "list", isHistory, opsMode],
queryFn: () =>
bookingsService.list({
status: isHistory ? CLEARANCE_HISTORY_STATUS : CLEARANCE_REVIEW_STATUS,
@@ -148,8 +157,10 @@ export default function DocumentClearanceListPage() {
});
const allRows = useMemo(() => {
- // GL clearance queue: customs bookings only
- const rows = (data?.items ?? []).map(toClearanceRow).filter((r) => r.hasCustoms);
+ // opsMode: self-clearance (non-customs) bookings; else customs bookings only.
+ const rows = (data?.items ?? [])
+ .map(toClearanceRow)
+ .filter((r) => (opsMode ? !r.hasCustoms : r.hasCustoms));
if (isHistory) {
return [...rows].sort((a, b) => {
@@ -159,7 +170,7 @@ export default function DocumentClearanceListPage() {
});
}
return rows;
- }, [data?.items, isHistory]);
+ }, [data?.items, isHistory, opsMode]);
const tabCounts = useMemo(
() => ({
@@ -310,8 +321,12 @@ export default function DocumentClearanceListPage() {
();
+ const { data: template, isLoading } = useContractTemplate(code);
+ const preview = useContractTemplatePreview(code);
+
+ const updateTemplate = useUpdateContractTemplate(code ?? "");
+ const addArticle = useAddArticle(code ?? "");
+ const updateArticle = useUpdateArticle(code ?? "");
+ const removeArticle = useRemoveArticle(code ?? "");
+ const replaceArticles = useReplaceArticles(code ?? "");
+
+ const [articleDraft, setArticleDraft] = useState(null);
+ const [deleteTarget, setDeleteTarget] = useState(null);
+ const [detailsOpen, setDetailsOpen] = useState(false);
+
+ const sortedArticles = useMemo(
+ () => [...(template?.articles ?? [])].sort((a, b) => a.order - b.order),
+ [template],
+ );
+
+ const moveArticle = (index: number, delta: -1 | 1) => {
+ const next = [...sortedArticles];
+ const target = index + delta;
+ if (target < 0 || target >= next.length) return;
+ [next[index], next[target]] = [next[target], next[index]];
+ replaceArticles.mutate(
+ next.map(({ id, title, body }) => ({ id, title, body })),
+ );
+ };
+
+ const saveArticle = () => {
+ if (!articleDraft) return;
+ if (articleDraft.id) {
+ updateArticle.mutate({
+ articleId: articleDraft.id,
+ payload: { title: articleDraft.title, body: articleDraft.body },
+ });
+ } else {
+ addArticle.mutate({ title: articleDraft.title, body: articleDraft.body });
+ }
+ setArticleDraft(null);
+ };
+
+ if (isLoading || !template) {
+ return (
+
+
+ );
+}
diff --git a/apps/edr-freight-web/portal/src/components/customer-actions/ContractClearanceAction.tsx b/apps/edr-freight-web/portal/src/components/customer-actions/ContractClearanceAction.tsx
index 4aa131c23..fbb8f97c2 100644
--- a/apps/edr-freight-web/portal/src/components/customer-actions/ContractClearanceAction.tsx
+++ b/apps/edr-freight-web/portal/src/components/customer-actions/ContractClearanceAction.tsx
@@ -83,7 +83,7 @@ export function ContractClearanceAction({
centered
overlayProps={{ blur: 2, backgroundOpacity: 0.55 }}
>
-
+
);
diff --git a/apps/edr-freight-web/portal/src/components/onboarding/OnboardingWizardDialog.tsx b/apps/edr-freight-web/portal/src/components/onboarding/OnboardingWizardDialog.tsx
index ab00965fa..849ba50c5 100644
--- a/apps/edr-freight-web/portal/src/components/onboarding/OnboardingWizardDialog.tsx
+++ b/apps/edr-freight-web/portal/src/components/onboarding/OnboardingWizardDialog.tsx
@@ -286,9 +286,13 @@ export default function OnboardingWizardDialog({
});
}, [roles, nationality, startMutation]);
- // Note: no "back to role selection" — once the draft is created the role(s)
- // are fixed; the form's first-step Back is a no-op so progress never resets.
- const handleBackToRoles = useCallback(() => { }, []);
+ // Back from the form's first step returns to nationality/role selection.
+ // Safe to re-enter: startOnboarding is idempotent — it reuses the existing
+ // draft, refreshes the nationality and creates only roles that don't exist yet.
+ const handleBackToRoles = useCallback(() => {
+ setStartError(null);
+ setPhase("nationality-role");
+ }, []);
// Save the current step's fields to the draft (PATCH /profile). Returns the
// server error message on failure so the form can show it (e.g. duplicate TIN).
@@ -359,7 +363,6 @@ export default function OnboardingWizardDialog({
// The active step across the whole journey, driving the header + progress pill.
const activeStep: WizardStep = phase === "form" ? formStep : phase;
const stepMeta = STEP_META[activeStep];
- console.log({ stepMeta, activeStep, STEP_META });
const activeIdx = WIZARD_STEPS.indexOf(activeStep);
// Closing from the congratulations panel also clears the completed flag so a
@@ -403,7 +406,6 @@ export default function OnboardingWizardDialog({
onSubmit: handleSubmit,
isPending: finishMutation.isPending,
onBack: handleBackToRoles,
- hideFirstStepBack: true,
initialStep: effectiveResumeStep,
resyncOpen: opened,
onStepChange: handleStepChange,
diff --git a/apps/edr-freight-web/portal/src/constants/URLS.ts b/apps/edr-freight-web/portal/src/constants/URLS.ts
index 89a3d57e7..5dfda7e58 100644
--- a/apps/edr-freight-web/portal/src/constants/URLS.ts
+++ b/apps/edr-freight-web/portal/src/constants/URLS.ts
@@ -5,6 +5,8 @@ export const URL_CONSTANTS = {
REFRESH_TOKEN: "/api/auth/refresh-token",
LOGOUT: "/api/auth/logout",
PROFILE: "/auth/profile",
+ FORGOT_PASSWORD_REQUEST: "/api/auth/forgot-password/request",
+ FORGOT_PASSWORD_VERIFY: "/api/auth/forgot-password/verify",
},
USERS: {
diff --git a/apps/edr-freight-web/portal/src/hooks/useResendCooldown.ts b/apps/edr-freight-web/portal/src/hooks/useResendCooldown.ts
new file mode 100644
index 000000000..deeca8125
--- /dev/null
+++ b/apps/edr-freight-web/portal/src/hooks/useResendCooldown.ts
@@ -0,0 +1,24 @@
+import { useEffect, useState } from "react";
+
+/** Seconds a user must wait before another OTP can be requested. */
+const DEFAULT_COOLDOWN_SECONDS = 60;
+
+/**
+ * Countdown that gates the "Resend code" button. Ticks with setTimeout rather
+ * than wall-clock arithmetic, so it needs no Date.now().
+ */
+export function useResendCooldown(seconds: number = DEFAULT_COOLDOWN_SECONDS) {
+ const [secondsLeft, setSecondsLeft] = useState(0);
+
+ useEffect(() => {
+ if (secondsLeft <= 0) return;
+ const t = setTimeout(() => setSecondsLeft((s) => s - 1), 1000);
+ return () => clearTimeout(t);
+ }, [secondsLeft]);
+
+ return {
+ secondsLeft,
+ start: () => setSecondsLeft(seconds),
+ reset: () => setSecondsLeft(0),
+ };
+}
diff --git a/apps/edr-freight-web/portal/src/pages/MyPortalPage/components/BookingRow.tsx b/apps/edr-freight-web/portal/src/pages/MyPortalPage/components/BookingRow.tsx
index b3acc1667..007fc7fe9 100644
--- a/apps/edr-freight-web/portal/src/pages/MyPortalPage/components/BookingRow.tsx
+++ b/apps/edr-freight-web/portal/src/pages/MyPortalPage/components/BookingRow.tsx
@@ -36,7 +36,9 @@ export const BookingRow = memo(function BookingRow({
// Contract ready for signature → "View & sign" jumps straight to the
// full-page contract viewer where the signature flow lives.
const canSign = bookingIsSignable(booking);
- const canApproveDelivery = booking.status === "COMPLETED";
+ // Visible from handover generation until the customer signs (flag is attached
+ // by the bookings list endpoint; false again the moment it's signed).
+ const canApproveDelivery = Boolean(booking.handoverAwaitingSignature);
const origin = booking.originYard?.label ?? booking.originYard?.code ?? "—";
const dest =
booking.destinationYard?.label ?? booking.destinationYard?.code ?? "—";
diff --git a/apps/edr-freight-web/portal/src/pages/accounts/CompanyProfileForm.tsx b/apps/edr-freight-web/portal/src/pages/accounts/CompanyProfileForm.tsx
index cc9f81a29..abfb61551 100644
--- a/apps/edr-freight-web/portal/src/pages/accounts/CompanyProfileForm.tsx
+++ b/apps/edr-freight-web/portal/src/pages/accounts/CompanyProfileForm.tsx
@@ -51,7 +51,6 @@ export default function CompanyProfileForm({
onBack,
initialStep,
resyncOpen,
- hideFirstStepBack,
onStepChange,
onSaveStep,
rehydrate,
@@ -73,8 +72,6 @@ export default function CompanyProfileForm({
initialStep?: CompanyStep;
/** When this flips true (dialog reopened), jump back to initialStep (furthest reached). */
resyncOpen?: boolean;
- /** Hide the Back button on the first step (onboarding can't go back to role pick). */
- hideFirstStepBack?: boolean;
/** Reports the active step so the parent can persist resume progress. */
onStepChange?: (step: CompanyStep) => void;
/** Persist the current step's data before advancing; returns an error to show. */
@@ -514,10 +511,6 @@ export default function CompanyProfileForm({
else setStep(stepOrder[currentIdx - 1]);
};
- // Back is hidden on the first step during onboarding (can't return to role
- // selection); otherwise always available.
- const showBack = !(hideFirstStepBack && step === "company");
-
return (
<>