fix: normalized the region and logged the otp properly

apps/edr-freight-api/src/modules/otp/otp.service.spec.ts

@@ -11,8 +11,15 @@ describe('normalizeOtpTarget', () => {
     expect(normalizeOtpTarget({ phone: '0712345678' }).phone).toBe('+251712345678');
   });
 
-  it('passes email targets through untouched', () => {
-    expect(normalizeOtpTarget({ email: 'a@b.com' })).toEqual({ email: 'a@b.com' });
+  it('canonicalises email case and surrounding whitespace to one key', () => {
+    const forms = ['a@b.com', 'A@B.com', '  a@B.COM  ', 'A@b.COM'];
+    const keys = forms.map((email) => normalizeOtpTarget({ email }).email);
+    expect(new Set(keys)).toEqual(new Set(['a@b.com']));
+  });
+
+  it('keeps an already-normalised email stable (idempotent)', () => {
+    const once = normalizeOtpTarget({ email: ' User@Example.COM ' }).email!;
+    expect(normalizeOtpTarget({ email: once }).email).toBe(once);
   });
 
   it('keeps an already-normalised number stable (idempotent)', () => {
@@ -40,8 +47,10 @@ describe('OtpService — send/verify agree across phone formats', () => {
         rows.delete(row.phone ?? row.email!);
       }),
     };
-    const sms = { sendSms: jest.fn().mockResolvedValue(undefined) };
-    const email = { sendEmail: jest.fn().mockResolvedValue(undefined) };
+    // Both clients return `{ queued }` — the service reads it to tell a published
+    // code apart from one the transport silently dropped.
+    const sms = { sendSms: jest.fn().mockResolvedValue({ queued: true }) };
+    const email = { sendEmail: jest.fn().mockResolvedValue({ queued: true }) };
     const service = new OtpService(repo as never, sms as never, email as never);
     return { service, rows };
   }
@@ -58,4 +67,16 @@ describe('OtpService — send/verify agree across phone formats', () => {
       service.verifyOtpForAction({ phone: '0986680099' }, stored),
     ).resolves.toEqual({ success: true });
   });
+
+  it('verifies a code sent to User@X.com when verify is called with user@x.com', async () => {
+    const { service, rows } = makeService();
+    await service.sendOtp({ email: '  User@Example.COM ' });
+    const stored = [...rows.values()][0]!.otp;
+
+    [...rows.values()][0]!.updatedAt = new Date();
+
+    await expect(
+      service.verifyOtpForAction({ email: 'user@example.com' }, stored),
+    ).resolves.toEqual({ success: true });
+  });
 });