Trains management CRUD issues solved

apps/edr-freight-api/src/modules/wagons/wagons.controller.ts

@@ -7,6 +7,7 @@ import {
   ParseUUIDPipe,
   Patch,
   Post,
+  Query,
 } from '@nestjs/common';
 import { ApiOperation, ApiTags } from '@nestjs/swagger';
 import { CreateWagonDto } from './dto/create-wagon.dto';
@@ -28,8 +29,8 @@ export class WagonsController {
 
   @Get()
   @ApiOperation({ summary: 'List all wagons' })
-  findAll() {
-    return this.wagonsService.findAll();
+  findAll(@Query() query: Record<string, string | undefined>) {
+    return this.wagonsService.findAll(query);
   }
 
   @Get(':id')
@@ -73,4 +74,4 @@ export class TrainWagonsReorderController {
   reorder(@Param('trainId', ParseUUIDPipe) trainId: string, @Body() dto: ReorderWagonsDto) {
     return this.wagonsService.reorderWagons(trainId, dto);
   }
-}
+}

apps/edr-freight-api/src/modules/wagons/wagons.service.ts

@@ -1,6 +1,6 @@
 import { Injectable, NotFoundException, ConflictException } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
-import { Repository, DataSource } from 'typeorm';
+import { Repository, DataSource, FindOptionsOrder, FindOptionsWhere, ILike } from 'typeorm';
 import { CreateWagonDto } from './dto/create-wagon.dto';
 import { UpdateWagonDto } from './dto/update-wagon.dto';
 import { AssignWagonToTrainDto } from './dto/assign-wagon-to-train.dto';
@@ -26,8 +26,31 @@ export class WagonsService {
     return this.wagonRepo.save(wagon);
   }
 
-  async findAll(): Promise<Wagon[]> {
-    return this.wagonRepo.find({ order: { wagonNumber: 'ASC' } });
+  async findAll(query: Record<string, string | undefined> = {}): Promise<Wagon[]> {
+    const where: FindOptionsWhere<Wagon>[] | FindOptionsWhere<Wagon> = [];
+    const search = query.search?.trim();
+    const status = query.status?.trim();
+    const trainId = query.trainId?.trim();
+
+    if (search) {
+      where.push({
+        wagonNumber: ILike(`%${search}%`),
+        ...(status ? { status } : {}),
+        ...(trainId ? { trainId } : {}),
+      });
+    }
+
+    const sortBy = ['wagonNumber', 'tareWeight', 'maxPayloadWeight', 'status', 'sequenceNumber'].includes(query.sortBy ?? '')
+      ? (query.sortBy as keyof Wagon)
+      : 'wagonNumber';
+    const sortOrder = query.sortOrder?.toUpperCase() === 'DESC' ? 'DESC' : 'ASC';
+
+    return this.wagonRepo.find({
+      where: search ? where : { ...(status ? { status } : {}), ...(trainId ? { trainId } : {}) },
+      order: { [sortBy]: sortOrder } as FindOptionsOrder<Wagon>,
+      skip: query.page && query.limit ? (Number(query.page) - 1) * Number(query.limit) : undefined,
+      take: query.limit ? Number(query.limit) : undefined,
+    });
   }
 
   async findById(id: string): Promise<Wagon> {
@@ -39,8 +62,6 @@ export class WagonsService {
   async update(id: string, dto: UpdateWagonDto): Promise<Wagon> {
     const wagon = await this.findById(id);
     Object.assign(wagon, dto);
-    if (dto.trainId === undefined) wagon.trainId = null;
-    if (dto.sequenceNumber === undefined) wagon.sequenceNumber = null;
     return this.wagonRepo.save(wagon);
   }
 
@@ -98,4 +119,4 @@ export class WagonsService {
       await queryRunner.release();
     }
   }
-}
+}