Merge pull request #27 from Tria-plc/WorkflowChange

Workflow change

apps/backoffice/src/app/features/exam/pages/ExamDetailPage.tsx

@@ -121,13 +121,18 @@ export function ExamDetailPage() {
 
   // Only approved bank items may go on a paper (US-EXAM-003), so the picker
   // must not offer drafts or retired questions either.
+  //
+  // BOTH describes a mixed paper — a question itself is never "BOTH" (see
+  // QuestionForm), so an equality check against it would match nothing and
+  // silently offer zero questions. Same skip-condition as the backend's own
+  // random draw (ExamService.selectRandomQuestions).
   const eligibleQuestions = useMemo(() => {
     if (!exam) return [];
     return allQuestions
       .filter(
         (q) =>
           q.certificationId === exam.certificationId &&
-          q.form === exam.form &&
+          (exam.form === 'BOTH' || q.form === exam.form) &&
           q.status === 'APPROVED',
       )
       .map((q) => ({ id: q.id, title: q.title, form: q.form, points: q.points }));

apps/backoffice/src/app/features/exam/types/exam.ts

@@ -3,6 +3,11 @@ import type { EstimatedTime } from "../../question/types/question";
 import type { QuestionForm } from "../../question/types/question";
 export type { QuestionForm };
 
+/**
+ * The paper's own form — unlike a question's (QuestionForm), an exam may mix
+ * both: BOTH means a mixed paper, resolved per-question against each
+ * question's own ESSAY/CHOICE form. Mirrors backend EExamForm.
+ */
 export type ExamForm = QuestionForm | "BOTH";
 
 export type ExamType = "WRITTEN" | "ORAL";
@@ -10,12 +15,7 @@ export type ExamAdministrationMethod = "OFFLINE" | "ONLINE";
 export type ExamEvaluationMethod = "SUM" | "AVERAGE" | "PERCENTAGE";
 export type ExamSelectionMethod = "MANUAL" | "RANDOM";
 export type ExamStatus =
-  | "PENDING"
+  "PENDING" | "ACTIVE" | "COMPLETED" | "CANCELLED" | "POSTPONED" | "PUBLISHED";
-  | "ACTIVE"
-  | "COMPLETED"
-  | "CANCELLED"
-  | "POSTPONED"
-  | "PUBLISHED";
 
 /** Only populated when the exam is fetched with `?i=questions,questions.options`. */
 export interface QuestionOptionBrief {
@@ -103,19 +103,14 @@ export interface RandomQuestionsPayload {
 
 /** What the invigilator recorded on the day (US-EXAM-009). */
 export type AttendanceStatus =
-  | 'REGISTERED'
+  "REGISTERED" | "PRESENT" | "ABSENT" | "LATE" | "WITHDRAWN" | "DISQUALIFIED";
-  | 'PRESENT'
-  | 'ABSENT'
-  | 'LATE'
-  | 'WITHDRAWN'
-  | 'DISQUALIFIED';
 
 export interface ExamRegistration {
   id: string;
   examId: string;
   profileId: string;
   admissionNumber: string;
-  kind: 'NEW' | 'RETAKE';
+  kind: "NEW" | "RETAKE";
   attemptNumber: number;
   attendanceStatus: AttendanceStatus;
   attendanceRemark: string | null;
@@ -129,12 +124,14 @@ export interface ExamRegistration {
     seafarerNumber: string | null;
   };
   /** The candidate's online sitting, when one has been started. */
-  attempt?: { id: string; status: 'IN_PROGRESS' | 'SUBMITTED' | 'EXPIRED' } | null;
+  attempt?: {
+    id: string;
+    status: "IN_PROGRESS" | "SUBMITTED" | "EXPIRED";
+  } | null;
 }
 
 export type RegradeOutcome =
-  | { graded: true; resultId: string }
+  { graded: true; resultId: string } | { graded: false; reason: string };
-  | { graded: false; reason: string };
 
 export interface RecordAttendancePayload {
   registrationId: string;
@@ -143,17 +140,10 @@ export interface RecordAttendancePayload {
 }
 
 export type ExamIncidentType =
-  | 'MISCONDUCT'
+  "MISCONDUCT" | "TECHNICAL_FAILURE" | "MEDICAL" | "ADMINISTRATIVE" | "OTHER";
-  | 'TECHNICAL_FAILURE'
-  | 'MEDICAL'
-  | 'ADMINISTRATIVE'
-  | 'OTHER';
 
 export type ExamIncidentStatus =
-  | 'OPEN'
+  "OPEN" | "UNDER_REVIEW" | "RESOLVED" | "DISMISSED";
-  | 'UNDER_REVIEW'
-  | 'RESOLVED'
-  | 'DISMISSED';
 
 export interface ExamIncident {
   id: string;
@@ -178,6 +168,6 @@ export interface CreateIncidentPayload {
 
 export interface ResolveIncidentPayload {
   incidentId: string;
-  outcome: 'RESOLVED' | 'DISMISSED';
+  outcome: "RESOLVED" | "DISMISSED";
   resolution: string;
 }

apps/backoffice/src/app/features/license-review/config/actions.ts

@@ -65,16 +65,9 @@ export interface ActionDefinition {
  */
 export const ACTIONS: ActionDefinition[] = [
   // ------------------------------------------------------------- workflow
-  {
+  // Claim is deliberately absent here: an officer claims from the queue
-    id: 'claim',
+  // (LicenseQueuePage), not from this detail page. That implementation is
-    tier: 'workflow',
+  // separate — see LicenseQueuePage/actions.tsx — and is unaffected by this.
-    labelKey: 'review.actions.claim',
-    // Mirrors the CLAIM transition's `from` list: an examined cert (CoC/CoP)
-    // sits in ELIGIBILITY_PAID once its eligibility fee clears, not SUBMITTED.
-    from: ['SUBMITTED', 'ELIGIBILITY_PAID'],
-    permissions: ['can:claim:license-application'],
-    emphasis: 'light',
-  },
   {
     id: 'assign',
     tier: 'workflow',