diff --git a/apps/e2e/visual/theme.spec.ts b/apps/e2e/visual/theme.spec.ts index d0392de81..cb6d62e29 100644 --- a/apps/e2e/visual/theme.spec.ts +++ b/apps/e2e/visual/theme.spec.ts @@ -100,29 +100,21 @@ for (const app of APPS) { } /** - * The skip link, on a real app shell. + * The skip link. * - * Not on the gallery route: the point of a skip link is bypassing the nav, and - * the gallery has none. The login page is the shell-less public route both apps - * share, so this uses the landing route instead — it carries the chrome without - * needing a session. + * A skip link is invisible until focused, so a broken one and a working one + * look identical in every screenshot — only a focus test separates them. * - * A skip link is invisible until focused, which means a broken one and a - * working one look identical in every screenshot. Only a focus test separates - * them. + * Runs against the gallery, which mounts the same SkipLink/MAIN_CONTENT_ID + * pair the real shells do. The shells themselves live behind auth, and the + * public landing route carries no nav to skip past. */ test.describe('skip link', () => { for (const app of APPS) { test(`${app.name} — reveals on focus and targets main`, async ({ page }) => { - await page.goto(`${app.url}/`, { waitUntil: 'networkidle' }); + await page.goto(`${app.url}/__gallery`, { waitUntil: 'networkidle' }); const link = page.locator('.ema-skip-link'); - if ((await link.count()) === 0) { - // The public landing route does not mount the app shell in every app; - // skipping is honest here, where asserting absence would be wrong. - test.skip(true, 'landing route does not mount the app shell'); - return; - } // Off-screen until focused... await expect(link).not.toBeInViewport(); diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-focus-ring-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-focus-ring-chromium-win32.png index 434007dca..8a6e4f371 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-focus-ring-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-focus-ring-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-desktop-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-desktop-chromium-win32.png index a3836a31b..b4fd8c01c 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-desktop-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-desktop-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-tablet-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-tablet-chromium-win32.png index cc4d3a1cc..b49071064 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-tablet-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-dark-tablet-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-desktop-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-desktop-chromium-win32.png index ff08cf4f6..c6a8a4a43 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-desktop-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-desktop-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-tablet-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-tablet-chromium-win32.png index 8fcaa1290..ce00d2f14 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-tablet-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/backoffice-gallery-light-tablet-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/portal-focus-ring-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/portal-focus-ring-chromium-win32.png index 9271b168c..92638d015 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/portal-focus-ring-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/portal-focus-ring-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-desktop-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-desktop-chromium-win32.png index fcb53cffa..5b66ba6cb 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-desktop-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-desktop-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-tablet-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-tablet-chromium-win32.png index 96c9165fb..1e96b6093 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-tablet-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-dark-tablet-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-desktop-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-desktop-chromium-win32.png index e50811108..99c3b8ebd 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-desktop-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-desktop-chromium-win32.png differ diff --git a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-tablet-chromium-win32.png b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-tablet-chromium-win32.png index 465a9af2d..17cd57f12 100644 Binary files a/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-tablet-chromium-win32.png and b/apps/e2e/visual/theme.spec.ts-snapshots/portal-gallery-light-tablet-chromium-win32.png differ