Tria/emaui
1
0
Fork 0
mirror of https://github.com/Tria-plc/emaui.git synced 2026-08-29 00:10:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: extract event values before updating state in editor drawers to prevent null reference errors

Browse Source
This commit is contained in:
estifanos
2026-08-28 10:04:23 +00:00
parent 19ef4215e0
commit 1c1347faeb
3 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/backoffice/src/app/features/certificate-requirements/components/DocumentRequirementEditorDrawer.tsx
View File

@@ -191,7 +191,13 @@ export function DocumentRequirementEditorDrawer({
error={keyError}
disabled={!isNew}
description={isNew ? t('certReq.doc.keyHelp', 'Stable slug identifying this document slot') : t('certReq.doc.keyLocked', 'Key cannot change once created')}
onChange={(e) => setDraft((d) => ({ ...d, key: e.currentTarget.value }))}
// The value is read out of the event first: a functional updater
// runs after React has released the event, so `currentTarget` is
// null by the time it would be read inside one.
onChange={(e) => {
const { value } = e.currentTarget;
setDraft((d) => ({ ...d, key: value }));
}}
/>
<BilingualInput
@@ -303,7 +309,10 @@ export function DocumentRequirementEditorDrawer({
<Checkbox
label={t('certReq.doc.requiresValidity', 'Requires validity dates')}
checked={draft.requiresValidityDates}
onChange={(e) => setDraft((d) => ({ ...d, requiresValidityDates: e.currentTarget.checked }))}
onChange={(e) => {
const { checked } = e.currentTarget;
setDraft((d) => ({ ...d, requiresValidityDates: checked }));
}}
/>
)}

10
apps/backoffice/src/app/features/certificate-requirements/components/FieldEditorDrawer.tsx
View File

@@ -113,7 +113,10 @@ export function FieldEditorDrawer({
? t('certReq.field.keyHelp', 'Letters, numbers and underscores only — becomes the form data key')
: t('certReq.field.keyLocked', 'Key cannot change once created')
}
onChange={(e) => setDraft((d) => ({ ...d, key: e.currentTarget.value }))}
onChange={(e) => {
const { value } = e.currentTarget;
setDraft((d) => ({ ...d, key: value }));
}}
/>
<BilingualInput
@@ -134,7 +137,10 @@ export function FieldEditorDrawer({
<Checkbox
label={t('certReq.field.required', 'Required')}
checked={Boolean(draft.required)}
onChange={(e) => setDraft((d) => ({ ...d, required: e.currentTarget.checked }))}
onChange={(e) => {
const { checked } = e.currentTarget;
setDraft((d) => ({ ...d, required: checked }));
}}
/>
<BilingualInput

10
apps/backoffice/src/app/features/certificate-requirements/components/SectionEditorDrawer.tsx
View File

@@ -72,7 +72,10 @@ export function SectionEditorDrawer({
? t('certReq.section.keyHelp', 'Letters, numbers and underscores only')
: t('certReq.section.keyLocked', 'Key cannot change once created')
}
onChange={(e) => setDraft((d) => ({ ...d, key: e.currentTarget.value }))}
onChange={(e) => {
const { value } = e.currentTarget;
setDraft((d) => ({ ...d, key: value }));
}}
/>
<BilingualInput
@@ -95,7 +98,10 @@ export function SectionEditorDrawer({
'Sections sharing the same group render together on one step',
)}
value={draft.group ?? ''}
onChange={(e) => setDraft((d) => ({ ...d, group: e.currentTarget.value || undefined }))}
onChange={(e) => {
const { value } = e.currentTarget;
setDraft((d) => ({ ...d, group: value || undefined }));
}}
/>
<NumberInput